kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-20 08:30:06 +00:00
Code Issues Projects Releases Wiki Activity

Expand test coverage.

Browse Source
This commit is contained in:
James Cole
2019-07-26 17:48:24 +02:00
parent 6ff4a0b45c
commit d94d34ca63
57 changed files with 2243 additions and 1597 deletions
Download Patch File Download Diff File Expand all files Collapse all files

191
tests/Feature/Controllers/Import/PrerequisitesControllerTest.php
View File

@@ -22,7 +22,10 @@ declare(strict_types=1);
namespace Tests\Feature\Controllers\Import;
use FireflyIII\Import\Prerequisites\BunqPrerequisites;
use FireflyIII\Import\Prerequisites\FakePrerequisites;
use FireflyIII\Import\Prerequisites\SpectrePrerequisites;
use FireflyIII\Import\Prerequisites\YnabPrerequisites;
use FireflyIII\Models\ImportJob;
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
use FireflyIII\Repositories\User\UserRepositoryInterface;
@@ -57,9 +60,13 @@ class PrerequisitesControllerTest extends TestCase
{
$this->mockDefaultSession();
$userRepos = $this->mock(UserRepositoryInterface::class);
$prereq = $this->mock(FakePrerequisites::class);
$prereq = $this->mock(BunqPrerequisites::class);
$this->mock(ImportJobRepositoryInterface::class);
// mock some prerequisites:
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'A_pre_job_' . $this->randomInt();
@@ -69,23 +76,25 @@ class PrerequisitesControllerTest extends TestCase
$job->file_type = '';
$job->save();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
$prereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$prereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$spectrePrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$ynabPrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'owner'])->atLeast()->once()->andReturn(true);
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$prereq->shouldReceive('setUser')->times(2);
$prereq->shouldReceive('isComplete')->times(2)->andReturn(false);
$prereq->shouldReceive('getView')->once()->andReturn('import.fake.prerequisites');
$prereq->shouldReceive('getViewParameters')->once()->andReturn(['api_key' => '']);
$this->be($this->user());
$response = $this->get(route('import.prerequisites.index', ['fake', $job->key]));
$response = $this->get(route('import.prerequisites.index', ['bunq', $job->key]));
$response->assertStatus(200);
}
@@ -99,6 +108,10 @@ class PrerequisitesControllerTest extends TestCase
$userRepos = $this->mock(UserRepositoryInterface::class);
$this->mock(ImportJobRepositoryInterface::class);
// mock some prerequisites:
$bunqPrereq = $this->mock(BunqPrerequisites::class);
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
$job = new ImportJob;
$job->user_id = $this->user()->id;
@@ -109,16 +122,20 @@ class PrerequisitesControllerTest extends TestCase
$job->file_type = '';
$job->save();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'fake_api_key', null])->andReturnNull();
// fake calls to prereq classes
$bunqPrereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$bunqPrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$spectrePrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$ynabPrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$this->be($this->user());
$response = $this->get(route('import.prerequisites.index', ['fake', $job->key]));
$response = $this->get(route('import.prerequisites.index', ['bunq', $job->key]));
$response->assertStatus(302);
$response->assertRedirect(route('import.index'));
}
@@ -130,29 +147,39 @@ class PrerequisitesControllerTest extends TestCase
{
$this->mockDefaultSession();
$userRepos = $this->mock(UserRepositoryInterface::class);
$prereq = $this->mock(FakePrerequisites::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
// mock some prerequisites:
$bunqPrereq = $this->mock(BunqPrerequisites::class);
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
// fake calls to prereq classes
$bunqPrereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$bunqPrereq->shouldReceive('isComplete')->andReturn(true)->atLeast()->once();
$spectrePrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
$ynabPrereq->shouldReceive('isComplete')->andReturn(false)->atLeast()->once();
//Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(),'x','x'])->atLeast()->once();
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'C_pre_job_' . $this->randomInt();
$job->status = 'new';
$job->provider = 'fake';
$job->provider = 'bunq';
$job->transactions = [];
$job->file_type = '';
$job->save();
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$repository->shouldReceive('setStatus')->once()->withArgs([Mockery::any(), 'has_prereq']);
$prereq->shouldReceive('setUser')->times(2);
$prereq->shouldReceive('isComplete')->times(2)->andReturn(true);
$this->be($this->user());
$response = $this->get(route('import.prerequisites.index', ['fake', $job->key]));
$response = $this->get(route('import.prerequisites.index', ['bunq', $job->key]));
$response->assertStatus(302);
$response->assertRedirect(route('import.job.configuration.index', [$job->key]));
@@ -167,13 +194,23 @@ class PrerequisitesControllerTest extends TestCase
{
$this->mockDefaultSession();
$userRepos = $this->mock(UserRepositoryInterface::class);
$prereq = $this->mock(FakePrerequisites::class);
$repository = $this->mock(ImportJobRepositoryInterface::class);
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
//Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(),'fake_api_key',null])->andReturnNull();
// mock some prerequisites:
$bunqPrereq = $this->mock(BunqPrerequisites::class);
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
// fake calls to prereq classes
$bunqPrereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$bunqPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectrePrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynabPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$bunqPrereq->shouldReceive('storePrerequisites')->atLeast()->once()->andReturn(new MessageBag);
$job = new ImportJob;
@@ -186,13 +223,13 @@ class PrerequisitesControllerTest extends TestCase
$job->save();
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$prereq->shouldReceive('setUser')->times(2);
$prereq->shouldReceive('storePrerequisites')->once()->andReturn(new MessageBag);
//$prereq->shouldReceive('setUser')->times(2);
//$prereq->shouldReceive('storePrerequisites')->once()->andReturn(new MessageBag);
$repository->shouldReceive('setStatus')->once()->withArgs([Mockery::any(), 'has_prereq']);
$prereq->shouldReceive('isComplete')->times(1)->andReturn(false);
$this->be($this->user());
$response = $this->post(route('import.prerequisites.post', ['fake', $job->key]));
$response = $this->post(route('import.prerequisites.post', ['bunq', $job->key]));
$response->assertStatus(302);
$response->assertRedirect(route('import.job.configuration.index', [$job->key]));
}
@@ -205,29 +242,41 @@ class PrerequisitesControllerTest extends TestCase
public function testPostBadState(): void
{
$this->mockDefaultSession();
$userRepos = $this->mock(UserRepositoryInterface::class);
$prereq = $this->mock(FakePrerequisites::class);
$userRepos = $this->mock(UserRepositoryInterface::class);
$prereq = $this->mock(FakePrerequisites::class);
$this->mock(ImportJobRepositoryInterface::class);
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
// mock some prerequisites:
$bunqPrereq = $this->mock(BunqPrerequisites::class);
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
$job = new ImportJob;
$job->user_id = $this->user()->id;
// fake calls to prereq classes
$bunqPrereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$bunqPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectrePrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynabPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
//Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
//Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
//Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'D_pre_job_' . $this->randomInt();
$job->status = 'badstate';
$job->provider = 'fake';
$job->provider = 'bunq';
$job->transactions = [];
$job->file_type = '';
$job->save();
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$prereq->shouldReceive('setUser')->times(1);
$prereq->shouldReceive('isComplete')->times(1)->andReturn(false);
$this->be($this->user());
$response = $this->post(route('import.prerequisites.post', ['fake', $job->key]));
$response = $this->post(route('import.prerequisites.post', ['bunq', $job->key]));
$response->assertStatus(302);
$response->assertRedirect(route('import.index'));
$response->assertSessionHas('error', 'To access this page, your import job cannot have status "badstate".');
@@ -242,23 +291,28 @@ class PrerequisitesControllerTest extends TestCase
{
$this->mockDefaultSession();
$userRepos = $this->mock(UserRepositoryInterface::class);
$prereq = $this->mock(FakePrerequisites::class);
$this->mock(ImportJobRepositoryInterface::class);
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
// mock some prerequisites:
$bunqPrereq = $this->mock(BunqPrerequisites::class);
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
// fake calls to prereq classes
$bunqPrereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$bunqPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectrePrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynabPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$bunqPrereq->shouldReceive('storePrerequisites')->atLeast()->once()->andReturn(new MessageBag);
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$prereq->shouldReceive('setUser')->once();
$prereq->shouldReceive('storePrerequisites')->once()->andReturn(new MessageBag);
$prereq->shouldReceive('setUser')->times(1);
$prereq->shouldReceive('isComplete')->times(1)->andReturn(false);
$this->be($this->user());
$response = $this->post(route('import.prerequisites.post', ['fake']));
$response = $this->post(route('import.prerequisites.post', ['bunq']));
$response->assertStatus(302);
$response->assertRedirect(route('import.index'));
}
@@ -275,16 +329,11 @@ class PrerequisitesControllerTest extends TestCase
$prereq = $this->mock(FakePrerequisites::class);
$this->mock(ImportJobRepositoryInterface::class);
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'bunq_api_key', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'spectre_app_id', null])->andReturnNull();
Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(), 'ynab_client_id', null])->andReturnNull();
//Preferences::shouldReceive('getForUser')->atLeast()->once()->withArgs([Mockery::any(),'fake_api_key',null])->andReturnNull();
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'D_pre_job_' . $this->randomInt();
$job->status = 'new';
$job->provider = 'fake';
$job->provider = 'bunq';
$job->transactions = [];
$job->file_type = '';
$job->save();
@@ -293,16 +342,30 @@ class PrerequisitesControllerTest extends TestCase
$messages->add('some', 'message');
$userRepos->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->atLeast()->once()->andReturn(false);
$prereq->shouldReceive('setUser')->times(1);
$prereq->shouldReceive('isComplete')->times(1)->andReturn(false);
$prereq->shouldReceive('setUser')->once();
$prereq->shouldReceive('storePrerequisites')->once()->andReturn($messages);
// mock some prerequisites:
$bunqPrereq = $this->mock(BunqPrerequisites::class);
$spectrePrereq = $this->mock(SpectrePrerequisites::class);
$ynabPrereq = $this->mock(YnabPrerequisites::class);
// fake calls to prereq classes
$bunqPrereq->shouldReceive('setUser')->atLeast()->once();
$spectrePrereq->shouldReceive('setUser')->atLeast()->once();
$ynabPrereq->shouldReceive('setUser')->atLeast()->once();
$bunqPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectrePrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynabPrereq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$bunqPrereq->shouldReceive('storePrerequisites')->atLeast()->once()->andReturn($messages);
$this->be($this->user());
$response = $this->post(route('import.prerequisites.post', ['fake', $job->key]));
$response = $this->post(route('import.prerequisites.post', ['bunq', $job->key]));
$response->assertStatus(302);
$response->assertRedirect(route('import.prerequisites.index', ['fake', $job->key]));
$response->assertRedirect(route('import.prerequisites.index', ['bunq', $job->key]));
$response->assertSessionHas('error', 'message');
}
}