kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-20 08:30:06 +00:00
Code Issues Projects Releases Wiki Activity

Fix tests.

Browse Source
This commit is contained in:
James Cole
2018-07-01 09:27:22 +02:00
parent 0502f2a4a5
commit db149ca6e1
50 changed files with 551 additions and 647 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/Feature/Controllers/Admin/ConfigurationControllerTest.php
View File

@@ -29,10 +29,6 @@ use Tests\TestCase;
/**
* Class ConfigurationControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ConfigurationControllerTest extends TestCase
{

10
tests/Feature/Controllers/Admin/HomeControllerTest.php
View File

@@ -29,10 +29,6 @@ use Tests\TestCase;
/**
* Class HomeControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class HomeControllerTest extends TestCase
{
@@ -46,8 +42,7 @@ class HomeControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\HomeController::index
* @covers \FireflyIII\Http\Controllers\Admin\HomeController::__construct
* @covers \FireflyIII\Http\Controllers\Admin\HomeController
*/
public function testIndex(): void
{
@@ -58,6 +53,9 @@ class HomeControllerTest extends TestCase
$response->assertSee('<ol class="breadcrumb">');
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\HomeController
*/
public function testTestMessage(): void
{
Event::fake();

35
tests/Feature/Controllers/Admin/LinkControllerTest.php
View File

@@ -30,10 +30,6 @@ use Tests\TestCase;
/**
* Class LinkControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class LinkControllerTest extends TestCase
{
@@ -47,8 +43,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::__construct
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::create
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testCreate(): void
{
@@ -59,7 +54,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::delete
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testDeleteEditable(): void
{
@@ -76,7 +71,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::delete
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testDeleteNonEditable(): void
{
@@ -89,7 +84,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::destroy
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testDestroy(): void
{
@@ -99,7 +94,7 @@ class LinkControllerTest extends TestCase
LinkType::create(['editable' => 1, 'inward' => 'hellox', 'outward' => 'byex', 'name' => 'Test typeX']);
$linkType = LinkType::where('editable', 1)->first();
$repository->shouldReceive('find')->andReturn($linkType);
$repository->shouldReceive('findNull')->andReturn($linkType);
$repository->shouldReceive('destroy');
$this->be($this->user());
$this->session(['link_types.delete.uri' => 'http://localhost']);
@@ -109,7 +104,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::edit
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testEditEditable(): void
{
@@ -123,7 +118,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::edit
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testEditNonEditable(): void
{
@@ -135,7 +130,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::index
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testIndex(): void
{
@@ -149,7 +144,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::show
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
*/
public function testShow(): void
{
@@ -160,7 +155,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::store
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
* @covers \FireflyIII\Http\Requests\LinkTypeFormRequest
*/
public function testStore(): void
@@ -172,7 +167,7 @@ class LinkControllerTest extends TestCase
'outward' => 'test outward' . random_int(1, 1000),
];
$repository->shouldReceive('store')->once()->andReturn(LinkType::first());
$repository->shouldReceive('find')->andReturn(LinkType::first());
$repository->shouldReceive('findNull')->andReturn(LinkType::first());
$this->session(['link_types.create.uri' => 'http://localhost']);
$this->be($this->user());
@@ -182,7 +177,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::store
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
* @covers \FireflyIII\Http\Requests\LinkTypeFormRequest
*/
public function testStoreRedirect(): void
@@ -203,7 +198,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::update
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
* @covers \FireflyIII\Http\Requests\LinkTypeFormRequest
*/
public function testUpdate(): void
@@ -227,7 +222,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::update
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
* @covers \FireflyIII\Http\Requests\LinkTypeFormRequest
*/
public function testUpdateNonEditable(): void
@@ -249,7 +244,7 @@ class LinkControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\LinkController::update
* @covers \FireflyIII\Http\Controllers\Admin\LinkController
* @covers \FireflyIII\Http\Requests\LinkTypeFormRequest
*/
public function testUpdateRedirect(): void

17
tests/Feature/Controllers/Admin/UpdateControllerTest.php
View File

@@ -34,10 +34,6 @@ use Tests\TestCase;
/**
* Class UpdateControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class UpdateControllerTest extends TestCase
{
@@ -51,8 +47,7 @@ class UpdateControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::index
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::__construct
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController
*/
public function testIndex(): void
{
@@ -75,7 +70,7 @@ class UpdateControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::post
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController
*/
public function testPost(): void
{
@@ -93,7 +88,7 @@ class UpdateControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::updateCheck
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController
*/
public function testUpdateCheck(): void
{
@@ -122,7 +117,7 @@ class UpdateControllerTest extends TestCase
/**
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::updateCheck
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController
*/
public function testUpdateCheckCurrent(): void
{
@@ -149,7 +144,7 @@ class UpdateControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::updateCheck
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController
*/
public function testUpdateCheckError(): void
{
@@ -172,7 +167,7 @@ class UpdateControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController::updateCheck
* @covers \FireflyIII\Http\Controllers\Admin\UpdateController
*/
public function testUpdateCheckNewer(): void
{

17
tests/Feature/Controllers/Admin/UserControllerTest.php
View File

@@ -29,10 +29,6 @@ use Tests\TestCase;
/**
* Class UserControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class UserControllerTest extends TestCase
{
@@ -46,7 +42,7 @@ class UserControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UserController::delete
* @covers \FireflyIII\Http\Controllers\Admin\UserController
*/
public function testDelete(): void
{
@@ -58,7 +54,7 @@ class UserControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UserController::destroy
* @covers \FireflyIII\Http\Controllers\Admin\UserController
*/
public function testDestroy(): void
{
@@ -71,7 +67,7 @@ class UserControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UserController::edit
* @covers \FireflyIII\Http\Controllers\Admin\UserController
*/
public function testEdit(): void
{
@@ -83,8 +79,7 @@ class UserControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UserController::index
* @covers \FireflyIII\Http\Controllers\Admin\UserController::__construct
* @covers \FireflyIII\Http\Controllers\Admin\UserController
*/
public function testIndex(): void
{
@@ -100,7 +95,7 @@ class UserControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UserController::show
* @covers \FireflyIII\Http\Controllers\Admin\UserController
*/
public function testShow(): void
{
@@ -121,7 +116,7 @@ class UserControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Admin\UserController::update
* @covers \FireflyIII\Http\Controllers\Admin\UserController
*/
public function testUpdate(): void
{