Fix tests.

This commit is contained in:
James Cole
2018-07-01 09:27:22 +02:00
parent 0502f2a4a5
commit db149ca6e1
50 changed files with 551 additions and 647 deletions

View File

@@ -43,10 +43,6 @@ use Tests\TestCase;
/**
* Class AccountControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class AccountControllerTest extends TestCase
{
@@ -60,8 +56,8 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::expenseAccounts
* @covers \FireflyIII\Generator\Chart\Basic\GeneratorInterface::singleSet
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @covers \FireflyIII\Generator\Chart\Basic\GeneratorInterface
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -84,8 +80,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::expenseBudget
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::getBudgetNames
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -112,8 +107,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::expenseBudgetAll
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::getBudgetNames
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -142,8 +136,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::expenseCategory
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::getCategoryNames
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -171,8 +164,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::expenseCategoryAll
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::getCategoryNames
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -202,10 +194,8 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::frontpage
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::accountBalanceChart
* @covers \FireflyIII\Generator\Chart\Basic\GeneratorInterface::multiSet
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @covers \FireflyIII\Generator\Chart\Basic\GeneratorInterface
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -232,7 +222,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::incomeCategory
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -260,7 +250,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::incomeCategoryAll
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -290,7 +280,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::period
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -311,8 +301,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::report
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::accountBalanceChart
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
*/
public function testReport(): void
{
@@ -328,7 +317,7 @@ class AccountControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\AccountController::revenueAccounts
* @covers \FireflyIII\Http\Controllers\Chart\AccountController
* @dataProvider dateRangeProvider
*
* @param string $range

View File

@@ -32,10 +32,6 @@ use Tests\TestCase;
/**
* Class BillControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BillControllerTest extends TestCase
{
@@ -49,8 +45,7 @@ class BillControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BillController::frontpage
* @covers \FireflyIII\Http\Controllers\Chart\BillController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\BillController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -71,7 +66,7 @@ class BillControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BillController::single
* @covers \FireflyIII\Http\Controllers\Chart\BillController
*/
public function testSingle(): void
{

View File

@@ -40,10 +40,6 @@ use Tests\TestCase;
/**
* Class BudgetControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BudgetControllerTest extends TestCase
{
@@ -57,8 +53,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::budget
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -79,7 +74,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::budgetLimit
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -99,7 +94,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::budgetLimit
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @expectedExceptionMessage This budget limit is not part of this budget.
*/
public function testBudgetLimitWrongLimit(): void
@@ -113,8 +108,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::expenseAsset
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getAccountNames
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -142,8 +136,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::expenseCategory
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getCategoryNames
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -176,8 +169,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::expenseExpense
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getAccountNames
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -210,10 +202,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::frontpage
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getExpensesForBudget
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::spentInPeriodWithout
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::spentInPeriodMulti
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -247,10 +236,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::frontpage
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getExpensesForBudget
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::spentInPeriodWithout
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::spentInPeriodMulti
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -286,10 +272,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::frontpage
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getExpensesForBudget
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::spentInPeriodWithout
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::spentInPeriodMulti
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -321,8 +304,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::period
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::getBudgetedInPeriod
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
*/
public function testPeriod(): void
{
@@ -342,7 +324,7 @@ class BudgetControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController::periodNoBudget
* @covers \FireflyIII\Http\Controllers\Chart\BudgetController
*/
public function testPeriodNoBudget(): void
{

View File

@@ -39,10 +39,6 @@ use Tests\TestCase;
/**
* Class BudgetReportControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BudgetReportControllerTest extends TestCase
{
@@ -56,8 +52,7 @@ class BudgetReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::accountExpense
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController
*/
public function testAccountExpense(): void
{
@@ -80,7 +75,7 @@ class BudgetReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::budgetExpense
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController
*/
public function testBudgetExpense(): void
{
@@ -102,10 +97,7 @@ class BudgetReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::mainChart
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::filterBudgetLimits
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::getExpenses
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController::groupByBudget
* @covers \FireflyIII\Http\Controllers\Chart\BudgetReportController
*/
public function testMainChart(): void
{

View File

@@ -35,10 +35,6 @@ use Tests\TestCase;
/**
* Class CategoryControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CategoryControllerTest extends TestCase
{
@@ -52,8 +48,7 @@ class CategoryControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::all
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -80,7 +75,7 @@ class CategoryControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::frontpage
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController
* @dataProvider dateRangeProvider
*
* @param string $range
@@ -106,7 +101,7 @@ class CategoryControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::reportPeriod
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController
*/
public function testReportPeriod(): void
{
@@ -123,7 +118,7 @@ class CategoryControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::reportPeriodNoCategory
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController
*/
public function testReportPeriodNoCategory(): void
{
@@ -140,8 +135,7 @@ class CategoryControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::specificPeriod
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController::makePeriodChart
* @covers \FireflyIII\Http\Controllers\Chart\CategoryController
* @dataProvider dateRangeProvider
*
* @param string $range

View File

@@ -36,10 +36,6 @@ use Tests\TestCase;
/**
* Class CategoryReportControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CategoryReportControllerTest extends TestCase
{
@@ -53,8 +49,7 @@ class CategoryReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::accountExpense
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController
*/
public function testAccountExpense(): void
{
@@ -75,7 +70,7 @@ class CategoryReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::accountIncome
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController
*/
public function testAccountIncome(): void
{
@@ -96,7 +91,7 @@ class CategoryReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::categoryExpense
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController
*/
public function testCategoryExpense(): void
{
@@ -117,7 +112,7 @@ class CategoryReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::categoryIncome
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController
*/
public function testCategoryIncome(): void
{
@@ -138,10 +133,7 @@ class CategoryReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::mainChart
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::groupByCategory
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::getExpenses
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController::getIncome
* @covers \FireflyIII\Http\Controllers\Chart\CategoryReportController
*/
public function testMainChart(): void
{

View File

@@ -33,10 +33,6 @@ use Tests\TestCase;
/**
* Class ExpenseReportControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ExpenseReportControllerTest extends TestCase
{
@@ -51,12 +47,7 @@ class ExpenseReportControllerTest extends TestCase
/**
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController::groupByName
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController::mainChart()
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController::getExpenses
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController::getIncome
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController::combineAccounts
* @covers \FireflyIII\Http\Controllers\Chart\ExpenseReportController
*/
public function testMainChart(): void
{

View File

@@ -31,10 +31,6 @@ use Tests\TestCase;
/**
* Class PiggyBankControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class PiggyBankControllerTest extends TestCase
{
@@ -48,8 +44,7 @@ class PiggyBankControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\PiggyBankController::history
* @covers \FireflyIII\Http\Controllers\Chart\PiggyBankController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\PiggyBankController
*/
public function testHistory(): void
{

View File

@@ -30,10 +30,6 @@ use Tests\TestCase;
/**
* Class ReportControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ReportControllerTest extends TestCase
{
@@ -47,9 +43,7 @@ class ReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::netWorth
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::arraySum
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\ReportController
*/
public function testNetWorth(): void
{
@@ -64,8 +58,7 @@ class ReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::operations
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::getChartData
* @covers \FireflyIII\Http\Controllers\Chart\ReportController
*/
public function testOperations(): void
{
@@ -83,8 +76,7 @@ class ReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::sum
* @covers \FireflyIII\Http\Controllers\Chart\ReportController::getChartData
* @covers \FireflyIII\Http\Controllers\Chart\ReportController
*/
public function testSum(): void
{

View File

@@ -40,10 +40,6 @@ use Tests\TestCase;
/**
* Class TagReportControllerTest
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class TagReportControllerTest extends TestCase
{
@@ -57,8 +53,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::accountExpense
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::__construct
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testAccountExpense(): void
{
@@ -86,7 +81,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::accountIncome
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testAccountIncome(): void
{
@@ -113,7 +108,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::budgetExpense()
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testBudgetExpense(): void
{
@@ -139,7 +134,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::categoryExpense()
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testCategoryExpense(): void
{
@@ -165,10 +160,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::mainChart()
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::getExpenses
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::getIncome
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::groupByTag
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testMainChart(): void
{
@@ -207,7 +199,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::tagExpense()
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testTagExpense(): void
{
@@ -233,7 +225,7 @@ class TagReportControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController::tagIncome
* @covers \FireflyIII\Http\Controllers\Chart\TagReportController
*/
public function testTagIncome(): void
{