Various PSR12 code cleanup

This commit is contained in:
James Cole
2022-12-29 19:41:57 +01:00
parent 0022009dd5
commit dbf3e76ecc
340 changed files with 4079 additions and 3816 deletions

View File

@@ -36,7 +36,7 @@ use Illuminate\Http\Request;
class ShowController extends Controller
{
/**
* @param Account $account
* @param Account $account
* @return JsonResponse
*/
public function show(Request $request, Account $account): JsonResponse

View File

@@ -36,6 +36,7 @@ use Illuminate\Http\JsonResponse;
class SumController extends Controller
{
use ConvertsExchangeRates;
private BillRepositoryInterface $repository;
/**
@@ -52,21 +53,7 @@ class SumController extends Controller
}
/**
* @param DateRequest $request
* @return JsonResponse
*/
public function unpaid(DateRequest $request): JsonResponse
{
$dates = $request->getAll();
$result = $this->repository->sumUnpaidInRange($dates['start'], $dates['end']);
$converted = $this->cerSum($result);
// convert to JSON response:
return response()->api($converted);
}
/**
* @param DateRequest $request
* @param DateRequest $request
* @return JsonResponse
*/
public function paid(DateRequest $request): JsonResponse
@@ -78,4 +65,18 @@ class SumController extends Controller
// convert to JSON response:
return response()->api($converted);
}
/**
* @param DateRequest $request
* @return JsonResponse
*/
public function unpaid(DateRequest $request): JsonResponse
{
$dates = $request->getAll();
$result = $this->repository->sumUnpaidInRange($dates['start'], $dates['end']);
$converted = $this->cerSum($result);
// convert to JSON response:
return response()->api($converted);
}
}

View File

@@ -30,7 +30,6 @@ use FireflyIII\Transformers\V2\BudgetTransformer;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
class ListController extends Controller
{
@@ -52,8 +51,8 @@ class ListController extends Controller
*/
public function index(Request $request): JsonResponse
{
$collection = $this->repository->getActiveBudgets();
$total = $collection->count();
$collection = $this->repository->getActiveBudgets();
$total = $collection->count();
$collection->slice($this->pageSize * $this->parameters->get('page'), $this->pageSize);
$paginator = new LengthAwarePaginator($collection, $total, $this->pageSize, $this->parameters->get('page'));

View File

@@ -53,7 +53,7 @@ class SumController extends Controller
}
/**
* @param DateRequest $request
* @param DateRequest $request
* @return JsonResponse
*/
public function budgeted(DateRequest $request): JsonResponse
@@ -66,7 +66,7 @@ class SumController extends Controller
}
/**
* @param DateRequest $request
* @param DateRequest $request
* @return JsonResponse
*/
public function spent(DateRequest $request): JsonResponse