Improve test coverage.

2025-10-22 20:16:22 +00:00 · 2018-09-02 20:13:25 +02:00
parent 96dd89fbeb
commit de754ca4e0
31 changed files with 861 additions and 385 deletions
--- a/tests/Feature/Controllers/System/CronControllerTest.php
+++ b/tests/Feature/Controllers/System/CronControllerTest.php
@@ -0,0 +1,117 @@
+<?php
+/**
+ * CronControllerTest.php
+ * Copyright (c) 2018 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace Tests\Feature\Controllers\System;
+
+use FireflyIII\Exceptions\FireflyException;
+use FireflyIII\Models\Preference;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
+use FireflyIII\Support\Cronjobs\RecurringCronjob;
+use Illuminate\Support\Collection;
+use Log;
+use Mockery;
+use Tests\TestCase;
+
+/**
+ *
+ * Class CronControllerTest
+ */
+class CronControllerTest extends TestCase
+{
+
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::debug(sprintf('Now in %s.', \get_class($this)));
+    }
+
+    /**
+     * @covers \FireflyIII\Http\Controllers\System\CronController
+     * @covers \FireflyIII\Support\Binder\CLIToken
+     */
+    public function testCron(): void
+    {
+        $users            = new Collection([$this->user()]);
+        $job              = $this->mock(RecurringCronjob::class);
+        $preference       = new Preference();
+        $preference->data = 'token';
+        $job->shouldReceive('fire')->once()->andReturn(true);
+        $repository = $this->mock(UserRepositoryInterface::class);
+        $repository->shouldReceive('all')->andReturn($users);
+        \Preferences::shouldReceive('getForUser')
+                    ->withArgs([Mockery::any(), 'access_token', null])
+                    ->andReturn($preference)->once();
+        $response = $this->get(route('cron.cron', ['token']));
+        $response->assertStatus(200);
+        $response->assertSee('The recurring transaction cron job fired successfully.');
+
+    }
+
+    /**
+     * @covers \FireflyIII\Http\Controllers\System\CronController
+     * @covers \FireflyIII\Support\Binder\CLIToken
+     */
+    public function testCronException(): void
+    {
+        $users            = new Collection([$this->user()]);
+        $job              = $this->mock(RecurringCronjob::class);
+        $preference       = new Preference();
+        $preference->data = 'token';
+        $job->shouldReceive('fire')->once()->andThrow(new FireflyException('Exception noted.'));
+        $repository = $this->mock(UserRepositoryInterface::class);
+        $repository->shouldReceive('all')->andReturn($users);
+        \Preferences::shouldReceive('getForUser')
+                    ->withArgs([Mockery::any(), 'access_token', null])
+                    ->andReturn($preference)->once();
+        $response = $this->get(route('cron.cron', ['token']));
+        $response->assertStatus(200);
+        $response->assertSee('Exception noted.');
+
+    }
+
+    /**
+     * @covers \FireflyIII\Http\Controllers\System\CronController
+     * @covers \FireflyIII\Support\Binder\CLIToken
+     */
+    public function testCronFalse(): void
+    {
+        $users            = new Collection([$this->user()]);
+        $job              = $this->mock(RecurringCronjob::class);
+        $preference       = new Preference();
+        $preference->data = 'token';
+        $job->shouldReceive('fire')->once()->andReturn(false);
+        $repository = $this->mock(UserRepositoryInterface::class);
+        $repository->shouldReceive('all')->andReturn($users);
+        \Preferences::shouldReceive('getForUser')
+                    ->withArgs([Mockery::any(), 'access_token', null])
+                    ->andReturn($preference)->once();
+        $response = $this->get(route('cron.cron', ['token']));
+        $response->assertStatus(200);
+        $response->assertSee('The recurring transaction cron job did not fire.');
+
+    }
+
+}