From e318e8e9cf8e2780f117a15a90aa4d801dfd2212 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 31 Dec 2023 17:29:00 +0100 Subject: [PATCH] Catch amounts. --- app/Api/V1/Requests/Models/PiggyBank/StoreRequest.php | 4 ++-- app/Api/V1/Requests/Models/PiggyBank/UpdateRequest.php | 4 ++-- app/Api/V1/Requests/Models/Recurrence/StoreRequest.php | 4 ++-- app/Api/V1/Requests/Models/Recurrence/UpdateRequest.php | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/Api/V1/Requests/Models/PiggyBank/StoreRequest.php b/app/Api/V1/Requests/Models/PiggyBank/StoreRequest.php index 35428faca7..87afccf4d9 100644 --- a/app/Api/V1/Requests/Models/PiggyBank/StoreRequest.php +++ b/app/Api/V1/Requests/Models/PiggyBank/StoreRequest.php @@ -64,11 +64,11 @@ class StoreRequest extends FormRequest { return [ 'name' => 'required|between:1,255|uniquePiggyBankForUser', - 'current_amount' => ['numeric', 'gte:0', 'lte:target_amount'], + 'current_amount' => ['numeric', 'gte:0', 'lte:target_amount','max:1000000000'], 'account_id' => 'required|numeric|belongsToUser:accounts,id', 'object_group_id' => 'numeric|belongsToUser:object_groups,id', 'object_group_title' => 'between:1,255', - 'target_amount' => ['numeric', 'gte:0', 'lte:target_amount', 'required'], + 'target_amount' => ['numeric', 'gte:0', 'lte:target_amount', 'required','max:1000000000'], 'start_date' => 'date|nullable', 'target_date' => 'date|nullable|after:start_date', 'notes' => 'max:65000', diff --git a/app/Api/V1/Requests/Models/PiggyBank/UpdateRequest.php b/app/Api/V1/Requests/Models/PiggyBank/UpdateRequest.php index e8448bcdf5..81cfa11576 100644 --- a/app/Api/V1/Requests/Models/PiggyBank/UpdateRequest.php +++ b/app/Api/V1/Requests/Models/PiggyBank/UpdateRequest.php @@ -69,8 +69,8 @@ class UpdateRequest extends FormRequest return [ 'name' => 'between:1,255|uniquePiggyBankForUser:'.$piggyBank->id, - 'current_amount' => ['numeric', 'gte:0', new LessThanPiggyTarget()], - 'target_amount' => 'numeric|gte:0', + 'current_amount' => ['numeric', 'gte:0', new LessThanPiggyTarget(),'max:1000000000'], + 'target_amount' => 'numeric|gte:0|max:1000000000', 'start_date' => 'date|nullable', 'target_date' => 'date|nullable|after:start_date', 'notes' => 'max:65000', diff --git a/app/Api/V1/Requests/Models/Recurrence/StoreRequest.php b/app/Api/V1/Requests/Models/Recurrence/StoreRequest.php index 4c4bf8a162..5855b3e019 100644 --- a/app/Api/V1/Requests/Models/Recurrence/StoreRequest.php +++ b/app/Api/V1/Requests/Models/Recurrence/StoreRequest.php @@ -92,8 +92,8 @@ class StoreRequest extends FormRequest 'repetitions.*.weekend' => 'numeric|min:1|max:4', 'transactions.*.description' => 'required|between:1,255', - 'transactions.*.amount' => 'required|numeric|gt:0', - 'transactions.*.foreign_amount' => 'nullable|numeric|gt:0', + 'transactions.*.amount' => 'required|numeric|gt:0|max:1000000000', + 'transactions.*.foreign_amount' => 'nullable|numeric|gt:0|max:1000000000', 'transactions.*.currency_id' => 'nullable|numeric|exists:transaction_currencies,id', 'transactions.*.currency_code' => 'nullable|min:3|max:51|exists:transaction_currencies,code', 'transactions.*.foreign_currency_id' => 'nullable|numeric|exists:transaction_currencies,id', diff --git a/app/Api/V1/Requests/Models/Recurrence/UpdateRequest.php b/app/Api/V1/Requests/Models/Recurrence/UpdateRequest.php index d0cc79925c..6b1115f93e 100644 --- a/app/Api/V1/Requests/Models/Recurrence/UpdateRequest.php +++ b/app/Api/V1/Requests/Models/Recurrence/UpdateRequest.php @@ -99,8 +99,8 @@ class UpdateRequest extends FormRequest 'repetitions.*.weekend' => 'nullable|numeric|min:1|max:4', 'transactions.*.description' => 'between:1,255', - 'transactions.*.amount' => 'numeric|gt:0', - 'transactions.*.foreign_amount' => 'nullable|numeric|gt:0', + 'transactions.*.amount' => 'numeric|gt:0|max:1000000000', + 'transactions.*.foreign_amount' => 'nullable|numeric|gt:0|max:1000000000', 'transactions.*.currency_id' => 'nullable|numeric|exists:transaction_currencies,id', 'transactions.*.currency_code' => 'nullable|min:3|max:51|exists:transaction_currencies,code', 'transactions.*.foreign_currency_id' => 'nullable|numeric|exists:transaction_currencies,id',