mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-10-14 00:04:24 +00:00
Some cleaning up courtesy of PHPStorm.
This commit is contained in:
@@ -10,7 +10,8 @@ use Illuminate\Support\Facades\Schema;
|
||||
|
||||
/**
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName) // method names are mandated by laravel.
|
||||
* @SuppressWarnings("TooManyMethods") // I'm fine with this
|
||||
* @SuppressWarnings(PHPMD.TooManyMethods)
|
||||
*
|
||||
*
|
||||
* Down:
|
||||
* 1. Create new Components based on Budgets.
|
||||
|
@@ -5,7 +5,7 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*
|
||||
* Class ChangesForV3310
|
||||
*/
|
||||
|
@@ -4,6 +4,9 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* Class EntrustSetupTables
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
class EntrustSetupTables extends Migration
|
||||
{
|
||||
|
@@ -5,6 +5,9 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* Class ChangesForV345
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
class ChangesForV345 extends Migration
|
||||
{
|
||||
|
@@ -5,6 +5,8 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* Class ChangesForV3462
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
*/
|
||||
class ChangesForV3462 extends Migration
|
||||
{
|
||||
|
@@ -5,6 +5,8 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* Class ChangesForV349
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
*/
|
||||
class ChangesForV349 extends Migration
|
||||
{
|
||||
|
@@ -5,6 +5,8 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* Class ChangesForV3410
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
*/
|
||||
class ChangesForV3410 extends Migration
|
||||
{
|
||||
|
@@ -12,6 +12,9 @@ use Illuminate\Database\Schema\Blueprint;
|
||||
|
||||
/**
|
||||
* Class ChangesForV370
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ShortMethodName)
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
class ChangesForV370 extends Migration
|
||||
{
|
||||
|
@@ -23,6 +23,8 @@ use Illuminate\Database\Seeder;
|
||||
/**
|
||||
*
|
||||
* Class TestDataSeeder
|
||||
* @SuppressWarnings(PHPMD.ExcessiveClassLength)
|
||||
* @SuppressWarnings(PHPMD.TooManyMethods)
|
||||
*/
|
||||
class TestDataSeeder extends Seeder
|
||||
{
|
||||
@@ -39,6 +41,9 @@ class TestDataSeeder extends Seeder
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
public function createRules()
|
||||
{
|
||||
// three rule groups to get started.
|
||||
@@ -433,26 +438,10 @@ class TestDataSeeder extends Seeder
|
||||
$ruleAction->action_value = 'Bills';
|
||||
$ruleAction->save();
|
||||
unset($ruleAction);
|
||||
|
||||
|
||||
// a normal rule: saves transactions where description contains "groceries"
|
||||
// and from account is "MyBank Checking Account"
|
||||
// send it to Groceries/Groceries
|
||||
|
||||
|
||||
//$ruleAction
|
||||
|
||||
// TODO a rule that triggers on something, just like the previous one, but it has "stop_processing" set to 1.
|
||||
// TODO a rule that triggers on that same thing, but it will not file, because the previous rule made FF skip it.
|
||||
|
||||
// TODO rule with specific actions.
|
||||
// TODO rule with actions and one action has stop_processing and other actions are not processed. Somewhere in test?
|
||||
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
public function run()
|
||||
{
|
||||
@@ -545,6 +534,9 @@ class TestDataSeeder extends Seeder
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
protected function createAssetAccounts()
|
||||
{
|
||||
$assets = ['MyBank Checking Account', 'Savings', 'Shared', 'Creditcard', 'Emergencies', 'STE'];
|
||||
@@ -663,6 +655,9 @@ class TestDataSeeder extends Seeder
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
protected function createPiggybanks()
|
||||
{
|
||||
$account = $this->findAccount('Savings');
|
||||
@@ -820,6 +815,8 @@ class TestDataSeeder extends Seeder
|
||||
* @param Carbon $date
|
||||
* @param $amount
|
||||
*
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*
|
||||
* @return TransactionJournal
|
||||
*/
|
||||
protected function createIncome($description, Carbon $date, $amount)
|
||||
@@ -1056,6 +1053,7 @@ class TestDataSeeder extends Seeder
|
||||
|
||||
/**
|
||||
* @param Carbon $date
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
protected function createGroceries(Carbon $date)
|
||||
{
|
||||
@@ -1113,6 +1111,7 @@ class TestDataSeeder extends Seeder
|
||||
|
||||
/**
|
||||
* @param Carbon $date
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
protected function createDrinksAndOthers(Carbon $date)
|
||||
{
|
||||
@@ -1331,6 +1330,12 @@ class TestDataSeeder extends Seeder
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param $date
|
||||
*
|
||||
* @return static
|
||||
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
|
||||
*/
|
||||
protected function createCar($date)
|
||||
{
|
||||
// twice:
|
||||
|
Reference in New Issue
Block a user