From e97283b34b257d86bfb7f524a249b37a8e425ca8 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Sun, 11 Mar 2018 14:13:23 +0100
Subject: [PATCH] Make sure transfers can't get a budget.

---
 app/Factory/TransactionFactory.php | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/Factory/TransactionFactory.php b/app/Factory/TransactionFactory.php
index b0f9406bf8..9ea92e73d2 100644
--- a/app/Factory/TransactionFactory.php
+++ b/app/Factory/TransactionFactory.php
@@ -26,6 +26,7 @@ namespace FireflyIII\Factory;
 
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Services\Internal\Support\TransactionServiceTrait;
 use FireflyIII\User;
 use Illuminate\Support\Collection;
@@ -124,6 +125,11 @@ class TransactionFactory
         }
 
         // set budget:
+        if ($journal->transactionType->type === TransactionType::TRANSFER) {
+            $data['budget_id']   = null;
+            $data['budget_name'] = null;
+        }
+
         $budget = $this->findBudget($data['budget_id'], $data['budget_name']);
         $this->setBudget($source, $budget);
         $this->setBudget($dest, $budget);