Some code cleanup. Fixes the tests.

This commit is contained in:
James Cole
2016-04-25 18:43:09 +02:00
parent 53c80aaef8
commit eb5e55a272
32 changed files with 64 additions and 54 deletions

View File

@@ -119,6 +119,7 @@ class RuleRepository implements RuleRepositoryInterface
$rule->order = ($rule->order + 1);
$rule->save();
$this->resetRulesInGroupOrder($rule->ruleGroup);
return true;
}
@@ -141,6 +142,7 @@ class RuleRepository implements RuleRepositoryInterface
$rule->order = ($rule->order - 1);
$rule->save();
$this->resetRulesInGroupOrder($rule->ruleGroup);
return true;
}
@@ -342,6 +344,7 @@ class RuleRepository implements RuleRepositoryInterface
$this->storeAction($rule, $actionValues);
}
return true;
}
@@ -349,6 +352,7 @@ class RuleRepository implements RuleRepositoryInterface
/**
* @param Rule $rule
* @param array $data
*
* @return bool
*/
private function storeTriggers(Rule $rule, array $data): bool
@@ -378,6 +382,7 @@ class RuleRepository implements RuleRepositoryInterface
$this->storeTrigger($rule, $triggerValues);
$order++;
}
return true;
}
}