diff --git a/app/Support/Steam.php b/app/Support/Steam.php index d462b1553f..8d07f440dd 100644 --- a/app/Support/Steam.php +++ b/app/Support/Steam.php @@ -107,6 +107,9 @@ class Steam if(null === $number) { return '0'; } + if('' === trim($number)) { + return '0'; + } if (str_contains($number, '.')) { if ($number[0] !== '-') { return bcadd($number, '0.'.str_repeat('0', $precision).'5', $precision); diff --git a/app/TransactionRules/Actions/UpdatePiggybank.php b/app/TransactionRules/Actions/UpdatePiggybank.php index 71e0c3cd30..2f55051b10 100644 --- a/app/TransactionRules/Actions/UpdatePiggybank.php +++ b/app/TransactionRules/Actions/UpdatePiggybank.php @@ -89,7 +89,7 @@ class UpdatePiggybank implements ActionInterface if ((int)$source->account_id === (int)$piggyBank->account_id) { Log::debug('Piggy bank account is linked to source, so remove amount from piggy bank.'); - $this->removeAmount($journal, $piggyBank, $destination->amount); + $this->removeAmount($piggyBank, $journalObj, $destination->amount); event(new TriggeredAuditLog($this->action->rule, $journalObj, 'remove_from_piggy', null, ['currency_symbol' => $journalObj->transactionCurrency->symbol, 'decimal_places' => $journalObj->transactionCurrency->decimal_places, 'amount' => $destination->amount, 'piggy' => $piggyBank->name])); @@ -97,7 +97,7 @@ class UpdatePiggybank implements ActionInterface } if ((int)$destination->account_id === (int)$piggyBank->account_id) { Log::debug('Piggy bank account is linked to source, so add amount to piggy bank.'); - $this->addAmount($journal, $piggyBank, $destination->amount); + $this->addAmount($piggyBank, $journalObj, $destination->amount); event(new TriggeredAuditLog($this->action->rule, $journalObj, 'add_to_piggy', null, ['currency_symbol' => $journalObj->transactionCurrency->symbol, 'decimal_places' => $journalObj->transactionCurrency->decimal_places, 'amount' => $destination->amount, 'piggy' => $piggyBank->name]));