Remove inspection, add TODO's, make code a bit simpler.

This commit is contained in:
James Cole
2019-08-16 21:38:35 +02:00
parent 820358af73
commit f09d0e87e4
23 changed files with 79 additions and 90 deletions

View File

@@ -73,7 +73,7 @@ class ShowController extends Controller
);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show an account.
*

View File

@@ -65,7 +65,7 @@ class ShowController extends Controller
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show a single category.
*

View File

@@ -382,7 +382,7 @@ class BudgetController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Shows a budget overview chart (spent and budgeted).
*

View File

@@ -66,7 +66,7 @@ class BudgetReportController extends Controller
);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Chart that groups expenses by the account.
*
@@ -97,7 +97,7 @@ class BudgetReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Chart that groups the expenses by budget.
*
@@ -128,7 +128,7 @@ class BudgetReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Main overview of a budget in the budget report.
*

View File

@@ -260,7 +260,7 @@ class CategoryController extends Controller
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Chart for period for transactions without a category.

View File

@@ -61,7 +61,7 @@ class CategoryReportController extends Controller
);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Chart for expenses grouped by expense account.
*
@@ -89,7 +89,7 @@ class CategoryReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Chart for income grouped by revenue account.
*
@@ -120,7 +120,7 @@ class CategoryReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Chart for expenses grouped by expense account.
*
@@ -151,7 +151,7 @@ class CategoryReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Piechart for income grouped by account.
*
@@ -182,7 +182,7 @@ class CategoryReportController extends Controller
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Main report category chart.
*

View File

@@ -18,7 +18,7 @@
* You should have received a copy of the GNU General Public License
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
/** @noinspection MoreThanThreeArgumentsInspection */
declare(strict_types=1);
namespace FireflyIII\Http\Controllers\Chart;
@@ -64,7 +64,7 @@ class ExpenseReportController extends Controller
);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Main chart that shows income and expense for a combination of expense/revenue accounts.
*

View File

@@ -53,7 +53,7 @@ class TagReportController extends Controller
$this->generator = app(GeneratorInterface::class);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generate expenses for tags grouped on account.
*
@@ -84,7 +84,7 @@ class TagReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generate income for tag grouped by account.
*
@@ -115,7 +115,7 @@ class TagReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generate expense for tag grouped on budget.
*
@@ -145,7 +145,7 @@ class TagReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generate expense for tag grouped on category.
*
@@ -175,7 +175,7 @@ class TagReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generate main tag overview chart.
*
@@ -292,7 +292,7 @@ class TagReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show expense grouped by expense account.
*
@@ -323,7 +323,7 @@ class TagReportController extends Controller
return response()->json($data);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show income grouped by tag.
*

View File

@@ -37,7 +37,7 @@ use Log;
*/
class ExchangeController extends Controller
{
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Returns an exchange rate.
*

View File

@@ -63,7 +63,7 @@ class ExpenseController extends Controller
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generates the overview per budget.
*
@@ -117,7 +117,7 @@ class ExpenseController extends Controller
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Generates the overview per category (spent and earned).
*
@@ -179,7 +179,7 @@ class ExpenseController extends Controller
return $result;
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Overview of spending.
*
@@ -232,7 +232,7 @@ class ExpenseController extends Controller
// for period, get spent and earned for each account (by name)
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* List of top expenses.
*
@@ -284,7 +284,7 @@ class ExpenseController extends Controller
return $result;
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* List of top income.
*

View File

@@ -69,7 +69,7 @@ class ReportController extends Controller
}
);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show account report.
*
@@ -138,7 +138,7 @@ class ReportController extends Controller
return $generator->generate();
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show budget report.
*
@@ -176,7 +176,7 @@ class ReportController extends Controller
return $generator->generate();
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Show category report.
*
@@ -386,7 +386,7 @@ class ReportController extends Controller
return redirect($uri);
}
/** @noinspection MoreThanThreeArgumentsInspection */
/**
* Get a tag report.
*