kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-20 00:20:03 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2018-08-04 17:30:06 +02:00
parent 5af026674f
commit f0d3ca5d53
88 changed files with 552 additions and 311 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Support/Import/Routine/Bunq/StageImportDataHandler.php
View File

@@ -111,6 +111,7 @@ class StageImportDataHandler
* @param LocalAccount $source
*
* @return array
* @throws FireflyException
*/
private function convertPayment(BunqPayment $payment, LocalAccount $source): array
{

2
app/Support/Import/Routine/Fake/StageFinalHandler.php
View File

@@ -47,7 +47,7 @@ class StageFinalHandler
for ($i = 0; $i < 5; $i++) {
$transaction = [
'type' => 'withdrawal',
'date' => Carbon::create()->format('Y-m-d'),
'date' => Carbon::now()->format('Y-m-d'),
'tags' => '',
'user' => $this->importJob->user_id,

2
app/Support/Import/Routine/File/CurrencyMapper.php
View File

@@ -71,7 +71,7 @@ class CurrencyMapper
return $result;
}
}
if (!isset($data['code']) || null === $data['code']) {
if (!isset($data['code'])) {
return null;
}

2
app/Support/Import/Routine/File/ImportableConverter.php
View File

@@ -212,7 +212,7 @@ class ImportableConverter
return [
'type' => $transactionType,
'date' => $this->convertDateValue($importable->date) ?? Carbon::create()->format('Y-m-d'),
'date' => $this->convertDateValue($importable->date) ?? Carbon::now()->format('Y-m-d'),
'tags' => $importable->tags,
'user' => $this->importJob->user_id,
'notes' => $importable->note,

3
app/Support/Import/Routine/Ynab/ImportDataHandler.php
View File

@@ -64,7 +64,7 @@ class ImportDataHandler
/**
* @var string $ynabId
* @var int $localId
* @var string $localId
*/
foreach ($mapping as $ynabId => $localId) {
$localAccount = $this->getLocalAccount((int)$localId);
@@ -252,7 +252,6 @@ class ImportDataHandler
/**
* @param string $token
* @param string $budget
* @param string $account
*
* @return array

2
app/Support/Import/Routine/Ynab/StageGetAccessHandler.php
View File

@@ -45,6 +45,8 @@ class StageGetAccessHandler
/**
* Send a token request to YNAB. Return with access token (if all goes well).
*
* @throws \Psr\Container\NotFoundExceptionInterface
* @throws \Psr\Container\ContainerExceptionInterface
* @throws FireflyException
*/
public function run(): void