mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-10-12 15:35:15 +00:00
Various code cleanup.
This commit is contained in:
@@ -55,14 +55,14 @@ class AddTag implements ActionInterface
|
||||
$factory = app(TagFactory::class);
|
||||
$factory->setUser(User::find($journal['user_id']));
|
||||
$tag = $factory->findOrCreate($this->action->action_value);
|
||||
// @codeCoverageIgnoreStart
|
||||
|
||||
if (null === $tag) {
|
||||
// could not find, could not create tag.
|
||||
Log::error(sprintf('RuleAction AddTag. Could not find or create tag "%s"', $this->action->action_value));
|
||||
|
||||
return false;
|
||||
}
|
||||
// @codeCoverageIgnoreEnd
|
||||
|
||||
$count = DB::table('tag_transaction_journal')
|
||||
->where('tag_id', $tag->id)
|
||||
->where('transaction_journal_id', $journal['transaction_journal_id'])
|
||||
|
@@ -91,7 +91,7 @@ class ConvertToTransfer implements ActionInterface
|
||||
return $this->convertDepositArray($journal, $asset);
|
||||
}
|
||||
|
||||
return false; // @codeCoverageIgnore
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@@ -73,7 +73,7 @@ class ConvertToWithdrawal implements ActionInterface
|
||||
return $this->convertTransferArray($journal);
|
||||
}
|
||||
|
||||
return false; // @codeCoverageIgnore
|
||||
return false;
|
||||
}
|
||||
|
||||
private function convertDepositArray(array $journal): bool
|
||||
|
Reference in New Issue
Block a user