kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-03 03:00:14 +00:00
Code Issues Projects Releases Wiki Activity

Various code fixes.

Browse Source
This commit is contained in:
James Cole
2022-11-04 05:11:05 +01:00
parent 8d8f81c27d
commit f16b679049
48 changed files with 226 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Services/Internal/Update/GroupUpdateService.php
View File

@@ -60,7 +60,7 @@ class GroupUpdateService
}
if (empty($transactions)) {
if (0 === count($transactions)) {
Log::debug('No transactions submitted, do nothing.');
return $transactionGroup;
@@ -119,7 +119,7 @@ class GroupUpdateService
private function updateTransactionJournal(TransactionGroup $transactionGroup, TransactionJournal $journal, array $data): void
{
Log::debug(sprintf('Now in %s', __METHOD__));
if (empty($data)) {
if (0 === count($data)) {
return;
}
if (1 === count($data) && array_key_exists('transaction_journal_id', $data)) {

4
app/Services/Internal/Update/RecurrenceUpdateService.php
View File

@@ -150,7 +150,7 @@ class RecurrenceUpdateService
private function updateRepetitions(Recurrence $recurrence, array $repetitions): void
{
$originalCount = $recurrence->recurrenceRepetitions()->count();
if (empty($repetitions)) {
if (0 === count($repetitions)) {
// wont drop repetition, rather avoid.
return;
}
@@ -228,7 +228,7 @@ class RecurrenceUpdateService
private function updateTransactions(Recurrence $recurrence, array $transactions): void
{
$originalCount = $recurrence->recurrenceTransactions()->count();
if (empty($transactions)) {
if (0 === count($transactions)) {
// wont drop transactions, rather avoid.
return;
}