Code clean up [skip ci]

app/Http/Controllers/AccountController.php

@@ -173,9 +173,9 @@ class AccountController extends Controller
         $types        = config('firefly.accountTypesByIdentifier.' . $what);
         $accounts     = $crud->getAccountsByType($types);
         /** @var Carbon $start */
-        $start        = clone session('start', Carbon::now()->startOfMonth());
+        $start = clone session('start', Carbon::now()->startOfMonth());
         /** @var Carbon $end */
-        $end          = clone session('end', Carbon::now()->endOfMonth());
+        $end = clone session('end', Carbon::now()->endOfMonth());
         $start->subDay();
 
         $ids           = $accounts->pluck('id')->toArray();
@@ -207,16 +207,16 @@ class AccountController extends Controller
         $subTitle     = $account->name;
         $range        = Preferences::get('viewRange', '1M')->data;
         /** @var Carbon $start */
-        $start        = session('start', Navigation::startOfPeriod(new Carbon, $range));
+        $start = session('start', Navigation::startOfPeriod(new Carbon, $range));
         /** @var Carbon $end */
-        $end          = session('end', Navigation::endOfPeriod(new Carbon, $range));
-        $page         = intval(Input::get('page'));
-        $pageSize     = Preferences::get('transactionPageSize', 50)->data;
-        $offset       = ($page - 1) * $pageSize;
-        $set          = $repository->journalsInPeriod(new Collection([$account]), [], $start, $end);
-        $count        = $set->count();
-        $subSet       = $set->splice($offset, $pageSize);
-        $journals     = new LengthAwarePaginator($subSet, $count, $pageSize, $page);
+        $end      = session('end', Navigation::endOfPeriod(new Carbon, $range));
+        $page     = intval(Input::get('page'));
+        $pageSize = Preferences::get('transactionPageSize', 50)->data;
+        $offset   = ($page - 1) * $pageSize;
+        $set      = $repository->journalsInPeriod(new Collection([$account]), [], $start, $end);
+        $count    = $set->count();
+        $subSet   = $set->splice($offset, $pageSize);
+        $journals = new LengthAwarePaginator($subSet, $count, $pageSize, $page);
         $journals->setPath('accounts/show/' . $account->id);
 
         // grouped other months thing:

app/Http/Controllers/Auth/AuthController.php

@@ -11,22 +11,10 @@ declare(strict_types = 1);
 
 namespace FireflyIII\Http\Controllers\Auth;
 
-use Auth;
-use Config;
-use FireflyIII\Events\UserRegistration;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
-use FireflyIII\Support\Facades\FireflyConfig;
 use FireflyIII\User;
 use Illuminate\Foundation\Auth\AuthenticatesAndRegistersUsers;
 use Illuminate\Foundation\Auth\ThrottlesLogins;
-use Illuminate\Http\Request;
-use Illuminate\Mail\Message;
-use Illuminate\Support\Facades\Lang;
-use Log;
-use Mail;
-use Session;
-use Swift_TransportException;
 use Validator;
 
 
@@ -57,7 +45,6 @@ class AuthController extends Controller
     }
 
 
-
     /**
      * Create a new user instance after a valid registration.
      *
@@ -76,11 +63,6 @@ class AuthController extends Controller
     }
 
 
-
-
-
-
-
     /**
      * Get a validator for an incoming registration request.
      *

app/Http/Controllers/BillController.php

@@ -130,7 +130,7 @@ class BillController extends Controller
         /** @var Carbon $start */
         $start = session('start');
         /** @var Carbon $end */
-        $end   = session('end');
+        $end = session('end');
 
         $bills = $repository->getBills();
         $bills->each(

app/Http/Controllers/BudgetController.php

@@ -252,7 +252,8 @@ class BudgetController extends Controller
         $count    = $journals->count();
         $journals = $journals->slice($offset, $pageSize);
         $list     = new LengthAwarePaginator($journals, $count, $pageSize);
-        $subTitle = trans('firefly.without_budget_between',
+        $subTitle = trans(
+            'firefly.without_budget_between',
             ['start' => $start->formatLocalized($this->monthAndDayFormat), 'end' => $end->formatLocalized($this->monthAndDayFormat)]
         );
         $list->setPath('/budgets/list/noBudget');

app/Http/Controllers/CategoryController.php

@@ -166,9 +166,9 @@ class CategoryController extends Controller
      */
     public function show(CRI $repository, AccountCrudInterface $crud, Category $category)
     {
-        $range        = Preferences::get('viewRange', '1M')->data;
+        $range = Preferences::get('viewRange', '1M')->data;
         /** @var Carbon $start */
-        $start        = session('start', Navigation::startOfPeriod(new Carbon, $range));
+        $start = session('start', Navigation::startOfPeriod(new Carbon, $range));
         /** @var Carbon $end */
         $end          = session('end', Navigation::endOfPeriod(new Carbon, $range));
         $hideCategory = true; // used in list.

app/Http/Controllers/Controller.php

@@ -11,15 +11,11 @@ declare(strict_types = 1);
 
 namespace FireflyIII\Http\Controllers;
 
-use App;
-use Auth;
 use Carbon\Carbon;
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
 use Illuminate\Routing\Controller as BaseController;
-use NumberFormatter;
-use Preferences;
 use View;
 
 /**

app/Http/Controllers/CurrencyController.php

@@ -81,7 +81,7 @@ class CurrencyController extends Controller
     }
 
     /**
-     * @param TransactionCurrency         $currency
+     * @param TransactionCurrency $currency
      *
      * @return \Illuminate\Http\RedirectResponse|View
      */
@@ -105,7 +105,7 @@ class CurrencyController extends Controller
     }
 
     /**
-     * @param TransactionCurrency         $currency
+     * @param TransactionCurrency $currency
      *
      * @return \Illuminate\Http\RedirectResponse
      * @throws \Exception

app/Http/Controllers/PiggyBankController.php

@@ -253,7 +253,7 @@ class PiggyBankController extends Controller
      */
     public function postAdd(PiggyBankRepositoryInterface $repository, ARI $accounts, PiggyBank $piggyBank)
     {
-        $amount        = strval(round(Input::get('amount'), 2));
+        $amount = strval(round(Input::get('amount'), 2));
         /** @var Carbon $date */
         $date          = session('end', Carbon::now()->endOfMonth());
         $leftOnAccount = $accounts->leftOnAccount($piggyBank->account, $date);

app/Http/Controllers/Popup/ReportController.php

@@ -112,6 +112,7 @@ class ReportController extends Controller
                         if ($tags === 0) {
                             return true;
                         }
+
                         return false;
                     }
                 );
@@ -194,6 +195,7 @@ class ReportController extends Controller
                 if ($journal->destination_account_id === $account->id) {
                     return true;
                 }
+
                 return false;
             }
         );
@@ -229,6 +231,7 @@ class ReportController extends Controller
                 ) {
                     return true;
                 }
+
                 return false;
             }
         );