Expand tests and fix various small issues in strict comparison.

app/Http/Controllers/Controller.php

@@ -23,10 +23,10 @@ use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
 use Illuminate\Routing\Controller as BaseController;
+use Route;
 use Session;
 use URL;
 use View;
-use Route;
 
 /**
  * Class Controller
@@ -66,10 +66,12 @@ class Controller extends BaseController
                 $this->dateTimeFormat    = (string)trans('config.date_time');
 
                 // get shown-intro-preference:
-                $key       = 'shown_demo_' . Route::currentRouteName();
+                if (auth()->check()) {
-                $shownDemo = Preferences::get($key, false)->data;
+                    $key       = 'shown_demo_' . Route::currentRouteName();
-                View::share('shownDemo', $shownDemo);
+                    $shownDemo = Preferences::get($key, false)->data;
-                View::share('current_route_name', Route::currentRouteName());
+                    View::share('shownDemo', $shownDemo);
+                    View::share('current_route_name', Route::currentRouteName());
+                }
 
                 return $next($request);
             }

app/Models/Account.php

@@ -116,7 +116,7 @@ class Account extends Model
     {
 
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/Attachment.php

@@ -55,7 +55,7 @@ class Attachment extends Model
     {
         if (auth()->check()) {
 
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/Bill.php

@@ -62,7 +62,7 @@ class Bill extends Model
     public static function routeBinder(Bill $value)
     {
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/Budget.php

@@ -85,7 +85,7 @@ class Budget extends Model
     public static function routeBinder(Budget $value)
     {
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/Category.php

@@ -86,7 +86,7 @@ class Category extends Model
     public static function routeBinder(Category $value)
     {
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/Rule.php

@@ -51,7 +51,7 @@ class Rule extends Model
     public static function routeBinder(Rule $value)
     {
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/RuleGroup.php

@@ -52,7 +52,7 @@ class RuleGroup extends Model
     public static function routeBinder(RuleGroup $value)
     {
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

app/Models/Tag.php

@@ -87,7 +87,7 @@ class Tag extends Model
     public static function routeBinder(Tag $value)
     {
         if (auth()->check()) {
-            if ($value->user_id === auth()->user()->id) {
+            if (intval($value->user_id) === auth()->user()->id) {
                 return $value;
             }
         }

config/twigbridge.php

@@ -156,6 +156,7 @@ return [
             'Preferences',
             'URL',
             'Config',
+            'Request',
             'ExpandedForm' => [
                 'is_safe' => [
                     'date', 'text', 'select', 'balance', 'optionsList', 'checkbox', 'amount', 'tags', 'integer', 'textarea', 'location',

resources/views/errors/404.twig

@@ -30,6 +30,8 @@
             <p class="text-danger">
                 The page you have requested does not exist. Please check that you have not entered
                 the wrong URL. Did you make a typo perhaps?
+
+                <!-- {{ Request.url() }} -->
             </p>
         </div>
     </div>

tests/Feature/Controllers/Auth/TwoFactorControllerTest.php

@@ -35,9 +35,16 @@ class TwoFactorControllerTest extends TestCase
         $truePref->data         = true;
         $secretPreference       = new Preference;
         $secretPreference->data = 'BlablaSeecret';
+
+
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthEnabled', false])->andReturn($truePref)->twice();
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret', null])->andReturn($secretPreference)->once();
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret'])->andReturn($secretPreference)->once();
+
+        $falsePref              = new Preference;
+        $falsePref->data        = false;
+        Preferences::shouldReceive('get')->withArgs(['shown_demo_two-factor.index', false])->andReturn($falsePref)->once();
+
         $response = $this->get(route('two-factor.index'));
         $response->assertStatus(200);
     }
@@ -54,6 +61,8 @@ class TwoFactorControllerTest extends TestCase
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthEnabled', false])->andReturn($falsePreference)->twice();
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret', null])->andReturn(null)->once();
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret'])->andReturn(null)->once();
+        Preferences::shouldReceive('get')->withArgs(['shown_demo_two-factor.index', false])->andReturn($falsePreference)->once();
+
         $response = $this->get(route('two-factor.index'));
         $response->assertStatus(302);
         $response->assertRedirect(route('index'));
@@ -74,6 +83,11 @@ class TwoFactorControllerTest extends TestCase
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthEnabled', false])->andReturn($truePref)->twice();
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret', null])->andReturn($secretPreference)->once();
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret'])->andReturn($secretPreference)->once();
+
+        $falsePref              = new Preference;
+        $falsePref->data        = false;
+        Preferences::shouldReceive('get')->withArgs(['shown_demo_two-factor.index', false])->andReturn($falsePref)->once();
+
         $response = $this->get(route('two-factor.index'));
         $response->assertStatus(500);
     }
@@ -92,6 +106,11 @@ class TwoFactorControllerTest extends TestCase
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthEnabled', false])->andReturn($truePreference);
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret', null])->andReturn($secretPreference);
         Preferences::shouldReceive('get')->withArgs(['twoFactorAuthSecret'])->andReturn($secretPreference);
+
+        $falsePref              = new Preference;
+        $falsePref->data        = false;
+        Preferences::shouldReceive('get')->withArgs(['shown_demo_two-factor.lost', false])->andReturn($falsePref)->once();
+
         $response = $this->get(route('two-factor.lost'));
         $response->assertStatus(200);
     }