From fb58bf1bf518e7c82cc59871cfa53d2bef492ee1 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 10:01:33 +0100 Subject: [PATCH] Cleaned up some todo entries [skip ci] --- app/controllers/BudgetController.php | 1 - app/controllers/GoogleChartController.php | 6 - .../Database/AccountType/AccountType.php | 7 - app/lib/FireflyIII/Database/Bill/Bill.php | 3 - app/lib/FireflyIII/Database/Budget/Budget.php | 4 +- .../FireflyIII/Database/Category/Category.php | 3 - .../Database/PiggyBank/PiggyBankShared.php | 1 - .../Database/Transaction/Transaction.php | 6 - .../TransactionCurrency.php | 3 - .../TransactionJournal/TransactionJournal.php | 1 - .../TransactionType/TransactionType.php | 7 - app/lib/FireflyIII/Report/Report.php | 2 - app/lib/FireflyIII/Shared/Toolkit/Amount.php | 2 +- app/tests/PiggybankPartTest.php | 222 ------------------ app/views/repeatedExpense/index.blade.php | 1 - bootstrap/start.php | 2 +- 16 files changed, 3 insertions(+), 268 deletions(-) delete mode 100644 app/tests/PiggybankPartTest.php diff --git a/app/controllers/BudgetController.php b/app/controllers/BudgetController.php index 4d48ce1e8f..c2888d1eab 100644 --- a/app/controllers/BudgetController.php +++ b/app/controllers/BudgetController.php @@ -99,7 +99,6 @@ class BudgetController extends BaseController /** * The index of the budget controller contains all budgets and the current relevant limit repetition. - * TODO move currentRep to the repository. * * @return $this */ diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index aadfc8e5a3..8edd0fe797 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -225,7 +225,6 @@ class GoogleChartController extends BaseController } /** - * TODO query move to helper. * * @return \Illuminate\Http\JsonResponse * @throws \FireflyIII\Exception\FireflyException @@ -256,7 +255,6 @@ class GoogleChartController extends BaseController } /** - * TODO still in use? * * @param Budget $budget * @param LimitRepetition $repetition @@ -290,7 +288,6 @@ class GoogleChartController extends BaseController } /** - * TODO still in use? * * @param Budget $budget * @param $year @@ -341,7 +338,6 @@ class GoogleChartController extends BaseController } /** - * TODO still in use? * * @param Category $component * @param $year @@ -407,7 +403,6 @@ class GoogleChartController extends BaseController } /** - * TODO see reports for better way to do this. * * @param $year * @@ -447,7 +442,6 @@ class GoogleChartController extends BaseController } /** - * TODO see reports for better way to do this. * * @param $year * diff --git a/app/lib/FireflyIII/Database/AccountType/AccountType.php b/app/lib/FireflyIII/Database/AccountType/AccountType.php index a2ec514338..58f6cebb13 100644 --- a/app/lib/FireflyIII/Database/AccountType/AccountType.php +++ b/app/lib/FireflyIII/Database/AccountType/AccountType.php @@ -25,7 +25,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function destroy(Eloquent $model) { - // TODO: Implement destroy() method. throw new NotImplementedException; } @@ -37,7 +36,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function store(array $data) { - // TODO: Implement store() method. throw new NotImplementedException; } @@ -50,7 +48,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function update(Eloquent $model, array $data) { - // TODO: Implement update() method. throw new NotImplementedException; } @@ -65,7 +62,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function validate(array $model) { - // TODO: Implement validate() method. throw new NotImplementedException; } @@ -79,7 +75,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -124,7 +119,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } @@ -136,7 +130,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } } diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index 22bc2f2ea0..65133d8441 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -142,7 +142,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -156,7 +155,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -178,7 +176,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index 770e703c1d..070a39adc2 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -119,7 +119,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -143,7 +142,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } @@ -335,7 +333,7 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf $limit->amount = $amount; $limit->repeat_freq = 'monthly'; $limit->repeats = 0; - $result = $limit->save(); + $limit->save(); \Log::info('ID: ' . $limit->id); /* * A newly stored limit also created a limit repetition. diff --git a/app/lib/FireflyIII/Database/Category/Category.php b/app/lib/FireflyIII/Database/Category/Category.php index a8d1ef3a37..a928c2d34e 100644 --- a/app/lib/FireflyIII/Database/Category/Category.php +++ b/app/lib/FireflyIII/Database/Category/Category.php @@ -108,7 +108,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -122,7 +121,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -144,7 +142,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index e4be2c7bf5..5a878e37f4 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -67,7 +67,6 @@ class PiggyBankShared */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/Transaction/Transaction.php b/app/lib/FireflyIII/Database/Transaction/Transaction.php index 7b3823b93c..a92f110d2e 100644 --- a/app/lib/FireflyIII/Database/Transaction/Transaction.php +++ b/app/lib/FireflyIII/Database/Transaction/Transaction.php @@ -28,7 +28,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function destroy(Eloquent $model) { - // TODO: Implement destroy() method. throw new NotImplementedException; } @@ -68,7 +67,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function update(Eloquent $model, array $data) { - // TODO: Implement update() method. throw new NotImplementedException; } @@ -103,7 +101,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -117,7 +114,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -129,7 +125,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } @@ -141,7 +136,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } } diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index d85daa266c..55b7c5f502 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -98,7 +98,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -112,7 +111,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -134,7 +132,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas */ public function getByIds(array $objectIds) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index a10ba47570..73bc4e3877 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -390,7 +390,6 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php index 8312e08a2a..b3b5191de4 100644 --- a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php +++ b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php @@ -27,7 +27,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function destroy(Eloquent $model) { - // TODO: Implement destroy() method. throw new NotImplementedException; } @@ -39,7 +38,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function store(array $data) { - // TODO: Implement store() method. throw new NotImplementedException; } @@ -52,7 +50,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function update(Eloquent $model, array $data) { - // TODO: Implement update() method. throw new NotImplementedException; } @@ -67,7 +64,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function validate(array $model) { - // TODO: Implement validate() method. throw new NotImplementedException; } @@ -81,7 +77,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -115,7 +110,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } @@ -127,7 +121,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } } diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 340179db5e..a032068318 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -10,8 +10,6 @@ use Illuminate\Database\Query\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; -// todo add methods to interface - /** * Class Report * diff --git a/app/lib/FireflyIII/Shared/Toolkit/Amount.php b/app/lib/FireflyIII/Shared/Toolkit/Amount.php index a419a6b993..39a1db073b 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Amount.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Amount.php @@ -145,4 +145,4 @@ class Amount return $currency->code; } -} \ No newline at end of file +} diff --git a/app/tests/PiggybankPartTest.php b/app/tests/PiggybankPartTest.php deleted file mode 100644 index 5e98b7f5e4..0000000000 --- a/app/tests/PiggybankPartTest.php +++ /dev/null @@ -1,222 +0,0 @@ -object = new PiggyBankPart; - } - - /** - * Tears down the fixture, for example, closes a network connection. - * This method is called after a test is executed. - */ - protected function tearDown() - { - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getReminder - * @todo Implement testGetReminder(). - */ - public function testGetReminder() - { - $this->object->getReminder(); - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setReminder - * @todo Implement testSetReminder(). - */ - public function testSetReminder() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getStartdate - * @todo Implement testGetStartdate(). - */ - public function testGetStartdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setStartdate - * @todo Implement testSetStartdate(). - */ - public function testSetStartdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getTargetdate - * @todo Implement testGetTargetdate(). - */ - public function testGetTargetdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setTargetdate - * @todo Implement testSetTargetdate(). - */ - public function testSetTargetdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getRepetition - * @todo Implement testGetRepetition(). - */ - public function testGetRepetition() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setRepetition - * @todo Implement testSetRepetition(). - */ - public function testSetRepetition() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::hasReminder - * @todo Implement testHasReminder(). - */ - public function testHasReminder() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::percentage - * @todo Implement testPercentage(). - */ - public function testPercentage() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getCurrentamount - * @todo Implement testGetCurrentamount(). - */ - public function testGetCurrentamount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setCurrentamount - * @todo Implement testSetCurrentamount(). - */ - public function testSetCurrentamount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getCumulativeAmount - * @todo Implement testGetCumulativeAmount(). - */ - public function testGetCumulativeAmount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setCumulativeAmount - * @todo Implement testSetCumulativeAmount(). - */ - public function testSetCumulativeAmount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getAmountPerBar - * @todo Implement testGetAmountPerBar(). - */ - public function testGetAmountPerBar() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setAmountPerBar - * @todo Implement testSetAmountPerBar(). - */ - public function testSetAmountPerBar() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } -} diff --git a/app/views/repeatedExpense/index.blade.php b/app/views/repeatedExpense/index.blade.php index 9690c5d830..a25336619a 100644 --- a/app/views/repeatedExpense/index.blade.php +++ b/app/views/repeatedExpense/index.blade.php @@ -9,7 +9,6 @@ - @foreach($expenses as $entry)
diff --git a/bootstrap/start.php b/bootstrap/start.php index a45a61456c..1b7c257703 100644 --- a/bootstrap/start.php +++ b/bootstrap/start.php @@ -97,5 +97,5 @@ Event::subscribe('FireflyIII\Event\TransactionJournal'); // set very tight rules on all models // create custom uniquely rules. // TODO add "Create new X" button to any list there is: categories, accounts, piggies, etc. -// TODO Install PHP5 and code thing and create very small methods. +// Install PHP5 and code thing and create very small methods. return $app;