kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Some general code cleanup.

Browse Source
This commit is contained in:
James Cole
2016-03-03 08:29:56 +01:00
parent 3a236456cd
commit fcf16051a2
7 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Export/Exporter/CsvExporter.php
View File

@@ -14,7 +14,6 @@ use FireflyIII\Export\Entry;
use FireflyIII\Models\ExportJob; use FireflyIII\Models\ExportJob;
use League\Csv\Writer; use League\Csv\Writer;
use SplFileObject; use SplFileObject;
use Storage;
/** /**
* Class CsvExporter * Class CsvExporter

9
app/Helpers/Csv/Specifix/AbnAmroDescription.php
View File

@@ -95,12 +95,13 @@ class AbnAmroDescription extends Specifix implements SpecifixInterface
// description and opposing account will be the same. // description and opposing account will be the same.
$this->data['opposing-account-name'] = $matches[4]; $this->data['opposing-account-name'] = $matches[4];
if( $matches[1] == 'GEA' ) { if ($matches[1] == 'GEA') {
$this->data['description'] = 'GEA ' . $matches[4]; $this->data['description'] = 'GEA ' . $matches[4];
} else { } else {
$this->data['description'] = $matches[4]; $this->data['description'] = $matches[4];
} }
return true; return true;
} }

1
app/Helpers/Help/HelpInterface.php
View File

@@ -18,6 +18,7 @@ interface HelpInterface
public function getFromCache(string $key): string; public function getFromCache(string $key): string;
/** /**
* @param string $language
* @param string $route * @param string $route
* *
* @return array * @return array

2
app/Http/Controllers/Chart/CategoryController.php
View File

@@ -152,6 +152,8 @@ class CategoryController extends Controller
* *
* @param CRI $repository * @param CRI $repository
* *
* @param ARI $accountRepository
*
* @return \Symfony\Component\HttpFoundation\Response * @return \Symfony\Component\HttpFoundation\Response
*/ */
public function frontpage(CRI $repository, ARI $accountRepository) public function frontpage(CRI $repository, ARI $accountRepository)

2
app/Http/Controllers/TagController.php
View File

@@ -222,7 +222,7 @@ class TagController extends Controller
$subTitleIcon = 'fa-tag'; $subTitleIcon = 'fa-tag';
$journals = $tag->transactionjournals()->expanded()->get(TransactionJournal::QUERYFIELDS); $journals = $tag->transactionjournals()->expanded()->get(TransactionJournal::QUERYFIELDS);
return view('tags.show', compact('tag', 'subTitle', 'subTitleIcon','journals')); return view('tags.show', compact('tag', 'subTitle', 'subTitleIcon', 'journals'));
} }
/** /**

8
app/Jobs/ExecuteRuleGroupOnExistingTransactions.php
View File

@@ -7,10 +7,15 @@ use FireflyIII\Models\RuleGroup;
use FireflyIII\Rules\Processor; use FireflyIII\Rules\Processor;
use FireflyIII\User; use FireflyIII\User;
use Illuminate\Contracts\Queue\ShouldQueue; use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Queue\InteractsWithQueue; use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels; use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Collection;
/**
* Class ExecuteRuleGroupOnExistingTransactions
*
* @package FireflyIII\Jobs
*/
class ExecuteRuleGroupOnExistingTransactions extends Job implements ShouldQueue class ExecuteRuleGroupOnExistingTransactions extends Job implements ShouldQueue
{ {
use InteractsWithQueue, SerializesModels; use InteractsWithQueue, SerializesModels;
@@ -29,6 +34,7 @@ class ExecuteRuleGroupOnExistingTransactions extends Job implements ShouldQueue
/** /**
* Create a new job instance. * Create a new job instance.
* *
* @param RuleGroup $ruleGroup
*/ */
public function __construct(RuleGroup $ruleGroup) public function __construct(RuleGroup $ruleGroup)
{ {

4
app/Jobs/MailError.php
View File

@@ -36,7 +36,9 @@ class MailError extends Job implements ShouldQueue
* @param User $user * @param User $user
* @param string $destination * @param string $destination
* @param string $ip * @param string $ip
* @param array $exception * @param array $exceptionData
*
* @internal param array $exception
*/ */
public function __construct(User $user, string $destination, string $ip, array $exceptionData) public function __construct(User $user, string $destination, string $ip, array $exceptionData)
{ {