kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Fix test coverage.

Browse Source
This commit is contained in:
James Cole
2019-08-09 05:58:52 +02:00
parent dcbc2ca0c3
commit fd2f4e1459
6 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Middleware/InterestingMessage.php
View File

@@ -44,7 +44,7 @@ class InterestingMessage
*/
public function handle(Request $request, Closure $next)
{
Log::debug(sprintf('Interesting Message middleware for URI %s', $request->url()));
//Log::debug(sprintf('Interesting Message middleware for URI %s', $request->url()));
if ($this->testing()) {
return $next($request);
}

9
app/Rules/BelongsUser.php
View File

@@ -31,6 +31,7 @@ use FireflyIII\Models\Budget;
use FireflyIII\Models\Category;
use FireflyIII\Models\PiggyBank;
use Illuminate\Contracts\Validation\Rule;
use Log;
/**
* Class BelongsUser
@@ -78,6 +79,7 @@ class BelongsUser implements Rule
return true; // @codeCoverageIgnore
}
$attribute = (string)$attribute;
Log::debug(sprintf('Going to validate %s', $attribute));
switch ($attribute) {
case 'piggy_bank_id':
return $this->validatePiggyBankId((int)$value);
@@ -112,6 +114,7 @@ class BelongsUser implements Rule
*/
protected function countField(string $class, string $field, string $value): int
{
$value = trim($value);
$objects = [];
// get all objects belonging to user:
if (PiggyBank::class === $class) {
@@ -124,8 +127,11 @@ class BelongsUser implements Rule
}
$count = 0;
foreach ($objects as $object) {
if (trim((string)$object->$field) === trim($value)) {
$objectValue = trim((string)$object->$field);
Log::debug(sprintf('Comparing object "%s" with value "%s"', $objectValue, $value));
if ($objectValue === $value) {
$count++;
Log::debug(sprintf('Hit! Count is now %d', $count));
}
}
@@ -182,6 +188,7 @@ class BelongsUser implements Rule
private function validateBillName(string $value): bool
{
$count = $this->countField(Bill::class, 'name', $value);
Log::debug(sprintf('Result of countField for bill name "%s" is %d', $value, $count));
return 1 === $count;
}