kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Some TODO's for the future.

Browse Source
This commit is contained in:
James Cole
2019-08-16 06:20:07 +02:00
parent 1ba45afeab
commit fdf99400bc
11 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Support/Import/JobConfiguration/Ynab/SelectAccountsHandler.php
View File

@@ -127,6 +127,7 @@ class SelectAccountsHandler implements YnabJobConfigurationInterface
/** @var Account $account */
foreach ($ffAccounts as $account) {
$accountId = $account->id;
// TODO we can use getAccountCurrency() instead
$currencyId = (int)$this->accountRepository->getMetaValue($account, 'currency_id');
$currency = $this->getCurrency($currencyId);
$array[$accountId] = [

1
app/Support/Import/JobConfiguration/Ynab/SelectBudgetHandler.php
View File

@@ -170,6 +170,7 @@ class SelectBudgetHandler implements YnabJobConfigurationInterface
}
/** @var Account $account */
foreach ($this->accounts as $account) {
// TODO we can use getAccountCurrency() instead
$currencyId = (int)$this->accountRepository->getMetaValue($account, 'currency_id');
Log::debug(sprintf('Currency of %s is %d (looking for %d).', $account->name, $currencyId, $currency->id));
if ($currencyId === $currency->id) {