kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-22 20:16:22 +00:00
Code Issues Projects Releases Wiki Activity

fix phpstan warnings

Browse Source
This commit is contained in:
James Cole
2025-01-03 15:53:10 +01:00
parent d95f3ca59f
commit fe4d139817
173 changed files with 374 additions and 360 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Validation/Account/DepositValidation.php
View File

@@ -83,8 +83,8 @@ trait DepositValidation
/**
* Pretty complex unfortunately.
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
*/
protected function validateDepositSource(array $array): bool
{

6
app/Validation/AccountValidator.php
View File

@@ -251,9 +251,9 @@ class AccountValidator
/**
* It's a long and fairly complex method, but I don't mind.
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.BooleanArgumentFlag)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
* @SuppressWarnings("PHPMD.BooleanArgumentFlag")
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
protected function findExistingAccount(array $validTypes, array $data, bool $inverse = false): ?Account
{

2
app/Validation/AutoBudget/ValidatesAutoBudgetRequest.php
View File

@@ -32,7 +32,7 @@ use Illuminate\Validation\Validator;
trait ValidatesAutoBudgetRequest
{
/**
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
protected function validateAutoBudgetAmount(Validator $validator): void
{

36
app/Validation/FireflyValidator.php
View File

@@ -57,7 +57,7 @@ class FireflyValidator extends Validator
* @throws InvalidCharactersException
* @throws SecretKeyTooShortException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate2faCode($attribute, $value): bool
{
@@ -85,7 +85,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateBelongsToUser($attribute, $value, $parameters): bool
{
@@ -103,7 +103,7 @@ class FireflyValidator extends Validator
* @param mixed $attribute
* @param mixed $value
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateBic($attribute, $value): bool
{
@@ -133,8 +133,8 @@ class FireflyValidator extends Validator
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function validateIban(mixed $attribute, mixed $value): bool
{
@@ -229,7 +229,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateLess($attribute, $value, $parameters): bool
{
@@ -244,7 +244,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateMore($attribute, $value, $parameters): bool
{
@@ -259,7 +259,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateMustExist($attribute, $value, $parameters): bool
{
@@ -443,7 +443,7 @@ class FireflyValidator extends Validator
* @param mixed $attribute
* @param mixed $value
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateSecurePassword($attribute, $value): bool
{
@@ -466,7 +466,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueAccountForUser($attribute, $value, $parameters): bool
{
@@ -614,7 +614,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueAccountNumberForUser($attribute, $value, $parameters): bool
{
@@ -668,7 +668,7 @@ class FireflyValidator extends Validator
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueCurrencyCode(?string $attribute, ?string $value): bool
{
@@ -676,7 +676,7 @@ class FireflyValidator extends Validator
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueCurrency(string $field, string $attribute, string $value): bool
{
@@ -698,7 +698,7 @@ class FireflyValidator extends Validator
* @param mixed $parameters
* @param mixed $something
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueExistingWebhook($value, $parameters, $something): bool
{
@@ -753,7 +753,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueObjectForUser($attribute, $value, $parameters): bool
{
@@ -787,7 +787,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueObjectGroup($attribute, $value, $parameters): bool
{
@@ -809,7 +809,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniquePiggyBankForUser($attribute, $value, $parameters): bool
{
@@ -830,7 +830,7 @@ class FireflyValidator extends Validator
* @param mixed $value
* @param mixed $parameters
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateUniqueWebhook($value, $parameters): bool
{

2
app/Validation/RecurrenceValidation.php
View File

@@ -301,7 +301,7 @@ trait RecurrenceValidation
}
/**
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
protected function validateTransactionId(Recurrence $recurrence, Validator $validator): void
{

15
app/Validation/TransactionValidation.php
View File

@@ -34,6 +34,7 @@ use FireflyIII\Models\TransactionGroup;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Models\UserGroup;
use FireflyIII\Repositories\Account\AccountRepository;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\User;
use Illuminate\Validation\Validator;
@@ -61,7 +62,7 @@ trait TransactionValidation
app('log')->debug(sprintf('Going to loop %d transaction(s)', count($transactions)));
/**
* @var null|int $index
* @var string|int $index
* @var array $transaction
*/
foreach ($transactions as $index => $transaction) {
@@ -91,7 +92,7 @@ trait TransactionValidation
}
/**
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
protected function validateSingleAccount(Validator $validator, int $index, string $transactionType, array $transaction): void
{
@@ -155,7 +156,7 @@ trait TransactionValidation
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
protected function sanityCheckReconciliation(Validator $validator, string $transactionType, int $index, array $source, array $destination): void
{
@@ -184,8 +185,8 @@ trait TransactionValidation
/**
* TODO describe this method.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
private function sanityCheckForeignCurrency(
Validator $validator,
@@ -222,7 +223,7 @@ trait TransactionValidation
return;
}
/** @var AccountRepositoryInterface $accountRepository */
/** @var AccountRepository $accountRepository */
$accountRepository = app(AccountRepositoryInterface::class);
$defaultCurrency = app('amount')->getDefaultCurrency();
$sourceCurrency = $accountRepository->getAccountCurrency($source) ?? $defaultCurrency;
@@ -347,7 +348,7 @@ trait TransactionValidation
$transactions = $this->getTransactionsArray($validator);
/**
* @var null|int $index
* @var string|int $index
* @var array $transaction
*/
foreach ($transactions as $index => $transaction) {