kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

fix phpstan warnings

Browse Source
This commit is contained in:
James Cole
2025-01-03 15:53:10 +01:00
parent d95f3ca59f
commit fe4d139817
173 changed files with 374 additions and 360 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/Validation/TransactionValidation.php
View File

@@ -34,6 +34,7 @@ use FireflyIII\Models\TransactionGroup;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Models\UserGroup;
use FireflyIII\Repositories\Account\AccountRepository;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\User;
use Illuminate\Validation\Validator;
@@ -61,7 +62,7 @@ trait TransactionValidation
app('log')->debug(sprintf('Going to loop %d transaction(s)', count($transactions)));
/**
* @var null|int $index
* @var string|int $index
* @var array $transaction
*/
foreach ($transactions as $index => $transaction) {
@@ -91,7 +92,7 @@ trait TransactionValidation
}
/**
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
protected function validateSingleAccount(Validator $validator, int $index, string $transactionType, array $transaction): void
{
@@ -155,7 +156,7 @@ trait TransactionValidation
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
protected function sanityCheckReconciliation(Validator $validator, string $transactionType, int $index, array $source, array $destination): void
{
@@ -184,8 +185,8 @@ trait TransactionValidation
/**
* TODO describe this method.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
private function sanityCheckForeignCurrency(
Validator $validator,
@@ -222,7 +223,7 @@ trait TransactionValidation
return;
}
/** @var AccountRepositoryInterface $accountRepository */
/** @var AccountRepository $accountRepository */
$accountRepository = app(AccountRepositoryInterface::class);
$defaultCurrency = app('amount')->getDefaultCurrency();
$sourceCurrency = $accountRepository->getAccountCurrency($source) ?? $defaultCurrency;
@@ -347,7 +348,7 @@ trait TransactionValidation
$transactions = $this->getTransactionsArray($validator);
/**
* @var null|int $index
* @var string|int $index
* @var array $transaction
*/
foreach ($transactions as $index => $transaction) {