fix phpstan warnings

2025-10-12 15:35:15 +00:00 · 2025-01-03 15:53:10 +01:00
parent d95f3ca59f
commit fe4d139817
173 changed files with 374 additions and 360 deletions
--- a/database/migrations/2016_06_16_000000_create_support_tables.php
+++ b/database/migrations/2016_06_16_000000_create_support_tables.php
@@ -55,7 +55,7 @@ class CreateSupportTables extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_06_16_000001_create_users_table.php
+++ b/database/migrations/2016_06_16_000001_create_users_table.php
@@ -46,7 +46,7 @@ class CreateUsersTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_06_16_000002_create_main_tables.php
+++ b/database/migrations/2016_06_16_000002_create_main_tables.php
@@ -73,7 +73,7 @@ class CreateMainTables extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
@@ -368,7 +368,7 @@ class CreateMainTables extends Migration
    }

    /**
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings("PHPMD.ExcessiveMethodLength")
     */
    private function createRuleTables(): void
    {
@@ -507,8 +507,8 @@ class CreateMainTables extends Migration
    }

    /**
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * @SuppressWarnings(PHPMD.NPathComplexity)
+     * @SuppressWarnings("PHPMD.ExcessiveMethodLength")
+     * @SuppressWarnings("PHPMD.NPathComplexity")
     */
    private function createTransactionTables(): void
    {
--- a/database/migrations/2016_08_25_091522_changes_for_3101.php
+++ b/database/migrations/2016_08_25_091522_changes_for_3101.php
@@ -38,7 +38,7 @@ class ChangesFor3101 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void {}
 }
--- a/database/migrations/2016_09_12_121359_fix_nullables.php
+++ b/database/migrations/2016_09_12_121359_fix_nullables.php
@@ -43,7 +43,7 @@ class FixNullables extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_10_09_150037_expand_transactions_table.php
+++ b/database/migrations/2016_10_09_150037_expand_transactions_table.php
@@ -55,7 +55,7 @@ class ExpandTransactionsTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_10_22_075804_changes_for_v410.php
+++ b/database/migrations/2016_10_22_075804_changes_for_v410.php
@@ -43,7 +43,7 @@ class ChangesForV410 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_11_24_210552_changes_for_v420.php
+++ b/database/migrations/2016_11_24_210552_changes_for_v420.php
@@ -55,7 +55,7 @@ class ChangesForV420 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_12_22_150431_changes_for_v430.php
+++ b/database/migrations/2016_12_22_150431_changes_for_v430.php
@@ -43,7 +43,7 @@ class ChangesForV430 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2016_12_28_203205_changes_for_v431.php
+++ b/database/migrations/2016_12_28_203205_changes_for_v431.php
@@ -112,7 +112,7 @@ class ChangesForV431 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2017_04_13_163623_changes_for_v440.php
+++ b/database/migrations/2017_04_13_163623_changes_for_v440.php
@@ -61,7 +61,7 @@ class ChangesForV440 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2017_06_02_105232_changes_for_v450.php
+++ b/database/migrations/2017_06_02_105232_changes_for_v450.php
@@ -84,7 +84,7 @@ class ChangesForV450 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2017_08_20_062014_changes_for_v470.php
+++ b/database/migrations/2017_08_20_062014_changes_for_v470.php
@@ -45,7 +45,7 @@ class ChangesForV470 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2017_11_04_170844_changes_for_v470a.php
+++ b/database/migrations/2017_11_04_170844_changes_for_v470a.php
@@ -56,7 +56,7 @@ class ChangesForV470a extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_01_01_000001_create_oauth_auth_codes_table.php
+++ b/database/migrations/2018_01_01_000001_create_oauth_auth_codes_table.php
@@ -45,7 +45,7 @@ class CreateOauthAuthCodesTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_01_01_000002_create_oauth_access_tokens_table.php
+++ b/database/migrations/2018_01_01_000002_create_oauth_access_tokens_table.php
@@ -45,7 +45,7 @@ class CreateOauthAccessTokensTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_01_01_000003_create_oauth_refresh_tokens_table.php
+++ b/database/migrations/2018_01_01_000003_create_oauth_refresh_tokens_table.php
@@ -45,7 +45,7 @@ class CreateOauthRefreshTokensTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_01_01_000004_create_oauth_clients_table.php
+++ b/database/migrations/2018_01_01_000004_create_oauth_clients_table.php
@@ -45,7 +45,7 @@ class CreateOauthClientsTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_01_01_000005_create_oauth_personal_access_clients_table.php
+++ b/database/migrations/2018_01_01_000005_create_oauth_personal_access_clients_table.php
@@ -45,7 +45,7 @@ class CreateOauthPersonalAccessClientsTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_03_19_141348_changes_for_v472.php
+++ b/database/migrations/2018_03_19_141348_changes_for_v472.php
@@ -70,7 +70,7 @@ class ChangesForV472 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_04_07_210913_changes_for_v473.php
+++ b/database/migrations/2018_04_07_210913_changes_for_v473.php
@@ -75,7 +75,7 @@ class ChangesForV473 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_04_29_174524_changes_for_v474.php
+++ b/database/migrations/2018_04_29_174524_changes_for_v474.php
@@ -39,7 +39,7 @@ class ChangesForV474 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void {}
 }
--- a/database/migrations/2018_06_08_200526_changes_for_v475.php
+++ b/database/migrations/2018_06_08_200526_changes_for_v475.php
@@ -48,8 +48,8 @@ class ChangesForV475 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
+     * @SuppressWarnings("PHPMD.ExcessiveMethodLength")
     */
    public function up(): void
    {
--- a/database/migrations/2018_09_05_195147_changes_for_v477.php
+++ b/database/migrations/2018_09_05_195147_changes_for_v477.php
@@ -61,7 +61,7 @@ class ChangesForV477 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2018_11_06_172532_changes_for_v479.php
+++ b/database/migrations/2018_11_06_172532_changes_for_v479.php
@@ -56,7 +56,7 @@ class ChangesForV479 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2019_01_28_193833_changes_for_v4710.php
+++ b/database/migrations/2019_01_28_193833_changes_for_v4710.php
@@ -46,7 +46,7 @@ class ChangesForV4710 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2019_02_05_055516_changes_for_v4711.php
+++ b/database/migrations/2019_02_05_055516_changes_for_v4711.php
@@ -42,7 +42,7 @@ class ChangesForV4711 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2019_02_11_170529_changes_for_v4712.php
+++ b/database/migrations/2019_02_11_170529_changes_for_v4712.php
@@ -42,7 +42,7 @@ class ChangesForV4712 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2019_03_11_223700_fix_ldap_configuration.php
+++ b/database/migrations/2019_03_11_223700_fix_ldap_configuration.php
@@ -57,7 +57,7 @@ class FixLdapConfiguration extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2019_03_22_183214_changes_for_v480.php
+++ b/database/migrations/2019_03_22_183214_changes_for_v480.php
@@ -113,7 +113,7 @@ class ChangesForV480 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2019_12_28_191351_make_locations_table.php
+++ b/database/migrations/2019_12_28_191351_make_locations_table.php
@@ -45,7 +45,7 @@ class MakeLocationsTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2020_03_13_201950_changes_for_v520.php
+++ b/database/migrations/2020_03_13_201950_changes_for_v520.php
@@ -45,7 +45,7 @@ class ChangesForV520 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2020_06_07_063612_changes_for_v530.php
+++ b/database/migrations/2020_06_07_063612_changes_for_v530.php
@@ -45,7 +45,7 @@ class ChangesForV530 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2020_06_30_202620_changes_for_v530a.php
+++ b/database/migrations/2020_06_30_202620_changes_for_v530a.php
@@ -57,7 +57,7 @@ class ChangesForV530a extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2020_07_24_162820_changes_for_v540.php
+++ b/database/migrations/2020_07_24_162820_changes_for_v540.php
@@ -98,7 +98,7 @@ class ChangesForV540 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2020_11_12_070604_changes_for_v550.php
+++ b/database/migrations/2020_11_12_070604_changes_for_v550.php
@@ -122,9 +122,9 @@ class ChangesForV550 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * @SuppressWarnings(PHPMD.NPathComplexity)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
+     * @SuppressWarnings("PHPMD.ExcessiveMethodLength")
+     * @SuppressWarnings("PHPMD.NPathComplexity")
     */
    public function up(): void
    {
--- a/database/migrations/2021_03_12_061213_changes_for_v550b2.php
+++ b/database/migrations/2021_03_12_061213_changes_for_v550b2.php
@@ -60,7 +60,7 @@ class ChangesForV550b2 extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2021_05_09_064644_add_ldap_columns_to_users_table.php
+++ b/database/migrations/2021_05_09_064644_add_ldap_columns_to_users_table.php
@@ -52,7 +52,7 @@ class AddLdapColumnsToUsersTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2021_05_13_053836_extend_currency_info.php
+++ b/database/migrations/2021_05_13_053836_extend_currency_info.php
@@ -40,7 +40,7 @@ class ExtendCurrencyInfo extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2021_07_05_193044_drop_tele_table.php
+++ b/database/migrations/2021_07_05_193044_drop_tele_table.php
@@ -41,7 +41,7 @@ class DropTeleTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2021_08_28_073733_user_groups.php
+++ b/database/migrations/2021_08_28_073733_user_groups.php
@@ -106,8 +106,8 @@ class UserGroups extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
+     * @SuppressWarnings("PHPMD.ExcessiveMethodLength")
     */
    public function up(): void
    {
--- a/database/migrations/2021_12_27_000001_create_local_personal_access_tokens_table.php
+++ b/database/migrations/2021_12_27_000001_create_local_personal_access_tokens_table.php
@@ -43,7 +43,7 @@ class CreateLocalPersonalAccessTokensTable extends Migration
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2022_08_21_104626_add_user_groups.php
+++ b/database/migrations/2022_08_21_104626_add_user_groups.php
@@ -31,7 +31,7 @@ return new class () extends Migration {
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2022_09_18_123911_create_notifications_table.php
+++ b/database/migrations/2022_09_18_123911_create_notifications_table.php
@@ -31,7 +31,7 @@ return new class () extends Migration {
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2022_10_01_074908_invited_users.php
+++ b/database/migrations/2022_10_01_074908_invited_users.php
@@ -31,7 +31,7 @@ return new class () extends Migration {
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2022_10_01_210238_audit_log_entries.php
+++ b/database/migrations/2022_10_01_210238_audit_log_entries.php
@@ -31,7 +31,7 @@ return new class () extends Migration {
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2023_08_11_192521_upgrade_og_table.php
+++ b/database/migrations/2023_08_11_192521_upgrade_og_table.php
@@ -31,7 +31,7 @@ return new class () extends Migration {
    /**
     * Run the migrations.
     *
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     */
    public function up(): void
    {
--- a/database/migrations/2023_10_21_113213_add_currency_pivot_tables.php
+++ b/database/migrations/2023_10_21_113213_add_currency_pivot_tables.php
@@ -29,7 +29,7 @@ use Illuminate\Support\Facades\Schema;

 return new class () extends Migration {
    /**
-     * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings("PHPMD.ShortMethodName")
     * Run the migrations.
     */
    public function up(): void
--- a/database/seeders/ExchangeRateSeeder.php
+++ b/database/seeders/ExchangeRateSeeder.php
@@ -87,7 +87,7 @@ class ExchangeRateSeeder extends Seeder
    }

    /**
-     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
+     * @SuppressWarnings("PHPMD.ExcessiveParameterList")
     */
    private function addRate(User $user, TransactionCurrency $from, TransactionCurrency $to, string $date, float $rate): void
    {