No need to use the exception either.

Catch random exception because why not.
Merge pull request #10886 from firefly-iii/release-1757480185
2025-09-16 09:51:16 +00:00 · 2025-09-10 07:03:41 +02:00 · 2025-09-10 07:03:23 +02:00 · 2025-09-10 06:56:34 +02:00 · 2025-09-10 06:56:25 +02:00 · 2025-09-10 06:51:11 +02:00
7 changed files with 29 additions and 23 deletions
--- a/app/Console/Commands/System/OutputsInstructions.php
+++ b/app/Console/Commands/System/OutputsInstructions.php
@@ -27,6 +27,7 @@ namespace FireflyIII\Console\Commands\System;
 use Carbon\Carbon;
 use FireflyIII\Support\System\GeneratesInstallationId;
 use Illuminate\Console\Command;
+use Random\RandomException;

 class OutputsInstructions extends Command
 {
@@ -266,7 +267,11 @@ class OutputsInstructions extends Command
            ];
        }

-        $random    = random_int(0, count($lines) - 1);
+        try {
+            $random = random_int(0, count($lines) - 1);
+        } catch (RandomException) {
+            $random = 0;
+        }
        if ($addQuotes) {
            $this->line(sprintf('       "%s"', $lines[$random]));

--- a/app/Helpers/Collector/Extensions/MetaCollection.php
+++ b/app/Helpers/Collector/Extensions/MetaCollection.php
@@ -24,6 +24,7 @@ declare(strict_types=1);

 namespace FireflyIII\Helpers\Collector\Extensions;

+use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\Bill;
 use FireflyIII\Models\Budget;
@@ -919,6 +920,8 @@ trait MetaCollection
    {
        $this->withCategoryInformation();
        $this->query->whereNull('category_transaction_journal.category_id');
+        // better fix for #10507
+        $this->query->whereNotIn('transaction_types.type', [TransactionTypeEnum::OPENING_BALANCE->value]);

        return $this;
    }
--- a/app/Helpers/Collector/GroupCollector.php
+++ b/app/Helpers/Collector/GroupCollector.php
@@ -1095,9 +1095,6 @@ class GroupCollector implements GroupCollectorInterface
            ->whereNull('transaction_groups.deleted_at')
            ->whereNull('transaction_journals.deleted_at')
            ->whereNull('source.deleted_at')
-
-            // #10507 ignore opening balance.
-            ->where('transaction_types.type', '!=', TransactionTypeEnum::OPENING_BALANCE->value)
            ->whereNotNull('transaction_groups.id')
            ->whereNull('destination.deleted_at')
            ->orderBy('transaction_journals.date', 'DESC')
--- a/changelog.md
+++ b/changelog.md
@@ -29,6 +29,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - [Discussion 10846](https://github.com/orgs/firefly-iii/discussions/10846) (Add support for WebP format in attachments) started by @Idestius
 - [Issue 10853](https://github.com/firefly-iii/firefly-iii/issues/10853) (Failed to Send Discord Notification) reported by @pimonteiro
 - [Issue 10854](https://github.com/firefly-iii/firefly-iii/issues/10854) (string / null in budget causes budget page to not render) reported by @4e868df3
+- [Discussion 10883](https://github.com/orgs/firefly-iii/discussions/10883) (Initial balance for account is missing from exported CSV) started by @ajaskiewiczpl

 ### API

--- a/composer.lock
+++ b/composer.lock
@@ -10738,16 +10738,16 @@
        },
        {
            "name": "larastan/larastan",
-            "version": "v3.6.1",
+            "version": "v3.7.0",
            "source": {
                "type": "git",
                "url": "https://github.com/larastan/larastan.git",
-                "reference": "3c223047e374befd1b64959784685d6ecccf66aa"
+                "reference": "6b7d28a2762a4b69f0f064e1e5b7358af11f04e4"
            },
            "dist": {
                "type": "zip",
-                "url": "https://api.github.com/repos/larastan/larastan/zipball/3c223047e374befd1b64959784685d6ecccf66aa",
-                "reference": "3c223047e374befd1b64959784685d6ecccf66aa",
+                "url": "https://api.github.com/repos/larastan/larastan/zipball/6b7d28a2762a4b69f0f064e1e5b7358af11f04e4",
+                "reference": "6b7d28a2762a4b69f0f064e1e5b7358af11f04e4",
                "shasum": ""
            },
            "require": {
@@ -10815,7 +10815,7 @@
            ],
            "support": {
                "issues": "https://github.com/larastan/larastan/issues",
-                "source": "https://github.com/larastan/larastan/tree/v3.6.1"
+                "source": "https://github.com/larastan/larastan/tree/v3.7.0"
            },
            "funding": [
                {
@@ -10823,7 +10823,7 @@
                    "type": "github"
                }
            ],
-            "time": "2025-08-25T07:24:56+00:00"
+            "time": "2025-09-09T15:17:27+00:00"
        },
        {
            "name": "laravel-json-api/testing",
--- a/config/firefly.php
+++ b/config/firefly.php
@@ -78,8 +78,8 @@ return [
        'running_balance_column' => env('USE_RUNNING_BALANCE', false),
        // see cer.php for exchange rates feature flag.
    ],
-    'version'                      => 'develop/2025-09-09',
-    'build_time'                   => 1757425682,
+    'version'                      => 'develop/2025-09-10',
+    'build_time'                   => 1757480083,
    'api_version'                  => '2.1.0', // field is no longer used.
    'db_version'                   => 26,

--- a/package-lock.json
+++ b/package-lock.json
@@ -9923,9 +9923,9 @@
            "license": "MIT"
        },
        "node_modules/regenerate-unicode-properties": {
-            "version": "10.2.0",
-            "resolved": "https://registry.npmjs.org/regenerate-unicode-properties/-/regenerate-unicode-properties-10.2.0.tgz",
-            "integrity": "sha512-DqHn3DwbmmPVzeKj9woBadqmXxLvQoQIwu7nopMc72ztvxVmVk2SBhSnx67zuye5TP+lJsb/TBQsjLKhnDf3MA==",
+            "version": "10.2.2",
+            "resolved": "https://registry.npmjs.org/regenerate-unicode-properties/-/regenerate-unicode-properties-10.2.2.tgz",
+            "integrity": "sha512-m03P+zhBeQd1RGnYxrGyDAPpWX/epKirLrp8e3qevZdVkKtnCrjjWczIbYc8+xd6vcTStVlqfycTx1KR4LOr0g==",
            "dev": true,
            "license": "MIT",
            "dependencies": {
@@ -9936,18 +9936,18 @@
            }
        },
        "node_modules/regexpu-core": {
-            "version": "6.2.0",
-            "resolved": "https://registry.npmjs.org/regexpu-core/-/regexpu-core-6.2.0.tgz",
-            "integrity": "sha512-H66BPQMrv+V16t8xtmq+UC0CBpiTBA60V8ibS1QVReIp8T1z8hwFxqcGzm9K6lgsN7sB5edVH8a+ze6Fqm4weA==",
+            "version": "6.3.0",
+            "resolved": "https://registry.npmjs.org/regexpu-core/-/regexpu-core-6.3.0.tgz",
+            "integrity": "sha512-ulzJYRb0qgR4t8eTgHeL7nnKL/4ul2yjnuTBEDIpYG7cSs8CcADE1q18RFFChXLP8WwRgPrHThGbYplvASdujw==",
            "dev": true,
            "license": "MIT",
            "dependencies": {
                "regenerate": "^1.4.2",
-                "regenerate-unicode-properties": "^10.2.0",
+                "regenerate-unicode-properties": "^10.2.2",
                "regjsgen": "^0.8.0",
                "regjsparser": "^0.12.0",
                "unicode-match-property-ecmascript": "^2.0.0",
-                "unicode-match-property-value-ecmascript": "^2.1.0"
+                "unicode-match-property-value-ecmascript": "^2.2.1"
            },
            "engines": {
                "node": ">=4"
@@ -11377,9 +11377,9 @@
            }
        },
        "node_modules/unicode-match-property-value-ecmascript": {
-            "version": "2.2.0",
-            "resolved": "https://registry.npmjs.org/unicode-match-property-value-ecmascript/-/unicode-match-property-value-ecmascript-2.2.0.tgz",
-            "integrity": "sha512-4IehN3V/+kkr5YeSSDDQG8QLqO26XpL2XP3GQtqwlT/QYSECAwFztxVHjlbh0+gjJ3XmNLS0zDsbgs9jWKExLg==",
+            "version": "2.2.1",
+            "resolved": "https://registry.npmjs.org/unicode-match-property-value-ecmascript/-/unicode-match-property-value-ecmascript-2.2.1.tgz",
+            "integrity": "sha512-JQ84qTuMg4nVkx8ga4A16a1epI9H6uTXAknqxkGF/aFfRLw1xC/Bp24HNLaZhHSkWd3+84t8iXnp1J0kYcZHhg==",
            "dev": true,
            "license": "MIT",
            "engines": {
Author	SHA1	Message	Date
James Cole	a3674c4dfe	No need to use the exception either.	2025-09-10 07:03:41 +02:00
James Cole	27480561ee	Catch random exception because why not.	2025-09-10 07:03:23 +02:00
github-actions[bot]	6ea7152423	Merge pull request #10886 from firefly-iii/release-1757480185 🤖 Automatically merge the PR into the develop branch.	2025-09-10 06:56:34 +02:00
JC5	dab95f7a86	🤖 Auto commit for release 'develop' on 2025-09-10	2025-09-10 06:56:25 +02:00
James Cole	93e926465f	Merge branch 'develop' of github.com:firefly-iii/firefly-iii into develop	2025-09-10 06:51:11 +02:00
github-actions[bot]	5b0be91f93	Merge pull request #10885 from firefly-iii/release-1757479782 🤖 Automatically merge the PR into the develop branch.	2025-09-10 06:49:50 +02:00
JC5	01e7b604da	🤖 Auto commit for release 'develop' on 2025-09-10	2025-09-10 06:49:42 +02:00
James Cole	974a550d22	Merge branch 'main' into develop	2025-09-10 06:44:16 +02:00
James Cole	58d175444b	Fix #10883	2025-09-10 06:43:24 +02:00
James Cole	29d8861e96	Merge pull request #10882 from firefly-iii/dependabot/npm_and_yarn/npm_and_yarn-f5c1666f0c	2025-09-10 06:02:57 +02:00
dependabot[bot]	eb832c750f	Bump vite in the npm_and_yarn group across 1 directory Bumps the npm_and_yarn group with 1 update in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `vite` from 7.1.2 to 7.1.5 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.5 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>	2025-09-09 20:59:51 +00:00