Merge branch 'release/5.2.5'

Update the pages and blocks icons

.deploy/heroku/.env.heroku

@@ -110,7 +110,8 @@ CER_PROVIDER=fixer
 FIXER_API_KEY=
 
 # If you wish to track your own behavior over Firefly III, set a valid analytics tracker ID here.
-ANALYTICS_ID=
+TRACKER_SITE_ID=
+TRACKER_URL=
 
 # Most parts of the database are encrypted by default, but you can turn this off if you want to.
 # This makes it easier to migrate your database. Not that some fields will never be decrypted.

.deploy/heroku/.locales

@@ -13,3 +13,7 @@ ru_RU
 hu_HU
 el_GR
 sv_SE
+zh-hans_CN
+zh-hant_CN
+fi_FI
+vi_VN

.env.example

@@ -5,34 +5,48 @@ APP_ENV=local
 # Set to true if you want to see debug information in error screens.
 APP_DEBUG=false
 
-# This should be your email address
+# This should be your email address.
+# If you use Docker or similar, you can set this variable from a file by using SITE_OWNER_FILE
 SITE_OWNER=mail@example.com
 
 # The encryption key for your sessions. Keep this very secure.
 # If you generate a new one existing data must be considered LOST.
-# Change it to a string of exactly 32 chars or use command `php artisan key:generate` to generate it
+# Change it to a string of exactly 32 chars or use something like `php artisan key:generate` to generate it.
+# If you use Docker or similar, you can set this variable from a file by using APP_KEY_FILE
 APP_KEY=SomeRandomStringOf32CharsExactly
 
+#
+# Firefly III will launch using this language (for new users and unauthenticated visitors)
+# For a list of available languages: https://github.com/firefly-iii/firefly-iii/tree/master/resources/lang
+#
+# If text is still in English, remember that not everything may have been translated.
+DEFAULT_LANGUAGE=en_US
+
+# The locale defines how numbers are formatted.
+# by default this value is the same as whatever the language is.
+DEFAULT_LOCALE=equal
+
 # Change this value to your preferred time zone.
 # Example: Europe/Amsterdam
+# For a list of supported time zones, see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
 TZ=Europe/Amsterdam
 
-# This variable must match your installation's external address but keep in mind that
-# it's only used on the command line as a fallback value.
-APP_URL=http://localhost
-
 # TRUSTED_PROXIES is a useful variable when using Docker and/or a reverse proxy.
 # Set it to ** and reverse proxies work just fine.
 TRUSTED_PROXIES=
 
 # The log channel defines where your log entries go to.
-# - Docker + versions <= 4.8.1.8 and before: use "stdout"
-# - Docker + versions >  4.8.1.8: use "docker_out"
-# - For everything else, use 'daily'
-
 # Several other options exist. You can use 'single' for one big fat error log (not recommended).
 # Also available are 'syslog', 'errorlog' and 'stdout' which will log to the system itself.
-LOG_CHANNEL=stdout
+# A rotating log option is 'daily', creates 5 files that (surprise) rotate.
+# Default setting 'stack' will log to 'daily' and to 'stdout' at the same time.
+
+# - Docker + versions <= 4.8.1.8 and before: use "stdout"
+# - Docker + versions >  4.8.1.8           : use "docker_out"
+# - Docker + versions >=  5.1.1            : use "stack"
+# - For everything else (als not Docker)   : use 'stack'
+
+LOG_CHANNEL=stack
 
 # Log level. You can set this from least severe to most severe:
 # debug, info, notice, warning, error, critical, alert, emergency
@@ -42,14 +56,17 @@ APP_LOG_LEVEL=notice
 
 # Database credentials. Make sure the database exists. I recommend a dedicated user for Firefly III
 # For other database types, please see the FAQ: https://docs.firefly-iii.org/support/faq
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+# Use "mysql" for MySQL and MariaDB. Use "sqlite" for SQLite.
 DB_CONNECTION=pgsql
-DB_HOST=firefly_iii_db
+DB_HOST=fireflyiiidb
 DB_PORT=5432
 DB_DATABASE=firefly
 DB_USERNAME=firefly
 DB_PASSWORD=secret_firefly_password
 
 # PostgreSQL supports SSL. You can configure it here.
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 PGSQL_SSL_MODE=prefer
 PGSQL_SSL_ROOT_CERT=null
 PGSQL_SSL_CERT=null
@@ -61,19 +78,25 @@ CACHE_DRIVER=file
 SESSION_DRIVER=file
 
 # If you set either of these to 'redis', you might want to update these settings too
+# If you use Docker or similar, you can set REDIS_HOST_FILE, REDIS_PASSWORD_FILE or
+# REDIS_PORT_FILE to set the value from a file instead of from an environment variable
 REDIS_HOST=127.0.0.1
 REDIS_PASSWORD=null
 REDIS_PORT=6379
-REDIS_DB="0" # always use quotes
+# always use quotes and make sure redis db "0" and "1" exists. Otherwise change accordingly.
+REDIS_DB="0"
 REDIS_CACHE_DB="1"
 
 # Cookie settings. Should not be necessary to change these.
+# If you use Docker or similar, you can set COOKIE_DOMAIN_FILE to set
+# the value from a file instead of from an environment variable
 COOKIE_PATH="/"
 COOKIE_DOMAIN=
 COOKIE_SECURE=false
 
 # If you want Firefly III to mail you, update these settings
 # For instructions, see: https://docs.firefly-iii.org/advanced-installation/email
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 MAIL_DRIVER=log
 MAIL_HOST=smtp.mailtrap.io
 MAIL_PORT=2525
@@ -83,13 +106,20 @@ MAIL_PASSWORD=null
 MAIL_ENCRYPTION=null
 
 # Other mail drivers:
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 MAILGUN_DOMAIN=
 MAILGUN_SECRET=
+
+
 # If you are on EU region in mailgun, use api.eu.mailgun.net, otherwise use api.mailgun.net
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 MAILGUN_ENDPOINT=api.mailgun.net
+
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 MANDRILL_SECRET=
 SPARKPOST_SECRET=
 
+
 # Firefly III can send you the following messages
 SEND_REGISTRATION_MAIL=true
 SEND_ERROR_MESSAGE=true
@@ -98,6 +128,7 @@ SEND_ERROR_MESSAGE=true
 SEND_REPORT_JOURNALS=true
 
 # Set a Mapbox API key here (see mapbox.com) so there might be a map available at various places.
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 MAPBOX_API_KEY=
 
 # The map will default to this location:
@@ -115,23 +146,25 @@ CER_PROVIDER=ratesapi
 # set a Fixer IO API key here (see https://fixer.io) to enable live currency exchange rates.
 # Please note that this WILL ONLY WORK FOR PAID fixer.io accounts because they severely limited
 # the free API up to the point where you might as well offer nothing.
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 FIXER_API_KEY=
 
-# If you wish to track your own behavior over Firefly III, set a valid analytics tracker ID here.
-ANALYTICS_ID=
-
 # Firefly III has two options for user authentication. "eloquent" is the default,
 # and "ldap" for LDAP servers.
 # For full instructions on these settings please visit:
 # https://docs.firefly-iii.org/advanced-installation/authentication
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 LOGIN_PROVIDER=eloquent
 
 # LDAP connection configuration
 # OpenLDAP, FreeIPA or ActiveDirectory
+# # If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 ADLDAP_CONNECTION_SCHEME=OpenLDAP
 ADLDAP_AUTO_CONNECT=true
 
 # LDAP connection settings
+# You can set the following variables from a file by appending them with _FILE:
+# ADLDAP_CONTROLLERS, ADLDAP_PORT, ADLDAP_BASEDN
 ADLDAP_CONTROLLERS=
 ADLDAP_PORT=389
 ADLDAP_TIMEOUT=5
@@ -140,12 +173,15 @@ ADLDAP_FOLLOW_REFFERALS=false
 ADLDAP_USE_SSL=false
 ADLDAP_USE_TLS=false
 
+# You can set the following variables from a file by appending them with _FILE:
 ADLDAP_ADMIN_USERNAME=
 ADLDAP_ADMIN_PASSWORD=
 
+# You can set the following variables from a file by appending them with _FILE:
 ADLDAP_ACCOUNT_PREFIX=
 ADLDAP_ACCOUNT_SUFFIX=
 
+
 # LDAP authentication settings.
 ADLDAP_PASSWORD_SYNC=false
 ADLDAP_LOGIN_FALLBACK=false
@@ -154,16 +190,38 @@ ADLDAP_DISCOVER_FIELD=distinguishedname
 ADLDAP_AUTH_FIELD=distinguishedname
 
 # Will allow SSO if your server provides an AUTH_USER field.
+# You can set the following variables from a file by appending them with _FILE:
 WINDOWS_SSO_DISCOVER=samaccountname
 WINDOWS_SSO_KEY=AUTH_USER
 
 # field to sync as local username.
+# You can set the following variable from a file by appending it with _FILE:
 ADLDAP_SYNC_FIELD=userprincipalname
 
-# You can disable the X-Frame-Options header if it interfears with tools like
+# You can disable the X-Frame-Options header if it interferes with tools like
-# Organizr. This is at your own risk.
+# Organizr. This is at your own risk. Applications running in frames run the risk
+# of leaking information to their parent frame.
 DISABLE_FRAME_HEADER=false
 
+# You can disable the Content Security Policy header when you're using an ancient browser
+# or any version of Microsoft Edge / Internet Explorer (which amounts to the same thing really)
+# This leaves you with the risk of not being able to stop XSS bugs should they ever surface.
+# This is at your own risk.
+DISABLE_CSP_HEADER=false
+
+# If you wish to track your own behavior over Firefly III, set valid analytics tracker information here.
+# Nobody uses this except for me on the demo site. But hey, feel free to use this if you want to.
+# Do not prepend the TRACKER_URL with http:// or https://
+# The only tracker supported is Matomo.
+# You can set the following variables from a file by appending them with _FILE:
+TRACKER_SITE_ID=
+TRACKER_URL=
+
+#
+# Firefly III could (in the future) collect telemetry on how you use Firefly III.
+# In order to allow this, change the following variable to true:
+SEND_TELEMETRY=false
+
 # You can fine tune the start-up of a Docker container by editing these environment variables.
 # Use this at your own risk. Disabling certain checks and features may result in lost of inconsistent data.
 # However if you know what you're doing you can significantly speed up container start times.
@@ -191,7 +249,7 @@ DKR_RUN_REPORT=true
 
 # Generate OAuth2 keys.
 # When disabled, Firefly III won't attempt to generate OAuth2 Passport keys. This won't be an issue, IFF (if and only if)
-# you had previously generated keys already and they're stored in your database for restauration.
+# you had previously generated keys already and they're stored in your database for restoration.
 DKR_RUN_PASSPORT_INSTALL=true
 
 # Leave the following configuration vars as is.
@@ -212,3 +270,15 @@ IS_SANDSTORM=false
 IS_DOCKER=false
 IS_HEROKU=false
 BUNQ_USE_SANDBOX=false
+
+#
+# If you have trouble configuring your Firefly III installation, DON'T BOTHER setting this variable.
+# It won't work. It doesn't do ANYTHING. Don't believe the lies you read online. I'm not joking.
+# This configuration value WILL NOT HELP.
+#
+# This variable is ONLY used in some of the emails Firefly III sends around. Nowhere else.
+# So when configuring anything WEB related this variable doesn't do anything. Nothing
+#
+# If you're stuck I understand you get desperate but look SOMEWHERE ELSE.
+#
+APP_URL=http://localhost

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -16,11 +16,10 @@ I am running Firefly III version x.x.x, and my problem is:
 <!-- Please add extra info here, such as OS, browser, and the output from the /debug page of your Firefly III installation (click the version at the bottom). -->
 
 **Bonus points**
-<!-- Earn bonus points by:
+<!-- Before you submit, verify the following please: -->
 
-- Post a stacktrace from your log files
+- I searched and nobody reported this bug before
-- Add a screenshot
+- I have added a stack trace from my log files <!-- (see https://bit.ly/FF3-get-debug-info) -->
-- Make a drawing
+- I have added a screenshot.
-- Donate money (just kidding ;)
+- I was able to replicate it on the demo site https://demo.firefly-iii.org/
-- Replicate the problem on the demo site https://demo.firefly-iii.org/
+<!-- - I donated money (this is a joke ;)-->
--->

.github/ISSUE_TEMPLATE/Custom.md

@@ -16,8 +16,8 @@ I am running Firefly III version x.x.x.
 
 <!-- Complete the following checklist for bonus points -->
 
-- [ ] I have read the FAQ at https://bit.ly/FF3-FAQ
+- I have read the FAQ at https://bit.ly/FF3-FAQ
-- [ ] I added a screenshot
+- I added a screenshot
-- [ ] I added log files (see https://bit.ly/FF3-get-logs)
+- I added log files <!-- (see https://bit.ly/FF3-get-debug-info) -->
-- [ ] I was able to replicate the issue on the demo site.
+- I was able to replicate the issue on the demo site.
-<!-- - [ ] I donated money (this is a joke :wink:)-->
+<!-- - I donated money (this is a joke :wink:)-->

.github/code_of_conduct.md

@@ -34,7 +34,7 @@ This Code of Conduct applies both within project spaces and in public spaces whe
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at thegrumpydictator@gmail.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at james@firefly-iii.org. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
 
 Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
 

.github/contributing.md

@@ -4,7 +4,7 @@
 
 ## Feature requests
 
-I am always interested in expanding Firefly III's many features. Just open a ticket or [drop me a line](mailto:thegrumpydictator@gmail.com).
+I am always interested in expanding Firefly III's many features. Just open a ticket or [drop me a line](mailto:james@firefly-iii.org).
 
 ## Pull requests
 

.github/lock.yml

@@ -0,0 +1,35 @@
+# Configuration for Lock Threads - https://github.com/dessant/lock-threads
+
+# Number of days of inactivity before a closed issue or pull request is locked
+daysUntilLock: 90
+
+# Skip issues and pull requests created before a given timestamp. Timestamp must
+# follow ISO 8601 (`YYYY-MM-DD`). Set to `false` to disable
+skipCreatedBefore: false
+
+# Issues and pull requests with these labels will be ignored. Set to `[]` to disable
+exemptLabels: []
+
+# Label to add before locking, such as `outdated`. Set to `false` to disable
+lockLabel: false
+
+# Comment to post before locking. Set to `false` to disable
+lockComment: false
+
+# Assign `resolved` as the reason for locking. Set to `false` to disable
+setLockReason: true
+
+# Limit to only `issues` or `pulls`
+# only: issues
+
+# Optionally, specify configuration settings just for `issues` or `pulls`
+# issues:
+#   exemptLabels:
+#     - help-wanted
+#   lockLabel: outdated
+
+# pulls:
+#   daysUntilLock: 30
+
+# Repository to extend settings from
+# _extends: repo

.github/security.md

@@ -6,7 +6,7 @@ Only the latest version of Firefly III is supported. If you're not running the l
 
 ## Reporting a Vulnerability
 
-If you find something that compromises the security of Firefly III, you should [send me a message](mailto:thegrumpydictator@gmail.com) as soon as possible. These issues will be fixed immediately. You can also open an issue, but if you feel the issue is sensitive, please drop me a message instead.
+If you find something that compromises the security of Firefly III, you should [send me a message](mailto:james@firefly-iii.org) as soon as possible. These issues will be fixed immediately. You can also open an issue, but if you feel the issue is sensitive, please drop me a message instead.
 
 You can use my [GPG key](https://keybase.io/jc5) for extra security. My [GitHub commits](https://github.com/firefly-iii/firefly-iii/commits/master) are almost always signed with this key.
 

.gitignore

@@ -1,4 +1,5 @@
 /node_modules
+/frontend/node_modules
 /public/hot
 /public/storage
 /storage/*.key

app/Api/V1/Controllers/AboutController.php

@@ -2,7 +2,7 @@
 
 /**
  * AboutController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Controllers/AccountController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AccountController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -31,6 +31,7 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Support\Http\Api\AccountFilter;
 use FireflyIII\Support\Http\Api\TransactionFilter;
 use FireflyIII\Transformers\AccountTransformer;
+use FireflyIII\Transformers\AttachmentTransformer;
 use FireflyIII\Transformers\PiggyBankTransformer;
 use FireflyIII\Transformers\TransactionGroupTransformer;
 use FireflyIII\User;
@@ -73,6 +74,35 @@ class AccountController extends Controller
         );
     }
 
+    /**
+     * @param Account $account
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
+     */
+    public function attachments(Account $account): JsonResponse
+    {
+        $manager    = $this->getManager();
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $collection = $this->repository->getAttachments($account);
+
+        $count       = $collection->count();
+        $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+
+        // make paginator:
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.accounts.attachments', [$account->id]) . $this->buildParams());
+
+        /** @var AttachmentTransformer $transformer */
+        $transformer = app(AttachmentTransformer::class);
+        $transformer->setParameters($this->parameters);
+
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
+
+        return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
+    }
+
     /**
      * Remove the specified resource from storage.
      *
@@ -104,7 +134,7 @@ class AccountController extends Controller
 
         // types to get, page size:
         $types    = $this->mapAccountTypes($this->parameters->get('type'));
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of accounts. Count it and split it.
         $collection = $this->repository->getAccountsByType($types);
@@ -142,7 +172,7 @@ class AccountController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->getPiggyBanks($account);
@@ -218,7 +248,7 @@ class AccountController extends Controller
      */
     public function transactions(Request $request, Account $account): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 
@@ -227,10 +257,8 @@ class AccountController extends Controller
         if (null !== $limit && $limit > 0) {
             $pageSize = $limit;
         }
-
         $types   = $this->mapTransactionTypes($this->parameters->get('type'));
         $manager = $this->getManager();
-
         /** @var User $admin */
         $admin = auth()->user();
 
@@ -240,7 +268,6 @@ class AccountController extends Controller
         $collector->setUser($admin)->setAccounts(new Collection([$account]))
                   ->withAPIInformation()->setLimit($pageSize)->setPage($this->parameters->get('page'))->setTypes($types);
 
-        // set range if necessary:
         if (null !== $this->parameters->get('start') && null !== $this->parameters->get('end')) {
             $collector->setRange($this->parameters->get('start'), $this->parameters->get('end'));
         }

app/Api/V1/Controllers/AttachmentController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AttachmentController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -92,8 +92,8 @@ class AttachmentController extends Controller
      * @param Attachment $attachment
      *
      * @codeCoverageIgnore
-     * @return LaravelResponse
      * @throws   FireflyException
+     * @return LaravelResponse
      */
     public function download(Attachment $attachment): LaravelResponse
     {
@@ -139,7 +139,7 @@ class AttachmentController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of accounts. Count it and split it.
         $collection  = $this->repository->get();
@@ -184,8 +184,8 @@ class AttachmentController extends Controller
      *
      * @param AttachmentStoreRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(AttachmentStoreRequest $request): JsonResponse
     {

app/Api/V1/Controllers/AvailableBudgetController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AvailableBudgetController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -92,7 +92,7 @@ class AvailableBudgetController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         $start = $this->parameters->get('start');
         $end   = $this->parameters->get('end');

app/Api/V1/Controllers/BillController.php

@@ -2,7 +2,7 @@
 
 /**
  * BillController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -85,7 +85,7 @@ class BillController extends Controller
     public function attachments(Bill $bill): JsonResponse
     {
         $manager    = $this->getManager();
-        $pageSize   = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $collection = $this->repository->getAttachments($bill);
 
         $count       = $collection->count();
@@ -130,7 +130,7 @@ class BillController extends Controller
     {
         $bills     = $this->repository->getBills();
         $manager   = $this->getManager();
-        $pageSize  = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize  = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $count     = $bills->count();
         $bills     = $bills->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
         $paginator = new LengthAwarePaginator($bills, $count, $pageSize, $this->parameters->get('page'));
@@ -158,7 +158,7 @@ class BillController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->getRulesForBill($bill);
@@ -206,8 +206,8 @@ class BillController extends Controller
      *
      * @param BillRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(BillRequest $request): JsonResponse
     {
@@ -235,7 +235,7 @@ class BillController extends Controller
      */
     public function transactions(Request $request, Bill $bill): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 

app/Api/V1/Controllers/BudgetController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * BudgetController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -25,13 +25,15 @@ namespace FireflyIII\Api\V1\Controllers;
 
 use Exception;
 use FireflyIII\Api\V1\Requests\BudgetLimitRequest;
-use FireflyIII\Api\V1\Requests\BudgetRequest;
+use FireflyIII\Api\V1\Requests\BudgetStoreRequest;
+use FireflyIII\Api\V1\Requests\BudgetUpdateRequest;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\Budget;
 use FireflyIII\Repositories\Budget\BudgetLimitRepositoryInterface;
 use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
 use FireflyIII\Support\Http\Api\TransactionFilter;
+use FireflyIII\Transformers\AttachmentTransformer;
 use FireflyIII\Transformers\BudgetLimitTransformer;
 use FireflyIII\Transformers\BudgetTransformer;
 use FireflyIII\Transformers\TransactionGroupTransformer;
@@ -89,7 +91,7 @@ class BudgetController extends Controller
     public function budgetLimits(Budget $budget): JsonResponse
     {
         $manager  = $this->getManager();
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $this->parameters->set('budget_id', $budget->id);
         $collection   = $this->blRepository->getBudgetLimits($budget, $this->parameters->get('start'), $this->parameters->get('end'));
         $count        = $collection->count();
@@ -108,6 +110,35 @@ class BudgetController extends Controller
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
     }
 
+    /**
+     * @param Budget $budget
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
+     */
+    public function attachments(Budget $budget): JsonResponse
+    {
+        $manager    = $this->getManager();
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $collection = $this->repository->getAttachments($budget);
+
+        $count       = $collection->count();
+        $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+
+        // make paginator:
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.budgets.attachments', [$budget->id]) . $this->buildParams());
+
+        /** @var AttachmentTransformer $transformer */
+        $transformer = app(AttachmentTransformer::class);
+        $transformer->setParameters($this->parameters);
+
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
+
+        return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
+    }
+
     /**
      * Remove the specified resource from storage.
      *
@@ -134,7 +165,7 @@ class BudgetController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->getBudgets();
@@ -179,13 +210,13 @@ class BudgetController extends Controller
     /**
      * Store a budget.
      *
-     * @param BudgetRequest $request
+     * @param BudgetStoreRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
      *
+     * @return JsonResponse
      */
-    public function store(BudgetRequest $request): JsonResponse
+    public function store(BudgetStoreRequest $request): JsonResponse
     {
         $budget  = $this->repository->store($request->getAll());
         $manager = $this->getManager();
@@ -205,8 +236,8 @@ class BudgetController extends Controller
      * @param BudgetLimitRequest $request
      * @param Budget             $budget
      *
-     * @return JsonResponse
      * @throws Exception
+     * @return JsonResponse
      */
     public function storeBudgetLimit(BudgetLimitRequest $request, Budget $budget): JsonResponse
     {
@@ -236,7 +267,7 @@ class BudgetController extends Controller
      */
     public function transactions(Request $request, Budget $budget): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // user can overrule page size with limit parameter.
         $limit = $this->parameters->get('limit');
@@ -291,12 +322,12 @@ class BudgetController extends Controller
     /**
      * Update a budget.
      *
-     * @param BudgetRequest $request
+     * @param BudgetUpdateRequest $request
      * @param Budget              $budget
      *
      * @return JsonResponse
      */
-    public function update(BudgetRequest $request, Budget $budget): JsonResponse
+    public function update(BudgetUpdateRequest $request, Budget $budget): JsonResponse
     {
         $data    = $request->getAll();
         $budget  = $this->repository->update($budget, $data);

app/Api/V1/Controllers/BudgetLimitController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * BudgetLimitController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -102,9 +102,9 @@ class BudgetLimitController extends Controller
     public function index(Request $request): JsonResponse
     {
         $manager  = $this->getManager();
-        $budgetId = (int)($request->get('budget_id') ?? 0);
+        $budgetId = (int) ($request->get('budget_id') ?? 0);
         $budget   = $this->repository->findNull($budgetId);
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $this->parameters->set('budget_id', $budgetId);
 
         $collection = new Collection;
@@ -156,16 +156,16 @@ class BudgetLimitController extends Controller
      *
      * @param BudgetLimitRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
      *
+     * @return JsonResponse
      */
     public function store(BudgetLimitRequest $request): JsonResponse
     {
         $data   = $request->getAll();
         $budget = $this->repository->findNull($data['budget_id']);
         if (null === $budget) {
-            throw new FireflyException('200004: Budget does not exist.');
+            throw new FireflyException('200004: Budget does not exist.'); // @codeCoverageIgnore
         }
         $data['budget'] = $budget;
         $budgetLimit    = $this->blRepository->storeBudgetLimit($data);
@@ -191,7 +191,7 @@ class BudgetLimitController extends Controller
      */
     public function transactions(Request $request, BudgetLimit $budgetLimit): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 

app/Api/V1/Controllers/CategoryController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CategoryController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -29,6 +29,7 @@ use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\Category;
 use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
 use FireflyIII\Support\Http\Api\TransactionFilter;
+use FireflyIII\Transformers\AttachmentTransformer;
 use FireflyIII\Transformers\CategoryTransformer;
 use FireflyIII\Transformers\TransactionGroupTransformer;
 use FireflyIII\User;
@@ -71,6 +72,35 @@ class CategoryController extends Controller
         );
     }
 
+    /**
+     * @param Category $category
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
+     */
+    public function attachments(Category $category): JsonResponse
+    {
+        $manager    = $this->getManager();
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $collection = $this->repository->getAttachments($category);
+
+        $count       = $collection->count();
+        $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+
+        // make paginator:
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.categories.attachments', [$category->id]) . $this->buildParams());
+
+        /** @var AttachmentTransformer $transformer */
+        $transformer = app(AttachmentTransformer::class);
+        $transformer->setParameters($this->parameters);
+
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
+
+        return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
+    }
+
     /**
      * Remove the specified resource from storage.
      *
@@ -97,7 +127,7 @@ class CategoryController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->getCategories();
@@ -146,8 +176,8 @@ class CategoryController extends Controller
      *
      * @param CategoryRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(CategoryRequest $request): JsonResponse
     {
@@ -175,7 +205,7 @@ class CategoryController extends Controller
      */
     public function transactions(Request $request, Category $category): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 

app/Api/V1/Controllers/Chart/AccountController.php

@@ -2,7 +2,7 @@
 
 /**
  * AccountController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -99,10 +99,10 @@ class AccountController extends Controller
 
         // loop the end balances. This is an array for each account ($expenses)
         foreach ($endBalances as $accountId => $expenses) {
-            $accountId = (int)$accountId;
+            $accountId = (int) $accountId;
             // loop each expense entry (each entry can be a different currency).
             foreach ($expenses as $currencyId => $endAmount) {
-                $currencyId = (int)$currencyId;
+                $currencyId = (int) $currencyId;
 
                 // see if there is an accompanying start amount.
                 // grab the difference and find the currency.
@@ -114,7 +114,7 @@ class AccountController extends Controller
                     $tempData[] = [
                         'name'        => $accountNames[$accountId],
                         'difference'  => $diff,
-                        'diff_float'  => (float)$diff,
+                        'diff_float'  => (float) $diff,
                         'currency_id' => $currencyId,
                     ];
                 }
@@ -247,10 +247,10 @@ class AccountController extends Controller
 
         // loop the end balances. This is an array for each account ($expenses)
         foreach ($endBalances as $accountId => $expenses) {
-            $accountId = (int)$accountId;
+            $accountId = (int) $accountId;
             // loop each expense entry (each entry can be a different currency).
             foreach ($expenses as $currencyId => $endAmount) {
-                $currencyId = (int)$currencyId;
+                $currencyId = (int) $currencyId;
 
                 // see if there is an accompanying start amount.
                 // grab the difference and find the currency.
@@ -263,7 +263,7 @@ class AccountController extends Controller
                         'name'        => $accountNames[$accountId],
                         'difference'  => bcmul($diff, '-1'),
                         //  For some reason this line is never covered in code coverage:
-                        'diff_float'  => ((float)$diff) * -1, // @codeCoverageIgnore
+                        'diff_float'  => ((float) $diff) * -1, // @codeCoverageIgnore
                         'currency_id' => $currencyId,
                     ];
                 }

app/Api/V1/Controllers/Chart/AvailableBudgetController.php

@@ -2,7 +2,7 @@
 
 /**
  * AvailableBudgetController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -83,9 +83,9 @@ class AvailableBudgetController extends Controller
                 $spent = $spentInfo['amount'];
             }
         }
-        $left = bcadd($availableBudget->amount, (string)$spent);
+        $left = bcadd($availableBudget->amount, (string) $spent);
         // left less than zero? Set to zero.
-        if (bccomp($left, '0') === -1) {
+        if (-1 === bccomp($left, '0')) {
             $left = '0';
         }
 

app/Api/V1/Controllers/Chart/CategoryController.php

@@ -2,7 +2,7 @@
 
 /**
  * CategoryController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -95,7 +95,7 @@ class CategoryController extends Controller
         $categories    = [];
 
 
-        foreach ([$spentWith, $earnedWith] as $set) {
+        foreach ([$spentWith, $earnedWith, $spentWithout, $earnedWithout] as $set) {
             foreach ($set as $currency) {
                 foreach ($currency['categories'] as $category) {
                     $categories[] = $category['name'];
@@ -104,7 +104,7 @@ class CategoryController extends Controller
                     // make data arrays if not yet present.
                     $tempData[$inKey]  = $tempData[$inKey] ?? [
                             'currency_id'             => $currency['currency_id'],
-                            'label'                   => (string)trans('firefly.box_earned_in_currency', ['currency' => $currency['currency_name']]),
+                            'label'                   => (string) trans('firefly.box_earned_in_currency', ['currency' => $currency['currency_name']]),
                             'currency_code'           => $currency['currency_code'],
                             'currency_symbol'         => $currency['currency_symbol'],
                             'currency_decimal_places' => $currency['currency_decimal_places'],
@@ -117,7 +117,7 @@ class CategoryController extends Controller
                         ];
                     $tempData[$outKey] = $tempData[$outKey] ?? [
                             'currency_id'             => $currency['currency_id'],
-                            'label'                   => (string)trans('firefly.box_spent_in_currency', ['currency' => $currency['currency_name']]),
+                            'label'                   => (string) trans('firefly.box_spent_in_currency', ['currency' => $currency['currency_name']]),
                             'currency_code'           => $currency['currency_code'],
                             'currency_symbol'         => $currency['currency_symbol'],
                             'currency_decimal_places' => $currency['currency_decimal_places'],
@@ -141,48 +141,48 @@ class CategoryController extends Controller
             }
         }
 
-        foreach ([$spentWithout, $earnedWithout] as $set) {
+        //        foreach ([] as $set) {
-            foreach ($set as $currency) {
+        //            foreach ($set as $currency) {
-                $inKey        = sprintf('%d-i', $currency['currency_id']);
+        //                $inKey        = sprintf('%d-i', $currency['currency_id']);
-                $outKey       = sprintf('%d-e', $currency['currency_id']);
+        //                $outKey       = sprintf('%d-e', $currency['currency_id']);
-                $categories[] = (string)trans('firefly.no_category');
+        //                $categories[] = (string)trans('firefly.no_category');
-                // make data arrays if not yet present.
+        //                // make data arrays if not yet present.
-                $tempData[$inKey]  = $tempData[$inKey] ?? [
+        //                $tempData[$inKey]  = $tempData[$inKey] ?? [
-                        'currency_id'             => $currency['currency_id'],
+        //                        'currency_id'             => $currency['currency_id'],
-                        'label'                   => (string)trans('firefly.box_earned_in_currency', ['currency' => $currency['currency_name']]),
+        //                        'label'                   => (string)trans('firefly.box_earned_in_currency', ['currency' => $currency['currency_name']]),
-                        'currency_code'           => $currency['currency_code'],
+        //                        'currency_code'           => $currency['currency_code'],
-                        'currency_symbol'         => $currency['currency_symbol'],
+        //                        'currency_symbol'         => $currency['currency_symbol'],
-                        'currency_decimal_places' => $currency['currency_decimal_places'],
+        //                        'currency_decimal_places' => $currency['currency_decimal_places'],
-                        'type'                    => 'bar', // line, area or bar
+        //                        'type'                    => 'bar', // line, area or bar
-                        'yAxisID'                 => 0, // 0, 1, 2
+        //                        'yAxisID'                 => 0, // 0, 1, 2
-                        'entries'                 => [
+        //                        'entries'                 => [
-                            // per category:
+        //                            // per category:
-                            // "category" => 5,
+        //                            // "category" => 5,
-                        ],
+        //                        ],
-                    ];
+        //                    ];
-                $tempData[$outKey] = $tempData[$outKey] ?? [
+        //                $tempData[$outKey] = $tempData[$outKey] ?? [
-                        'currency_id'             => $currency['currency_id'],
+        //                        'currency_id'             => $currency['currency_id'],
-                        'label'                   => (string)trans('firefly.box_spent_in_currency', ['currency' => $currency['currency_name']]),
+        //                        'label'                   => (string)trans('firefly.box_spent_in_currency', ['currency' => $currency['currency_name']]),
-                        'currency_code'           => $currency['currency_code'],
+        //                        'currency_code'           => $currency['currency_code'],
-                        'currency_symbol'         => $currency['currency_symbol'],
+        //                        'currency_symbol'         => $currency['currency_symbol'],
-                        'currency_decimal_places' => $currency['currency_decimal_places'],
+        //                        'currency_decimal_places' => $currency['currency_decimal_places'],
-                        'type'                    => 'bar', // line, area or bar
+        //                        'type'                    => 'bar', // line, area or bar
-                        'yAxisID'                 => 0, // 0, 1, 2
+        //                        'yAxisID'                 => 0, // 0, 1, 2
-                        'entries'                 => [
+        //                        'entries'                 => [
-                            // per category:
+        //                            // per category:
-                            // "category" => 5,
+        //                            // "category" => 5,
-                        ],
+        //                        ],
-                    ];
+        //                    ];
-                foreach ($currency['transaction_journals'] as $journal) {
+        //                foreach ($currency['transaction_journals'] as $journal) {
-                    // is it expense or income?
+        //                    // is it expense or income?
-                    $letter                                  = -1 === bccomp($journal['amount'], '0') ? 'e' : 'i';
+        //                    $letter                                  = -1 === bccomp($journal['amount'], '0') ? 'e' : 'i';
-                    $currentKey                              = sprintf('%d-%s', $currency['currency_id'], $letter);
+        //                    $currentKey                              = sprintf('%d-%s', $currency['currency_id'], $letter);
-                    $name                                    = (string)trans('firefly.no_category');
+        //                    $name                                    = (string)trans('firefly.no_category');
-                    $tempData[$currentKey]['entries'][$name] = $tempData[$currentKey]['entries'][$name] ?? '0';
+        //                    $tempData[$currentKey]['entries'][$name] = $tempData[$currentKey]['entries'][$name] ?? '0';
-                    $tempData[$currentKey]['entries'][$name] = bcadd($tempData[$currentKey]['entries'][$name], $journal['amount']);
+        //                    $tempData[$currentKey]['entries'][$name] = bcadd($tempData[$currentKey]['entries'][$name], $journal['amount']);
-                }
+        //                }
-            }
+        //            }
-        }
+        //        }
 
         // re-sort every spent array and add 0 for missing entries.
         foreach ($tempData as $index => $set) {

app/Api/V1/Controllers/ConfigurationController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ConfigurationController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -51,7 +51,6 @@ class ConfigurationController extends Controller
         parent::__construct();
         $this->middleware(
             function ($request, $next) {
-                /** @noinspection UnusedConstructorDependenciesInspection */
                 $this->repository = app(UserRepositoryInterface::class);
                 /** @var User $admin */
                 $admin = auth()->user();
@@ -109,13 +108,12 @@ class ConfigurationController extends Controller
         $lastCheck = app('fireflyconfig')->get('last_update_check');
         /** @var Configuration $singleUser */
         $singleUser = app('fireflyconfig')->get('single_user_mode');
-        $data       = [
+
+        return [
             'is_demo_site'            => null === $isDemoSite ? null : $isDemoSite->data,
-            'permission_update_check' => null === $updateCheck ? null : (int)$updateCheck->data,
+            'permission_update_check' => null === $updateCheck ? null : (int) $updateCheck->data,
-            'last_update_check'       => null === $lastCheck ? null : (int)$lastCheck->data,
+            'last_update_check'       => null === $lastCheck ? null : (int) $lastCheck->data,
             'single_user_mode'        => null === $singleUser ? null : $singleUser->data,
         ];
-
-        return $data;
     }
 }

app/Api/V1/Controllers/Controller.php

@@ -2,7 +2,7 @@
 
 /**
  * Controller.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -104,7 +104,7 @@ class Controller extends BaseController
     private function getParameters(): ParameterBag
     {
         $bag  = new ParameterBag;
-        $page = (int)request()->get('page');
+        $page = (int) request()->get('page');
         if (0 === $page) {
             $page = 1;
         }
@@ -131,7 +131,7 @@ class Controller extends BaseController
         foreach ($integers as $integer) {
             $value = request()->query->get($integer);
             if (null !== $value) {
-                $bag->set($integer, (int)$value);
+                $bag->set($integer, (int) $value);
             }
         }
 

app/Api/V1/Controllers/CurrencyController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CurrencyController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -116,7 +116,7 @@ class CurrencyController extends Controller
 
         // types to get, page size:
         $types    = $this->mapAccountTypes($this->parameters->get('type'));
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of accounts. Count it and split it.
         /** @var AccountRepositoryInterface $accountRepository */
@@ -126,7 +126,7 @@ class CurrencyController extends Controller
         // filter list on currency preference:
         $collection = $unfiltered->filter(
             static function (Account $account) use ($currency, $accountRepository) {
-                $currencyId = (int)$accountRepository->getMetaValue($account, 'currency_id');
+                $currencyId = (int) $accountRepository->getMetaValue($account, 'currency_id');
 
                 return $currencyId === $currency->id;
             }
@@ -165,7 +165,7 @@ class CurrencyController extends Controller
 
         $manager = $this->getManager();
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of available budgets. Count it and split it.
 
@@ -209,7 +209,7 @@ class CurrencyController extends Controller
 
         /** @var BillRepositoryInterface $repository */
         $repository = app(BillRepositoryInterface::class);
-        $pageSize   = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $unfiltered = $repository->getBills();
 
         // filter and paginate list:
@@ -249,7 +249,7 @@ class CurrencyController extends Controller
         $blRepository = app(BudgetLimitRepositoryInterface::class);
 
         $manager      = $this->getManager();
-        $pageSize     = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize     = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $collection   = $blRepository->getAllBudgetLimitsByCurrency($currency, $this->parameters->get('start'), $this->parameters->get('end'));
         $count        = $collection->count();
         $budgetLimits = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
@@ -278,7 +278,7 @@ class CurrencyController extends Controller
     {
         // create some objects:
         $manager    = $this->getManager();
-        $pageSize   = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $collection = $this->repository->getExchangeRates($currency);
 
 
@@ -302,9 +302,9 @@ class CurrencyController extends Controller
      *
      * @param TransactionCurrency $currency
      *
-     * @return JsonResponse
      * @throws FireflyException
      * @codeCoverageIgnore
+     * @return JsonResponse
      */
     public function delete(TransactionCurrency $currency): JsonResponse
     {
@@ -318,6 +318,10 @@ class CurrencyController extends Controller
         if ($this->repository->currencyInUse($currency)) {
             throw new FireflyException('200006: Currency in use.'); // @codeCoverageIgnore
         }
+        if ($this->repository->isFallbackCurrency($currency)) {
+            throw new FireflyException('200026: Currency is fallback.'); // @codeCoverageIgnore
+        }
+
         $this->repository->destroy($currency);
 
         return response()->json([], 204);
@@ -387,7 +391,7 @@ class CurrencyController extends Controller
      */
     public function index(): JsonResponse
     {
-        $pageSize   = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $collection = $this->repository->getAll();
         $count      = $collection->count();
         // slice them:
@@ -451,7 +455,7 @@ class CurrencyController extends Controller
     {
         $manager = $this->getManager();
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         /** @var RecurringRepositoryInterface $repository */
@@ -502,7 +506,7 @@ class CurrencyController extends Controller
     public function rules(TransactionCurrency $currency): JsonResponse
     {
         $manager  = $this->getManager();
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         /** @var RuleRepositoryInterface $repository */
@@ -563,13 +567,33 @@ class CurrencyController extends Controller
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
     }
 
+    /**
+     * Show a currency.
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
+     */
+    public function showDefault(): JsonResponse
+    {
+        $manager  = $this->getManager();
+        $currency = app('amount')->getDefaultCurrencyByUser(auth()->user());
+
+        /** @var CurrencyTransformer $transformer */
+        $transformer = app(CurrencyTransformer::class);
+        $transformer->setParameters($this->parameters);
+
+        $resource = new Item($currency, $transformer, 'currencies');
+
+        return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
+    }
+
     /**
      * Store new currency.
      *
      * @param CurrencyRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(CurrencyRequest $request): JsonResponse
     {
@@ -603,7 +627,7 @@ class CurrencyController extends Controller
      */
     public function transactions(Request $request, TransactionCurrency $currency): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 

app/Api/V1/Controllers/CurrencyExchangeRateController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CurrencyExchangeRateController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -69,8 +69,8 @@ class CurrencyExchangeRateController extends Controller
      *
      * @param Request $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function index(Request $request): JsonResponse
     {

app/Api/V1/Controllers/ImportController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ImportController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -40,6 +40,9 @@ use League\Fractal\Resource\Item;
 
 /**
  * Class ImportController
+ *
+ * @deprecated
+ * @codeCoverageIgnore
  */
 class ImportController extends Controller
 {
@@ -75,7 +78,7 @@ class ImportController extends Controller
     {
         // create some objects:
         $manager  = $this->getManager();
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of accounts. Count it and split it.
         $collection = $this->repository->get();
@@ -125,7 +128,7 @@ class ImportController extends Controller
      */
     public function transactions(Request $request, ImportJob $importJob): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 

app/Api/V1/Controllers/LinkTypeController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * LinkTypeController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -79,9 +79,9 @@ class LinkTypeController extends Controller
      *
      * @param LinkType $linkType
      *
-     * @return JsonResponse
      * @throws FireflyException
      * @codeCoverageIgnore
+     * @return JsonResponse
      */
     public function delete(LinkType $linkType): JsonResponse
     {
@@ -103,7 +103,7 @@ class LinkTypeController extends Controller
     {
         // create some objects:
         $manager  = $this->getManager();
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of accounts. Count it and split it.
         $collection = $this->repository->get();
@@ -151,8 +151,8 @@ class LinkTypeController extends Controller
      *
      * @param LinkTypeRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(LinkTypeRequest $request): JsonResponse
     {
@@ -187,7 +187,7 @@ class LinkTypeController extends Controller
      */
     public function transactions(Request $request, LinkType $linkType): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 
@@ -241,8 +241,8 @@ class LinkTypeController extends Controller
      * @param LinkTypeRequest $request
      * @param LinkType        $linkType
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function update(LinkTypeRequest $request, LinkType $linkType): JsonResponse
     {

app/Api/V1/Controllers/PiggyBankController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PiggyBankController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -27,6 +27,7 @@ use FireflyIII\Api\V1\Requests\PiggyBankRequest;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\PiggyBank;
 use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
+use FireflyIII\Transformers\AttachmentTransformer;
 use FireflyIII\Transformers\PiggyBankEventTransformer;
 use FireflyIII\Transformers\PiggyBankTransformer;
 use FireflyIII\User;
@@ -83,6 +84,36 @@ class PiggyBankController extends Controller
         return response()->json([], 204);
     }
 
+
+    /**
+     * @param PiggyBank $piggyBank
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
+     */
+    public function attachments(PiggyBank $piggyBank): JsonResponse
+    {
+        $manager    = $this->getManager();
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $collection = $this->repository->getAttachments($piggyBank);
+
+        $count       = $collection->count();
+        $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+
+        // make paginator:
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.piggy_banks.attachments', [$piggyBank->id]) . $this->buildParams());
+
+        /** @var AttachmentTransformer $transformer */
+        $transformer = app(AttachmentTransformer::class);
+        $transformer->setParameters($this->parameters);
+
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
+
+        return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
+    }
+
     /**
      * List all of them.
      *
@@ -93,7 +124,7 @@ class PiggyBankController extends Controller
     {
         $manager = $this->getManager();
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->getPiggyBanks();
@@ -126,7 +157,7 @@ class PiggyBankController extends Controller
     public function piggyBankEvents(PiggyBank $piggyBank): JsonResponse
     {
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $manager  = $this->getManager();
 
         $collection = $this->repository->getEvents($piggyBank);
@@ -175,8 +206,8 @@ class PiggyBankController extends Controller
      *
      * @param PiggyBankRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(PiggyBankRequest $request): JsonResponse
     {

app/Api/V1/Controllers/PreferenceController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PreferenceController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -147,10 +147,10 @@ class PreferenceController extends Controller
                 $newValue = explode(',', $data['data']);
                 break;
             case 'listPageSize':
-                $newValue = (int)$data['data'];
+                $newValue = (int) $data['data'];
                 break;
             case 'customFiscalYear':
-                $newValue = 1 === (int)$data['data'];
+                $newValue = 1 === (int) $data['data'];
                 break;
         }
         $result = app('preferences')->set($preference->name, $newValue);

app/Api/V1/Controllers/RecurrenceController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RecurrenceController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -99,7 +99,7 @@ class RecurrenceController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->getAll();
@@ -149,8 +149,8 @@ class RecurrenceController extends Controller
      *
      * @param RecurrenceStoreRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(RecurrenceStoreRequest $request): JsonResponse
     {
@@ -178,7 +178,7 @@ class RecurrenceController extends Controller
      */
     public function transactions(Request $request, Recurrence $recurrence): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 
@@ -224,9 +224,9 @@ class RecurrenceController extends Controller
     }
 
     /**
-     * @return JsonResponse
      * @throws FireflyException
      * @codeCoverageIgnore
+     * @return JsonResponse
      */
     public function trigger(): JsonResponse
     {

app/Api/V1/Controllers/RuleController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RuleController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -105,7 +105,7 @@ class RuleController extends Controller
         $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->ruleRepository->getAll();
@@ -214,12 +214,12 @@ class RuleController extends Controller
      * @param RuleTestRequest $request
      * @param Rule            $rule
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function testRule(RuleTestRequest $request, Rule $rule): JsonResponse
     {
-        $pageSize   = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $parameters = $request->getTestParameters();
         /** @var Rule $rule */
         Log::debug(sprintf('Now testing rule #%d, "%s"', $rule->id, $rule->title));

app/Api/V1/Controllers/RuleGroupController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RuleGroupController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -106,7 +106,7 @@ class RuleGroupController extends Controller
     {
         $manager = $this->getManager();
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of rule groups. Count it and split it.
         $collection = $this->ruleGroupRepository->get();
@@ -177,7 +177,7 @@ class RuleGroupController extends Controller
     {
         $manager = $this->getManager();
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->ruleGroupRepository->getRules($group);
@@ -246,13 +246,13 @@ class RuleGroupController extends Controller
      * @param RuleGroupTestRequest $request
      * @param RuleGroup            $group
      *
-     * @return JsonResponse
      * @throws FireflyException
      *
+     * @return JsonResponse
      */
     public function testGroup(RuleGroupTestRequest $request, RuleGroup $group): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         Log::debug('Now in testGroup()');
         /** @var Collection $rules */
         $rules = $this->ruleGroupRepository->getActiveRules($group);
@@ -305,8 +305,8 @@ class RuleGroupController extends Controller
      * @param RuleGroupTriggerRequest $request
      * @param RuleGroup               $group
      *
-     * @return JsonResponse
      * @throws Exception
+     * @return JsonResponse
      */
     public function triggerGroup(RuleGroupTriggerRequest $request, RuleGroup $group): JsonResponse
     {

app/Api/V1/Controllers/Search/AccountController.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * AccountController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -21,7 +22,6 @@
 
 namespace FireflyIII\Api\V1\Controllers\Search;
 
-
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Support\Http\Api\AccountFilter;
 use FireflyIII\Support\Search\AccountSearch;
@@ -32,6 +32,7 @@ use Illuminate\Http\Response;
 use Illuminate\Pagination\LengthAwarePaginator;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
+use Log;
 
 /**
  * Class AccountController
@@ -62,6 +63,7 @@ class AccountController extends Controller
      */
     public function search(Request $request)
     {
+        Log::debug('Now in account search()');
         $manager = $this->getManager();
         $query   = $request->get('query');
         $field   = $request->get('field');
@@ -70,6 +72,8 @@ class AccountController extends Controller
             return response(null, 422);
         }
         $types = $this->mapAccountTypes($type);
+        Log::debug(sprintf('Going to search for "%s" in types', $query), $types);
+
         /** @var AccountSearch $search */
         $search = app(AccountSearch::class);
         $search->setUser(auth()->user());
@@ -79,6 +83,8 @@ class AccountController extends Controller
 
         $accounts = $search->search();
 
+        Log::debug(sprintf('Found %d accounts', $accounts->count()));
+
         /** @var AccountTransformer $transformer */
         $transformer = app(AccountTransformer::class);
         $transformer->setParameters($this->parameters);
@@ -91,5 +97,4 @@ class AccountController extends Controller
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
     }
-
 }

app/Api/V1/Controllers/Search/TransactionController.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * TransactionController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -21,13 +22,8 @@
 
 namespace FireflyIII\Api\V1\Controllers\Search;
 
-
 use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Support\Search\SearchInterface;
-use FireflyIII\Support\Search\TransactionSearch;
-use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
-use Illuminate\Http\Response;
 
 /**
  * Class TransactionController
@@ -35,13 +31,13 @@ use Illuminate\Http\Response;
 class TransactionController extends Controller
 {
     /** @var string */
-    const SEARCH_ALL = 'all';
+    public const SEARCH_ALL = 'all';
     /** @var string */
-    const SEARCH_DESCRIPTION = 'description';
+    public const SEARCH_DESCRIPTION = 'description';
     /** @var string */
-    const SEARCH_NOTES = 'notes';
+    public const SEARCH_NOTES = 'notes';
     /** @var string */
-    const SEARCH_ACCOUNTS = 'accounts';
+    public const SEARCH_ACCOUNTS = 'accounts';
     /** @var array */
     private $validFields;
 
@@ -59,11 +55,10 @@ class TransactionController extends Controller
     /**
      * @param Request $request
      *
-     * @return JsonResponse|Response
+     * @return void
      */
-    public function search(Request $request)
+    public function search(Request $request): void
     {
         die('the route is present but nobody\'s home.');
     }
-
 }

app/Api/V1/Controllers/Search/TransferController.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * TransferController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -21,16 +22,13 @@
 
 namespace FireflyIII\Api\V1\Controllers\Search;
 
-
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Search\TransferRequest;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Support\Search\TransferSearch;
 use FireflyIII\Transformers\TransactionGroupTransformer;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
 use Illuminate\Http\Response;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
@@ -41,10 +39,9 @@ use League\Fractal\Resource\Collection as FractalCollection;
 class TransferController extends Controller
 {
     /**
-     * @param Request $request
+     * @param TransferRequest $request
      *
      * @return JsonResponse|Response
-     * @throws FireflyException
      */
     public function search(TransferRequest $request)
     {
@@ -82,7 +79,7 @@ class TransferController extends Controller
         }
 
         // collector to return results.
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $manager  = $this->getManager();
         /** @var User $admin */
         $admin = auth()->user();

app/Api/V1/Controllers/SummaryController.php

@@ -2,7 +2,7 @@
 
 /**
  * SummaryController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -24,7 +24,6 @@ declare(strict_types=1);
 
 namespace FireflyIII\Api\V1\Controllers;
 
-
 use Carbon\Carbon;
 use Exception;
 use FireflyIII\Api\V1\Requests\DateRequest;
@@ -42,7 +41,6 @@ use FireflyIII\Repositories\Budget\OperationsRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Collection;
 
 /**
  * Class SummaryController
@@ -98,8 +96,8 @@ class SummaryController extends Controller
     /**
      * @param DateRequest $request
      *
-     * @return JsonResponse
      * @throws Exception
+     * @return JsonResponse
      */
     public function basic(DateRequest $request): JsonResponse
     {
@@ -125,7 +123,6 @@ class SummaryController extends Controller
         }
 
         return response()->json($return);
-
     }
 
     /**
@@ -152,25 +149,6 @@ class SummaryController extends Controller
         return $result;
     }
 
-    /**
-     * This method will scroll through the results of the spentInPeriodMc() array and return the correct info.
-     *
-     * @param array               $spentInfo
-     * @param TransactionCurrency $currency
-     *
-     * @return string
-     */
-    private function findInSpentArray(array $spentInfo, TransactionCurrency $currency): string
-    {
-        foreach ($spentInfo as $array) {
-            if ($array['currency_id'] === $currency->id) {
-                return (string)$array['amount'];
-            }
-        }
-
-        return '0'; // @codeCoverageIgnore
-    }
-
     /**
      * @param Carbon $start
      * @param Carbon $end
@@ -198,8 +176,7 @@ class SummaryController extends Controller
         $set = $collector->getExtractedJournals();
         /** @var array $transactionJournal */
         foreach ($set as $transactionJournal) {
-
+            $currencyId           = (int) $transactionJournal['currency_id'];
-            $currencyId           = (int)$transactionJournal['currency_id'];
             $incomes[$currencyId] = $incomes[$currencyId] ?? '0';
             $incomes[$currencyId] = bcadd($incomes[$currencyId], bcmul($transactionJournal['amount'], '-1'));
             $sums[$currencyId]    = $sums[$currencyId] ?? '0';
@@ -221,7 +198,7 @@ class SummaryController extends Controller
 
         /** @var array $transactionJournal */
         foreach ($set as $transactionJournal) {
-            $currencyId            = (int)$transactionJournal['currency_id'];
+            $currencyId            = (int) $transactionJournal['currency_id'];
             $expenses[$currencyId] = $expenses[$currencyId] ?? '0';
             $expenses[$currencyId] = bcadd($expenses[$currencyId], $transactionJournal['amount']);
             $sums[$currencyId]     = $sums[$currencyId] ?? '0';
@@ -295,7 +272,7 @@ class SummaryController extends Controller
         $return       = [];
         foreach ($paidAmount as $currencyId => $amount) {
             $amount   = bcmul($amount, '-1');
-            $currency = $this->currencyRepos->findNull((int)$currencyId);
+            $currency = $this->currencyRepos->findNull((int) $currencyId);
             if (null === $currency) {
                 continue;
             }
@@ -315,7 +292,7 @@ class SummaryController extends Controller
 
         foreach ($unpaidAmount as $currencyId => $amount) {
             $amount   = bcmul($amount, '-1');
-            $currency = $this->currencyRepos->findNull((int)$currencyId);
+            $currency = $this->currencyRepos->findNull((int) $currencyId);
             if (null === $currency) {
                 continue;
             }
@@ -340,8 +317,8 @@ class SummaryController extends Controller
      * @param Carbon $start
      * @param Carbon $end
      *
-     * @return array
      * @throws Exception
+     * @return array
      */
     private function getLeftToSpendInfo(Carbon $start, Carbon $end): array
     {
@@ -360,7 +337,7 @@ class SummaryController extends Controller
             $days   = $today->diffInDays($end) + 1;
             $perDay = '0';
             if (0 !== $days && bccomp($leftToSpend, '0') > -1) {
-                $perDay = bcdiv($leftToSpend, (string)$days);
+                $perDay = bcdiv($leftToSpend, (string) $days);
             }
 
             $return[] = [
@@ -373,14 +350,18 @@ class SummaryController extends Controller
                 'currency_decimal_places' => $row['currency_decimal_places'],
                 'value_parsed'            => app('amount')->formatFlat($row['currency_symbol'], $row['currency_decimal_places'], $leftToSpend, false),
                 'local_icon'              => 'money',
-                'sub_title'               => (string)trans(
+                'sub_title'               => (string) trans(
-                    'firefly.box_spend_per_day', ['amount' => app('amount')->formatFlat(
+                    'firefly.box_spend_per_day',
-                    $row['currency_symbol'], $row['currency_decimal_places'], $perDay, false
+                    ['amount' => app('amount')->formatFlat(
+                        $row['currency_symbol'],
+                        $row['currency_decimal_places'],
+                        $perDay,
+                        false
                     )]
                 ),
             ];
-
         }
+
         return $return;
     }
 
@@ -443,5 +424,4 @@ class SummaryController extends Controller
 
         return $return;
     }
-
 }

app/Api/V1/Controllers/TagController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TagController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -25,12 +25,13 @@ namespace FireflyIII\Api\V1\Controllers;
 
 use Carbon\Carbon;
 use FireflyIII\Api\V1\Requests\DateRequest;
-use FireflyIII\Api\V1\Requests\TagUpdateRequest;
 use FireflyIII\Api\V1\Requests\TagStoreRequest;
+use FireflyIII\Api\V1\Requests\TagUpdateRequest;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\Tag;
 use FireflyIII\Repositories\Tag\TagRepositoryInterface;
 use FireflyIII\Support\Http\Api\TransactionFilter;
+use FireflyIII\Transformers\AttachmentTransformer;
 use FireflyIII\Transformers\TagTransformer;
 use FireflyIII\Transformers\TransactionGroupTransformer;
 use FireflyIII\User;
@@ -117,7 +118,7 @@ class TagController extends Controller
     {
         $manager = $this->getManager();
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of budgets. Count it and split it.
         $collection = $this->repository->get();
@@ -138,6 +139,36 @@ class TagController extends Controller
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
     }
 
+
+    /**
+     * @param Tag $tag
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
+     */
+    public function attachments(Tag $tag): JsonResponse
+    {
+        $manager    = $this->getManager();
+        $pageSize   = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $collection = $this->repository->getAttachments($tag);
+
+        $count       = $collection->count();
+        $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+
+        // make paginator:
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.tags.attachments', [$tag->id]) . $this->buildParams());
+
+        /** @var AttachmentTransformer $transformer */
+        $transformer = app(AttachmentTransformer::class);
+        $transformer->setParameters($this->parameters);
+
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
+
+        return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
+    }
+
     /**
      * List single resource.
      *
@@ -190,7 +221,7 @@ class TagController extends Controller
      */
     public function transactions(Request $request, Tag $tag): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 
@@ -288,8 +319,8 @@ class TagController extends Controller
         ];
         /** @var Tag $tag */
         foreach ($tags as $tag) {
-            $earned = (float)$this->repository->earnedInPeriod($tag, $start, $end);
+            $earned = (float) $this->repository->earnedInPeriod($tag, $start, $end);
-            $spent  = (float)$this->repository->spentInPeriod($tag, $start, $end);
+            $spent  = (float) $this->repository->spentInPeriod($tag, $start, $end);
             $size   = ($spent * -1) + $earned;
             $min    = $min ?? $size;
             if ($size > 0) {

app/Api/V1/Controllers/TransactionController.php

@@ -2,7 +2,7 @@
 
 /**
  * TransactionController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -29,6 +29,7 @@ use FireflyIII\Api\V1\Requests\TransactionUpdateRequest;
 use FireflyIII\Events\StoredTransactionGroup;
 use FireflyIII\Events\UpdatedTransactionGroup;
 use FireflyIII\Exceptions\DuplicateTransactionException;
+use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\TransactionGroup;
 use FireflyIII\Models\TransactionJournal;
@@ -109,7 +110,6 @@ class TransactionController extends Controller
         $resource = new FractalCollection($attachments, $transformer, 'attachments');
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
-
     }
 
     /**
@@ -152,7 +152,7 @@ class TransactionController extends Controller
      */
     public function index(Request $request): JsonResponse
     {
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
 
@@ -214,7 +214,6 @@ class TransactionController extends Controller
         $resource = new FractalCollection($events, $transformer, 'piggy_bank_events');
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
-
     }
 
     /**
@@ -274,6 +273,7 @@ class TransactionController extends Controller
      */
     public function store(TransactionStoreRequest $request): JsonResponse
     {
+        Log::debug('Now in API TransactionController::store()');
         $data         = $request->getAll();
         $data['user'] = auth()->user()->id;
 
@@ -283,6 +283,7 @@ class TransactionController extends Controller
         try {
             $transactionGroup = $this->groupRepository->store($data);
         } catch (DuplicateTransactionException $e) {
+            Log::warning('Caught a duplicate. Return error message.');
             // return bad validation message.
             // TODO use Laravel's internal validation thing to do this.
             $response = [
@@ -293,9 +294,22 @@ class TransactionController extends Controller
             ];
 
             return response()->json($response, 422);
-        }
+        } catch (FireflyException $e) {
+            Log::warning('Caught an exception. Return error message.');
+            Log::error($e->getMessage());
+            // return bad validation message.
+            // TODO use Laravel's internal validation thing to do this.
+            $response = [
+                'message' => 'The given data was invalid.',
+                'errors'  => [
+                    'transactions.0.description' => [sprintf('Internal exception: %s', $e->getMessage())],
+                ],
+            ];
 
-        event(new StoredTransactionGroup($transactionGroup));
+            return response()->json($response, 422);
+        }
+        app('preferences')->mark();
+        event(new StoredTransactionGroup($transactionGroup, $data['apply_rules'] ?? true));
 
         $manager = $this->getManager();
         /** @var User $admin */
@@ -338,7 +352,8 @@ class TransactionController extends Controller
         $transactionGroup = $this->groupRepository->update($transactionGroup, $data);
         $manager          = $this->getManager();
 
-        event(new UpdatedTransactionGroup($transactionGroup));
+        app('preferences')->mark();
+        event(new UpdatedTransactionGroup($transactionGroup, $data['apply_rules'] ?? true));
 
         /** @var User $admin */
         $admin = auth()->user();
@@ -362,6 +377,5 @@ class TransactionController extends Controller
         $resource = new Item($selectedGroup, $transformer, 'transactions');
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
-
     }
 }

app/Api/V1/Controllers/TransactionLinkController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TransactionLinkController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -105,7 +105,7 @@ class TransactionLinkController extends Controller
         $name = $request->get('name');
 
         // types to get, page size:
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $linkType = $this->repository->findByName($name);
 
         // get list of transaction links. Count it and split it.
@@ -155,8 +155,8 @@ class TransactionLinkController extends Controller
      *
      * @param TransactionLinkRequest $request
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function store(TransactionLinkRequest $request): JsonResponse
     {
@@ -186,8 +186,8 @@ class TransactionLinkController extends Controller
      * @param TransactionLinkRequest $request
      * @param TransactionJournalLink $journalLink
      *
-     * @return JsonResponse
      * @throws FireflyException
+     * @return JsonResponse
      */
     public function update(TransactionLinkRequest $request, TransactionJournalLink $journalLink): JsonResponse
     {

app/Api/V1/Controllers/UserController.php

@@ -2,7 +2,7 @@
 
 /**
  * UserController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -70,9 +70,9 @@ class UserController extends Controller
      *
      * @param User $user
      *
-     * @return JsonResponse
      * @throws FireflyException
      * @codeCoverageIgnore
+     * @return JsonResponse
      */
     public function delete(User $user): JsonResponse
     {
@@ -95,7 +95,7 @@ class UserController extends Controller
     public function index(): JsonResponse
     {
         // user preferences
-        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $pageSize = (int) app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
         $manager  = $this->getManager();
 
         // build collection

app/Api/V1/Requests/AccountStoreRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * AccountStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/AccountUpdateRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * AccountUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/AttachmentStoreRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AttachmentStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -23,9 +23,6 @@ declare(strict_types=1);
 
 namespace FireflyIII\Api\V1\Requests;
 
-use FireflyIII\Models\Bill;
-use FireflyIII\Models\ImportJob;
-use FireflyIII\Models\TransactionJournal;
 use FireflyIII\Rules\IsValidAttachmentModel;
 
 /**
@@ -57,8 +54,8 @@ class AttachmentStoreRequest extends Request
             'filename' => $this->string('filename'),
             'title'    => $this->string('title'),
             'notes'    => $this->nlString('notes'),
-            'model'    => $this->string('model'),
+            'model'    => $this->string('attachable_type'),
-            'model_id' => $this->integer('model_id'),
+            'model_id' => $this->integer('attachable_id'),
         ];
     }
 
@@ -69,22 +66,22 @@ class AttachmentStoreRequest extends Request
      */
     public function rules(): array
     {
-        $models = implode(
+        $models = config('firefly.valid_attachment_models');
-            ',',
+        $models = array_map(
-            [
+
-                str_replace('FireflyIII\\Models\\', '', Bill::class),
+            static function (string $className) {
-                str_replace('FireflyIII\\Models\\', '', ImportJob::class),
+                return str_replace('FireflyIII\\Models\\', '', $className);
-                str_replace('FireflyIII\\Models\\', '', TransactionJournal::class),
+            }, $models
-            ]
         );
-        $model  = $this->string('model');
+        $models = implode(',', $models);
+        $model  = $this->string('attachable_type');
 
         return [
             'filename'        => 'required|between:1,255',
             'title'           => 'between:1,255',
             'notes'           => 'between:1,65000',
-            'model'    => sprintf('required|in:%s', $models),
+            'attachable_type' => sprintf('required|in:%s', $models),
-            'model_id' => ['required', 'numeric', new IsValidAttachmentModel($model)],
+            'attachable_id'   => ['required', 'numeric', new IsValidAttachmentModel($model)],
         ];
     }
 }

app/Api/V1/Requests/AttachmentUpdateRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AttachmentUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -52,8 +52,8 @@ class AttachmentUpdateRequest extends Request
             'filename' => $this->string('filename'),
             'title'    => $this->string('title'),
             'notes'    => $this->nlString('notes'),
-            'model'    => $this->string('model'),
+            'model'    => $this->string('attachable_type'),
-            'model_id' => $this->integer('model_id'),
+            'model_id' => $this->integer('attachable_id'),
         ];
     }
 

app/Api/V1/Requests/AvailableBudgetRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AvailableBudgetRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -64,15 +64,13 @@ class AvailableBudgetRequest extends Request
      */
     public function rules(): array
     {
-        $rules = [
+        return [
             'currency_id'   => 'numeric|exists:transaction_currencies,id',
             'currency_code' => 'min:3|max:3|exists:transaction_currencies,code',
             'amount'        => 'required|numeric|more:0',
             'start'         => 'required|date|before:end',
             'end'           => 'required|date|after:start',
         ];
-
-        return $rules;
     }
 
 

app/Api/V1/Requests/BillRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * BillRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -60,7 +60,7 @@ class BillRequest extends Request
             $active = $this->boolean('active');
         }
 
-        $data = [
+        return [
             'name'          => $this->string('name'),
             'amount_min'    => $this->string('amount_min'),
             'amount_max'    => $this->string('amount_max'),
@@ -72,8 +72,6 @@ class BillRequest extends Request
             'active'        => $active,
             'notes'         => $this->nlString('notes'),
         ];
-
-        return $data;
     }
 
     /**
@@ -121,10 +119,10 @@ class BillRequest extends Request
         $validator->after(
             static function (Validator $validator) {
                 $data = $validator->getData();
-                $min  = (float)($data['amount_min'] ?? 0);
+                $min  = (float) ($data['amount_min'] ?? 0);
-                $max  = (float)($data['amount_max'] ?? 0);
+                $max  = (float) ($data['amount_max'] ?? 0);
                 if ($min > $max) {
-                    $validator->errors()->add('amount_min', (string)trans('validation.amount_min_over_max'));
+                    $validator->errors()->add('amount_min', (string) trans('validation.amount_min_over_max'));
                 }
             }
         );

app/Api/V1/Requests/BudgetLimitRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * BudgetLimitRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/BudgetRequest.php

@@ -1,91 +0,0 @@
-<?php
-/**
- * BudgetRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
- *
- * This file is part of Firefly III (https://github.com/firefly-iii).
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-declare(strict_types=1);
-
-namespace FireflyIII\Api\V1\Requests;
-
-use FireflyIII\Models\Budget;
-use FireflyIII\Rules\IsBoolean;
-
-/**
- * Class BudgetRequest
- *
- * @codeCoverageIgnore
- * TODO AFTER 4.8,0: split this into two request classes.
- */
-class BudgetRequest extends Request
-{
-    /**
-     * Authorize logged in users.
-     *
-     * @return bool
-     */
-    public function authorize(): bool
-    {
-        // Only allow authenticated users
-        return auth()->check();
-    }
-
-    /**
-     * Get all data from the request.
-     *
-     * @return array
-     */
-    public function getAll(): array
-    {
-        $active = true;
-        if (null !== $this->get('active')) {
-            $active = $this->boolean('active');
-        }
-
-        return [
-            'name'   => $this->string('name'),
-            'active' => $active,
-            'order'  => 0,
-        ];
-    }
-
-    /**
-     * The rules that the incoming request must be matched against.
-     *
-     * @return array
-     */
-    public function rules(): array
-    {
-        $rules = [
-            'name'   => 'required|between:1,100|uniqueObjectForUser:budgets,name',
-            'active' => [new IsBoolean],
-        ];
-        switch ($this->method()) {
-            default:
-                break;
-            case 'PUT':
-            case 'PATCH':
-                /** @var Budget $budget */
-                $budget        = $this->route()->parameter('budget');
-                $rules['name'] = sprintf('required|between:1,100|uniqueObjectForUser:budgets,name,%d', $budget->id);
-                break;
-        }
-
-        return $rules;
-    }
-}

app/Api/V1/Requests/BudgetStoreRequest.php

@@ -0,0 +1,106 @@
+<?php
+/**
+ * BudgetStoreRequest.php
+ * Copyright (c) 2019 james@firefly-iii.org
+ *
+ * This file is part of Firefly III (https://github.com/firefly-iii).
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace FireflyIII\Api\V1\Requests;
+
+use FireflyIII\Rules\IsBoolean;
+use Illuminate\Validation\Validator;
+
+/**
+ * Class BudgetStoreRequest
+ *
+ * @codeCoverageIgnore
+ */
+class BudgetStoreRequest extends Request
+{
+    /**
+     * Authorize logged in users.
+     *
+     * @return bool
+     */
+    public function authorize(): bool
+    {
+        // Only allow authenticated users
+        return auth()->check();
+    }
+
+    /**
+     * Get all data from the request.
+     *
+     * @return array
+     */
+    public function getAll(): array
+    {
+        $active = true;
+        if (null !== $this->get('active')) {
+            $active = $this->boolean('active');
+        }
+
+        return [
+            'name'                      => $this->string('name'),
+            'active'                    => $active,
+            'order'                     => 0,
+            'auto_budget_type'          => $this->string('auto_budget_type'),
+            'transaction_currency_id'   => $this->integer('auto_budget_currency_id'),
+            'transaction_currency_code' => $this->string('auto_budget_currency_code'),
+            'auto_budget_amount'        => $this->string('auto_budget_amount'),
+            'auto_budget_period'        => $this->string('auto_budget_period'),
+        ];
+    }
+
+    /**
+     * The rules that the incoming request must be matched against.
+     *
+     * @return array
+     */
+    public function rules(): array
+    {
+        return [
+            'name'                      => 'required|between:1,100|uniqueObjectForUser:budgets,name',
+            'active'                    => [new IsBoolean],
+            'auto_budget_type'          => 'in:reset,rollover,none',
+            'auto_budget_currency_id'   => 'exists:transaction_currencies,id',
+            'auto_budget_currency_code' => 'exists:transaction_currencies,code',
+            'auto_budget_amount'        => 'min:0|max:1000000000',
+            'auto_budget_period'        => 'in:daily,weekly,monthly,quarterly,half_year,yearly',
+        ];
+    }
+
+
+    /**
+     * Configure the validator instance with special rules for after the basic validation rules.
+     *
+     * @param Validator $validator
+     *
+     * @return void
+     */
+    public function withValidator(Validator $validator): void
+    {
+        $validator->after(
+            function (Validator $validator) {
+                // validate all account info
+                $this->validateAutoBudgetAmount($validator);
+            }
+        );
+    }
+}

app/Api/V1/Requests/BudgetUpdateRequest.php

@@ -0,0 +1,107 @@
+<?php
+/**
+ * BudgetUpdateRequest.php
+ * Copyright (c) 2019 james@firefly-iii.org
+ *
+ * This file is part of Firefly III (https://github.com/firefly-iii).
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace FireflyIII\Api\V1\Requests;
+
+use FireflyIII\Rules\IsBoolean;
+use Illuminate\Validation\Validator;
+
+/**
+ * Class BudgetUpdateRequest
+ *
+ * @codeCoverageIgnore
+ */
+class BudgetUpdateRequest extends Request
+{
+    /**
+     * Authorize logged in users.
+     *
+     * @return bool
+     */
+    public function authorize(): bool
+    {
+        // Only allow authenticated users
+        return auth()->check();
+    }
+
+    /**
+     * Get all data from the request.
+     *
+     * @return array
+     */
+    public function getAll(): array
+    {
+        $active = true;
+        if (null !== $this->get('active')) {
+            $active = $this->boolean('active');
+        }
+
+        return [
+            'name'                      => $this->string('name'),
+            'active'                    => $active,
+            'order'                     => 0,
+            'auto_budget_type'          => $this->string('auto_budget_type'),
+            'transaction_currency_id'   => $this->integer('auto_budget_currency_id'),
+            'transaction_currency_code' => $this->string('auto_budget_currency_code'),
+            'auto_budget_amount'        => $this->string('auto_budget_amount'),
+            'auto_budget_period'        => $this->string('auto_budget_period'),
+        ];
+    }
+
+    /**
+     * The rules that the incoming request must be matched against.
+     *
+     * @return array
+     */
+    public function rules(): array
+    {
+        $budget = $this->route()->parameter('budget');
+
+        return [
+            'name'                      => sprintf('required|between:1,100|uniqueObjectForUser:budgets,name,%d', $budget->id),
+            'active'                    => [new IsBoolean],
+            'auto_budget_type'          => 'in:reset,rollover,none',
+            'auto_budget_currency_id'   => 'exists:transaction_currencies,id',
+            'auto_budget_currency_code' => 'exists:transaction_currencies,code',
+            'auto_budget_amount'        => 'min:0|max:1000000000',
+            'auto_budget_period'        => 'in:daily,weekly,monthly,quarterly,half_year,yearly',
+        ];
+    }
+
+    /**
+     * Configure the validator instance with special rules for after the basic validation rules.
+     *
+     * @param Validator $validator
+     *
+     * @return void
+     */
+    public function withValidator(Validator $validator): void
+    {
+        $validator->after(
+            function (Validator $validator) {
+                // validate all account info
+                $this->validateAutoBudgetAmount($validator);
+            }
+        );
+    }
+}

app/Api/V1/Requests/CategoryRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CategoryRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/ConfigurationRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * ConfigurationRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/CurrencyRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CurrencyRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/DateRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * DateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/LinkTypeRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * LinkTypeRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/PiggyBankRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PiggyBankRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/PreferenceRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PreferenceRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/RecurrenceStoreRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RecurrenceStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -26,6 +26,7 @@ namespace FireflyIII\Api\V1\Requests;
 use Carbon\Carbon;
 use FireflyIII\Rules\BelongsUser;
 use FireflyIII\Rules\IsBoolean;
+use FireflyIII\Validation\CurrencyValidation;
 use FireflyIII\Validation\RecurrenceValidation;
 use FireflyIII\Validation\TransactionValidation;
 use Illuminate\Validation\Validator;
@@ -35,7 +36,7 @@ use Illuminate\Validation\Validator;
  */
 class RecurrenceStoreRequest extends Request
 {
-    use RecurrenceValidation, TransactionValidation;
+    use RecurrenceValidation, TransactionValidation, CurrencyValidation;
 
     /**
      * Authorize logged in users.
@@ -63,7 +64,8 @@ class RecurrenceStoreRequest extends Request
         if (null !== $this->get('apply_rules')) {
             $applyRules = $this->boolean('apply_rules');
         }
-        $return = [
+
+        return [
             'recurrence'   => [
                 'type'         => $this->string('type'),
                 'title'        => $this->string('title'),
@@ -77,8 +79,6 @@ class RecurrenceStoreRequest extends Request
             'transactions' => $this->getTransactionData(),
             'repetitions'  => $this->getRepetitionData(),
         ];
-
-        return $return;
     }
 
     /**
@@ -168,8 +168,8 @@ class RecurrenceStoreRequest extends Request
             $return[] = [
                 'type'    => $repetition['type'],
                 'moment'  => $repetition['moment'],
-                'skip'    => (int)$repetition['skip'],
+                'skip'    => (int) $repetition['skip'],
-                'weekend' => (int)$repetition['weekend'],
+                'weekend' => (int) $repetition['weekend'],
             ];
         }
 
@@ -193,29 +193,7 @@ class RecurrenceStoreRequest extends Request
         }
         /** @var array $transaction */
         foreach ($transactions as $transaction) {
-            $return[] = [
+            $return[] = $this->getSingleRecurrenceData($transaction);
-                'amount'                => $transaction['amount'],
-                'currency_id'           => isset($transaction['currency_id']) ? (int)$transaction['currency_id'] : null,
-                'currency_code'         => $transaction['currency_code'] ?? null,
-                'foreign_amount'        => $transaction['foreign_amount'] ?? null,
-                'foreign_currency_id'   => isset($transaction['foreign_currency_id']) ? (int)$transaction['foreign_currency_id'] : null,
-                'foreign_currency_code' => $transaction['foreign_currency_code'] ?? null,
-                'source_id'             => isset($transaction['source_id']) ? (int)$transaction['source_id'] : null,
-                'source_name'           => isset($transaction['source_name']) ? (string)$transaction['source_name'] : null,
-                'destination_id'        => isset($transaction['destination_id']) ? (int)$transaction['destination_id'] : null,
-                'destination_name'      => isset($transaction['destination_name']) ? (string)$transaction['destination_name'] : null,
-                'description'           => $transaction['description'],
-                'type'                  => $this->string('type'),
-
-                // new and updated fields:
-                'piggy_bank_id'         => isset($transaction['piggy_bank_id']) ? (int)$transaction['piggy_bank_id'] : null,
-                'piggy_bank_name'       => $transaction['piggy_bank_name'] ?? null,
-                'tags'                  => $transaction['tags'] ?? [],
-                'budget_id'             => isset($transaction['budget_id']) ? (int)$transaction['budget_id'] : null,
-                'budget_name'           => $transaction['budget_name'] ?? null,
-                'category_id'           => isset($transaction['category_id']) ? (int)$transaction['category_id'] : null,
-                'category_name'         => $transaction['category_name'] ?? null,
-            ];
         }
 
         return $return;

app/Api/V1/Requests/RecurrenceUpdateRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RecurrenceUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -26,6 +26,7 @@ namespace FireflyIII\Api\V1\Requests;
 use FireflyIII\Models\Recurrence;
 use FireflyIII\Rules\BelongsUser;
 use FireflyIII\Rules\IsBoolean;
+use FireflyIII\Validation\CurrencyValidation;
 use FireflyIII\Validation\RecurrenceValidation;
 use FireflyIII\Validation\TransactionValidation;
 use Illuminate\Validation\Validator;
@@ -35,7 +36,7 @@ use Illuminate\Validation\Validator;
  */
 class RecurrenceUpdateRequest extends Request
 {
-    use RecurrenceValidation, TransactionValidation;
+    use RecurrenceValidation, TransactionValidation, CurrencyValidation;
 
     /**
      * Authorize logged in users.
@@ -63,7 +64,8 @@ class RecurrenceUpdateRequest extends Request
         if (null !== $this->get('apply_rules')) {
             $applyRules = $this->boolean('apply_rules');
         }
-        $return = [
+
+        return [
             'recurrence'   => [
                 'type'              => $this->nullableString('type'),
                 'title'             => $this->nullableString('title'),
@@ -78,8 +80,6 @@ class RecurrenceUpdateRequest extends Request
             'transactions' => $this->getTransactionData(),
             'repetitions'  => $this->getRepetitionData(),
         ];
-
-        return $return;
     }
 
     /**
@@ -141,7 +141,7 @@ class RecurrenceUpdateRequest extends Request
     {
         $validator->after(
             function (Validator $validator) {
-                $this->validateOneRecurrenceTransactionUpdate($validator);
+                $this->validateOneRecurrenceTransaction($validator);
                 $this->validateOneRepetitionUpdate($validator);
                 $this->validateRecurrenceRepetition($validator);
                 $this->validateRepetitionMoment($validator);
@@ -170,8 +170,8 @@ class RecurrenceUpdateRequest extends Request
             $return[] = [
                 'type'    => $repetition['type'],
                 'moment'  => $repetition['moment'],
-                'skip'    => (int)$repetition['skip'],
+                'skip'    => (int) $repetition['skip'],
-                'weekend' => (int)$repetition['weekend'],
+                'weekend' => (int) $repetition['weekend'],
             ];
         }
 
@@ -195,29 +195,7 @@ class RecurrenceUpdateRequest extends Request
         }
         /** @var array $transaction */
         foreach ($transactions as $transaction) {
-            $return[] = [
+            $return[] = $this->getSingleRecurrenceData($transaction);
-                'amount'                => $transaction['amount'],
-                'currency_id'           => isset($transaction['currency_id']) ? (int)$transaction['currency_id'] : null,
-                'currency_code'         => $transaction['currency_code'] ?? null,
-                'foreign_amount'        => $transaction['foreign_amount'] ?? null,
-                'foreign_currency_id'   => isset($transaction['foreign_currency_id']) ? (int)$transaction['foreign_currency_id'] : null,
-                'foreign_currency_code' => $transaction['foreign_currency_code'] ?? null,
-                'source_id'             => isset($transaction['source_id']) ? (int)$transaction['source_id'] : null,
-                'source_name'           => isset($transaction['source_name']) ? (string)$transaction['source_name'] : null,
-                'destination_id'        => isset($transaction['destination_id']) ? (int)$transaction['destination_id'] : null,
-                'destination_name'      => isset($transaction['destination_name']) ? (string)$transaction['destination_name'] : null,
-                'description'           => $transaction['description'],
-                'type'                  => $this->string('type'),
-
-                // new and updated fields:
-                'piggy_bank_id'         => isset($transaction['piggy_bank_id']) ? (int)$transaction['piggy_bank_id'] : null,
-                'piggy_bank_name'       => $transaction['piggy_bank_name'] ?? null,
-                'tags'                  => $transaction['tags'] ?? [],
-                'budget_id'             => isset($transaction['budget_id']) ? (int)$transaction['budget_id'] : null,
-                'budget_name'           => $transaction['budget_name'] ?? null,
-                'category_id'           => isset($transaction['category_id']) ? (int)$transaction['category_id'] : null,
-                'category_name'         => $transaction['category_name'] ?? null,
-            ];
         }
 
         return $return;

app/Api/V1/Requests/Request.php

@@ -2,7 +2,7 @@
 
 /**
  * Request.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -34,4 +34,36 @@ use FireflyIII\Http\Requests\Request as FireflyIIIRequest;
  */
 class Request extends FireflyIIIRequest
 {
+    /**
+     * @param array $transaction
+     *
+     * @return array
+     */
+    protected function getSingleRecurrenceData(array $transaction): array
+    {
+        return [
+            'amount'                => $transaction['amount'],
+            'currency_id'           => isset($transaction['currency_id']) ? (int) $transaction['currency_id'] : null,
+            'currency_code'         => $transaction['currency_code'] ?? null,
+            'foreign_amount'        => $transaction['foreign_amount'] ?? null,
+            'foreign_currency_id'   => isset($transaction['foreign_currency_id']) ? (int) $transaction['foreign_currency_id'] : null,
+            'foreign_currency_code' => $transaction['foreign_currency_code'] ?? null,
+            'source_id'             => isset($transaction['source_id']) ? (int) $transaction['source_id'] : null,
+            'source_name'           => isset($transaction['source_name']) ? (string) $transaction['source_name'] : null,
+            'destination_id'        => isset($transaction['destination_id']) ? (int) $transaction['destination_id'] : null,
+            'destination_name'      => isset($transaction['destination_name']) ? (string) $transaction['destination_name'] : null,
+            'description'           => $transaction['description'],
+            'type'                  => $this->string('type'),
+
+            // new and updated fields:
+            'piggy_bank_id'         => isset($transaction['piggy_bank_id']) ? (int) $transaction['piggy_bank_id'] : null,
+            'piggy_bank_name'       => $transaction['piggy_bank_name'] ?? null,
+            'tags'                  => $transaction['tags'] ?? [],
+            'budget_id'             => isset($transaction['budget_id']) ? (int) $transaction['budget_id'] : null,
+            'budget_name'           => $transaction['budget_name'] ?? null,
+            'category_id'           => isset($transaction['category_id']) ? (int) $transaction['category_id'] : null,
+            'category_name'         => $transaction['category_name'] ?? null,
+        ];
+    }
+
 }

app/Api/V1/Requests/RuleGroupRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RuleGroupRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/RuleGroupTestRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * RuleGroupTestRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -54,7 +54,7 @@ class RuleGroupTestRequest extends Request
      */
     public function getTestParameters(): array
     {
-        $return = [
+        return [
             'page'          => $this->getPage(),
             'start_date'    => $this->getDate('start_date'),
             'end_date'      => $this->getDate('end_date'),
@@ -62,9 +62,6 @@ class RuleGroupTestRequest extends Request
             'trigger_limit' => $this->getTriggerLimit(),
             'accounts'      => $this->getAccounts(),
         ];
-
-
-        return $return;
     }
 
     /**
@@ -80,7 +77,7 @@ class RuleGroupTestRequest extends Request
      */
     private function getAccounts(): Collection
     {
-        $accountList = '' === (string)$this->query('accounts') ? [] : explode(',', $this->query('accounts'));
+        $accountList = '' === (string) $this->query('accounts') ? [] : explode(',', $this->query('accounts'));
         $accounts    = new Collection;
 
         /** @var AccountRepositoryInterface $accountRepository */
@@ -88,7 +85,7 @@ class RuleGroupTestRequest extends Request
 
         foreach ($accountList as $accountId) {
             Log::debug(sprintf('Searching for asset account with id "%s"', $accountId));
-            $account = $accountRepository->findNull((int)$accountId);
+            $account = $accountRepository->findNull((int) $accountId);
             if ($this->validAccount($account)) {
                 /** @noinspection NullPointerExceptionInspection */
                 Log::debug(sprintf('Found account #%d ("%s") and its an asset account', $account->id, $account->name));
@@ -117,7 +114,7 @@ class RuleGroupTestRequest extends Request
      */
     private function getPage(): int
     {
-        return 0 === (int)$this->query('page') ? 1 : (int)$this->query('page');
+        return 0 === (int) $this->query('page') ? 1 : (int) $this->query('page');
 
     }
 
@@ -126,7 +123,7 @@ class RuleGroupTestRequest extends Request
      */
     private function getSearchLimit(): int
     {
-        return 0 === (int)$this->query('search_limit') ? (int)config('firefly.test-triggers.limit') : (int)$this->query('search_limit');
+        return 0 === (int) $this->query('search_limit') ? (int) config('firefly.test-triggers.limit') : (int) $this->query('search_limit');
     }
 
     /**
@@ -134,7 +131,7 @@ class RuleGroupTestRequest extends Request
      */
     private function getTriggerLimit(): int
     {
-        return 0 === (int)$this->query('triggered_limit') ? (int)config('firefly.test-triggers.range') : (int)$this->query('triggered_limit');
+        return 0 === (int) $this->query('triggered_limit') ? (int) config('firefly.test-triggers.range') : (int) $this->query('triggered_limit');
     }
 
     /**

app/Api/V1/Requests/RuleGroupTriggerRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * RuleGroupTriggerRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -54,14 +54,11 @@ class RuleGroupTriggerRequest extends Request
      */
     public function getTriggerParameters(): array
     {
-        $return = [
+        return [
             'start_date' => $this->getDate('start_date'),
             'end_date'   => $this->getDate('end_date'),
             'accounts'   => $this->getAccounts(),
         ];
-
-
-        return $return;
     }
 
     /**
@@ -80,7 +77,7 @@ class RuleGroupTriggerRequest extends Request
      */
     private function getAccounts(): Collection
     {
-        $accountList = '' === (string)$this->query('accounts') ? [] : explode(',', $this->query('accounts'));
+        $accountList = '' === (string) $this->query('accounts') ? [] : explode(',', $this->query('accounts'));
         $accounts    = new Collection;
 
         /** @var AccountRepositoryInterface $accountRepository */
@@ -88,7 +85,7 @@ class RuleGroupTriggerRequest extends Request
 
         foreach ($accountList as $accountId) {
             Log::debug(sprintf('Searching for asset account with id "%s"', $accountId));
-            $account = $accountRepository->findNull((int)$accountId);
+            $account = $accountRepository->findNull((int) $accountId);
             if ($this->validAccount($account)) {
                 /** @noinspection NullPointerExceptionInspection */
                 Log::debug(sprintf('Found account #%d ("%s") and its an asset account', $account->id, $account->name));

app/Api/V1/Requests/RuleStoreRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RuleStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -65,7 +65,7 @@ class RuleStoreRequest extends Request
             $stopProcessing = $this->boolean('stop_processing');
         }
 
-        $data = [
+        return [
             'title'            => $this->string('title'),
             'description'      => $this->string('description'),
             'rule_group_id'    => $this->integer('rule_group_id'),
@@ -77,8 +77,6 @@ class RuleStoreRequest extends Request
             'triggers'         => $this->getRuleTriggers(),
             'actions'          => $this->getRuleActions(),
         ];
-
-        return $data;
     }
 
     /**
@@ -94,7 +92,8 @@ class RuleStoreRequest extends Request
         // some triggers and actions require text:
         $contextTriggers = implode(',', config('firefly.context-rule-triggers'));
         $contextActions  = implode(',', config('firefly.context-rule-actions'));
-        $rules           = [
+
+        return [
             'title'                      => 'required|between:1,100|uniqueObjectForUser:rules,title',
             'description'                => 'between:1,5000|nullable',
             'rule_group_id'              => 'required|belongsToUser:rule_groups|required_without:rule_group_title',
@@ -112,8 +111,6 @@ class RuleStoreRequest extends Request
             'stop_processing'            => [new IsBoolean],
             'active'                     => [new IsBoolean],
         ];
-
-        return $rules;
     }
 
     /**
@@ -144,7 +141,7 @@ class RuleStoreRequest extends Request
         $actions = $data['actions'] ?? [];
         // need at least one trigger
         if (0 === count($actions)) {
-            $validator->errors()->add('title', (string)trans('validation.at_least_one_action'));
+            $validator->errors()->add('title', (string) trans('validation.at_least_one_action'));
         }
     }
 
@@ -159,7 +156,7 @@ class RuleStoreRequest extends Request
         $triggers = $data['triggers'] ?? [];
         // need at least one trigger
         if (0 === count($triggers)) {
-            $validator->errors()->add('title', (string)trans('validation.at_least_one_trigger'));
+            $validator->errors()->add('title', (string) trans('validation.at_least_one_trigger'));
         }
     }
 
@@ -175,8 +172,8 @@ class RuleStoreRequest extends Request
                 $return[] = [
                     'type'            => $action['type'],
                     'value'           => $action['value'],
-                    'active'          => $this->convertBoolean((string)($action['active'] ?? 'false')),
+                    'active'          => $this->convertBoolean((string) ($action['active'] ?? 'false')),
-                    'stop_processing' => $this->convertBoolean((string)($action['stop_processing'] ?? 'false')),
+                    'stop_processing' => $this->convertBoolean((string) ($action['stop_processing'] ?? 'false')),
                 ];
             }
         }
@@ -196,8 +193,8 @@ class RuleStoreRequest extends Request
                 $return[] = [
                     'type'            => $trigger['type'],
                     'value'           => $trigger['value'],
-                    'active'          => $this->convertBoolean((string)($trigger['active'] ?? 'false')),
+                    'active'          => $this->convertBoolean((string) ($trigger['active'] ?? 'false')),
-                    'stop_processing' => $this->convertBoolean((string)($trigger['stop_processing'] ?? 'false')),
+                    'stop_processing' => $this->convertBoolean((string) ($trigger['stop_processing'] ?? 'false')),
                 ];
             }
         }

app/Api/V1/Requests/RuleTestRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * RuleTestRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -54,7 +54,7 @@ class RuleTestRequest extends Request
      */
     public function getTestParameters(): array
     {
-        $return = [
+        return [
             'page'          => $this->getPage(),
             'start_date'    => $this->getDate('start_date'),
             'end_date'      => $this->getDate('end_date'),
@@ -62,9 +62,6 @@ class RuleTestRequest extends Request
             'trigger_limit' => $this->getTriggerLimit(),
             'accounts'      => $this->getAccounts(),
         ];
-
-
-        return $return;
     }
 
     /**
@@ -80,7 +77,7 @@ class RuleTestRequest extends Request
      */
     private function getAccounts(): Collection
     {
-        $accountList = '' === (string)$this->query('accounts') ? [] : explode(',', $this->query('accounts'));
+        $accountList = '' === (string) $this->query('accounts') ? [] : explode(',', $this->query('accounts'));
         $accounts    = new Collection;
 
         /** @var AccountRepositoryInterface $accountRepository */
@@ -88,7 +85,7 @@ class RuleTestRequest extends Request
 
         foreach ($accountList as $accountId) {
             Log::debug(sprintf('Searching for asset account with id "%s"', $accountId));
-            $account = $accountRepository->findNull((int)$accountId);
+            $account = $accountRepository->findNull((int) $accountId);
             if ($this->validAccount($account)) {
                 /** @noinspection NullPointerExceptionInspection */
                 Log::debug(sprintf('Found account #%d ("%s") and its an asset account', $account->id, $account->name));
@@ -117,7 +114,7 @@ class RuleTestRequest extends Request
      */
     private function getPage(): int
     {
-        return 0 === (int)$this->query('page') ? 1 : (int)$this->query('page');
+        return 0 === (int) $this->query('page') ? 1 : (int) $this->query('page');
 
     }
 
@@ -126,7 +123,7 @@ class RuleTestRequest extends Request
      */
     private function getSearchLimit(): int
     {
-        return 0 === (int)$this->query('search_limit') ? (int)config('firefly.test-triggers.limit') : (int)$this->query('search_limit');
+        return 0 === (int) $this->query('search_limit') ? (int) config('firefly.test-triggers.limit') : (int) $this->query('search_limit');
     }
 
     /**
@@ -134,7 +131,7 @@ class RuleTestRequest extends Request
      */
     private function getTriggerLimit(): int
     {
-        return 0 === (int)$this->query('triggered_limit') ? (int)config('firefly.test-triggers.range') : (int)$this->query('triggered_limit');
+        return 0 === (int) $this->query('triggered_limit') ? (int) config('firefly.test-triggers.range') : (int) $this->query('triggered_limit');
     }
 
     /**

app/Api/V1/Requests/RuleTriggerRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * RuleTriggerRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -53,14 +53,11 @@ class RuleTriggerRequest extends Request
      */
     public function getTriggerParameters(): array
     {
-        $return = [
+        return [
             'start_date' => $this->getDate('start_date'),
             'end_date'   => $this->getDate('end_date'),
             'accounts'   => $this->getAccounts(),
         ];
-
-
-        return $return;
     }
 
     /**
@@ -79,7 +76,7 @@ class RuleTriggerRequest extends Request
      */
     private function getAccounts(): Collection
     {
-        $accountList = '' === (string)$this->query('accounts') ? [] : explode(',', $this->query('accounts'));
+        $accountList = '' === (string) $this->query('accounts') ? [] : explode(',', $this->query('accounts'));
         $accounts    = new Collection;
 
         /** @var AccountRepositoryInterface $accountRepository */
@@ -87,7 +84,7 @@ class RuleTriggerRequest extends Request
 
         foreach ($accountList as $accountId) {
             Log::debug(sprintf('Searching for asset account with id "%s"', $accountId));
-            $account = $accountRepository->findNull((int)$accountId);
+            $account = $accountRepository->findNull((int) $accountId);
             if ($this->validAccount($account)) {
                 /** @noinspection NullPointerExceptionInspection */
                 Log::debug(sprintf('Found account #%d ("%s") and its an asset account', $account->id, $account->name));

app/Api/V1/Requests/RuleUpdateRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RuleUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -65,7 +65,7 @@ class RuleUpdateRequest extends Request
             $stopProcessing = $this->boolean('stop_processing');
         }
 
-        $data = [
+        return [
             'title'            => $this->nullableString('title'),
             'description'      => $this->nullableString('description'),
             'rule_group_id'    => $this->nullableInteger('rule_group_id'),
@@ -77,8 +77,6 @@ class RuleUpdateRequest extends Request
             'triggers'         => $this->getRuleTriggers(),
             'actions'          => $this->getRuleActions(),
         ];
-
-        return $data;
     }
 
     /**
@@ -95,7 +93,8 @@ class RuleUpdateRequest extends Request
         // some triggers and actions require text:
         $contextTriggers = implode(',', config('firefly.context-rule-triggers'));
         $contextActions  = implode(',', config('firefly.context-rule-actions'));
-        $rules           = [
+
+        return [
             'title'                      => sprintf('between:1,100|uniqueObjectForUser:rules,title,%d', $rule->id),
             'description'                => 'between:1,5000|nullable',
             'rule_group_id'              => 'belongsToUser:rule_groups',
@@ -113,8 +112,6 @@ class RuleUpdateRequest extends Request
             'stop_processing'            => [new IsBoolean],
             'active'                     => [new IsBoolean],
         ];
-
-        return $rules;
     }
 
     /**
@@ -145,7 +142,7 @@ class RuleUpdateRequest extends Request
         $actions = $data['actions'] ?? null;
         // need at least one action
         if (is_array($actions) && 0 === count($actions)) {
-            $validator->errors()->add('title', (string)trans('validation.at_least_one_action'));
+            $validator->errors()->add('title', (string) trans('validation.at_least_one_action'));
         }
     }
 
@@ -160,7 +157,7 @@ class RuleUpdateRequest extends Request
         $triggers = $data['triggers'] ?? null;
         // need at least one trigger
         if (is_array($triggers) && 0 === count($triggers)) {
-            $validator->errors()->add('title', (string)trans('validation.at_least_one_trigger'));
+            $validator->errors()->add('title', (string) trans('validation.at_least_one_trigger'));
         }
     }
 
@@ -179,8 +176,8 @@ class RuleUpdateRequest extends Request
                 $return[] = [
                     'type'            => $action['type'],
                     'value'           => $action['value'],
-                    'active'          => $this->convertBoolean((string)($action['active'] ?? 'false')),
+                    'active'          => $this->convertBoolean((string) ($action['active'] ?? 'false')),
-                    'stop_processing' => $this->convertBoolean((string)($action['stop_processing'] ?? 'false')),
+                    'stop_processing' => $this->convertBoolean((string) ($action['stop_processing'] ?? 'false')),
                 ];
             }
         }
@@ -203,8 +200,8 @@ class RuleUpdateRequest extends Request
                 $return[] = [
                     'type'            => $trigger['type'],
                     'value'           => $trigger['value'],
-                    'active'          => $this->convertBoolean((string)($trigger['active'] ?? 'false')),
+                    'active'          => $this->convertBoolean((string) ($trigger['active'] ?? 'false')),
-                    'stop_processing' => $this->convertBoolean((string)($trigger['stop_processing'] ?? 'false')),
+                    'stop_processing' => $this->convertBoolean((string) ($trigger['stop_processing'] ?? 'false')),
                 ];
             }
         }

app/Api/V1/Requests/Search/TransferRequest.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * TransferRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -21,7 +22,6 @@
 
 namespace FireflyIII\Api\V1\Requests\Search;
 
-
 use FireflyIII\Api\V1\Requests\Request;
 use FireflyIII\Rules\IsTransferAccount;
 
@@ -54,5 +54,4 @@ class TransferRequest extends Request
             'date'        => 'required|date',
         ];
     }
-
 }

app/Api/V1/Requests/TagStoreRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TagStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/TagUpdateRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * TagUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Api/V1/Requests/TransactionLinkRequest.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TransactionLinkRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -110,8 +110,8 @@ class TransactionLinkRequest extends Request
         $journalRepos->setUser($user);
 
         $data      = $validator->getData();
-        $inwardId  = (int)($data['inward_id'] ?? 0);
+        $inwardId  = (int) ($data['inward_id'] ?? 0);
-        $outwardId = (int)($data['outward_id'] ?? 0);
+        $outwardId = (int) ($data['outward_id'] ?? 0);
         $inward    = $journalRepos->findNull($inwardId);
         $outward   = $journalRepos->findNull($outwardId);
 

app/Api/V1/Requests/TransactionStoreRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * TransactionStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -28,16 +28,18 @@ use FireflyIII\Rules\BelongsUser;
 use FireflyIII\Rules\IsBoolean;
 use FireflyIII\Rules\IsDateOrTime;
 use FireflyIII\Support\NullArrayObject;
+use FireflyIII\Validation\CurrencyValidation;
+use FireflyIII\Validation\GroupValidation;
 use FireflyIII\Validation\TransactionValidation;
 use Illuminate\Validation\Validator;
-
+use Log;
 
 /**
  * Class TransactionStoreRequest
  */
 class TransactionStoreRequest extends Request
 {
-    use TransactionValidation;
+    use TransactionValidation, GroupValidation, CurrencyValidation;
 
     /**
      * Authorize logged in users.
@@ -46,6 +48,8 @@ class TransactionStoreRequest extends Request
      */
     public function authorize(): bool
     {
+        Log::debug('Authorize TransactionStoreRequest');
+
         // Only allow authenticated users
         return auth()->check();
     }
@@ -57,13 +61,14 @@ class TransactionStoreRequest extends Request
      */
     public function getAll(): array
     {
-        $data = [
+        Log::debug('get all data in TransactionStoreRequest');
+
+        return [
             'group_title'             => $this->string('group_title'),
             'error_if_duplicate_hash' => $this->boolean('error_if_duplicate_hash'),
+            'apply_rules'             => $this->boolean('apply_rules', true),
             'transactions'            => $this->getTransactionData(),
         ];
-
-        return $data;
     }
 
     /**
@@ -73,10 +78,13 @@ class TransactionStoreRequest extends Request
      */
     public function rules(): array
     {
-        $rules = [
+        Log::debug('Collect rules of TransactionStoreRequest');
+
+        return [
             // basic fields for group:
             'group_title'                          => 'between:1,1000|nullable',
             'error_if_duplicate_hash'              => [new IsBoolean],
+            'apply_rules'                          => [new IsBoolean],
 
             // transaction rules (in array for splits):
             'transactions.*.type'                  => 'required|in:withdrawal,deposit,transfer,opening-balance,reconciliation',
@@ -150,8 +158,6 @@ class TransactionStoreRequest extends Request
             'transactions.*.invoice_date'          => 'date|nullable',
         ];
 
-        return $rules;
-
 
     }
 
@@ -208,63 +214,63 @@ class TransactionStoreRequest extends Request
             $return[] = [
                 'type'  => $this->stringFromValue($object['type']),
                 'date'  => $this->dateFromValue($object['date']),
-                'order' => $this->integerFromValue((string)$object['order']),
+                'order' => $this->integerFromValue((string) $object['order']),
 
-                'currency_id'           => $this->integerFromValue((string)$object['currency_id']),
+                'currency_id'           => $this->integerFromValue((string) $object['currency_id']),
                 'currency_code'         => $this->stringFromValue($object['currency_code']),
 
                 // foreign currency info:
-                'foreign_currency_id'   => $this->integerFromValue((string)$object['foreign_currency_id']),
+                'foreign_currency_id'   => $this->integerFromValue((string) $object['foreign_currency_id']),
                 'foreign_currency_code' => $this->stringFromValue($object['foreign_currency_code']),
 
                 // amount and foreign amount. Cannot be 0.
-                'amount'                => $this->stringFromValue((string)$object['amount']),
+                'amount'                => $this->stringFromValue((string) $object['amount']),
-                'foreign_amount'        => $this->stringFromValue((string)$object['foreign_amount']),
+                'foreign_amount'        => $this->stringFromValue((string) $object['foreign_amount']),
 
                 // description.
                 'description'           => $this->stringFromValue($object['description']),
 
                 // source of transaction. If everything is null, assume cash account.
-                'source_id'             => $this->integerFromValue((string)$object['source_id']),
+                'source_id'             => $this->integerFromValue((string) $object['source_id']),
                 'source_name'           => $this->stringFromValue($object['source_name']),
                 'source_iban'           => $this->stringFromValue($object['source_iban']),
                 'source_number'         => $this->stringFromValue($object['source_number']),
                 'source_bic'            => $this->stringFromValue($object['source_bic']),
 
                 // destination of transaction. If everything is null, assume cash account.
-                'destination_id'        => $this->integerFromValue((string)$object['destination_id']),
+                'destination_id'        => $this->integerFromValue((string) $object['destination_id']),
                 'destination_name'      => $this->stringFromValue($object['destination_name']),
                 'destination_iban'      => $this->stringFromValue($object['destination_iban']),
                 'destination_number'    => $this->stringFromValue($object['destination_number']),
                 'destination_bic'       => $this->stringFromValue($object['destination_bic']),
 
                 // budget info
-                'budget_id'             => $this->integerFromValue((string)$object['budget_id']),
+                'budget_id'             => $this->integerFromValue((string) $object['budget_id']),
                 'budget_name'           => $this->stringFromValue($object['budget_name']),
 
                 // category info
-                'category_id'           => $this->integerFromValue((string)$object['category_id']),
+                'category_id'           => $this->integerFromValue((string) $object['category_id']),
                 'category_name'         => $this->stringFromValue($object['category_name']),
 
                 // journal bill reference. Optional. Will only work for withdrawals
-                'bill_id'               => $this->integerFromValue((string)$object['bill_id']),
+                'bill_id'               => $this->integerFromValue((string) $object['bill_id']),
                 'bill_name'             => $this->stringFromValue($object['bill_name']),
 
                 // piggy bank reference. Optional. Will only work for transfers
-                'piggy_bank_id'         => $this->integerFromValue((string)$object['piggy_bank_id']),
+                'piggy_bank_id'         => $this->integerFromValue((string) $object['piggy_bank_id']),
                 'piggy_bank_name'       => $this->stringFromValue($object['piggy_bank_name']),
 
                 // some other interesting properties
-                'reconciled'            => $this->convertBoolean((string)$object['reconciled']),
+                'reconciled'            => $this->convertBoolean((string) $object['reconciled']),
                 'notes'                 => $this->nlStringFromValue($object['notes']),
                 'tags'                  => $this->arrayFromValue($object['tags']),
 
                 // all custom fields:
-                'internal_reference'    => $this->stringFromValue($object['internal_reference']),
+                'internal_reference'    => $this->stringFromValue((string) $object['internal_reference']),
-                'external_id'           => $this->stringFromValue($object['external_id']),
+                'external_id'           => $this->stringFromValue((string) $object['external_id']),
                 'original_source'       => sprintf('ff3-v%s|api-v%s', config('firefly.version'), config('firefly.api_version')),
                 'recurrence_id'         => $this->integerFromValue($object['recurrence_id']),
-                'bunq_payment_id'       => $this->stringFromValue($object['bunq_payment_id']),
+                'bunq_payment_id'       => $this->stringFromValue((string) $object['bunq_payment_id']),
 
                 'sepa_cc'       => $this->stringFromValue($object['sepa_cc']),
                 'sepa_ct_op'    => $this->stringFromValue($object['sepa_ct_op']),

app/Api/V1/Requests/TransactionUpdateRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * TransactionUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -28,6 +28,7 @@ use FireflyIII\Models\TransactionGroup;
 use FireflyIII\Rules\BelongsUser;
 use FireflyIII\Rules\IsBoolean;
 use FireflyIII\Rules\IsDateOrTime;
+use FireflyIII\Validation\GroupValidation;
 use FireflyIII\Validation\TransactionValidation;
 use Illuminate\Validation\Validator;
 use Log;
@@ -37,7 +38,7 @@ use Log;
  */
 class TransactionUpdateRequest extends Request
 {
-    use TransactionValidation;
+    use TransactionValidation, GroupValidation;
 
     /** @var array Array values. */
     private $arrayFields;
@@ -138,6 +139,7 @@ class TransactionUpdateRequest extends Request
 
         $data = [
             'transactions' => $this->getTransactionData(),
+            'apply_rules'  => $this->boolean('apply_rules', true),
         ];
         if ($this->has('group_title')) {
             $data['group_title'] = $this->string('group_title');
@@ -153,9 +155,10 @@ class TransactionUpdateRequest extends Request
      */
     public function rules(): array
     {
-        $rules = [
+        return [
             // basic fields for group:
             'group_title'                          => 'between:1,1000',
+            'apply_rules'                          => [new IsBoolean],
 
             // transaction rules (in array for splits):
             'transactions.*.type'                  => 'in:withdrawal,deposit,transfer,opening-balance,reconciliation',
@@ -220,8 +223,6 @@ class TransactionUpdateRequest extends Request
             'transactions.*.payment_date'          => 'date|nullable',
             'transactions.*.invoice_date'          => 'date|nullable',
         ];
-
-        return $rules;
     }
 
     /**
@@ -277,6 +278,111 @@ class TransactionUpdateRequest extends Request
         );
     }
 
+    /**
+     * @param array $current
+     * @param array $transaction
+     *
+     * @return array
+     */
+    private function getArrayData(array $current, array $transaction): array
+    {
+        foreach ($this->arrayFields as $fieldName) {
+            if (array_key_exists($fieldName, $transaction)) {
+                $current[$fieldName] = $this->arrayFromValue($transaction[$fieldName]);
+            }
+        }
+
+        return $current;
+    }
+
+    /**
+     * @param array $current
+     * @param array $transaction
+     *
+     * @return array
+     */
+    private function getBooleanData(array $current, array $transaction): array
+    {
+        foreach ($this->booleanFields as $fieldName) {
+            if (array_key_exists($fieldName, $transaction)) {
+                $current[$fieldName] = $this->convertBoolean((string) $transaction[$fieldName]);
+            }
+        }
+
+        return $current;
+    }
+
+    /**
+     * @param array $current
+     * @param array $transaction
+     *
+     * @return array
+     */
+    private function getDateData(array $current, array $transaction): array
+    {
+        foreach ($this->dateFields as $fieldName) {
+            Log::debug(sprintf('Now at date field %s', $fieldName));
+            if (array_key_exists($fieldName, $transaction)) {
+                $current[$fieldName] = $this->dateFromValue((string) $transaction[$fieldName]);
+                Log::debug(sprintf('New value: "%s"', (string) $transaction[$fieldName]));
+            }
+        }
+
+        return $current;
+    }
+
+    /**
+     * For each field, add it to the array if a reference is present in the request:
+     *
+     * @param array $current
+     *
+     * @return array
+     */
+    private function getIntegerData(array $current, array $transaction): array
+    {
+        foreach ($this->integerFields as $fieldName) {
+            if (array_key_exists($fieldName, $transaction)) {
+                $current[$fieldName] = $this->integerFromValue((string) $transaction[$fieldName]);
+            }
+        }
+
+        return $current;
+    }
+
+    /**
+     * @param array $current
+     * @param array $transaction
+     *
+     * @return array
+     */
+    private function getNlStringData(array $current, array $transaction): array
+    {
+        foreach ($this->textareaFields as $fieldName) {
+            if (array_key_exists($fieldName, $transaction)) {
+                $current[$fieldName] = $this->nlStringFromValue((string) $transaction[$fieldName]);
+            }
+        }
+
+        return $current;
+    }
+
+    /**
+     * @param array $current
+     * @param array $transaction
+     *
+     * @return array
+     */
+    private function getStringData(array $current, array $transaction): array
+    {
+        foreach ($this->stringFields as $fieldName) {
+            if (array_key_exists($fieldName, $transaction)) {
+                $current[$fieldName] = $this->stringFromValue((string) $transaction[$fieldName]);
+            }
+        }
+
+        return $current;
+    }
+
     /**
      * Get transaction data.
      *
@@ -290,48 +396,15 @@ class TransactionUpdateRequest extends Request
          * @var int   $index
          * @var array $transaction
          */
-        foreach ($this->get('transactions') as $index => $transaction) {
+        foreach ($this->get('transactions') as $transaction) {
             // default response is to update nothing in the transaction:
             $current  = [];
-
+            $current  = $this->getIntegerData($current, $transaction);
-            // for each field, add it to the array if a reference is present in the request:
+            $current  = $this->getStringData($current, $transaction);
-            foreach ($this->integerFields as $fieldName) {
+            $current  = $this->getNlStringData($current, $transaction);
-                if (array_key_exists($fieldName, $transaction)) {
+            $current  = $this->getDateData($current, $transaction);
-                    $current[$fieldName] = $this->integerFromValue((string)$transaction[$fieldName]);
+            $current  = $this->getBooleanData($current, $transaction);
-                }
+            $current  = $this->getArrayData($current, $transaction);
-            }
-
-            foreach ($this->stringFields as $fieldName) {
-                if (array_key_exists($fieldName, $transaction)) {
-                    $current[$fieldName] = $this->stringFromValue((string)$transaction[$fieldName]);
-                }
-            }
-
-            foreach ($this->textareaFields as $fieldName) {
-                if (array_key_exists($fieldName, $transaction)) {
-                    $current[$fieldName] = $this->nlStringFromValue((string)$transaction[$fieldName]);
-                }
-            }
-
-            foreach ($this->dateFields as $fieldName) {
-                Log::debug(sprintf('Now at date field %s', $fieldName));
-                if (array_key_exists($fieldName, $transaction)) {
-                    $current[$fieldName] = $this->dateFromValue((string)$transaction[$fieldName]);
-                    Log::debug(sprintf('New value: "%s"', (string)$transaction[$fieldName]));
-                }
-            }
-
-            foreach ($this->booleanFields as $fieldName) {
-                if (array_key_exists($fieldName, $transaction)) {
-                    $current[$fieldName] = $this->convertBoolean((string)$transaction[$fieldName]);
-                }
-            }
-
-            foreach ($this->arrayFields as $fieldName) {
-                if (array_key_exists($fieldName, $transaction)) {
-                    $current[$fieldName] = $this->arrayFromValue($transaction[$fieldName]);
-                }
-            }
             $return[] = $current;
         }
 

app/Api/V1/Requests/UserStoreRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * UserStoreRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -69,14 +69,13 @@ class UserStoreRequest extends Request
         if (null !== $this->get('blocked')) {
             $blocked = $this->boolean('blocked');
         }
-        $data = [
+
+        return [
             'email'        => $this->string('email'),
             'blocked'      => $blocked,
             'blocked_code' => $this->string('blocked_code'),
             'role'         => $this->string('role'),
         ];
-
-        return $data;
     }
 
     /**

app/Api/V1/Requests/UserUpdateRequest.php

@@ -2,7 +2,7 @@
 
 /**
  * UserUpdateRequest.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -69,14 +69,13 @@ class UserUpdateRequest extends Request
         if (null !== $this->get('blocked')) {
             $blocked = $this->boolean('blocked');
         }
-        $data = [
+
+        return [
             'email'        => $this->string('email'),
             'blocked'      => $blocked,
             'blocked_code' => $this->string('blocked_code'),
             'role'         => $this->string('role'),
         ];
-
-        return $data;
     }
 
     /**
@@ -87,14 +86,13 @@ class UserUpdateRequest extends Request
     public function rules(): array
     {
         $user = $this->route()->parameter('user');
-        $rules = [
+
+        return [
             'email'        => sprintf('email|unique:users,email,%d', $user->id),
             'blocked'      => [new IsBoolean],
             'blocked_code' => 'in:email_changed',
             'role'         => 'in:owner,demo,',
         ];
-
-        return $rules;
     }
 
 }

app/Console/Commands/Correction/CorrectDatabase.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CorrectDatabase.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -30,6 +30,7 @@ use Schema;
 
 /**
  * Class CorrectDatabase
+ *
  * @codeCoverageIgnore
  */
 class CorrectDatabase extends Command
@@ -73,7 +74,7 @@ class CorrectDatabase extends Command
             'firefly-iii:fix-ob-currencies',
             'firefly-iii:fix-long-descriptions',
             'firefly-iii:fix-recurring-transactions',
-            'firefly-iii:restore-oauth-keys'
+            'firefly-iii:restore-oauth-keys',
         ];
         foreach ($commands as $command) {
             $this->line(sprintf('Now executing %s', $command));
@@ -82,6 +83,8 @@ class CorrectDatabase extends Command
             echo $result;
         }
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 }

app/Console/Commands/Correction/CorrectOpeningBalanceCurrencies.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * CorrectOpeningBalanceCurrencies.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -76,6 +77,8 @@ class CorrectOpeningBalanceCurrencies extends Command
             $this->info('There was nothing to fix in the opening balance transactions.');
         }
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 
@@ -111,17 +114,14 @@ class CorrectOpeningBalanceCurrencies extends Command
      */
     private function getAccount(TransactionJournal $journal): ?Account
     {
-        $excluded     = [];
         $transactions = $journal->transactions()->with(['account', 'account.accountType'])->get();
         /** @var Transaction $transaction */
         foreach ($transactions as $transaction) {
             $account = $transaction->account;
-            if (null !== $account) {
+            if ((null !== $account) && AccountType::INITIAL_BALANCE !== $account->accountType->type) {
-                if (AccountType::INITIAL_BALANCE !== $account->accountType->type) {
                 return $account;
             }
         }
-        }
 
         return null;
     }

app/Console/Commands/Correction/CreateAccessTokens.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CreateAccessTokens.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -50,8 +50,8 @@ class CreateAccessTokens extends Command
     /**
      * Execute the console command.
      *
-     * @return int
      * @throws Exception
+     * @return int
      */
     public function handle(): int
     {
@@ -78,6 +78,8 @@ class CreateAccessTokens extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verify access tokens in %s seconds.', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 }

app/Console/Commands/Correction/CreateLinkTypes.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CreateLinkTypes.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -47,7 +47,7 @@ class CreateLinkTypes extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return int
      */
     public function handle(): int
     {
@@ -79,6 +79,8 @@ class CreateLinkTypes extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified link types in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 }

app/Console/Commands/Correction/DeleteEmptyGroups.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * DeleteEmptyGroups.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -25,7 +25,6 @@ namespace FireflyIII\Console\Commands\Correction;
 
 use Exception;
 use FireflyIII\Models\TransactionGroup;
-use FireflyIII\Models\TransactionJournal;
 use Illuminate\Console\Command;
 use Log;
 
@@ -50,16 +49,17 @@ class DeleteEmptyGroups extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
      * @throws Exception;
+     *
+     * @return int
      */
     public function handle(): int
     {
         Log::debug(sprintf('Now in %s', __METHOD__));
         $start = microtime(true);
-        $groupIds  =
+        $groupIds
-            TransactionGroup
+               = TransactionGroup
-            ::leftJoin('transaction_journals','transaction_groups.id','=','transaction_journals.transaction_group_id')
+            ::leftJoin('transaction_journals', 'transaction_groups.id', '=', 'transaction_journals.transaction_group_id')
             ->whereNull('transaction_journals.id')->get(['transaction_groups.id'])->pluck('id')->toArray();
 
         $total = count($groupIds);
@@ -76,6 +76,8 @@ class DeleteEmptyGroups extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified empty groups in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 }

app/Console/Commands/Correction/DeleteEmptyJournals.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * DeleteEmptyJournals.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -58,6 +58,7 @@ class DeleteEmptyJournals extends Command
         $this->deleteUnevenJournals();
         $this->deleteEmptyJournals();
 
+        // app('telemetry')->feature('executed-command', $this->signature);
 
         return 0;
     }
@@ -101,18 +102,18 @@ class DeleteEmptyJournals extends Command
             ->get([DB::raw('COUNT(transactions.transaction_journal_id) as the_count'), 'transaction_journal_id']);
         $total = 0;
         foreach ($set as $row) {
-            $count = (int)$row->the_count;
+            $count = (int) $row->the_count;
             if (1 === $count % 2) {
                 // uneven number, delete journal and transactions:
                 try {
-                    TransactionJournal::find((int)$row->transaction_journal_id)->delete();
+                    TransactionJournal::find((int) $row->transaction_journal_id)->delete();
                     // @codeCoverageIgnoreStart
                 } catch (Exception $e) {
                     Log::info(sprintf('Could not delete journal: %s', $e->getMessage()));
                 }
                 // @codeCoverageIgnoreEnd
 
-                Transaction::where('transaction_journal_id', (int)$row->transaction_journal_id)->delete();
+                Transaction::where('transaction_journal_id', (int) $row->transaction_journal_id)->delete();
                 $this->info(sprintf('Deleted transaction journal #%d because it had an uneven number of transactions.', $row->transaction_journal_id));
                 $total++;
             }

app/Console/Commands/Correction/DeleteOrphanedTransactions.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * DeleteOrphanedTransactions.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -51,8 +51,8 @@ class DeleteOrphanedTransactions extends Command
     /**
      * Execute the console command.
      *
-     * @return int
      * @throws Exception
+     * @return int
      */
     public function handle(): int
     {
@@ -62,6 +62,7 @@ class DeleteOrphanedTransactions extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified orphans in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
@@ -79,7 +80,7 @@ class DeleteOrphanedTransactions extends Command
         /** @var Transaction $transaction */
         foreach ($set as $transaction) {
             // delete journals
-            $journal = TransactionJournal::find((int)$transaction->transaction_journal_id);
+            $journal = TransactionJournal::find((int) $transaction->transaction_journal_id);
             if ($journal) {
                 try {
                     $journal->delete();
@@ -89,10 +90,13 @@ class DeleteOrphanedTransactions extends Command
                 }
                 // @codeCoverageIgnoreEnd
             }
-            Transaction::where('transaction_journal_id', (int)$transaction->transaction_journal_id)->delete();
+            Transaction::where('transaction_journal_id', (int) $transaction->transaction_journal_id)->delete();
             $this->line(
-                sprintf('Deleted transaction journal #%d because account #%d was already deleted.',
+                sprintf(
-                        $transaction->transaction_journal_id, $transaction->account_id)
+                    'Deleted transaction journal #%d because account #%d was already deleted.',
+                    $transaction->transaction_journal_id,
+                    $transaction->account_id
+                )
             );
             $count++;
         }
@@ -120,7 +124,7 @@ class DeleteOrphanedTransactions extends Command
             );
         /** @var stdClass $entry */
         foreach ($set as $entry) {
-            $transaction = Transaction::find((int)$entry->transaction_id);
+            $transaction = Transaction::find((int) $entry->transaction_id);
             $transaction->delete();
             $this->info(
                 sprintf(
@@ -134,6 +138,5 @@ class DeleteOrphanedTransactions extends Command
         if (0 === $count) {
             $this->info('No orphaned transactions.');
         }
-
     }
 }

app/Console/Commands/Correction/DeleteZeroAmount.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * DeleteZeroAmount.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -49,6 +49,7 @@ class DeleteZeroAmount extends Command
 
     /**
      * Execute the console command.
+     *
      * @return int
      */
     public function handle(): int
@@ -77,6 +78,8 @@ class DeleteZeroAmount extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified zero-amount integrity in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 }

app/Console/Commands/Correction/EnableCurrencies.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * EnableCurrencies.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -52,7 +52,7 @@ class EnableCurrencies extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return int
      */
     public function handle(): int
     {
@@ -62,28 +62,28 @@ class EnableCurrencies extends Command
         /** @var Collection $meta */
         $meta = AccountMeta::where('name', 'currency_id')->groupBy('data')->get(['data']);
         foreach ($meta as $entry) {
-            $found[] = (int)$entry->data;
+            $found[] = (int) $entry->data;
         }
 
         // get all from journals:
         /** @var Collection $journals */
         $journals = TransactionJournal::groupBy('transaction_currency_id')->get(['transaction_currency_id']);
         foreach ($journals as $entry) {
-            $found[] = (int)$entry->transaction_currency_id;
+            $found[] = (int) $entry->transaction_currency_id;
         }
 
         // get all from transactions
         /** @var Collection $transactions */
         $transactions = Transaction::groupBy('transaction_currency_id')->get(['transaction_currency_id']);
         foreach ($transactions as $entry) {
-            $found[] = (int)$entry->transaction_currency_id;
+            $found[] = (int) $entry->transaction_currency_id;
         }
 
         // get all from budget limits
         /** @var Collection $limits */
         $limits = BudgetLimit::groupBy('transaction_currency_id')->get(['transaction_currency_id']);
         foreach ($limits as $entry) {
-            $found[] = (int)$entry->transaction_currency_id;
+            $found[] = (int) $entry->transaction_currency_id;
         }
 
         $found = array_unique($found);
@@ -101,6 +101,8 @@ class EnableCurrencies extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified currencies in %s seconds.', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
+
         return 0;
     }
 }

app/Console/Commands/Correction/FixAccountTypes.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * FixAccountTypes.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -49,20 +49,20 @@ class FixAccountTypes extends Command
      * @var string
      */
     protected $signature = 'firefly-iii:fix-account-types';
+    /** @var int */
+    private $count;
     /** @var array */
     private $expected;
     /** @var AccountFactory */
     private $factory;
     /** @var array */
     private $fixable;
-    /** @var int */
-    private $count;
 
     /**
      * Execute the console command.
      *
-     * @return int
      * @throws FireflyException
+     * @return int
      */
     public function handle(): int
     {
@@ -106,26 +106,16 @@ class FixAccountTypes extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verifying account types took %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
-    /**
-     * Laravel will execute ALL __construct() methods for ALL commands whenever a SINGLE command is
-     * executed. This leads to noticeable slow-downs and class calls. To prevent this, this method should
-     * be called from the handle method instead of using the constructor to initialize the command.
-     *
-     * @codeCoverageIgnore
-     */
-    private function stupidLaravel(): void
-    {
-        $this->count = 0;
-    }
-
     /**
      * @param TransactionJournal $journal
      * @param string             $type
      * @param Transaction        $source
      * @param Transaction        $dest
+     *
      * @throws FireflyException
      */
     private function fixJournal(TransactionJournal $journal, string $type, Transaction $source, Transaction $dest): void
@@ -167,9 +157,12 @@ class FixAccountTypes extends Command
                 $dest->save();
                 $this->info(
                     sprintf(
-                        'Transaction journal #%d, destination account changed from #%d ("%s") to #%d ("%s").', $journal->id,
+                        'Transaction journal #%d, destination account changed from #%d ("%s") to #%d ("%s").',
-                        $oldDest->id, $oldDest->name,
+                        $journal->id,
-                        $result->id, $result->name
+                        $oldDest->id,
+                        $oldDest->name,
+                        $result->id,
+                        $result->name
                     )
                 );
                 $this->inspectJournal($journal);
@@ -184,9 +177,12 @@ class FixAccountTypes extends Command
                 $source->save();
                 $this->info(
                     sprintf(
-                        'Transaction journal #%d, source account changed from #%d ("%s") to #%d ("%s").', $journal->id,
+                        'Transaction journal #%d, source account changed from #%d ("%s") to #%d ("%s").',
-                        $oldSource->id, $oldSource->name,
+                        $journal->id,
-                        $result->id, $result->name
+                        $oldSource->id,
+                        $oldSource->name,
+                        $result->id,
+                        $result->name
                     )
                 );
                 $this->inspectJournal($journal);
@@ -198,7 +194,6 @@ class FixAccountTypes extends Command
                 break;
 
         }
-
     }
 
     /**
@@ -274,4 +269,15 @@ class FixAccountTypes extends Command
         }
     }
 
+    /**
+     * Laravel will execute ALL __construct() methods for ALL commands whenever a SINGLE command is
+     * executed. This leads to noticeable slow-downs and class calls. To prevent this, this method should
+     * be called from the handle method instead of using the constructor to initialize the command.
+     *
+     * @codeCoverageIgnore
+     */
+    private function stupidLaravel(): void
+    {
+        $this->count = 0;
+    }
 }

app/Console/Commands/Correction/FixLongDescriptions.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * FixLongDescriptions.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -65,7 +66,7 @@ class FixLongDescriptions extends Command
         $groups = TransactionGroup::get(['id', 'title']);
         /** @var TransactionGroup $group */
         foreach ($groups as $group) {
-            if (strlen($group->title) > self::MAX_LENGTH) {
+            if (strlen((string)$group->title) > self::MAX_LENGTH) {
                 $group->title = substr($group->title, 0, self::MAX_LENGTH);
                 $group->save();
                 $this->line(sprintf('Truncated description of transaction group #%d', $group->id));
@@ -73,6 +74,8 @@ class FixLongDescriptions extends Command
         }
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified all transaction group and journal title lengths in %s seconds.', $end));
+
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 }

app/Console/Commands/Correction/FixPiggies.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * FixPiggies.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -54,7 +54,7 @@ class FixPiggies extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return int
      */
     public function handle(): int
     {
@@ -98,6 +98,7 @@ class FixPiggies extends Command
         $end = round(microtime(true) - $start, 2);
         $this->line(sprintf('Verified the content of %d piggy bank events in %s seconds.', $set->count(), $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 }

app/Console/Commands/Correction/FixRecurringTransactions.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * FixRecurringTransactions.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -51,16 +52,6 @@ class FixRecurringTransactions extends Command
     /** @var UserRepositoryInterface */
     private $userRepos;
 
-    /**
-     * Create a new command instance.
-     *
-     * @return void
-     */
-    public function __construct()
-    {
-        parent::__construct();
-    }
-
     /**
      * Execute the console command.
      *
@@ -76,6 +67,7 @@ class FixRecurringTransactions extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Corrected recurring transactions %s seconds.', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 

app/Console/Commands/Correction/FixUnevenAmount.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * FixUnevenAmount.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -63,8 +63,8 @@ class FixUnevenAmount extends Command
                       ->get(['transaction_journal_id', DB::raw('SUM(amount) AS the_sum')]);
         /** @var stdClass $entry */
         foreach ($journals as $entry) {
-            if (0 !== bccomp((string)$entry->the_sum, '0')) {
+            if (0 !== bccomp((string) $entry->the_sum, '0')) {
-                $this->fixJournal((int)$entry->transaction_journal_id);
+                $this->fixJournal((int) $entry->transaction_journal_id);
                 $count++;
             }
         }
@@ -75,6 +75,7 @@ class FixUnevenAmount extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified amount integrity in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
@@ -90,11 +91,42 @@ class FixUnevenAmount extends Command
         }
         /** @var Transaction $source */
         $source = $journal->transactions()->where('amount', '<', 0)->first();
-        $amount = bcmul('-1', (string)$source->amount);
+
+        if (null === $source) {
+            $this->error(
+                sprintf(
+                    'Journal #%d ("%s") has no source transaction. It will be deleted to maintain database consistency.',
+                    $journal->id ?? 0,
+                    $journal->description ?? ''
+                )
+            );
+            Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete();
+            TransactionJournal::where('id', $journal->description ?? 0)->forceDelete();
+
+            return;
+        }
+
+        $amount = bcmul('-1', (string) $source->amount);
 
         // fix amount of destination:
         /** @var Transaction $destination */
         $destination = $journal->transactions()->where('amount', '>', 0)->first();
+
+        if (null === $destination) {
+            $this->error(
+                sprintf(
+                    'Journal #%d ("%s") has no destination transaction. It will be deleted to maintain database consistency.',
+                    $journal->id ?? 0,
+                    $journal->description ?? ''
+                )
+            );
+
+            Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete();
+            TransactionJournal::where('id', $journal->description ?? 0)->forceDelete();
+
+            return;
+        }
+
         $destination->amount = $amount;
         $destination->save();
 

app/Console/Commands/Correction/RemoveBills.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RemoveBills.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -48,7 +48,7 @@ class RemoveBills extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return int
      */
     public function handle(): int
     {
@@ -71,6 +71,7 @@ class RemoveBills extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified bills / journals in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 }

app/Console/Commands/Correction/RenameMetaFields.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RenameMetaFields.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -83,6 +83,7 @@ class RenameMetaFields extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Renamed meta fields in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 

app/Console/Commands/Correction/TransferBudgets.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TransferBudgets.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -74,6 +74,7 @@ class TransferBudgets extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Verified budget/journals in %s seconds.', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 }

app/Console/Commands/CreateDatabase.php

@@ -1,4 +1,26 @@
 <?php
+declare(strict_types=1);
+
+
+/**
+ * CreateDatabase.php
+ * Copyright (c) 2020 james@firefly-iii.org
+ *
+ * This file is part of Firefly III (https://github.com/firefly-iii).
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
 
 namespace FireflyIII\Console\Commands;
 
@@ -33,10 +55,12 @@ class CreateDatabase extends Command
     public function handle()
     {
         if ('mysql' !== env('DB_CONNECTION')) {
-            $this->info('This command currently applies to MySQL connections only.');
+            $this->info(sprintf('CreateDB does not apply to "%s", skipped.', env('DB_CONNECTION')));
+
+            return 0;
         }
         // try to set up a raw connection:
-        $dsn     = sprintf('mysql:host=%s;charset=utf8mb4', env('DB_HOST'));
+        $dsn     = sprintf('mysql:host=%s;port=%d;charset=utf8mb4', env('DB_HOST', 'localhost'), env('DB_PORT', '3306'));
         $options = [
             PDO::ATTR_ERRMODE            => PDO::ERRMODE_EXCEPTION,
             PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_ASSOC,

app/Console/Commands/DecryptDatabase.php

@@ -2,7 +2,7 @@
 
 /**
  * DecryptDatabase.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -30,6 +30,7 @@ use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Preference;
 use Illuminate\Console\Command;
 use Illuminate\Contracts\Encryption\DecryptException;
+use JsonException;
 use Log;
 
 /**
@@ -54,8 +55,8 @@ class DecryptDatabase extends Command
     /**
      * Execute the console command.
      *
-     * @return int
      * @throws FireflyException
+     * @return int
      */
     public function handle(): int
     {
@@ -92,11 +93,15 @@ class DecryptDatabase extends Command
                     // A separate routine for preferences:
                     if ('preferences' === $table) {
                         // try to json_decrypt the value.
-                        $value = json_decode($value, true) ?? $value;
+                        try {
+                            $value = json_decode($value, true, 512, JSON_THROW_ON_ERROR) ?? $value;
+                        } catch(JsonException $e) {
+                            Log::error($e->getMessage());
+                        }
                         Log::debug(sprintf('Decrypted field "%s" "%s" to "%s" in table "%s" (row #%d)', $field, $original, print_r($value, true), $table, $id));
 
                         /** @var Preference $object */
-                        $object = Preference::find((int)$id);
+                        $object = Preference::find((int) $id);
                         if (null !== $object) {
                             $object->data = $value;
                             $object->save();
@@ -118,6 +123,7 @@ class DecryptDatabase extends Command
         }
         $this->info('Done!');
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
@@ -131,7 +137,7 @@ class DecryptDatabase extends Command
         $configName = sprintf('is_decrypted_%s', $table);
         $configVar  = app('fireflyconfig')->get($configName, false);
         if (null !== $configVar) {
-            return (bool)$configVar->data;
+            return (bool) $configVar->data;
         }
 
         return false;
@@ -142,8 +148,9 @@ class DecryptDatabase extends Command
      * Tries to decrypt data. Will only throw an exception when the MAC is invalid.
      *
      * @param $value
-     * @return string
+     *
      * @throws FireflyException
+     * @return string
      */
     private function tryDecrypt($value)
     {

app/Console/Commands/Export/ExportData.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * ExportData.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -22,6 +23,7 @@
 namespace FireflyIII\Console\Commands\Export;
 
 use Carbon\Carbon;
+use Exception;
 use FireflyIII\Console\Commands\VerifiesAccessToken;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\AccountType;
@@ -32,6 +34,7 @@ use FireflyIII\User;
 use Illuminate\Console\Command;
 use Illuminate\Support\Collection;
 use InvalidArgumentException;
+use League\Csv\CannotInsertRecord;
 use Log;
 
 /**
@@ -41,14 +44,6 @@ class ExportData extends Command
 {
     use VerifiesAccessToken;
 
-    /** @var JournalRepositoryInterface */
-    private $journalRepository;
-
-    /** @var AccountRepositoryInterface */
-    private $accountRepository;
-
-    /** @var User */
-    private $user;
     /**
      * The console command description.
      *
@@ -77,29 +72,25 @@ class ExportData extends Command
     {--export-bills : Create a file with all your bills and some meta data.}
     {--export-piggies : Create a file with all your piggy banks and some meta data.}
     {--force : Force overwriting of previous exports if found.}';
-
+    /** @var AccountRepositoryInterface */
-
+    private $accountRepository;
-    /**
+    /** @var JournalRepositoryInterface */
-     * Create a new command instance.
+    private $journalRepository;
-     *
+    /** @var User */
-     * @return void
+    private $user;
-     */
-    public function __construct()
-    {
-        parent::__construct();
-    }
 
     /**
      * Execute the console command.
      *
-     * @return int
      * @throws FireflyException
+     * @throws CannotInsertRecord
+     * @return int
      */
     public function handle(): int
     {
         // verify access token
         if (!$this->verifyAccessToken()) {
-            $this->error('Invalid access token.');
+            $this->error('Invalid access token. Check /profile.');
 
             return 1;
         }
@@ -145,8 +136,12 @@ class ExportData extends Command
             $this->exportData($options, $data);
         } catch (FireflyException $e) {
             $this->error(sprintf('Could not store data: %s', $e->getMessage()));
+
+            // app('telemetry')->feature('executed-command-with-error', $this->signature);
+            return 1;
         }
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
@@ -174,8 +169,8 @@ class ExportData extends Command
     }
 
     /**
-     * @return Collection
      * @throws FireflyException
+     * @return Collection
      */
     private function getAccountsParameter(): Collection
     {
@@ -183,7 +178,7 @@ class ExportData extends Command
         $accounts    = new Collection;
         $accountList = $this->option('accounts');
         $types       = [AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE];
-        if (null !== $accountList && '' !== (string)$accountList) {
+        if (null !== $accountList && '' !== (string) $accountList) {
             $accountIds = explode(',', $accountList);
             $accounts   = $this->accountRepository->getAccountsById($accountIds);
         }
@@ -207,44 +202,49 @@ class ExportData extends Command
     /**
      * @param string $field
      *
-     * @return Carbon
      * @throws FireflyException
+     * @throws Exception
+     * @return Carbon
      */
     private function getDateParameter(string $field): Carbon
     {
-        $date = null;
+        $date = Carbon::now()->subYear();
         if (null !== $this->option($field)) {
             try {
                 $date = Carbon::createFromFormat('Y-m-d', $this->option($field));
             } catch (InvalidArgumentException $e) {
                 Log::error($e->getMessage());
-                throw new FireflyException(sprintf('%s date "%s" must be formatted YYYY-MM-DD', $field, $this->option('start')));
+                $this->error(sprintf('%s date "%s" must be formatted YYYY-MM-DD. Field will be ignored.', $field, $this->option('start')));
-            }
-        }
-        if (null === $date && 'start' === $field) {
-            $journal = $this->journalRepository->firstNull();
-            $date    = null === $journal ? Carbon::now()->subYear() : $date;
-        }
-        if (null === $date && 'end' === $field) {
-            $date = new Carbon;
-        }
-        if ('start' === $date) {
-            $date->startOfDay();
-        }
-        if ('end' === $date) {
-            $date->endOfDay();
             }
 
             return $date;
         }
+        if ('start' === $field) {
+            $journal = $this->journalRepository->firstNull();
+            $date    = null === $journal ? Carbon::now()->subYear() : $journal->date;
+            $date->startOfDay();
+
+            return $date;
+        }
+        if ('end' === $field) {
+            $date = new Carbon;
+            $date->endOfDay();
+
+            return $date;
+        }
+
+        // fallback
+        return $date;
+    }
 
     /**
-     * @return string
      * @throws FireflyException
+     *
+     * @return string
      */
     private function getExportDirectory(): string
     {
-        $directory = $this->option('export_directory');
+        $directory = (string) $this->option('export_directory');
         if (null === $directory) {
             $directory = './';
         }
@@ -256,8 +256,8 @@ class ExportData extends Command
     }
 
     /**
-     * @return array
      * @throws FireflyException
+     * @return array
      */
     private function parseOptions(): array
     {

app/Console/Commands/Import/CreateCSVImport.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CreateCSVImport.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -39,6 +39,9 @@ use Log;
 
 /**
  * Class CreateCSVImport.
+ *
+ * @deprecated
+ * @codeCoverageIgnore
  */
 class CreateCSVImport extends Command
 {
@@ -60,12 +63,12 @@ class CreateCSVImport extends Command
                             {configuration? : The configuration file to use for the import.}
                             {--user=1 : The user ID that the import should import for.}
                             {--token= : The user\'s access token.}';
-    /** @var UserRepositoryInterface */
-    private $userRepository;
-    /** @var ImportJobRepositoryInterface */
-    private $importRepository;
     /** @var ImportJob */
     private $importJob;
+    /** @var ImportJobRepositoryInterface */
+    private $importRepository;
+    /** @var UserRepositoryInterface */
+    private $userRepository;
 
     /**
      * Run the command.
@@ -87,13 +90,13 @@ class CreateCSVImport extends Command
         }
         // @codeCoverageIgnoreEnd
         /** @var User $user */
-        $user          = $this->userRepository->findNull((int)$this->option('user'));
+        $user          = $this->userRepository->findNull((int) $this->option('user'));
-        $file          = (string)$this->argument('file');
+        $file          = (string) $this->argument('file');
-        $configuration = (string)$this->argument('configuration');
+        $configuration = (string) $this->argument('configuration');
 
         $this->importRepository->setUser($user);
 
-        $configurationData = json_decode(file_get_contents($configuration), true);
+        $configurationData = json_decode(file_get_contents($configuration), true, 512, JSON_THROW_ON_ERROR);
         $this->importJob   = $this->importRepository->create('file');
 
 
@@ -125,6 +128,7 @@ class CreateCSVImport extends Command
         } catch (FireflyException $e) {
             $this->errorLine($e->getMessage());
 
+            // app('telemetry')->feature('executed-command-with-error', $this->signature);
             return 1;
         }
 
@@ -134,6 +138,7 @@ class CreateCSVImport extends Command
         } catch (FireflyException $e) {
             $this->errorLine($e->getMessage());
 
+            // app('telemetry')->feature('executed-command-with-error', $this->signature);
             return 1;
         }
 
@@ -143,25 +148,14 @@ class CreateCSVImport extends Command
         // clear cache for user:
         app('preferences')->setForUser($user, 'lastActivity', microtime());
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
-    /**
-     * Laravel will execute ALL __construct() methods for ALL commands whenever a SINGLE command is
-     * executed. This leads to noticeable slow-downs and class calls. To prevent this, this method should
-     * be called from the handle method instead of using the constructor to initialize the command.
-     *
-     * @codeCoverageIgnore
-     */
-    private function stupidLaravel(): void
-    {
-        $this->userRepository   = app(UserRepositoryInterface::class);
-        $this->importRepository = app(ImportJobRepositoryInterface::class);
-    }
-
     /**
      * @param string     $message
      * @param array|null $data
+     *
      * @codeCoverageIgnore
      */
     private function errorLine(string $message, array $data = null): void
@@ -171,9 +165,34 @@ class CreateCSVImport extends Command
 
     }
 
+    /**
+     *
+     */
+    private function giveFeedback(): void
+    {
+        $this->infoLine('Job has finished.');
+
+
+        if (null !== $this->importJob->tag) {
+            $this->infoLine(sprintf('%d transaction(s) have been imported.', $this->importJob->tag->transactionJournals->count()));
+            $this->infoLine(sprintf('You can find your transactions under tag "%s"', $this->importJob->tag->tag));
+        }
+
+        if (null === $this->importJob->tag) {
+            $this->errorLine('No transactions have been imported :(.');
+        }
+        if (count($this->importJob->errors) > 0) {
+            $this->infoLine(sprintf('%d error(s) occurred:', count($this->importJob->errors)));
+            foreach ($this->importJob->errors as $err) {
+                $this->errorLine('- ' . $err);
+            }
+        }
+    }
+
     /**
      * @param string $message
      * @param array  $data
+     *
      * @codeCoverageIgnore
      */
     private function infoLine(string $message, array $data = null): void
@@ -182,65 +201,6 @@ class CreateCSVImport extends Command
         $this->line($message);
     }
 
-    /**
-     * Verify user inserts correct arguments.
-     *
-     * @noinspection MultipleReturnStatementsInspection
-     * @return bool
-     * @codeCoverageIgnore
-     */
-    private function validArguments(): bool
-    {
-        $file          = (string)$this->argument('file');
-        $configuration = (string)$this->argument('configuration');
-        $cwd           = getcwd();
-        $enabled       = (bool)config('import.enabled.file');
-
-        if (false === $enabled) {
-            $this->errorLine('CSV Provider is not enabled.');
-
-            return false;
-        }
-
-        if (!file_exists($file)) {
-            $this->errorLine(sprintf('Firefly III cannot find file "%s" (working directory: "%s").', $file, $cwd));
-
-            return false;
-        }
-
-        if (!file_exists($configuration)) {
-            $this->errorLine(sprintf('Firefly III cannot find configuration file "%s" (working directory: "%s").', $configuration, $cwd));
-
-            return false;
-        }
-
-        $configurationData = json_decode(file_get_contents($configuration), true);
-        if (null === $configurationData) {
-            $this->errorLine(sprintf('Firefly III cannot read the contents of configuration file "%s" (working directory: "%s").', $configuration, $cwd));
-
-            return false;
-        }
-
-        return true;
-    }
-
-    /**
-     * Store the supplied file as an attachment to this job.
-     *
-     * @param string $file
-     * @throws FireflyException
-     */
-    private function storeFile(string $file): void
-    {
-        // store file as attachment.
-        if ('' !== $file) {
-            $messages = $this->importRepository->storeCLIUpload($this->importJob, 'import_file', $file);
-            if ($messages->count() > 0) {
-                throw new FireflyException($messages->first());
-            }
-        }
-    }
-
     /**
      * Keep repeating import call until job lands on "provider_finished".
      *
@@ -307,26 +267,75 @@ class CreateCSVImport extends Command
     }
 
     /**
+     * Store the supplied file as an attachment to this job.
      *
+     * @param string $file
+     *
+     * @throws FireflyException
      */
-    private function giveFeedback(): void
+    private function storeFile(string $file): void
     {
-        $this->infoLine('Job has finished.');
+        // store file as attachment.
-
+        if ('' !== $file) {
-
+            $messages = $this->importRepository->storeCLIUpload($this->importJob, 'import_file', $file);
-        if (null !== $this->importJob->tag) {
+            if ($messages->count() > 0) {
-            $this->infoLine(sprintf('%d transaction(s) have been imported.', $this->importJob->tag->transactionJournals->count()));
+                throw new FireflyException($messages->first());
-            $this->infoLine(sprintf('You can find your transactions under tag "%s"', $this->importJob->tag->tag));
+            }
+        }
     }
 
-        if (null === $this->importJob->tag) {
+    /**
-            $this->errorLine('No transactions have been imported :(.');
+     * Laravel will execute ALL __construct() methods for ALL commands whenever a SINGLE command is
+     * executed. This leads to noticeable slow-downs and class calls. To prevent this, this method should
+     * be called from the handle method instead of using the constructor to initialize the command.
+     *
+     * @codeCoverageIgnore
+     */
+    private function stupidLaravel(): void
+    {
+        $this->userRepository   = app(UserRepositoryInterface::class);
+        $this->importRepository = app(ImportJobRepositoryInterface::class);
     }
-        if (count($this->importJob->errors) > 0) {
+
-            $this->infoLine(sprintf('%d error(s) occurred:', count($this->importJob->errors)));
+    /**
-            foreach ($this->importJob->errors as $err) {
+     * Verify user inserts correct arguments.
-                $this->errorLine('- ' . $err);
+     *
+     * @noinspection MultipleReturnStatementsInspection
+     * @return bool
+     * @codeCoverageIgnore
+     */
+    private function validArguments(): bool
+    {
+        $file          = (string) $this->argument('file');
+        $configuration = (string) $this->argument('configuration');
+        $cwd           = getcwd();
+        $enabled       = (bool) config('import.enabled.file');
+
+        if (false === $enabled) {
+            $this->errorLine('CSV Provider is not enabled.');
+
+            return false;
         }
+
+        if (!file_exists($file)) {
+            $this->errorLine(sprintf('Firefly III cannot find file "%s" (working directory: "%s").', $file, $cwd));
+
+            return false;
         }
+
+        if (!file_exists($configuration)) {
+            $this->errorLine(sprintf('Firefly III cannot find configuration file "%s" (working directory: "%s").', $configuration, $cwd));
+
+            return false;
+        }
+
+        $configurationData = json_decode(file_get_contents($configuration), true, 512, JSON_THROW_ON_ERROR);
+        if (null === $configurationData) {
+            $this->errorLine(sprintf('Firefly III cannot read the contents of configuration file "%s" (working directory: "%s").', $configuration, $cwd));
+
+            return false;
+        }
+
+        return true;
     }
 }

app/Console/Commands/Integrity/ReportEmptyObjects.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportEmptyObjects.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -64,6 +64,7 @@ class ReportEmptyObjects extends Command
         $end = round(microtime(true) - $start, 2);
         $this->info(sprintf('Report on empty objects finished in %s seconds', $end));
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 

app/Console/Commands/Integrity/ReportIntegrity.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportIntegrity.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -30,6 +30,7 @@ use Schema;
 
 /**
  * Class ReportIntegrity
+ *
  * @codeCoverageIgnore
  */
 class ReportIntegrity extends Command
@@ -68,6 +69,7 @@ class ReportIntegrity extends Command
             echo $result;
         }
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 }

app/Console/Commands/Integrity/ReportSum.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportSum.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -54,6 +54,7 @@ class ReportSum extends Command
     {
         $this->reportSum();
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }
 
@@ -69,7 +70,7 @@ class ReportSum extends Command
 
         /** @var User $user */
         foreach ($userRepository->all() as $user) {
-            $sum = (string)$user->transactions()->sum('amount');
+            $sum = (string) $user->transactions()->sum('amount');
             if (0 !== bccomp($sum, '0')) {
                 $message = sprintf('Error: Transactions for user #%d (%s) are off by %s!', $user->id, $user->email, $sum);
                 $this->error($message);

app/Console/Commands/Integrity/RestoreOAuthKeys.php

@@ -1,7 +1,8 @@
 <?php
+declare(strict_types=1);
 /**
  * RestoreOAuthKeys.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2020 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -21,8 +22,6 @@
 
 namespace FireflyIII\Console\Commands\Integrity;
 
-use Artisan;
-use Crypt;
 use FireflyIII\Support\System\OAuthKeys;
 use Illuminate\Console\Command;
 
@@ -53,6 +52,7 @@ class RestoreOAuthKeys extends Command
     {
         $this->restoreOAuthKeys();
 
+        // app('telemetry')->feature('executed-command', $this->signature);
         return 0;
     }