From 55d01d3defed4bfdc74704dbea0da9548a97a979 Mon Sep 17 00:00:00 2001 From: Travis Cross Date: Fri, 28 Feb 2014 23:12:29 +0000 Subject: [PATCH] Send silent packets when idle with SRTP Originally we did the same thing with SRTP that we do without SRTP, which is to simply not send packets when e.g. sleep is called. At commits d63323977fa611b141441f12af9a94ec19b5f829 and 5259814aee16ede974456490a79e8a98de1d6d2e we enabled sending silence packets with comfort noise when SRTP is active. We appear to have done this for interop purposes; many devices can't handle gaps in the stream of SRTP packets. But our current comfort noise implementation doesn't take the codec rate into account (FS-6291), so on 16kHz codecs the constant we chose created an annoying level of static between sound file playback. With this commit we preserve the sending of SRTP packets during idle periods, but make those packets completely silent. Thanks-to: Anthony Minessale FS-5053 --resolve --- src/switch_rtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/switch_rtp.c b/src/switch_rtp.c index ba2e11e562..4fcc88eee0 100644 --- a/src/switch_rtp.c +++ b/src/switch_rtp.c @@ -3041,7 +3041,7 @@ SWITCH_DECLARE(switch_status_t) switch_rtp_add_crypto_key(switch_rtp_t *rtp_sess memset(policy, 0, sizeof(*policy)); - switch_channel_set_variable(channel, "send_silence_when_idle", "400"); + switch_channel_set_variable(channel, "send_silence_when_idle", "-1"); switch (crypto_key->type) { case AES_CM_128_HMAC_SHA1_80: