From 61c7a110b2b6313fc5ccbc0ba0973027c060a8a3 Mon Sep 17 00:00:00 2001 From: Michael Jerris Date: Fri, 15 May 2009 16:01:31 +0000 Subject: [PATCH] Tue May 12 13:23:33 CDT 2009 Pekka Pessi * tport.c: do not use out-of-scope array in tport_deliver() Ignore-this: a651d5eb213850d9dfd317102a432f8e Coverity issue. git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13331 d0543943-73ff-0310-b7d9-9358b9ac24b2 --- libs/sofia-sip/.update | 2 +- libs/sofia-sip/libsofia-sip-ua/tport/tport.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libs/sofia-sip/.update b/libs/sofia-sip/.update index 5c8be86d5e..f90a1aa213 100644 --- a/libs/sofia-sip/.update +++ b/libs/sofia-sip/.update @@ -1 +1 @@ -Fri May 15 10:59:42 CDT 2009 +Fri May 15 11:01:11 CDT 2009 diff --git a/libs/sofia-sip/libsofia-sip-ua/tport/tport.c b/libs/sofia-sip/libsofia-sip-ua/tport/tport.c index dd3892ecdb..2bf0b2d262 100644 --- a/libs/sofia-sip/libsofia-sip-ua/tport/tport.c +++ b/libs/sofia-sip/libsofia-sip-ua/tport/tport.c @@ -2952,6 +2952,7 @@ void tport_deliver(tport_t *self, tport_t *ref; int error; struct tport_delivery *d; + char ipaddr[SU_ADDRSIZE + 2]; assert(msg); @@ -2962,7 +2963,6 @@ void tport_deliver(tport_t *self, *d->d_from = *self->tp_name; if (tport_is_primary(self)) { - char ipaddr[SU_ADDRSIZE + 2]; su_sockaddr_t const *su = msg_addr(msg); #if SU_HAVE_IN6 @@ -3005,16 +3005,16 @@ void tport_deliver(tport_t *self, ref = tport_incref(self); - if (self->tp_pri->pri_vtable->vtp_deliver) { self->tp_pri->pri_vtable->vtp_deliver(self, msg, now); } else tport_base_deliver(self, msg, now); - tport_decref(&ref); - + memset(d->d_from, 0, sizeof d->d_from); d->d_msg = NULL; + + tport_decref(&ref); } /** Pass message to the protocol stack */