kenmirrors/freeswitch
1
0
Fork 0
mirror of https://github.com/signalwire/freeswitch.git synced 2025-04-06 21:06:04 +00:00
Code Issues Projects Releases Wiki Activity

[mod_sofia] scan-build: Dereference of null pointer in sofia_handle_sip_i_bye(), sofia_handle_sip_i_invite() and our_sofia_event_callback()

Browse Source
This commit is contained in:
Andrey Volk 2021-04-02 00:27:59 +03:00
parent ac1a3dc565
commit 6726922e34
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mod/endpoints/mod_sofia/sofia.c
View File

@ -960,7 +960,7 @@ void sofia_handle_sip_i_bye(switch_core_session_t *session, int status,
char st[80] = ""; char st[80] = "";
#endif #endif
if (!session) { if (!session || !sip) {
return; return;
} }
@ -1615,7 +1615,7 @@ static void our_sofia_event_callback(nua_event_t event,
authorization = sip->sip_proxy_authorization; authorization = sip->sip_proxy_authorization;
} }
if (authorization) { if (authorization && sip->sip_request) {
char network_ip[80] = ""; char network_ip[80] = "";
int network_port; int network_port;
sofia_glue_get_addr(de->data->e_msg, network_ip, sizeof(network_ip), &network_port); sofia_glue_get_addr(de->data->e_msg, network_ip, sizeof(network_ip), &network_port);
@ -10694,8 +10694,9 @@ void sofia_handle_sip_i_invite(switch_core_session_t *session, nua_t *nua, sofia
} }
} }
if (sip->sip_from && sip->sip_from->a_url) {
tech_pvt->from_user = switch_core_session_strdup(session, sip->sip_from->a_url->url_user); tech_pvt->from_user = switch_core_session_strdup(session, sip->sip_from->a_url->url_user);
}
tech_pvt->mparams.remote_ip = switch_core_session_strdup(session, network_ip); tech_pvt->mparams.remote_ip = switch_core_session_strdup(session, network_ip);
tech_pvt->mparams.remote_port = network_port; tech_pvt->mparams.remote_port = network_port;
@ -11268,7 +11269,7 @@ void sofia_handle_sip_i_invite(switch_core_session_t *session, nua_t *nua, sofia
if (profile->pres_type) { if (profile->pres_type) {
const char *presence_id = switch_channel_get_variable(channel, "presence_id"); const char *presence_id = switch_channel_get_variable(channel, "presence_id");
if (zstr(presence_id)) { if (zstr(presence_id) && sip->sip_from && sip->sip_from->a_url) {
const char *user = switch_str_nil(sip->sip_from->a_url->url_user); const char *user = switch_str_nil(sip->sip_from->a_url->url_user);
const char *host = switch_str_nil(sip->sip_from->a_url->url_host); const char *host = switch_str_nil(sip->sip_from->a_url->url_host);
char *tmp = switch_mprintf("%s@%s", user, host); char *tmp = switch_mprintf("%s@%s", user, host);