FS-7513: cleanup

This commit is contained in:
Anthony Minessale 2015-02-16 20:46:52 -06:00 committed by Michael Jerris
parent 7307005c56
commit 84074ab804
2 changed files with 13 additions and 13 deletions

View File

@ -1078,6 +1078,10 @@ static void layer_set_logo(conference_member_t *member, mcu_layer_t *layer, cons
goto end; goto end;
} }
if (path) {
switch_img_free(&layer->logo_img);
}
if (*path == '{') { if (*path == '{') {
dup = strdup(path); dup = strdup(path);
path = dup; path = dup;
@ -1117,12 +1121,6 @@ static void layer_set_logo(conference_member_t *member, mcu_layer_t *layer, cons
} }
} }
if (path) {
switch_img_free(&layer->logo_img);
}
if (path && strcasecmp(path, "clear")) { if (path && strcasecmp(path, "clear")) {
layer->logo_img = switch_img_read_png(path); layer->logo_img = switch_img_read_png(path);
} }
@ -8432,8 +8430,10 @@ static switch_status_t conf_api_sub_vid_logo_img(conference_member_t *member, sw
} }
layer = &member->conference->canvas->layers[member->video_layer_id]; layer = &member->conference->canvas->layers[member->video_layer_id];
member->video_logo = switch_core_strdup(member->pool, text); if (!strcasecmp(text, "clear")) {
member->video_logo = switch_core_strdup(member->pool, text);
}
layer_set_logo(member, layer, text); layer_set_logo(member, layer, text);

View File

@ -856,30 +856,30 @@ SWITCH_DECLARE(switch_image_t *) switch_img_read_png(const char* file_name)
/* open file and test for it being a png */ /* open file and test for it being a png */
FILE *fp = fopen(file_name, "rb"); FILE *fp = fopen(file_name, "rb");
if (!fp) { if (!fp) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "File %s could not be opened for reading", file_name); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "File %s could not be opened for reading\n", file_name);
goto end; goto end;
} }
fread(header, 1, 8, fp); fread(header, 1, 8, fp);
if (png_sig_cmp(header, 0, 8)) { if (png_sig_cmp(header, 0, 8)) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "File %s is not recognized as a PNG file", file_name); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "File %s is not recognized as a PNG file\n", file_name);
goto end; goto end;
} }
png_ptr = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL); png_ptr = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
if (!png_ptr) { if (!png_ptr) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "png_create_read_struct failed"); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "png_create_read_struct failed\n");
goto end; goto end;
} }
info_ptr = png_create_info_struct(png_ptr); info_ptr = png_create_info_struct(png_ptr);
if (!info_ptr) { if (!info_ptr) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "png_create_info_struct failed"); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "png_create_info_struct failed\n");
goto end; goto end;
} }
if (setjmp(png_jmpbuf(png_ptr))) { if (setjmp(png_jmpbuf(png_ptr))) {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error during init_io"); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error during init_io\n");
goto end; goto end;
} }