From 98a3749c1068e2140ec582a61394b10c30a59d55 Mon Sep 17 00:00:00 2001 From: Andrey Volk Date: Fri, 31 Jan 2025 18:58:34 +0300 Subject: [PATCH] [libesl] Coverity 1546296 Check of thread-shared field evades lock acquisition --- libs/esl/src/esl.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libs/esl/src/esl.c b/libs/esl/src/esl.c index d29926eb5c..f39bda83b1 100644 --- a/libs/esl/src/esl.c +++ b/libs/esl/src/esl.c @@ -1531,11 +1531,15 @@ ESL_DECLARE(esl_status_t) esl_send_recv_timed(esl_handle_t *handle, const char * const char *hval; esl_status_t status; - if (!handle || !handle->connected || handle->sock == ESL_SOCK_INVALID) { - return ESL_FAIL; - } + if (!handle) { + return ESL_FAIL; + } esl_mutex_lock(handle->mutex); + if (!handle->connected || handle->sock == ESL_SOCK_INVALID) { + esl_mutex_unlock(handle->mutex); + return ESL_FAIL; + } esl_event_safe_destroy(&handle->last_sr_event);