kenmirrors/freeswitch
1
0
Fork 0
mirror of https://github.com/signalwire/freeswitch.git synced 2025-04-29 13:43:07 +00:00
Code Issues Projects Releases Wiki Activity

[core] scan-build: Value stored to 'status' is never read - switch_ivr_eavesdrop_session()

Browse Source
This commit is contained in:
Dragos Oancea 2020-02-12 21:54:33 +00:00
parent c714401935
commit c0b833fe74
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/switch_ivr_async.c
View File

@ -2183,8 +2183,7 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_eavesdrop_session(switch_core_session
const char *group_name = switch_channel_get_variable(tchannel, "eavesdrop_group"); const char *group_name = switch_channel_get_variable(tchannel, "eavesdrop_group");
/* If we don't have a group, then return */ /* If we don't have a group, then return */
if (!group_name) { if (!group_name) {
status = SWITCH_STATUS_BREAK; switch_goto_status(SWITCH_STATUS_BREAK, end);
goto end;
} }
/* Separate the group */ /* Separate the group */
data = strdup(group_name); data = strdup(group_name);
@ -2199,8 +2198,7 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_eavesdrop_session(switch_core_session
switch_safe_free(data); switch_safe_free(data);
/* If we didn't find any match, then end */ /* If we didn't find any match, then end */
if (!ok) { if (!ok) {
status = SWITCH_STATUS_BREAK; switch_goto_status(SWITCH_STATUS_BREAK, end);
goto end;
} }
} }
@ -2225,7 +2223,6 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_eavesdrop_session(switch_core_session
SWITCH_CODEC_FLAG_ENCODE | SWITCH_CODEC_FLAG_DECODE, SWITCH_CODEC_FLAG_ENCODE | SWITCH_CODEC_FLAG_DECODE,
NULL, switch_core_session_get_pool(session)) != SWITCH_STATUS_SUCCESS) { NULL, switch_core_session_get_pool(session)) != SWITCH_STATUS_SUCCESS) {
switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_ERROR, "Cannot init codec\n"); switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_ERROR, "Cannot init codec\n");
switch_core_session_rwunlock(tsession);
goto end; goto end;
} }
@ -2585,8 +2582,7 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_eavesdrop_session(switch_core_session
msg.message_id = SWITCH_MESSAGE_INDICATE_UNBRIDGE; msg.message_id = SWITCH_MESSAGE_INDICATE_UNBRIDGE;
switch_core_session_receive_message(session, &msg); switch_core_session_receive_message(session, &msg);
status = SWITCH_STATUS_SUCCESS;
end: end:
if (codec_initialized) if (codec_initialized)
@ -2611,7 +2607,6 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_eavesdrop_session(switch_core_session
} }
switch_core_session_rwunlock(tsession); switch_core_session_rwunlock(tsession);
status = SWITCH_STATUS_SUCCESS;
switch_core_session_reset(session, SWITCH_TRUE, SWITCH_TRUE); switch_core_session_reset(session, SWITCH_TRUE, SWITCH_TRUE);
} }