From 5b63e4d04527fe9950fb2e80650e97f5e3b44961 Mon Sep 17 00:00:00 2001 From: Andrey Volk Date: Sat, 15 Feb 2020 02:22:36 +0400 Subject: [PATCH] [apr] Fix dead assignment and use of uninitialized variable in strings. --- libs/apr/strings/apr_snprintf.c | 1 - libs/apr/strings/apr_strings.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libs/apr/strings/apr_snprintf.c b/libs/apr/strings/apr_snprintf.c index 4f59f92c76..611f2d7972 100644 --- a/libs/apr/strings/apr_snprintf.c +++ b/libs/apr/strings/apr_snprintf.c @@ -110,7 +110,6 @@ static char *apr_cvt(double arg, int ndigits, int *decpt, int *sign, arg = -arg; } arg = modf(arg, &fi); - p1 = &buf[NDIG]; /* * Do integer part */ diff --git a/libs/apr/strings/apr_strings.c b/libs/apr/strings/apr_strings.c index ec687913c5..771d351f19 100644 --- a/libs/apr/strings/apr_strings.c +++ b/libs/apr/strings/apr_strings.c @@ -124,7 +124,7 @@ APR_DECLARE(void *) apr_pmemdup(apr_pool_t *a, const void *m, apr_size_t n) APR_DECLARE_NONSTD(char *) apr_pstrcat(apr_pool_t *a, ...) { char *cp, *argp, *res; - apr_size_t saved_lengths[MAX_SAVED_LENGTHS]; + apr_size_t saved_lengths[MAX_SAVED_LENGTHS] = { 0 }; int nargs = 0; /* Pass one --- find length of required string */