4eefe8279b
Merge pull request #2543 from signalwire/risky
...
[Core] rtp_common_write: Coverity 1227609 Calling risky function
2024-07-30 00:09:24 +03:00
a99ed5c46f
[Core] Introduce SWITCH_RAND_MAX to switch_rand()
2024-07-29 22:26:27 +03:00
b38d879413
[Core] rtp_common_write: Coverity 1227609 Calling risky function
2024-07-29 17:02:42 +03:00
93072c9503
[core] check_rtcp_and_ice() - stringop-overflow: Fix build on Debian Bookworm.
2024-07-25 21:46:40 +03:00
74f386bf94
swigall
2024-06-11 14:44:07 +02:00
9f362ea315
[Core] Better handle error cases in switch_rand().
2024-06-07 23:12:20 +03:00
0c8b5987f0
[mod_fsv] Fix use of 2gb of memory. Fix compiler warnings preventing builds on Bookworm.
2024-06-07 23:03:24 +03:00
3b65e27116
[mod_av] Fix use of switch_size_t in fs_rtp_parse_h263_rfc2190().
2024-06-07 18:19:52 +03:00
c7e793c345
[Core] Add new switch_rand() a compliant random number generator API. Add a unit-test.
...
* [Core] Add new switch_rand() a compliant random number generator API. Add a unit-test.
* Fall back to rand() on unsupported platforms compile time.
2024-06-06 21:14:36 +03:00
41bc763d80
[core] Fix scan-build 14 in port allocator
2024-05-19 21:43:55 +03:00
85400015b7
[Core] VAD: Add a math sanity check to the switch_vad_process
2024-05-19 21:22:31 +03:00
5b1c2688da
[Core, mod_sofia] Add switch_uint31_t type. Fix CSeq bigger than 2^31-1.
2024-05-09 22:20:14 +03:00
31cf32d91f
Merge pull request #2449 from signalwire/fix_scan_build_mod_amrwb
...
[mod_amrwb] Fix scan-build 14
2024-04-26 16:37:10 +03:00
f3ace249f5
Merge pull request #2448 from signalwire/fix_scan_build_mod_avmd
...
[mod_avmd] Fix scan-build 14
2024-04-26 16:35:53 +03:00
84ab90895a
[mod_amrwb] Fix scan-build 14
2024-04-26 13:11:54 +00:00
597ee613de
[mod_avmd] Fix scan-build 14
2024-04-26 12:58:44 +00:00
ef32d90e91
[mod_av] Fix scan-build 14
2024-04-26 12:41:07 +00:00
d5ad504723
[mod_vlc] Resolve double mutex lock
2024-04-18 12:06:40 +03:00
d7d38c7d03
Merge pull request #2381 from signalwire/opus_noop
...
[mod_opus] Fix status returned by switch_opus_decode(). Should be SWITCH_STATUS_FALSE instead of SWITCH_STATUS_NOOP. Add a unit-test.
2024-02-23 18:36:11 +03:00
5ce9057a12
Merge pull request #2392 from signalwire/kazoo
...
[Core] Remove mod_kazoo from tree
2024-02-22 22:06:32 +03:00
49029c8575
[mod_sofia] Set missing CF_3PCC flag
2024-02-22 19:23:40 +03:00
70d76bcc0e
[Core] Remove mod_kazoo from tree
2024-02-21 21:27:35 +03:00
647035c323
[mod_opus] Fix status returned by switch_opus_decode(). Should be SWITCH_STATUS_FALSE instead of SWITCH_STATUS_NOOP. Add a unit-test.
2024-02-06 00:36:35 +03:00
9df3076f29
[mod_event_socket] Check if listener is running before pushing more logs or events to its queue
...
This fixes a possibility for MAX_MISSED to be exceeded if more logs are
attempted to be pushed to the listener's queue after running kill_listener but
before the listener thread gets CPU time and removes itself.
On a heavily loaded system with a lot of logs in the event dispatch queue
these excessive logs may prove fatal since socket_logger itself will produce
logs about the full queue, resulting in a circular situation of never-ending logs.
The same logic was applied to event_handler after finding the same behaviour
mentioned in signalwire/freeswitch#2143 .
2024-01-29 19:05:45 +03:00
8b7a8c4aea
[core] SDP: replace SIP lingo in SDP offer/answer.
2024-01-26 21:01:32 +03:00
1c05719100
[Core] softtimer: fix crash in timezones when reloading xml
...
* switch_time: fix segfault null TIMEZONES_LIST.hash when reloading xml
* Unbind before destroying TIMEZONES_LIST.hash. Protect TIMEZONES_LIST.hash with a mutex that's allocated in core's global runtime.memory_pool so the mutex does not die on softtimer shutdown.
---------
Co-authored-by: Andrey Volk <andywolk@gmail.com>
2024-01-24 22:04:32 +03:00
d148a3e412
[mod_amr, mod_amrwb] Fix input data corruption
...
* Fix input data corruption in AMR and AMRWB codecs
* [amr/amrwb] Check encoded frame size before decoding
* [mod_amr, mod_amrwb] Coding guidelines cleanup.
---------
Co-authored-by: Dmitry Kunilov <dmitry.kunilov@upm.solutions>
Co-authored-by: Andrey Volk <andywolk@gmail.com>
2024-01-24 16:50:08 +03:00
d3c60820d7
[mod_amqp] Adjusting to Appropriate Log Level for Message
...
* [mod_amqp] Adjusting to Appropriate Log Level for Message
Refined Logging Level for FreeSWITCH's mod_amqp: The logging level for the AMQP module in FreeSWITCH has been updated from 'warning' to 'debug'. This adjustment ensures a more suitable level for the log message and eliminates any potential impact on production environments. Previously, the 'warning' level would lead to unnecessary log entries for each individual message, although there was no actual warning condition. This change improves logging efficiency and appropriateness for mod_amqp's operations within FreeSWITCH.
* [MOD_AMQP] Change LogLevel to DEBUG1 as it is more appropriate for this message
2024-01-10 19:01:26 +03:00
6ae8ce604a
swigall
2023-12-22 17:12:41 +00:00
6ea8c96c3d
[Core] Reject DTLS packets coming from a source different than the current ICE negotiated path.
2023-12-21 22:56:32 +00:00
2e7424169e
[mod_conference] Remove static from cJSON vars in conference_jlist
2023-12-19 22:42:54 +03:00
c155ea7008
[Core] Fix implicit conversion from enumeration type 'switch_odbc_status_t' to different enumeration type 'switch_status_t'.
2023-12-14 13:44:22 +03:00
48608177d7
[core] Fix missing 192 key lengths
2023-12-13 00:27:59 +03:00
f7e19e5134
[mod_sofia] BYE Reason header was limited in length.
2023-12-11 22:48:00 +03:00
f05b7507aa
[mod_conference] Avoid a race in member->read_impl access
...
The conference output loop accesses the member's read_impl while
resampling. The output loop also spawns off the input loop thread, which
is where the member->read_impl is actually initialised. This results in
an uncommon race where the output loop sometimes gets an uninitialised
member->read_impl and bails with logs something like this:
2023-10-12 18:19:01.436844 [DEBUG] conference_loop.c:1340 Setup timer soft success interval: 20 samples: 960 from codec L16
2023-10-12 18:19:01.436844 [DEBUG] conference_loop.c:1497 Outbound conference channel answered, setting CFLAG_ANSWERED
2023-10-12 18:19:01.436844 [NOTICE] switch_core_media.c:15852 Activating write resampler
2023-10-12 18:19:01.436844 [DEBUG] switch_core_media.c:16097 Engaging Write Buffer at 1920 bytes to accommodate 0->1920
2023-10-12 18:19:01.436844 [ERR] switch_core_media.c:16112 Write Buffer 0 bytes Failed!
As a solution, we initialise the member->read_impl even before we start
up the input loop, so that this race can never happen.
2023-11-07 09:42:27 -05:00
104c0b3fec
[core] Fix flopping routes on ICE negotiation
2023-10-12 12:15:46 +00:00
f5a41d3092
[mod_pgsql] Coverity: 1227660 Logically dead code
2023-10-05 18:05:32 +03:00
d08424384b
[Core] Coverity: 1024552 Logically dead code
2023-10-05 18:03:32 +03:00
79ce088101
[Core] Coverity: Dereference before null check
...
* [Core] Coverity: 1060958 Dereference before null check
* [Core] Coverity: 1024236 Dereference before null check
2023-10-05 00:26:26 +03:00
c4115537e0
[Core] Coverity: Use of 32-bit time_t
...
* [Core] Coverity: 1500270 Use of 32-bit time_t
* [Core] Coverity: 1500229 Use of 32-bit time_t
* [Core] Coverity: 1500235 Use of 32-bit time_t
* [Core] Coverity: 1500244 Use of 32-bit time_t
* [Core] Coverity: 1500250 Use of 32-bit time_t
* [Core] Coverity: 1500245 Use of 32-bit time_t
* [Core] Coverity: 1500255 Use of 32-bit time_t
* [Core] Coverity: 1500370 Use of 32-bit time_t
* Cleanup
2023-10-04 18:24:16 +03:00
792eee44d0
Merge pull request #2232 from signalwire/coverity_1364946
...
[core] Coverity 1364946 Unchecked return value
2023-09-11 14:06:48 +03:00
ff71b9089c
Merge pull request #2233 from signalwire/coverity_1325269
...
[core] Coverity 1325269 Dereference before null check
2023-09-11 14:06:05 +03:00
bb9afcb388
[core] Coverity fixes
...
* [core] Coverity 1518099, 1518097, 1518098 (Unchecked return value from library)
* [core] Coverity 1468551 Unchecked return value
* [core] Coverity 1468293 Unchecked return value
* [core] Coverity 1468274 Explicit null dereferenced
* [core] Coverity 1395588 Unchecked return value
* [core] Coverity 1395515 Logically dead code
* [core] Coverity 1364984 Result is not floating-point
* [core] Coverity 1395554, 1468440 Dereference before null check
* [core] Coverity 1024487 Dereference after null check
* [core] Coverity 1024872 Unchecked return value
* [core] Coverity 1025822 Unchecked return value
* [core] Coverity 1025823 Unchecked return value
* [core] Coverity 1087637, 1346467, 1087638 Unchecked return value
* [core] Coverity 1107607 Unchecked return value
* [core] Coverity 1210777 Unchecked return value
* [core] Coverity 1227670 Dereference before null check
* [core] Coverity 1024551 Logically dead code
* [core] Coverity 1024560 Logically dead code
* [core] Coverity 1024664 Operands don't affect result
* [core] Coverity 1364957 Dereference after null check
* [core] Coverity 1395572 Logically dead code
* [core] Coverity 1412459 Unchecked return value
* [core] Coverity 1412490 Unchecked return value
* [core] Coverity 1395515/2 Logically dead code
* [core] Coverity cleanup
2023-09-08 20:17:57 +03:00
4c51ba9064
[core] Coverity 1364946 Unchecked return value
2023-09-08 17:54:58 +01:00
ebcb099a01
[core] Coverity 1325269 Dereference before null check
2023-09-08 17:54:33 +01:00
b6ccc27e6f
[core] JB audio: check for jb type and silence some debug. ( #1191 )
2023-09-05 23:19:59 +03:00
5c289cc063
swigall
2023-08-13 16:00:05 +00:00
9347c96712
[Core] check_ice: sanitize second field of the candidates. Add new switch_is_uint_in_range() API.
2023-08-13 15:49:58 +03:00
eb918fe180
[Core] Fix switch_console.c for Galera Mariadb cluster
...
Fix in switch_console.c file.
Adds column names when inserting data.
Calls to use the complete table in Galera Multi-Master Cluster
2023-08-11 23:13:00 +03:00
113889b14d
Merge pull request #1554 from wmasilva/mod_verto-msg_event_add_context_header
...
[mod_verto] Add context into msg event header
2023-08-11 20:08:31 +03:00
c5be6262b4
[mod_mariadb] Fix "DeadLock. The retries are over." message.
...
Co-authored-by: Sergei Rozhkov <git@zserg.ru>
2023-08-11 19:53:32 +03:00
558d3a6b11
[mod_verto] Add context into msg event header
2023-08-11 18:36:47 +03:00
ffadaffdd8
[core] Use auto DH params with openssl3
...
Co-authored-by: Matteo Brancaleoni <matteo.brancaleoni@voismart.it>
2023-08-11 14:33:40 +03:00
9cad385930
[mod_logfile] add logfile open error log and fixes a missing \n
2023-08-11 14:21:59 +03:00
41507363f3
[Core] Fix greedy_sort for codecs containing different fmtp
2023-07-31 21:30:35 +03:00
cfb39e88dc
[Core] Sanitize match count during negotiation
2023-07-31 21:30:25 +03:00
6b67970bbb
[Core] Add new switch_channel_get_variable_strdup() and switch_channel_get_variable_buf() APIs that avoid allocating channel variables in a session's memory pool.
2023-07-28 22:29:22 +03:00
1f364254a6
Merge pull request #2181 from signalwire/shout
...
[mod_shout] Replace deprecated meta functions with shout_set_meta()
2023-07-25 03:27:16 +03:00
820e42aa89
Merge pull request #2178 from signalwire/rtmp
...
[mod_rtmp] Add OpenSSL 3 support.
2023-07-25 03:04:26 +03:00
47e18be18d
[mod_shout] Replace deprecated meta functions with shout_set_meta()
2023-07-25 02:49:51 +03:00
c37ed7c816
[Core] switch_curl_process_mime(): fix build on older systems.
2023-07-25 01:44:20 +03:00
f7e5ae793e
Merge pull request #2175 from signalwire/curl
...
[Core, mod_cidlookup, mod_curl, mod_httapi, mod_http_cache, mod_kazoo, mod_shout] Add new switch_curl_mime APIs replacing switch_curl_process_form_post_params() and make code be compatible with libcurl>=7.87.0
2023-07-25 01:28:57 +03:00
64f8ff03be
[Core, mod_mariadb, mod_ilbc] Fix build on gcc 12.
2023-07-25 00:25:53 +03:00
2ef59577a9
[mod_rtmp] Add OpenSSL 3 support.
2023-07-24 23:47:47 +03:00
5966077030
[Core, mod_cidlookup, mod_curl, mod_httapi, mod_http_cache, mod_kazoo, mod_shout] Add new switch_curl_mime APIs replacing switch_curl_process_form_post_params() and make code be compatible with libcurl>=7.87.0
2023-07-24 23:40:27 +03:00
0cdf1a5757
Merge pull request #2177 from signalwire/skinny
...
[mod_skinny] Fix build on Debian 12: error: array subscript 'skinny_message_t {aka struct skinny_message}[0]' is partly outside array bounds
2023-07-24 23:07:15 +03:00
62c1036b51
Merge pull request #2176 from signalwire/test
...
[Unit-tests] Fix possible overflows and an undefined variable in the test framework.
2023-07-24 22:33:47 +03:00
00818e7b25
[Core] OpenSSL 3 support
2023-07-24 21:56:46 +03:00
cced3e7f1b
[Unit-tests] Fix possible overflows and an undefined variable in the test framework.
2023-07-24 21:23:53 +03:00
1b58c8bdd0
[mod_skinny] Fix build on Debian 12: error: array subscript 'skinny_message_t {aka struct skinny_message}[0]' is partly outside array bounds
2023-07-24 21:15:52 +03:00
0f445e1ddd
[core, mod_opus] more elastic jitterbuffer with Opus codec
...
* [core, mod_opus] more elastic jitterbuffer with Opus codec
* [Core] JB: Fix crash on null channel
* [Core] JB: Fix target_seq race in check_jb_size()
* Code cleanup
---------
Co-authored-by: Julien Chavanton <jchavanton@gmail.com>
2023-07-21 20:03:00 +03:00
55f2dc4759
[core] Coverity fixes
...
* [core] Coverity CID 1024233 (Dereference before null check)
* [core] Coverity CID 1024239 (Dereference before null check)
* [core] Coverity CID 1024242 (Dereference before null check)
* [core] Coverity CID 1024243 (Dereference before null check)
* [core] Coverity CID 1024453 (Dereference before null check)
* [core] Coverity CID 1024554 (Logically dead code)
* [core] Coverity CID 1024868 (unchecked return value from library)
* [core] Coverity CID 1024869 (unchecked return value from library)
* [core] Coverity CID 1468281 (Dereference before null check)
* [core] Coverity CID 1024238 (Dereference before null check)
* [core] Coverity CID 1468621 (Copy into fixed size buffer)
* [core] Coverity CID 1024871 (Unchecked return value)
2023-07-21 13:49:40 +03:00
9f8de014a1
[mod_av] Add FFmpeg 5.1.3 support on Windows.
2023-07-18 19:38:06 +03:00
667783831b
[mod_av] Migrate to FFmpeg 5.1
2023-07-18 10:32:05 +00:00
2f81317ac1
Merge pull request #2155 from signalwire/move_to_packetizer
...
[core,mod_av,unit-tests] Make transition to core packetizer
2023-07-17 18:31:27 +03:00
fdce50e420
[Core] Fix missing MEDIA_PARAMS in message_names.
2023-07-16 21:20:56 +03:00
34f1d974f5
Revert "[core, mod_opus] more elastic jitterbuffer with Opus codec ( #2069 )"
...
This reverts commit 67840823c1
2023-07-12 18:18:17 +03:00
95457f7922
Revert "[mod_opus] Fix Windows build regression made by previous commit"
...
This reverts commit 25afda9be0
2023-07-12 18:17:52 +03:00
2cf57c41b6
[mod_python3] fix build on Python 3.10+
...
fix #2145
2023-07-10 19:21:04 +02:00
930341ba86
[core,mod_av,unit-tests] Make transition to core packetizer
2023-07-10 12:58:19 +00:00
c9fb586c34
[mod_verto] Fix function declarations without a prototype
2023-07-08 06:29:23 -05:00
ab211c542a
Merge pull request #2140 from signalwire/fix_vars_not_used
...
[core,miniupnpc,modules] Fix not used variables
2023-07-05 13:18:15 +01:00
bd5bea5b2c
Merge pull request #2141 from signalwire/remove_verbatim
...
[mod_sofia] Remove non-implemented verbose feature
2023-07-04 17:04:37 +03:00
2afad15f48
[mod_sofia] Remove non-implemented verbose feature
2023-07-04 10:37:48 +01:00
5656972bfe
[core,miniupnpc,modules] Fix not used variables
2023-07-04 10:18:16 +01:00
a160eced99
[core,libyuv,modules] Fix function declarations without a prototype
2023-07-04 09:56:40 +01:00
b355bf21e6
[mod_conference] Add flag to destroy the conference only when all mandatory members disconnect. And set endconf to end the conference when any member with the flag disconnects ( #2079 )
...
* feature/mod_conference_mandatory_member_flag: Add flag to destroy the conference only when all mandatory members disconnect. And set endconf to end the conference when any member with the flag disconnects
2023-06-28 19:39:22 +03:00
25afda9be0
[mod_opus] Fix Windows build regression made by previous commit
2023-06-23 21:25:16 +03:00
67840823c1
[core, mod_opus] more elastic jitterbuffer with Opus codec ( #2069 )
2023-06-23 16:45:31 +03:00
f64314ff48
[mod_sofia] Map SWITCH_CAUSE_REJECT_ALL cause to 603
2023-06-22 22:39:51 +03:00
9c63f03b45
[Core] Add new cause REJECT_ALL
2023-06-22 22:39:46 +03:00
7bc999309c
[mod_opus] fix remote codec rate to match.
2023-06-15 16:29:43 +03:00
5e914efc8c
[core, mod_opus] bring more fmtp params to core (offer/answer).
2023-06-15 16:26:17 +03:00
f90aeade4f
[core] Opus RTP timestamp: adding an exception on RTP session creation.
...
https://www.rfc-editor.org/rfc/rfc7587.html
"The RTP timestamp is incremented with a 48000 Hz
clock rate for all modes of Opus and all sampling rates. The unit
for the timestamp is samples per single (mono) channel"
Follow up: 50f57f85732b0d5a58a39f3fca7b654f894b0c9d, ccbef9e0c7
2023-06-15 16:25:46 +03:00
5065c0b118
[mod_opus] fix samples_per_packet for 8khz, 16khz, 24khz.
2023-06-15 16:22:52 +03:00
a458d704ab
[mod_opus] show uuid in logs.
2023-06-14 16:01:27 +03:00
24452ff104
[mod_opus] fix configuration glitches (switch_true() instead of atoi()).
2023-06-14 15:57:54 +03:00
9b20b324f5
[mod_sofia] Coverity fixes
...
[mod_sofia] coverity CID 1024253 (Dereference before null check)
[mod_sofia] coverity CID 1024254 (Dereference before null check)
[mod_sofia] coverity CID 1257620 (Logically dead code)
[mod_sofia] coverity CID 1024750 (Dereference null return value)
2023-06-12 18:17:12 +03:00
b4e43214f7
[Core] Fix possible deadlock in switch_core_media_set_codec()
2023-06-12 17:47:02 +03:00
86875d2381
[mod_verto] Coverity fixes
...
[mod_verto] coverity CID 1468439 (Dereference after null check)
[mod_verto] coverity CID 1294451 (Dereference before null check)
[mod_verto] coverity CID 1468443 (Logically dead code)
2023-06-12 17:25:37 +03:00
Andrey Volk
Jakub Karolczyk
Hadžem Hadžić
Anton Olofsson
Dragos Oancea
wmasilva
Dmitry Kunilov
mahald
Arun Raghavan
Sergei Rozhkov
Matteo
Seven Du
jpfox156
Victor Seva
David Villasmil
Julien Chavanton
Giacomo Vacca