22024 Commits

Author SHA1 Message Date
Jakub Karolczyk
49c1c35982
[core] Coverity fixes
* [core] Coverity CID 1468218 (Resource leak)

* [core] Coverity CID 1468214 (Resource leak)

* [core] Coverity CID 1294472 (Resource leak)

* [core] Coverity CID 1294470 (Resource leak)

* [core] Coverity CID 1500361 (Resource leak)

* [core] Coverity CID 1500308 (Resource leak)

* [core] Coverity CID 1500278 (Resource leak)

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2023-04-01 00:07:59 +03:00
Andrey Volk
55313696db [Core] Remove unused count variable from switch_core_session_execute_exten() 2023-03-31 22:48:11 +03:00
Andrey Volk
9940623bce [Core] Fix switch_core_sqldb_destroy() function declaration. 2023-03-31 20:47:56 +03:00
Jakub Karolczyk
9494148b10
[mod_sofia] Coverity fixes
* [mod_sofia] Coverity CID 1468634 (Resource leak)

* [mod_sofia] Coverity CID 1294467 (Resource leak)

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2023-03-30 22:00:40 +03:00
Jakub Karolczyk
65b24c65db [mod_pgsql] Coverity CID 1468401 (Resource leak) 2023-03-29 23:26:35 +01:00
Andrey Volk
f5f7f76cd4
Merge pull request #2006 from dragos-oancea/mod_amr-cov
[mod_amr] coverity CID 1395603 (Unsigned compared against 0)
2023-03-29 19:19:47 +03:00
Dragos Oancea
3d547647b2
[mod_verto] Coverity fixes
* [mod_verto] coverity CID (Logically dead code)

* [mod_verto] coverity CID 1468609 (Logically dead code)
2023-03-29 19:14:54 +03:00
Andrey Volk
16884775b9
Merge pull request #2005 from dragos-oancea/mod_opus-cov
[mod_opus] coverity CID 1320733 (Result is not floating-point)
2023-03-29 19:12:19 +03:00
Dragos Oancea
48b8b0c4d7
[Core] Coverity fixes
* [core] coverity CID 1395504 (Logically dead code)

* [core] coverity CID 1395581 (Dereference before null check)

* [core] coverity CID 1346451 (Improper use of negative value)

* [core] coverity CID 1395497 (Dereference before null check)

* [core] coverity CID 1468458 (Dereference before null check)
2023-03-29 19:08:18 +03:00
Andrey Volk
8e5dc5a087 [mod_opusfile] Fix missing rdlock unlock in switch_opusfile_open() 2023-03-29 19:05:18 +03:00
Dragos Oancea
3c1824a685 [mod_amr] coverity CID 1395603 (Unsigned compared against 0) 2023-03-29 17:20:04 +03:00
Dragos Oancea
3c4695ea31 [mod_opus] coverity CID 1320733 (Result is not floating-point) 2023-03-29 17:18:57 +03:00
Tomasz Ostrowski
afc8d78a18
[mod_enum] Fix use-after-free if creating resolver from file failed 2023-03-28 17:36:01 +03:00
Andrey Volk
6c97e3b0f4 [Core] Fix missing mutex unlock in switch_ivr_dmachine_ping() 2023-03-28 17:10:25 +03:00
Andrey Volk
02c25a24a4
Merge pull request #1765 from greenbea/patch-14
[mod_say_en] change epoch to 64 bit int
2023-03-28 17:06:58 +03:00
Andrey Volk
ef9268ec0c
Merge pull request #1900 from jyelloz/master
[mod_ladspa] Added activate/deactivate support.
2023-03-28 17:00:28 +03:00
Henrique
bb2fa44071
[mod_conference] handle personal canvas with vmuted member 2023-03-28 16:53:16 +03:00
yois615
6d65f8e08c
[mod_callcenter] Fix stale agents and UUID broadcasts
* [call_center] Stop uuid_broadcast on answer

* [mod_callcenter] Fix stale members in database

When a channel is originated to an agent but the
member fails to bridge to that agent, the database is
not updated with the member status and a stale entry
of 'Answered' persists until mod_callcenter is restarted.

Additionally, cc_agent_found is set before the bridge,
therefore ending the while loop on the member channel.
If there is a problem with the agent bridge, the call is
terminated prematurely.

In this commit, we:

* Move the SQL update of the member
to the 'Answered' state to the agent thread instead of
the member's thread, so that correct data is populated.

* Reset the members state accordingly to Abandoned or
Waiting if the channels fail to bridge.

* Use cc_agent_bridged to end the member loop,
so that a member is put back on queue if the agent
channel fails to bridge.
2023-03-28 14:53:16 +03:00
yois615
965e88a6b0
[core, mod_cidlookup] Free memory allocated via strdup
In mod_cidlookup and several other modules, config parameters
are read from external XML files using the SWITCH_CONFIG_ITEM_STRING_STRDUP
method.  These items do not have string_options, and are not freed
with switch_xml_config_cleanup.  We therefore need to call switch_safe_free
for config without string_options.  We also add switch_xml_config_cleanup
to mod_cidlookup.  There are other modules that may be affected but this
commit makes no attempt at fixing those.

Fixes #1752
2023-03-28 01:47:23 +03:00
Andrey Volk
f680a29405
Merge pull request #1413 from yois615/master
[mod_sofia] Randomize OPTIONS Ping interval
2023-03-28 01:43:35 +03:00
Tomasz Ostrowski
8e604e8a94
[mod_event_multicast] Few fixes
* [mod_event_multicast] Fix crash / invalid pointer dereference

* [mod_event_multicast] Check current number of addresses before zeroing memory on init

* [mod_event_multicast] Fix condition checking number of addresses on init

* [mod_event_multicast] Fix addresses zeroing on init

* [mod_event_multicast] Reorder memset and assert after malloc
2023-03-27 20:23:07 +03:00
Andrey Volk
2c36dcdd50
Merge pull request #1843 from greenbea/patch-17
[mod_commands] Fix and improve coalesce function
2023-03-27 20:03:40 +03:00
Andrey Volk
49eb8a77ee
Merge pull request #1996 from greenbea/amqp_subclass_support
[mod_amqp] Event subclass support
2023-03-27 19:55:46 +03:00
Дилян Палаузов
99ca7436d8
[mod_commands] add completions for fsctl api_expansion and sync_clock_when_idle 2023-03-27 19:50:51 +03:00
Andrey Volk
be1b1c8085
Merge pull request #1976 from greenbea/patch-19
[core] switch_ivr_originate set originate endpoint used
2023-03-27 19:41:32 +03:00
Tomasz Ostrowski
01d3b3c0e3
[Core] ICE: fix wrong buffer size being passed and unitialized buffer 2023-03-23 21:15:41 +03:00
agree
8cf90dae41 [mod_commands] Fix and improve coalesece function
* fixed memory leak
* added custom delimeter support
2023-03-21 12:23:19 -04:00
agree
6eb685d353 [mod_amqp] Events subclass support 2023-03-21 12:16:01 -04:00
Andrey Volk
23e6569fb0 [Core] Fix race condition of session_table hash in switch_core_session_request_uuid() 2023-03-02 12:53:00 +03:00
agree
81046e943a [core] switch_ivr_originate set originate endpoint used
This commit introduces a new channel variable that sets the channel endpoint used by the originate. This is particulary useful when using `execute_on_originate` that will execute multiple times when using fake endpoints as `user/` or `group/`. With this variable, a user can determine which endpoint is being used by the originate, and whether they want to process it.
2023-02-26 21:50:51 -05:00
Andrey Volk
83e4ccf802 [Build-System] Windows: Update OpenSSL to 1.1.1t, libpq to 10.23, curl to 7.88.0, rabbitmq-c to 0.13.0. Allow using build numbers and bump libks version requirement to 1.8.2_1 and signalwire-c to 1.3.2_1 compiled with openssl 1.1.1t 2023-02-22 16:14:09 +03:00
demonspork
1a2033b915
[mod_sofia] Ignore user agent for display update when channel variable update_ignore_ua is true 2023-02-10 21:16:57 +03:00
Andrey Volk
3cb697c495 swigall 2023-02-03 18:46:31 +00:00
Adrian Fretwell
3326f4ec57
[mod_python3] Create an event on python_fetch() 2023-01-24 18:14:29 +03:00
Andrey Volk
889afccad0 [mod_xml_curl] Fix leaking event in xml_url_fetch() 2023-01-24 14:14:27 +03:00
Jordan Yelloz
9fd214fcbb
[mod_ladspa] Add activate/deactivate support.
Without these -- especially activate() -- stateful plugins will not be
set up correctly.

For example, the low-pass filter "lpf" in the CMT library may produce
a pop when starting since its state is not zeroed out.
2023-01-18 12:02:16 -07:00
Andrey Volk
4b350962d3 [mod_verto] Limit websocket payload size to 1000000. 2023-01-17 00:36:44 +03:00
Andrey Volk
5cc2a4fc2e
Merge pull request #1910 from signalwire/osx
[Unit-tests] mod_sofia: avoid duplicate symbols on macos.
2023-01-17 00:26:05 +03:00
Minh
c69c399dd2
[mod_sofia] New chanvars for inbound multiple header identity 2023-01-09 16:00:49 +03:00
Andrey Volk
84cb1bdf84 [Unit-tests] mod_sofia: avoid duplicate symbols on macos. 2022-12-31 02:41:55 +03:00
Andrey Volk
a739e197a5 [Core] Fix false-positive illegal memory access detection in switch_console_complete() 2022-12-26 16:36:04 +03:00
Andrey Volk
f71a56022a [Core] switch_mprintf: Increase the size of loop variables in the printf() implementation. Add unit-tests disabled by default. 2022-12-09 23:11:25 +03:00
morwin1
62d3e52cf9
[mod_python3] Fix compiler warnings 2022-12-06 20:07:19 +03:00
Andrey Volk
d2f84c8342
Merge pull request #1881 from signalwire/originatefence
[Core] Fix crash in enterprise originate: memory fence the handles.
2022-12-06 01:33:14 +03:00
David Villasmil
13646cc888
[mod_sofia] Parse extra headers on reINVITE 2022-12-01 21:51:17 +03:00
Andrey Volk
ded2a4c1be [Core] Fix crash in enterprise originate: memory fence the handles. 2022-11-30 23:22:01 +03:00
Anthony Minessale
edd36639c7 [Core] Blind pass at using a rwlock for chat_hash 2022-11-21 13:58:28 +03:00
Joseph Nadiv
7afeceb47e [mod_sofia] Randomize OPTIONS Ping interval
In FS-6400, the attempt was made to randomize OPTIONS
packets to be sent at a random interval.  The same random
interval is applied to all endpoints so this doesn't work.
Furthermore, rounding within the code, as well as
reseeding with srand() on each run will ultimately
make the ping times converge over time.  Once the
times converge, they will not separate since the reseeding
will cause the same random number to apply to each
registration.

This commmit will apply the random interval only during
initial registration and update of registration.
All subsequent pings will be incremented with the
actual value of ping-mean-interval. (This parameter
name is no longer accurate, and would be better named
ping-max-interval).

srand() has been moved to the start of the worker
thread, and all repeat calls have been removed,
so that each call of rand(), even during the
same second, generates a different random number.

Fixes #1132, Fixes #1133
2022-11-20 13:51:41 -05:00
Andrey Volk
17453e0079 [Core] Remove deprecated SWITCH_STACK_NODUP flag. Change switch_event_add_header_string() behavior to always dup. 2022-11-08 01:48:25 +03:00
Andrey Volk
ffa2207926 [Core] SWITCH_STACK_NODUP flag is deprecated and will be soon removed. Introduce switch_event_add_header_string_nodup() API. 2022-11-08 01:17:08 +03:00