Commit Graph

21962 Commits

Author SHA1 Message Date
Jakub Karolczyk 84ab90895a [mod_amrwb] Fix scan-build 14 2024-04-26 13:11:54 +00:00
Hadžem Hadžić d5ad504723
[mod_vlc] Resolve double mutex lock 2024-04-18 12:06:40 +03:00
Andrey Volk d7d38c7d03
Merge pull request #2381 from signalwire/opus_noop
[mod_opus] Fix status returned by switch_opus_decode(). Should be SWITCH_STATUS_FALSE instead of SWITCH_STATUS_NOOP. Add a unit-test.
2024-02-23 18:36:11 +03:00
Andrey Volk 5ce9057a12
Merge pull request #2392 from signalwire/kazoo
[Core] Remove mod_kazoo from tree
2024-02-22 22:06:32 +03:00
Jakub Karolczyk 49029c8575 [mod_sofia] Set missing CF_3PCC flag 2024-02-22 19:23:40 +03:00
Andrey Volk 70d76bcc0e [Core] Remove mod_kazoo from tree 2024-02-21 21:27:35 +03:00
Andrey Volk 647035c323 [mod_opus] Fix status returned by switch_opus_decode(). Should be SWITCH_STATUS_FALSE instead of SWITCH_STATUS_NOOP. Add a unit-test. 2024-02-06 00:36:35 +03:00
Anton Olofsson 9df3076f29
[mod_event_socket] Check if listener is running before pushing more logs or events to its queue
This fixes a possibility for MAX_MISSED to be exceeded if more logs are
attempted to be pushed to the listener's queue after running kill_listener but
before the listener thread gets CPU time and removes itself.

On a heavily loaded system with a lot of logs in the event dispatch queue
these excessive logs may prove fatal since socket_logger itself will produce
logs about the full queue, resulting in a circular situation of never-ending logs.

The same logic was applied to event_handler after finding the same behaviour
mentioned in signalwire/freeswitch#2143.
2024-01-29 19:05:45 +03:00
Dragos Oancea 8b7a8c4aea [core] SDP: replace SIP lingo in SDP offer/answer. 2024-01-26 21:01:32 +03:00
wmasilva 1c05719100
[Core] softtimer: fix crash in timezones when reloading xml
* switch_time: fix segfault null TIMEZONES_LIST.hash when reloading xml

* Unbind before destroying TIMEZONES_LIST.hash. Protect TIMEZONES_LIST.hash with a mutex that's allocated in core's global runtime.memory_pool so the mutex does not die on softtimer shutdown.

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2024-01-24 22:04:32 +03:00
Dmitry Kunilov d148a3e412
[mod_amr, mod_amrwb] Fix input data corruption
* Fix input data corruption in AMR and AMRWB codecs

* [amr/amrwb] Check encoded frame size before decoding

* [mod_amr, mod_amrwb] Coding guidelines cleanup.

---------

Co-authored-by: Dmitry Kunilov <dmitry.kunilov@upm.solutions>
Co-authored-by: Andrey Volk <andywolk@gmail.com>
2024-01-24 16:50:08 +03:00
mahald d3c60820d7
[mod_amqp] Adjusting to Appropriate Log Level for Message
* [mod_amqp] Adjusting to Appropriate Log Level for Message

Refined Logging Level for FreeSWITCH's mod_amqp: The logging level for the AMQP module in FreeSWITCH has been updated from 'warning' to 'debug'. This adjustment ensures a more suitable level for the log message and eliminates any potential impact on production environments. Previously, the 'warning' level would lead to unnecessary log entries for each individual message, although there was no actual warning condition. This change improves logging efficiency and appropriateness for mod_amqp's operations within FreeSWITCH.

* [MOD_AMQP] Change LogLevel to DEBUG1 as it is more appropriate for this message
2024-01-10 19:01:26 +03:00
Andrey Volk 6ae8ce604a swigall 2023-12-22 17:12:41 +00:00
Jakub Karolczyk 6ea8c96c3d [Core] Reject DTLS packets coming from a source different than the current ICE negotiated path. 2023-12-21 22:56:32 +00:00
Andrey Volk 2e7424169e [mod_conference] Remove static from cJSON vars in conference_jlist 2023-12-19 22:42:54 +03:00
Andrey Volk c155ea7008 [Core] Fix implicit conversion from enumeration type 'switch_odbc_status_t' to different enumeration type 'switch_status_t'. 2023-12-14 13:44:22 +03:00
Jakub Karolczyk 48608177d7 [core] Fix missing 192 key lengths 2023-12-13 00:27:59 +03:00
Andrey Volk f7e19e5134 [mod_sofia] BYE Reason header was limited in length. 2023-12-11 22:48:00 +03:00
Arun Raghavan f05b7507aa [mod_conference] Avoid a race in member->read_impl access
The conference output loop accesses the member's read_impl while
resampling. The output loop also spawns off the input loop thread, which
is where the member->read_impl is actually initialised. This results in
an uncommon race where the output loop sometimes gets an uninitialised
member->read_impl and bails with logs something like this:

2023-10-12 18:19:01.436844 [DEBUG] conference_loop.c:1340 Setup timer soft success interval: 20  samples: 960 from codec L16
2023-10-12 18:19:01.436844 [DEBUG] conference_loop.c:1497 Outbound conference channel answered, setting CFLAG_ANSWERED
2023-10-12 18:19:01.436844 [NOTICE] switch_core_media.c:15852 Activating write resampler
2023-10-12 18:19:01.436844 [DEBUG] switch_core_media.c:16097 Engaging Write Buffer at 1920 bytes to accommodate 0->1920
2023-10-12 18:19:01.436844 [ERR] switch_core_media.c:16112 Write Buffer 0 bytes Failed!

As a solution, we initialise the member->read_impl even before we start
up the input loop, so that this race can never happen.
2023-11-07 09:42:27 -05:00
Jakub Karolczyk 104c0b3fec [core] Fix flopping routes on ICE negotiation 2023-10-12 12:15:46 +00:00
Andrey Volk f5a41d3092
[mod_pgsql] Coverity: 1227660 Logically dead code 2023-10-05 18:05:32 +03:00
Andrey Volk d08424384b
[Core] Coverity: 1024552 Logically dead code 2023-10-05 18:03:32 +03:00
Andrey Volk 79ce088101
[Core] Coverity: Dereference before null check
* [Core] Coverity: 1060958 Dereference before null check

* [Core] Coverity: 1024236 Dereference before null check
2023-10-05 00:26:26 +03:00
Andrey Volk c4115537e0
[Core] Coverity: Use of 32-bit time_t
* [Core] Coverity: 1500270 Use of 32-bit time_t

* [Core] Coverity: 1500229 Use of 32-bit time_t

* [Core] Coverity: 1500235 Use of 32-bit time_t

* [Core] Coverity: 1500244 Use of 32-bit time_t

* [Core] Coverity: 1500250 Use of 32-bit time_t

* [Core] Coverity: 1500245 Use of 32-bit time_t

* [Core] Coverity: 1500255 Use of 32-bit time_t

* [Core] Coverity: 1500370 Use of 32-bit time_t

* Cleanup
2023-10-04 18:24:16 +03:00
Andrey Volk 792eee44d0
Merge pull request #2232 from signalwire/coverity_1364946
[core] Coverity 1364946 Unchecked return value
2023-09-11 14:06:48 +03:00
Andrey Volk ff71b9089c
Merge pull request #2233 from signalwire/coverity_1325269
[core] Coverity 1325269 Dereference before null check
2023-09-11 14:06:05 +03:00
Jakub Karolczyk bb9afcb388
[core] Coverity fixes
* [core] Coverity 1518099, 1518097, 1518098 (Unchecked return value from library)

* [core] Coverity 1468551 Unchecked return value

* [core] Coverity 1468293 Unchecked return value

* [core] Coverity 1468274 Explicit null dereferenced

* [core] Coverity 1395588 Unchecked return value

* [core] Coverity 1395515 Logically dead code

* [core] Coverity 1364984 Result is not floating-point

* [core] Coverity 1395554, 1468440 Dereference before null check

* [core] Coverity 1024487 Dereference after null check

* [core] Coverity 1024872 Unchecked return value

* [core] Coverity 1025822 Unchecked return value

* [core] Coverity 1025823 Unchecked return value

* [core] Coverity 1087637, 1346467, 1087638 Unchecked return value

* [core] Coverity 1107607 Unchecked return value

* [core] Coverity 1210777 Unchecked return value

* [core] Coverity 1227670 Dereference before null check

* [core] Coverity 1024551 Logically dead code

* [core] Coverity 1024560 Logically dead code

* [core] Coverity 1024664 Operands don't affect result

* [core] Coverity 1364957 Dereference after null check

* [core] Coverity 1395572 Logically dead code

* [core] Coverity 1412459 Unchecked return value

* [core] Coverity 1412490 Unchecked return value

* [core] Coverity 1395515/2 Logically dead code

* [core] Coverity cleanup
2023-09-08 20:17:57 +03:00
Jakub Karolczyk 4c51ba9064 [core] Coverity 1364946 Unchecked return value 2023-09-08 17:54:58 +01:00
Jakub Karolczyk ebcb099a01 [core] Coverity 1325269 Dereference before null check 2023-09-08 17:54:33 +01:00
Dragos Oancea b6ccc27e6f [core] JB audio: check for jb type and silence some debug. (#1191) 2023-09-05 23:19:59 +03:00
Andrey Volk 5c289cc063 swigall 2023-08-13 16:00:05 +00:00
Andrey Volk 9347c96712 [Core] check_ice: sanitize second field of the candidates. Add new switch_is_uint_in_range() API. 2023-08-13 15:49:58 +03:00
Sergei Rozhkov eb918fe180
[Core] Fix switch_console.c for Galera Mariadb cluster
Fix in switch_console.c file.
Adds column names when inserting data.
Calls to use the complete table in Galera Multi-Master Cluster
2023-08-11 23:13:00 +03:00
Andrey Volk 113889b14d
Merge pull request #1554 from wmasilva/mod_verto-msg_event_add_context_header
[mod_verto] Add context into msg event header
2023-08-11 20:08:31 +03:00
Sergei Rozhkov c5be6262b4
[mod_mariadb] Fix "DeadLock. The retries are over." message.
Co-authored-by: Sergei Rozhkov <git@zserg.ru>
2023-08-11 19:53:32 +03:00
António Silva 558d3a6b11 [mod_verto] Add context into msg event header 2023-08-11 18:36:47 +03:00
Matteo ffadaffdd8
[core] Use auto DH params with openssl3
Co-authored-by: Matteo Brancaleoni <matteo.brancaleoni@voismart.it>
2023-08-11 14:33:40 +03:00
Seven Du 9cad385930
[mod_logfile] add logfile open error log and fixes a missing \n 2023-08-11 14:21:59 +03:00
Andrey Volk 41507363f3 [Core] Fix greedy_sort for codecs containing different fmtp 2023-07-31 21:30:35 +03:00
Andrey Volk cfb39e88dc [Core] Sanitize match count during negotiation 2023-07-31 21:30:25 +03:00
Andrey Volk 6b67970bbb [Core] Add new switch_channel_get_variable_strdup() and switch_channel_get_variable_buf() APIs that avoid allocating channel variables in a session's memory pool. 2023-07-28 22:29:22 +03:00
Andrey Volk 1f364254a6
Merge pull request #2181 from signalwire/shout
[mod_shout] Replace deprecated meta functions with shout_set_meta()
2023-07-25 03:27:16 +03:00
Andrey Volk 820e42aa89
Merge pull request #2178 from signalwire/rtmp
[mod_rtmp] Add OpenSSL 3 support.
2023-07-25 03:04:26 +03:00
Andrey Volk 47e18be18d [mod_shout] Replace deprecated meta functions with shout_set_meta() 2023-07-25 02:49:51 +03:00
Andrey Volk c37ed7c816 [Core] switch_curl_process_mime(): fix build on older systems. 2023-07-25 01:44:20 +03:00
Andrey Volk f7e5ae793e
Merge pull request #2175 from signalwire/curl
[Core, mod_cidlookup, mod_curl, mod_httapi, mod_http_cache, mod_kazoo, mod_shout] Add new switch_curl_mime APIs replacing switch_curl_process_form_post_params() and make code be compatible with libcurl>=7.87.0
2023-07-25 01:28:57 +03:00
Andrey Volk 64f8ff03be [Core, mod_mariadb, mod_ilbc] Fix build on gcc 12. 2023-07-25 00:25:53 +03:00
Andrey Volk 2ef59577a9 [mod_rtmp] Add OpenSSL 3 support. 2023-07-24 23:47:47 +03:00
Andrey Volk 5966077030 [Core, mod_cidlookup, mod_curl, mod_httapi, mod_http_cache, mod_kazoo, mod_shout] Add new switch_curl_mime APIs replacing switch_curl_process_form_post_params() and make code be compatible with libcurl>=7.87.0 2023-07-24 23:40:27 +03:00
Andrey Volk 0cdf1a5757
Merge pull request #2177 from signalwire/skinny
[mod_skinny] Fix build on Debian 12: error: array subscript 'skinny_message_t {aka struct skinny_message}[0]' is partly outside array bounds
2023-07-24 23:07:15 +03:00