Commit Graph

15947 Commits

Author SHA1 Message Date
Brian West 1aa2fc7548 FS-3332 --resolve 2014-04-25 15:53:21 -05:00
William King 0ba59aa6c2 Expanding on 052638186b to support boolean tel url params in mod_sofia 2014-04-25 13:49:59 -07:00
William King f27fe7ed08 BNPH-6470 follow up to commit 68d863a179 removing the original line that performed the curl request to avoid a double request in mod_xml_curl 2014-04-25 12:11:09 -07:00
Brian West 68d863a179 FS-6470 2014-04-25 11:50:06 -05:00
Brian West 7e15c938e2 FS-6482 --resolve 2014-04-24 14:05:18 -05:00
Anthony Minessale d171e156d7 fix issues with heartbeat in bypass media mode 2014-04-24 23:21:15 +05:00
William King bcc2aa9899 Fixing memory leak that would occur when reloading mod_xml_curl 2014-04-24 09:13:00 -07:00
Anthony Minessale 4def48b881 revert 2014-04-24 20:58:23 +05:00
Anthony Minessale 2e0cd74e07 FS-6477 --resolve 2014-04-22 23:51:44 +05:00
Anthony Minessale 61e22e8b50 FS-6476 --resolve 2014-04-22 23:25:41 +05:00
Chris Rienzo 25c9b6196b mod_rayo: preserve old caller ID behavior if display name is not given 2014-04-22 13:30:15 -04:00
Chris Rienzo 1eab82ba2d mod_rayo: relax recent caller ID restrictions a bit 2014-04-22 08:50:50 -04:00
Travis Cross 175c9eebca Remove extraneous abort(3) when sending chat
This appears to have been accidentally added in commit
79ebcb104b which sought to provide a
mechanism for disabling Sofia's chat interface.  The abort(3) here
achieved that a bit too well.
2014-04-19 19:26:27 +00:00
Anthony Minessale 79ebcb104b add enable-chat sofia profile param which defaults to true when not present, set to false to turn off the chat interface in sofia 2014-04-19 12:29:10 -05:00
Travis Cross 59fd9b90d0 Correct display of last write timestamp
On start DTMF packets we were showing the last write timestamp as a
signed value when it's an unsigned value, which could result in it
appearing incongruous with later packets where the value was displayed
correctly.
2014-04-19 01:48:49 +00:00
Brian West 265de3d314 FS-6082 --resolve 2014-04-18 15:17:23 -05:00
Brian West 190c241c81 FS-6452 mod_spy doesn't react on events without variable_domain_name 2014-04-17 20:12:27 -05:00
Anthony Minessale 18df083c69 don't send heartbeat until the first timeout has elapsed rather than instantly 2014-04-18 00:06:24 +05:00
Seven Du 37ee4299fb fix compiler warning 2014-04-17 14:58:18 +08:00
Anthony Minessale bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
Anthony Minessale 2bc2811050 FS-5997 regression from commit 70accd9f27 this caused some attended transfers to calls with multiple targets to get the abondoned channels to be stuck on write lock 2014-04-17 02:41:40 +05:00
William King 748b7dea3c Get rid of a small memory leak when the configs are reloaded in mod_enum 2014-04-16 09:27:34 -07:00
Anthony Minessale a4a792488b add generic keepalive system and implement it in sofia to send MESSAGE or INFO packets in-dialog at specified interval.
Adds app: enable_keepalive 0|<seconds>
This app can be run in the dialplan or with execute_on_* type variables for B-legs.

Adds sofia param: keepalive-method  : defaults to MESSAGE can also be "INFO"
This param sets which SIP method to use.
2014-04-16 06:10:25 +05:00
Chris Rienzo ae69c5a7b0 FS-6407 --resolve mod_rayo: support SIP URI caller ID w/ display name 2014-04-15 14:27:49 -04:00
Raymond Chandler 052638186b add parsing of user params on invite 2014-04-15 12:48:07 -04:00
Anthony Minessale b99ef3af01 add SWITCH_MESSAGE_HEARTBEAT_EVENT indication to execute on a session when session heartbeat fires 2014-04-15 21:22:36 +05:00
Nathan Neulinger 96523a9bef mod_skinny: fix leak 2014-04-14 15:04:06 -05:00
Nathan Neulinger 93a84cf130 FS-6460 --resolve fix leaked RTP ports that cause mod_skinny to fail after N calls 2014-04-14 13:23:05 -05:00
Chris Rienzo e8078d8aef mod_rayo: clean up module hashes on shutdown 2014-04-14 12:01:31 -04:00
Chris Rienzo b0c2c6d67c FS-6447 --resolve return subscriber-absent platform-code 20 if <dial> is attempted to user that is not registered 2014-04-14 09:47:41 -04:00
Peter Olsson 295964f0ec FS-6457 --resolve
Upgrade to OpenSSL 1.0.1g in Windows build (Visual Studio 2010 and 2012)
2014-04-13 10:01:17 +02:00
Travis Cross 2dba7dd367 Avoid leaking memory on mod_cdr_sqlite unload 2014-04-12 06:59:02 +00:00
Travis Cross 39f960a212 Avoid leaking memory on mod_voicemail unload 2014-04-12 06:48:36 +00:00
Travis Cross 886a730ae8 Avoid leaking memory on mod_hash unload 2014-04-12 06:43:11 +00:00
Travis Cross 237da22e22 Avoid leaking memory on unload of mod_dptools
Automated leak detectors find leaked memory on shutdown.  Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-12 06:31:31 +00:00
Travis Cross 12af80d6b2 Condense styling a bit 2014-04-12 05:06:51 +00:00
Travis Cross 538cdd378c Hide warning about sometimes initialized variable
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-12 05:02:09 +00:00
Travis Cross 3f8cf4a59d Fix memory leak in subscription handling
We were leaking one event (~539 bytes) for every subscribe packet
received with both an "event: as-feature-event" and an authorization
header.
2014-04-12 05:00:41 +00:00
James Le Cuirot 4bdb7129ba Ungetlib libmemcached
Tested with several libmemcached versions between 0.31 and
1.0.18. Unfortunately the API is extremely volatile and awkward to
use. Packaging scripts still need addressing.

FS-353
2014-04-11 22:55:36 +00:00
James Le Cuirot 23fe7f5c9f Add libyaml pkg-config LIBS to LIBADD not LDFLAGS
Per the automake manual these should go in LIBADD.

http://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html

FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-04-11 22:53:14 +00:00
Anthony Minessale 38c6e89db0 remove SSML from mod_rss 2014-04-11 03:33:57 +05:00
Anthony Minessale 7428746ce2 FS-6453 --resolve 2014-04-11 03:24:14 +05:00
Anthony Minessale 7e9c350532 avoid recomputing hash 2014-04-11 03:08:27 +05:00
Anthony Minessale f1d7721710 FS-6448 --resolve revert string func patch cos some things free it 2014-04-11 02:36:13 +05:00
Chris Rienzo a86623972d mod_rayo: fixed input crash introduced in 2014-04-07 commit 2014-04-10 10:20:47 -04:00
Travis Cross b72194b72b Move loop exit conditionals
The net effect here is the code looks more "regular" and reads more
linearly.
2014-04-09 18:41:03 +00:00
Travis Cross 4a8dace5ab Avoid considering more phrase actions after break
Previously we would continue considering phrase actions even after
receiving a break action; we would only break on the next input
clause.  It appears the intent here was to break before the next
action.
2014-04-09 18:41:02 +00:00
Travis Cross 75b8f3e0a8 Improve comment 2014-04-09 18:41:02 +00:00
Travis Cross ffc3f9bb0b Consolidate two conditionals
If we get SWITCH_STATUS_BREAK then we didn't get
SWITCH_STATUS_SUCCESS.
2014-04-09 18:41:02 +00:00
Travis Cross 549aba0d2f Remove variable assignment without effect
We're breaking out of the loop here anyway, so setting done to true is
useless.
2014-04-09 18:41:02 +00:00
Travis Cross 2ace7bc79b Fix memory leak in phrase macro playback
We were leaking memory when break_on_match was set or when we received
back SWITCH_STATUS_BREAK from a callee as we were failing to free
field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross f83d6770ff Remove tautological conditional
If pattern is null we're setting it to a non-null value, so this
branch will always be taken.

Use `git diff -w` or `git log -p -w` to see what's going on in this
commit.
2014-04-09 18:41:02 +00:00
Travis Cross 1a71cf886e Fix memory leak on memory error
In the event of a memory error, we were trying to free a null pointer
while leaking the allocation for field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross a0b8d92219 Move variables down into loop where they're used
These variables aren't used outside of this for loop, so they should
be declared within it.
2014-04-09 18:41:01 +00:00
Anthony Minessale 4178688b4a add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc 2014-04-09 23:26:47 +05:00
Anthony Minessale d789c6470a free global pool on shutdown 2014-04-09 23:26:47 +05:00
Anthony Minessale 0449baca59 clear event queue on shutdown 2014-04-09 23:26:46 +05:00
Travis Cross 2d811e0ba0 Suppress spurious warning in phrase macro playback
Prior to this commit, if anything at all went wrong in
switch_ivr_phrase_macro_event() we would generate a warning like this:

  [WARNING] switch_ivr_play_say.c:348 Macro [macro_name]: 'pattern_name' did not match any patterns

This is clearly misleading.  The natural thing to do on seeing that
message is to verify that the language files are there, and that the
pattern really does exist in that macro.  But none of that was usually
the problem.  The message would be generated if the language wasn't
found, or if the channel had gone away, for example.

With this commit, we verify that we actually tried looking for the
pattern before displaying the warning about the pattern not matching.
2014-04-09 04:48:09 +00:00
Travis Cross 1e273e514d Avoid playback on dead channels in voicemail
For years we've been generating spurious messages like:

  [WARNING] switch_ivr_play_say.c:348 Macro [voicemail_ack]: 'saved' did not match any patterns

This would happen when the caller hangs up during the playback of
certain prompts in the voicemail system where we weren't checking the
return value of vm_macro_get().  Looking closely at the log, it's
clear we were calling down into switch_ivr_phrase_macro() long after
the channel was gone.

The message above is also misleading -- switch_ivr_phrase_macro()
would have been able to find that pattern just fine, but it never
actually looked because the channel was gone.  We'll clean up that
message in a follow on commit.
2014-04-09 04:46:47 +00:00
Anthony Minessale 369bb55d15 remove unnecessary pool create 2014-04-09 03:18:21 +05:00
Travis Cross 1636550176 Add immediate sanity check on untrusted length
We were actually checking this indirectly in the loop that follows,
but it's more clear to check this immediately and directly.
2014-04-08 21:08:02 +00:00
William King 711e49c46a Don't leak these 4 hash tables when mod_fifo is reloaded 2014-04-08 11:18:23 -07:00
William King aae1954c07 FS-6442 --resolve 2014-04-08 10:36:36 -07:00
Brian West de7d5a9e07 Resolve key length issue with AES GCM 128/256 2014-04-08 11:04:41 -05:00
Anthony Minessale 72c52052dc FS-6436 2014-04-08 20:30:23 +05:00
Chris Rienzo 264a12a4af mod_rayo: fix memory corruption in dial, input, output 2014-04-07 12:37:39 -04:00
Anthony Minessale c98fb0bd0e send muted members as recvonly on RFC4575 data 2014-04-07 20:51:29 +05:00
William King 658d938754 Unused return value 2014-04-06 23:49:05 -07:00
Anthony Minessale 65fd534346 fix seg in complete del with no arg 2014-04-07 01:04:51 +05:00
Anthony Minessale a608550800 FS-5832 regression.... After this change the sticky completes were deleting. This should correct it 2014-04-06 03:51:36 +05:00
Anthony Minessale 77056e3c81 fix seg in alias del 2014-04-05 21:09:28 +05:00
Travis Cross fb7fa3d66a Update gitignore 2014-04-05 07:57:05 +00:00
Travis Cross c26343d0c9 Merge in upstream changes to my-basic
We can't use their new mb_gets() because they call exit(3) in the
event of a read error, which isn't what we want.
2014-04-05 06:48:02 +00:00
Travis Cross 8da4259539 Cleanup whitespace 2014-04-05 06:43:49 +00:00
Travis Cross 32c03b39d9 Replace gets(3) with fgets(3) in my-basic
gets(3) is going away; it's been removed by C11, and gcc now warns on
it, breaking the build.
2014-04-05 04:45:30 +00:00
Brian West 34b31f8f02 swig managed 2014-04-04 07:27:48 -05:00
Michael Jerris 5320075df7 FS-6429: --resolve check return values of fread and gets 2014-04-03 21:43:12 -04:00
Michael Jerris 98237f5962 fix mod_basic clang build warning, we don't need to declare var we don't use on this side of the ifdef 2014-04-03 19:35:43 -04:00
Michael Jerris 4e86b03126 FS-6424: --resolve properly export symbols from stfu 2014-04-03 13:58:13 -04:00
Anthony Minessale 287fd66800 FS-6403 --resolve
This commit also reverts 2 previous attempts to fix this very rare race issue spanning back to 2009

62ce853897 Patch from MOC
3a85348cdf FS-2302 mutex added around switch_xml_toxml()

The real problem was switch_xml_toxml_buf() was actually temporarily modifying the xml structure being searialized to make it appaer to be a root structure then serializing it and restoring the pointers.  This caused a non-threadsafe operation when some other thread was scanning the same xml structure.

This patch removes the modification and instead passes a new arg to switch_xml_toxml_r indicating to treat the structure as if it were a root structure.

This bug has been present since the induction of xml into FS.
2014-04-03 20:30:45 +05:00
Brian West 19e3175518 FS-6422: --resolve obvious copy and paste error 2014-04-03 07:20:41 -05:00
Anthony Minessale 1ce92b3ae7 FS-6421 --resolve 2014-04-02 16:43:36 -05:00
Jeff Lenk 554abf3e0c vs2010 reswig 2014-04-01 18:13:07 -05:00
Anthony Minessale 7151d6acea FS-6402 part 2 2014-04-02 03:21:37 +05:00
Travis Cross a78596221a Add uuid_ring_ready API command
We already had uuid_answer and uuid_pre_answer, so we might as well
add uuid_ring_ready.
2014-04-01 20:58:49 +00:00
Travis Cross 6234a94f41 Cleanup style for consistency 2014-04-01 20:54:44 +00:00
Travis Cross a8dd56f2b3 Convert my_basic files to Unix newline format 2014-04-01 20:41:19 +00:00
Anthony Minessale 5c0cff70b3 FS-6402 --resolve 2014-04-02 01:20:19 +05:00
Michael Jerris 0cc3a17072 FS-6408: fix passing of CPPFLAGS to spandsp build 2014-04-01 13:28:22 -04:00
Ken Rice 6681176ce9 prevent a segfault in mod_basic if someone calls basic from CLI w/ no args 2014-04-01 08:57:15 -05:00
Anthony Minessale e458fa2d5a allow execute with no args 2014-03-31 18:37:35 -05:00
Anthony Minessale 3a2736291e add mod_basic 2014-03-31 18:08:59 -05:00
Anthony Minessale d08116e762 FS-6310 hold up, revert 2014-03-31 17:32:07 -05:00
Anthony Minessale 7532a7e0d5 FS-6310 --resolve try this version 2014-03-31 17:03:01 -05:00
Anthony Minessale aa147fa5fd FS-6412 --resolve 2014-03-31 16:22:33 -05:00
Travis Cross b9369f6d4e Remove stray executable bits 2014-03-31 20:38:09 +00:00
Anthony Minessale c02a5e67b8 FS-6413 --resolve with this patch you will need to make sure the boxes have the clocks synced and both started inside the same occurence of the most recent new year. 2014-03-31 15:23:50 -05:00
Anthony Minessale 107c5eccc3 video refresh floor holder on conference join 2014-03-31 22:39:46 +05:00
Tamas Cseke 9b56dff275 Say zero in time measurement only if it is neccessary 2014-03-31 09:33:17 +02:00
William King e0d9d7f0b2 FS-6410 Adding some log lines to mod_sonar so that it is more clear what is happening when the app is sending and detecting pings. 2014-03-29 19:08:24 -07:00
Brian West 89094cfca0 start updating doxygen 2014-03-28 10:04:31 -05:00
Jeff Lenk 7ed144d115 * Deprecate mod_spidermonkey windows part 1 2014-03-26 18:33:37 -05:00
Michael Jerris d40615267e FS-353: better error reporting for missing lib, don't error on clean 2014-03-26 17:11:18 -04:00
Travis Cross f9d065cda3 Use system libyaml for mod_yaml
FS-353
2014-03-26 19:27:22 +00:00
Travis Cross 5e3ba399c7 Use CPPFLAGS in mod_yaml 2014-03-26 19:27:21 +00:00
Michael Jerris 885fdbf28c hack harder 2014-03-26 14:49:59 -04:00
Travis Cross b0bcc011ea Deprecate mod_spidermonkey
We consider mod_spidermonkey to be completely replaced by mod_v8 (and
more generally by mod_lua) at this point.  We've barely supported
mod_spidermonkey for years.  Everyone should stop using it.

We're keeping this around for awhile in case people are relying on C
extensions to mod_spidermonkey and need time to migrate.  This module
may or may not be part of a v1.4 release depending on whether we find
anyone cares.  It definitely will not be part of the next release
after v1.4.
2014-03-26 18:01:49 +00:00
Michael Jerris 310f2ec3d6 initialize var 2014-03-26 11:25:23 -04:00
Raymond Chandler 5cccc6270b seg-- 2014-03-25 23:31:16 -04:00
Raymond Chandler 0ddd151a22 FS-5845 more leaks found by mikej 2014-03-25 22:44:37 -04:00
Brian West 04de0f77d3 FS-6396 fix mod_silk builid on FreeBSD 2014-03-25 20:25:11 -05:00
Chris Rienzo 98bba8b57a mod_mongo: switched from C++ to latest C driver 2014-03-24 17:34:56 -04:00
Chris Rienzo 0b9e5c82a5 FS-6402 mod_rayo/mod_ssml: add mutex to hashes now that iteration is no longer thread-safe 2014-03-24 17:03:33 -04:00
Michael Jerris 5ac9748827 FS-5845: don't leak dbh in error conditions 2014-03-24 16:10:12 -04:00
Travis Cross cde20f6fe6 Require sqlite as a system dependency
This purges sqlite from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-24 12:54:49 +00:00
James Le Cuirot 8574988c3a Completely unbundle libedit
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-24 12:39:59 +00:00
Jeff Lenk 1cde5f01e0 FS-6386 --resolve 2014-03-23 16:15:49 -05:00
Peter Olsson c8fa0f0c4b mod_v8: Use parallel build by default. Use configure flag "--disable-parallel-build-v8" to disable it. It's disabled by default for Debian build scripts, since parallel build has some issues with cowbuilder. 2014-03-23 09:25:41 +01:00
Peter Olsson 742e28e1c5 FS-6395 2014-03-22 12:56:46 +01:00
Peter Olsson 8be3ca59e2 FS-6395 2014-03-22 11:55:04 +01:00
Brian West f890854e0d FS-6381 add hostname to conference cdr 2014-03-21 17:23:50 -05:00
Jeff Lenk dd242f3ba6 FS-6346 2014-03-20 18:32:19 -05:00
Travis Cross 1470622292 Require libcurl as a system dependency
This purges libcurl from our tree and requires it to be present on the
system for building and running FreeSWITCH.

FS-353
2014-03-20 21:15:29 +00:00
Travis Cross c993962d0b Update some modules to use CPPFLAGS
These modules use curl and we'll be adding in some bits to the
CPPFLAGS.
2014-03-20 21:09:46 +00:00
Travis Cross a489cd311e Cleanup whitespace 2014-03-20 20:35:58 +00:00
Travis Cross 4dec1607ce Revert "Cleanup whitespace"
Too much was staged accidentally on that last commit.

This reverts commit f112627242.
2014-03-20 20:34:18 +00:00
Travis Cross f112627242 Cleanup whitespace 2014-03-20 20:33:34 +00:00
Peter Olsson 03739a8293 FS-6365 --resolve 2014-03-20 19:48:37 +01:00
James Le Cuirot b283db6319 Completely unbundle speex
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-20 15:28:25 +00:00
James Le Cuirot e85f06ee2f Completely unbundle pcre
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-20 15:28:23 +00:00
Brian West 2da4e3d3b8 FS-6293: fix mod_managed srcdir build 2014-03-20 08:34:16 -05:00
Brian West 09811b522f FS-6369: fix uninstall on mod_managed 2014-03-20 08:16:14 -05:00
Michael Jerris 8cd69cc0f4 fix perldir to at least point to install the same place as the code looks for it. Note, on fhs type builds, where prefix is /usr, these files are going to go into /usr/perl, which probably isn't right, but thats where the code looks too, we should do something better for builds that are not in the prefix 2014-03-19 17:24:26 -04:00
Travis Cross 962eaaeae8 Make sure -w is set in mod_perl CXXFLAGS
Autogenerated bits of the code warn when building which would
otherwise break the build.
2014-03-19 21:01:30 +00:00
Michael Jerris f3acb03dc0 S-6341:make sure to unlock too 2014-03-19 16:38:53 -04:00
Brian West c4c0f38aab FS-6294 FS-6308 NetBSD support should work test and report back please. 2014-03-19 14:34:07 -05:00
Michael Jerris 496a6db5c4 cxx 2014-03-19 08:33:47 -04:00
Michael Jerris f575dd6f05 this is a cxx mod 2014-03-19 08:32:25 -04:00
Tamas Cseke 064bf5dde0 FS-6371 --resolve json cdr is missing some caller profile times 2014-03-19 11:01:22 +01:00
Brian West c9757f72a5 FS-6292 additional define to avoid on NetBSD, If someone wants to get this workign please submit patches 2014-03-19 03:35:47 -05:00
Travis Cross 1f76e88f15 Fix mod_opal build
...by separating out CPPFLAGS and CXXFLAGS.
2014-03-19 02:24:59 +00:00
Travis Cross 88e00e220c Use $(shell) make function in mod_opal 2014-03-19 02:24:59 +00:00
Michael Jerris 2ce609ac45 FS-6293: fix mod_spidermonkey srcdir build 2014-03-18 22:20:52 -04:00
Travis Cross bd4af28648 Reorder lines in mod_h323 build 2014-03-19 01:32:03 +00:00
Travis Cross d95d4b5014 Move mod_h323 -fno-exceptions flag to CXXFLAGS 2014-03-19 01:32:03 +00:00
Travis Cross ff3872432f Remove ptlib include in mod_h323
This doesn't seem needed, and the empty include was breaking the
build.
2014-03-19 01:32:03 +00:00
Travis Cross 3dce3d10a0 Move define to CPPFLAGS in mod_h323 2014-03-19 01:32:02 +00:00
Michael Jerris 8bc49da4ba use correct source file 2014-03-18 21:14:36 -04:00
Travis Cross eb9041cdb0 Separate out CFLAGS and CPPFLAGS in mod_h323
CPPFLAGS should contain -I and -D flags.

This also has the effect of fixing the build of this module.
2014-03-19 01:13:51 +00:00
Travis Cross 0e22f1e954 Fix mod_java build issues
...including one syntax error and an underspecified cast.
2014-03-19 00:43:24 +00:00