kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-06-27 11:50:00 +00:00
Code Issues Projects Releases Wiki Activity

review logger factory code part: use switch/case (#3812)

Browse Source 
Styling code of `logger.js`:

Just use `switch/case` instead of `if/else if`

---------

Co-authored-by: Veeck <github@veeck.de>
This commit is contained in:
Bugsounet - Cédric 2025-06-20 17:12:24 +02:00 committed by GitHub
parent 9a3f4f098b
commit c7c0e67c1d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -52,6 +52,7 @@ planned for 2025-07-01
- [core] Update dependencies including electron to v36 (#3774, #3788, #3811, #3804) - [core] Update dependencies including electron to v36 (#3774, #3788, #3811, #3804)
- [core] Update package type to `commonjs` - [core] Update package type to `commonjs`
- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#3812)
## [2.31.0] - 2025-04-01 ## [2.31.0] - 2025-04-01

37
js/logger.js
View File

@ -11,26 +11,35 @@
label: (arg) => { label: (arg) => {
const { method, defaultTokens } = arg; const { method, defaultTokens } = arg;
let label = defaultTokens.label(arg); let label = defaultTokens.label(arg);
if (method === "error") { switch (method) {
label = styleText("red", label); case "error":
} else if (method === "warn") { label = styleText("red", label);
label = styleText("yellow", label); break;
} else if (method === "debug") { case "warn":
label = styleText("bgBlue", label); label = styleText("yellow", label);
} else if (method === "info") { break;
label = styleText("blue", label); case "debug":
label = styleText("bgBlue", label);
break;
case "info":
label = styleText("blue", label);
break;
} }
return label; return label;
}, },
msg: (arg) => { msg: (arg) => {
const { method, defaultTokens } = arg; const { method, defaultTokens } = arg;
let msg = defaultTokens.msg(arg); let msg = defaultTokens.msg(arg);
if (method === "error") { switch (method) {
msg = styleText("red", msg); case "error":
} else if (method === "warn") { msg = styleText("red", msg);
msg = styleText("yellow", msg); break;
} else if (method === "info") { case "warn":
msg = styleText("blue", msg); msg = styleText("yellow", msg);
break;
case "info":
msg = styleText("blue", msg);
break;
} }
return msg; return msg;
} }