3335781af4
While removing unnecessary conditionals (for `compliments` reported in https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/27 and for `weather` reported in https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/28), I noticed a bug in the imperial conversion path: falsy property checks like `if (imperialWeatherObject.temperature)` silently skip the conversion when the value is `0`. So at exactly 0 °C, the result would show `0 °F` instead of the correct `32 °F`. I wrote unit tests for `convertWeatherObjectToImperial` first, which confirmed the bug, then fixed it by replacing the falsy checks with the `in` operator. Which I also find more intuitive to read. Weather APIs deliver floating point values, so hitting exactly `0.0` might be rare in practice - more likely `0.1` or `-0.1`, which are truthy and convert fine. That should explain why it went unnoticed by users.
MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant. MagicMirror² is built by the creator of the original MagicMirror with the incredible help of a growing community of contributors.
MagicMirror² focuses on a modular plugin system and uses Electron as an application wrapper. So no more web server or browser installs necessary!
Documentation
For the full documentation including installation instructions, please visit our dedicated documentation website: https://docs.magicmirror.builders.
Links
- Website: https://magicmirror.builders
- Documentation: https://docs.magicmirror.builders
- Forum: https://forum.magicmirror.builders
- Technical discussions: https://forum.magicmirror.builders/category/11/core-system
- Discord: https://discord.gg/J5BAtvx
- Blog: https://michaelteeuw.nl/tagged/magicmirror
- Donations: https://magicmirror.builders/#donate
Contributing Guidelines
Contributions of all kinds are welcome, not only in the form of code but also with regards to
- bug reports
- documentation
- translations
For the full contribution guidelines, check out: https://docs.magicmirror.builders/about/contributing.html
Enjoying MagicMirror? Consider a donation!
MagicMirror² is Open Source and free. That doesn't mean we don't need any money.
Please consider a donation to help us cover the ongoing costs like webservers and email services. If we receive enough donations we might even be able to free up some working hours and spend some extra time improving the MagicMirror² core.
To donate, please follow this link.
