b474198267
## What does this PR accomplish? The `postinstall` script runs `git clean -df fonts vendor modules/default` unconditionally. When `magicmirror` is installed as an npm dependency (e.g. `npm install magicmirror` or as a transitive dep in another project), npm runs `postinstall` in a directory that is **not** a git repository. This causes: ``` fatal: not a git repository (or any of the parent directories): .git ``` npm treats the non-zero exit as a failure → the entire installation aborts with `code 128`. This makes it impossible to use `magicmirror` as an npm dependency in any third-party project. The issue has been present since at least **v2.34.0**. In **v2.35.0** `modules/default` was added to the clean targets, but the root cause predates that change. ## Fix Added `scripts/postinstall.js` — a cross-platform Node.js script that guards the `git clean` call with a `git rev-parse --git-dir` check. - When running inside a real git repository: behaviour is identical to before. - When running outside one (e.g. installed as an npm package): step is silently skipped. `package.json` `postinstall` updated from the bare `git clean` call to: ```json "postinstall": "node scripts/postinstall.js" ``` This approach is cross-platform (Linux, macOS, Windows) and keeps the logic readable rather than inlined as a one-liner. Does this solve a related issue? No existing issue tracked. Discovered while using magicmirror as a devDependency in a companion tooling project — installation failed unconditionally on all platforms. Checklist - Targets the develop branch - No visual changes (script + package.json only) - node --run lint:prettier run — no changes needed for .js script
MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant. MagicMirror² is built by the creator of the original MagicMirror with the incredible help of a growing community of contributors.
MagicMirror² focuses on a modular plugin system and uses Electron as an application wrapper. So no more web server or browser installs necessary!
Documentation
For the full documentation including installation instructions, please visit our dedicated documentation website: https://docs.magicmirror.builders.
Links
- Website: https://magicmirror.builders
- Documentation: https://docs.magicmirror.builders
- Forum: https://forum.magicmirror.builders
- Technical discussions: https://forum.magicmirror.builders/category/11/core-system
- Discord: https://discord.gg/J5BAtvx
- Blog: https://michaelteeuw.nl/tagged/magicmirror
- Donations: https://magicmirror.builders/#donate
Contributing Guidelines
Contributions of all kinds are welcome, not only in the form of code but also with regards to
- bug reports
- documentation
- translations
For the full contribution guidelines, check out: https://docs.magicmirror.builders/about/contributing.html
Enjoying MagicMirror? Consider a donation!
MagicMirror² is Open Source and free. That doesn't mean we don't need any money.
Please consider a donation to help us cover the ongoing costs like webservers and email services. If we receive enough donations we might even be able to free up some working hours and spend some extra time improving the MagicMirror² core.
To donate, please follow this link.
