mirror of https://github.com/MichMich/MagicMirror.git synced 2025-07-16 11:53:13 +00:00

Kristjan ESPERANTO d3187689f0

Switch to ESLint v9 and flat config (#3558 )

Since PR #3551 was not yet complete, I made my own attempt.

1. Update to ESLint v9.
2. Replace deprecated `.eslintrc.json` and `.eslintignore` by flat
config `eslint.config.mjs`.
3. Adapt `check_config.js` to use flat config.
4. Since `eslint-plugin-import` still doesn't support ESLint v9 I
removed it. We can add it back when it does support v9.
5. Run tests `npm run check:js` and `npm run config:check`.
6. In order not to overload this PR, I have not yet activated more
additional rules - there are some useful ones in the new plugin
`@eslint/js`.

@bugsounet, please don't take it as an offence that I have created a
competing PR. The migration to ESLint v9 has been burning under my nails
for some time.

2024-09-25 21:05:11 +02:00

2.4 KiB

Raw Blame History

Contribution Policy for MagicMirror²

Thanks for contributing to MagicMirror²!

We hold our code to standard, and these standards are documented below.

Linters

We use prettier for automatic linting of all our files: npm run lint:prettier.

JavaScript: Run ESLint

We use ESLint on our JavaScript files.

The ESLint configuration is in our eslint.config.mjs file.

To run ESLint, use npm run lint:js.

CSS: Run StyleLint

We use StyleLint to lint our CSS. Our configuration is in our .stylelintrc file.

To run StyleLint, use npm run lint:css.

Testing

We use Jest for JavaScript testing.

To run all tests, use npm run test.

The specific test commands are defined in package.json. So you can also run the specific tests with other commands, e.g. npm run test:unit or npx jest tests/e2e/env_spec.js.

Submitting Issues

Please only submit reproducible issues.

If you're not sure if it's a real bug or if it's just you, please open a topic on the forum: https://forum.magicmirror.builders/category/15/bug-hunt

Problems installing or configuring your MagicMirror? Check out: https://forum.magicmirror.builders/category/10/troubleshooting

When submitting a new issue, please supply the following information:

Platform: Place your platform here... give us your web browser/Electron version and your hardware (Raspberry Pi 2/3/4, Windows, Mac, Linux, System V UNIX).

Node Version: Make sure it's version 18 or later (recommended is 20).

MagicMirror² Version: Please let us know which version of MagicMirror² you are running. It can be found in the package.json file.

Description: Provide a detailed description about the issue and include specific details to help us understand the problem. Adding screenshots will help describing the problem.

Steps to Reproduce: List the step by step process to reproduce the issue.

Expected Results: Describe what you expected to see.

Actual Results: Describe what you actually saw.

Configuration: What does the used config.js file look like? Don't forget to remove any sensitive information!

Additional Notes: Provide any other relevant notes not previously mentioned. This is optional.

2.4 KiB Raw Blame History