kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-17 07:18:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid potential deadlocks in channel_walk_locked, and detect serious failures

Browse Source 
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3340 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Mark Spencer
2004-06-29 10:51:00 +00:00
parent 408ead2dda
commit 30910d48bc
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
channel.c
View File

@@ -452,6 +452,8 @@ struct ast_channel *ast_channel_walk_locked(struct ast_channel *prev)
{
/* Returns next channel (locked) */
struct ast_channel *l, *ret=NULL;
int retries = 0;
retry:
ast_mutex_lock(&chlock);
l = channels;
if (!prev) {
@@ -465,8 +467,21 @@ struct ast_channel *ast_channel_walk_locked(struct ast_channel *prev)
ret = l->next;
l = l->next;
}
if (ret)
ast_mutex_lock(&ret->lock);
if (ret) {
if (ast_mutex_trylock(&ret->lock)) {
if (retries < 10)
ast_log(LOG_DEBUG, "Avoiding deadlock for '%s'\n", ret->name);
else
ast_log(LOG_WARNING, "Avoided deadlock for '%s', %d retries!\n", ret->name, retries);
ast_mutex_unlock(&chlock);
if (retries < 10) {
usleep(1);
retries++;
goto retry;
} else
return NULL;
}
}
ast_mutex_unlock(&chlock);
return ret;