kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-06 01:45:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merged revisions 203721 via svnmerge from

Browse Source 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r203721 | dbrooks | 2009-06-26 15:13:51 -0500 (Fri, 26 Jun 2009) | 16 lines
  
  Fixing voicemail's error in checking max silence vs min message length
  
  Max silence was represented in milliseconds, yet vmminsecs (minmessage) was represented
  as seconds.
  
  Also, the inequality was reversed. The warning, if triggered, was "Max silence should 
  be less than minmessage or you may get empty messages", which should have been logged 
  if max silence was greater than minmessage, but the check was for less than.
  
  Also, conforming if statement to coding guidelines.
  
  closes issue #15331)
  Reported by: markd
  
  Review: https://reviewboard.asterisk.org/r/293/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@203722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
David Brooks
2009-06-26 20:16:24 +00:00
parent cb69985027
commit 3a8efb7b9f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/app_voicemail.c
View File

@@ -9380,8 +9380,9 @@ static int load_config(int reload)
if ((val = ast_variable_retrieve(cfg, "general", "minsecs"))) {
if (sscanf(val, "%d", &x) == 1) {
vmminsecs = x;
if (maxsilence <= vmminsecs)
if (maxsilence / 1000 >= vmminsecs) {
ast_log(LOG_WARNING, "maxsilence should be less than minmessage or you may get empty messages\n");
}
} else {
ast_log(LOG_WARNING, "Invalid min message time length\n");
}
@@ -9393,8 +9394,9 @@ static int load_config(int reload)
}
if (sscanf(val, "%d", &x) == 1) {
vmminsecs = x;
if (maxsilence <= vmminsecs)
if (maxsilence / 1000 >= vmminsecs) {
ast_log(LOG_WARNING, "maxsilence should be less than minmessage or you may get empty messages\n");
}
} else {
ast_log(LOG_WARNING, "Invalid min message time length\n");
}