kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2026-07-27 16:07:15 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix problem with RFC 2833 DTMF not being accepted.

Browse Source 
A recent check was added to ensure that we did not erroneously
detect duplicate DTMF when we received packets out of order.
The problem was that the check did not account for the fact that
the seqno of an RTP stream will roll over back to 0 after hitting
65535. Now, we have a secondary check that will ensure that the
seqno rolling over will not cause us to stop accepting DTMF.

(closes issue #17571)
Reported by: mdeneen
Patches: 
      rtp_seqno_rollover.patch uploaded by mmichelson (license 60)
Tested by: richardf, maxochoa, JJCinAZ



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@274157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Mark Michelson
2010-07-06 14:29:23 +00:00
parent 989ecebcb0
commit 5724d8f905
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
main/rtp.c
+5 -1
View File
@@ -776,7 +776,11 @@ static void process_rfc2833(struct ast_rtp *rtp, unsigned char *data, int len, u
new_duration += 0xFFFF + 1;
new_duration = (new_duration & ~0xFFFF) | samples;
if (rtp->lastevent > seqno) {
/* The second portion of this check is to not mistakenly
* stop accepting DTMF if the seqno rolls over beyond
* 65535.
*/
if (rtp->lastevent > seqno && rtp->lastevent - seqno < 50) {
/* Out of order frame. Processing this can cause us to
* improperly duplicate incoming DTMF, so just drop
* this.