kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-24 14:56:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

AST-2017-010: Fix cdr_object_update_party_b_userfield_cb() buf overrun

Browse Source 
cdr_object_update_party_b_userfield_cb() could overrun the fixed buffer if
the supplied string is too long.  The long string could be supplied by
external means using the CDR(userfield) function.

This may seem reminiscent to AST-2017-001 (ASTERISK_26897) and it is.  The
earlier patch fixed the buffer overrun for Party A's userfield while this
patch fixes the same thing for Party B's userfield.

ASTERISK-27337

Change-Id: I0fa767f65ecec7e676ca465306ff9e0edbf3b652
This commit is contained in:
Richard Mudgett
2017-10-03 16:19:52 -05:00
committed by George Joseph
parent fbaca8d545
commit 6fce3fdedd
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
main/cdr.c
View File

@@ -3252,7 +3252,8 @@ static int cdr_object_update_party_b_userfield_cb(void *obj, void *arg, int flag
}
if (it_cdr->party_b.snapshot
&& !strcasecmp(it_cdr->party_b.snapshot->name, info->channel_name)) {
strcpy(it_cdr->party_b.userfield, info->userfield);
ast_copy_string(it_cdr->party_b.userfield, info->userfield,
sizeof(it_cdr->party_b.userfield));
}
}
return 0;
@@ -3275,7 +3276,8 @@ void ast_cdr_setuserfield(const char *channel_name, const char *userfield)
if (it_cdr->fn_table == &finalized_state_fn_table && it_cdr->next != NULL) {
continue;
}
ast_copy_string(it_cdr->party_a.userfield, userfield, AST_MAX_USER_FIELD);
ast_copy_string(it_cdr->party_a.userfield, userfield,
sizeof(it_cdr->party_a.userfield));
}
ao2_unlock(cdr);
}