Commit Graph

7484 Commits

Author SHA1 Message Date
Russell Bryant
03ad135134 Fix a memory leak that I just noticed in the device state handling in app_queue.
On most device state changes, it would leak roughly 8 to 64 bytes (the length of
the name of the device).


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65389 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 13:07:03 +00:00
Christian Richter
0b6da8d56e we stop the tones only when we're in the pre-call phase, otherwise e.g. when in CONNECTED state we should not stop tones when we receive an Information Message
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65328 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 07:46:39 +00:00
Steve Murphy
fd1fc0a9c1 This update will fix the situation that occurs as described by 9717, where when several targets are specified for a dial, if any one them reports FAIL, the whole call gets FAIL, even though others were ringing OK. I rearranged the priorities, so that a new disposition, NULL, is at the lowest level, and the disposition get init'd to NULL. Then, next up is FAIL, and next up is BUSY, then NOANSWER, then ANSWERED. All the related set routines will only do so if the disposition value to be set to is greater than what's already there. This gives the intended effect. So, if all the targets are busy, you'd get BUSY for the call disposition. If all get BUSY, but one, and that one rings is not answered, you get NOANSWER. If by some freak of nature, the NULL value doesn't get overridden, then the disp2str routine will report NOANSWER as before.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65172 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 20:56:20 +00:00
Olle Johansson
86882515a8 Not getting an ACK to a 200 OK in the initial invite is critical to the call.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 18:10:46 +00:00
Olle Johansson
21ea4dc3f1 Issue 9235 - part of the problem, maybe not all. Please retry with this patch (and no
other patch) if you have problems with hanging SIP channels. Thank you.

A special Thank You to WeBRainstorm that gave me access to his system.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65075 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 15:12:09 +00:00
Christian Richter
58bcd919d5 fixed a warning regarding Keypad encoding. encode the IE sending_complete at the right position.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65007 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 11:23:11 +00:00
Christian Richter
06b2955d26 we *need* to send a PROCEEDING when sending_complete is set, even if need_more_infos is requested.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64902 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 08:24:08 +00:00
Tilghman Lesher
b2f84c347f How is it that we never caught that this is returning the opposite of our documentation, until now?
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-17 21:14:36 +00:00
Jason Parker
dfd24c33d2 If we have a negative current message, we shouldn't go back even further...
Issue 9727.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-17 16:52:38 +00:00
Olle Johansson
9ebfde54a1 Fixing possible bug in auth of BYE
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64603 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-16 10:55:16 +00:00
Olle Johansson
80e4abca3d Support SIP uri's starting with SIP: and sip: (reported by Tony Mountfield on the mailing list. Thanks!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-16 09:08:22 +00:00
Olle Johansson
aa9ff74af5 Issue #9726 - rlister - Better logging for ACL denials
While at it, also added better logging and handling of peers that are not supposed to register.

My patch, stole the issue report from Russell. My apologies, Russell :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64514 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-16 08:25:56 +00:00
Christian Richter
b60fd4bc20 in the case immediate=yes, we directly jump into the dialplan, where people can use PlayTones to indicate a Dialtone, so we don't need to to that by ourself. also we should not do a dialtone_indicate for incoming calls on a TE port in overlapdialmode.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-16 08:23:42 +00:00
Joshua Colp
3b1ad79633 Only perform stripping of - strings from the channel name for Zap channels. Anywhere else we might remove a legitimate part of a device name. (issue #9668 reported by stevedavies)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64275 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-14 18:34:06 +00:00
Tilghman Lesher
29aa7c809b Issue 9121 - fixups for safe_asterisk script
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-11 16:31:03 +00:00
Jason Parker
074cc21291 Fix an issue with trying to kill a thread before it gets created.
Issue 9709, patch by nic_bellamy.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-10 23:14:55 +00:00
Olle Johansson
07ba0e379b Do not allocate SIP pvt's for PEERs we can not reach.
This was seen as a lot of dialogs being created then immediately destroyed at reload/restart of the SIP channel.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-10 20:38:54 +00:00
Matthew Fredrickson
818c25352e Make sure we only create a DSP if it's requested on SUB_REAL
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 17:20:20 +00:00
Joshua Colp
7dc491d090 Properly handle hints that point to multiple devices in chan_sip. Why chan_sip is even doing this I have no idea but I would rather not go into a rant. (issue #9536 reported by rlister)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63610 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 16:51:03 +00:00
Tilghman Lesher
47047d5004 Replicate fix from 51158 (app_voicemail) to app_directory (Issue 9224)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 14:48:06 +00:00
Christian Richter
fcad34fd9f release_chan frees ch, so we should never touch ch after release_chan, this may cause segfaults.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63519 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 11:26:16 +00:00
Tilghman Lesher
25930c842f Issue 9602 - segfault in app_macro
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 22:19:15 +00:00
Christian Richter
048000f9d6 added application misdn_check_l2l1 which tries to pull up the L1/L2 on all ports that have the layers down in a group. It waits then for a timeout. This helps for scenarios where multiple PMP BRIs are grouped together, or where a provider has a faulty PTP Implementation, that looses the L2 after a while.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 15:07:37 +00:00
Tilghman Lesher
616e3502e7 Issue 9527 - upon entering a folder, no message is selected (curmsg == -1), so deleting causes memory corruption (beyond bounds)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63359 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 06:20:16 +00:00
Joshua Colp
71befa9884 Properly handle what happens during a masquerade in relation to group counting. (issue #9657 reported by ramonpeek)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-07 21:39:52 +00:00
Olle Johansson
999633ab4f Releasing the whole in-memory configuration while you're adding to it is not a good thing.
Please review this change. Caused by additions (+) to non-existing contexts.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-07 14:06:50 +00:00
Joshua Colp
3a218f3a09 When a peer is seeded or built tell the devicestate core to update it's status. This is easier then having chan_sip load before pbx_config. (issue #9658 reported by dlynes)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62987 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 16:42:19 +00:00
Christian Richter
2102128500 when we're in state WAITING4DIGS, we use the asterisk tone-generator which prods us, so we can't just return -1 in misdn_write in this case. Added a MISDN_KEYPAD channel variable, and fixed the sending of keypad. this enables us to modify the call forward parameters in the switch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62945 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 15:39:21 +00:00
Christian Richter
70e95c4846 fixed the problem that misdn_write did not return -1 when called with 0 samples in a frame this resultet in a deadlock in some circumstances, when the call ended because of a busy extension. added encoding of keypad.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62885 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 13:59:00 +00:00
Kevin P. Fleming
de32406990 doh... initializing the pointer variable will work just a bit better
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62841 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 00:23:00 +00:00
Kevin P. Fleming
0b78d1542c increase reliability and efficiency of static Realtime config loading via ODBC:
don't request fields we aren't going to use
	don't request sorting on fields that are pointless to sort on
	explicitly request the fields we want, because we can't expect the database to always return them in the order they were created
	
(reported by blitzrage in person (!), patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62796 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-02 23:53:46 +00:00
Steve Murphy
26cab38b64 Some tweaks to satisfy CDR bug 8796, where being in 'h' extension louses up the dst field
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-02 20:10:32 +00:00
Tilghman Lesher
9b71a5799b Issue 9638 - if a text frame is sent with no terminating NULL through a bridged
IAX connection, the remote end will receive garbage characters tacked onto the
end.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-02 17:38:16 +00:00
Russell Bryant
c8a90488d6 Remove an unnecessary check that makes it so if you hang up after doing an
attended transfer before the target extension answers the channel, the transfer
is not successful.  (issue #9338, patch by svanlund)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62547 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-01 21:55:19 +00:00
Russell Bryant
8da91a20e3 Add indications.conf information for the Philippines.
(issue #9525, reported and patched by loloski)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-01 16:26:23 +00:00
Russell Bryant
274afdc345 This patch fixes an issue where depending on the cause code, when the network
sends a PRI disconnect, the call may not be properly hung up.
(issue #9588, reported and patched by softins)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-30 15:57:26 +00:00
Joshua Colp
80d88816df Update copyright notice. It's now the year 2007!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-30 14:34:07 +00:00
Jason Parker
d97b6e3d34 This transcoder message needn't be a NOTICE.
I've seen it cause confusion more than a few times.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-27 16:16:16 +00:00
Olle Johansson
3bafdca29f Issue #7351 - SIP Cancel fails due to the wrong contact uri. Reported by PPYY, failed to fix by OEJ
final fix by wojtekka - THANKS!!!! THis was a hard one to catch.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-27 13:57:45 +00:00
Joshua Colp
babe9cbbef Revert previous fix for when the IAX2 channel goes funky (that's the technical term). This is causing legit calls to be prematurely hung up. (issue #9600 reported by justdave)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@62037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-26 16:30:57 +00:00
Joshua Colp
897b4c0ca3 Don't count failed include attempts against the configuration include level. (issue #9593 reported by mostyn)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-26 01:25:03 +00:00
Kevin P. Fleming
cd3ef82ba4 handle a very bizarre race condition with channels being redirected before a simple switch can be started on them (issue #9286)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 22:24:59 +00:00
Russell Bryant
bc604c9e9a If the callerid= option is specified, but empty, clear any previous data.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 21:55:23 +00:00
Russell Bryant
85cff883ee Ensure that callerid settings are reset on a reload.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 21:06:22 +00:00
Joshua Colp
6ab97a0292 Merge rewritten group counting support. No more storing data on the variable list of the channels. That was bad, mmmk? (issue #7497 reported by sabbathbh)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 18:52:50 +00:00
Russell Bryant
eab557da86 Fix a typo where cid_num got copied instead of cid_ani.
(issue #9587, reported and patched by xrg)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 16:20:38 +00:00
Russell Bryant
c5a87ff71d Don't crash if a manager connection provides a username that exists in
manager.conf but does not have a password, and also requests MD5 
authentication. (ASA-2007-012)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-24 21:33:59 +00:00
Dwayne M. Hubbard
1cde24d633 removed #if 0 block from chan_phone, chan_zap, and chan_modem restart_monitor()
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-24 18:20:31 +00:00
Dwayne M. Hubbard
654c04bfc9 removed pthread_join in restart_monitor() to make it like chan_zap and other channel drivers
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61776 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-24 17:42:12 +00:00
Joshua Colp
a31a2ef862 Allow RFC2833 to be sent in the response SDP when an INVITE comes in without SDP. (issue #9546 reported by mcrawford)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61771 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-24 16:05:06 +00:00