Commit Graph

9954 Commits

Author SHA1 Message Date
Luigi Rizzo
06fab1382b clarify the use of the standard SIP port number, 5060,
and rename the old DEFAULT_SIP_PORT as STANDARD_SIP_PORT
to make it clear that this is not something we can change,
unlike other defaults.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 08:08:35 +00:00
Luigi Rizzo
15fcc45c4e improve formatting of SIP packets when dumped to the verbose
output stream, so it is easier to find them in the log.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 07:40:27 +00:00
Joshua Colp
f54fc75796 Timeout values are in seconds (issue #7122 reported by jmls)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 18:23:21 +00:00
Jason Parker
a35c0989dd Merged revisions 44764 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44764 | qwell | 2006-10-09 11:12:35 -0500 (Mon, 09 Oct 2006) | 4 lines

Fix a problem where phones that go "missing" never got unregistered.

Issue #8067, reported by pj, patch by Anthony LaMantia (with minor whitespace modifications)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44765 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 16:15:16 +00:00
Joshua Colp
5f503b7669 Blocked revisions 44760 via svnmerge
........
r44760 | file | 2006-10-09 11:46:53 -0400 (Mon, 09 Oct 2006) | 2 lines

iaxs[callno] may go away if we try to avoid the deadlock

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44763 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 15:52:29 +00:00
Joshua Colp
7b3665596f Merged revisions 44759 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44759 | file | 2006-10-09 11:41:28 -0400 (Mon, 09 Oct 2006) | 2 lines

Properly avoid a collision with iax2_hangup (issue #8115 reported by vazir)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44762 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 15:49:45 +00:00
Olle Johansson
d766095219 Being pedantic... "media" is easier to understand than "data" in the function name... :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44753 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 11:20:02 +00:00
Luigi Rizzo
853f7ed660 slightly restructure sipsock_read() removing a "goto"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 09:04:30 +00:00
Luigi Rizzo
69af2cea2f use S_OR in one place
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44751 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 08:33:52 +00:00
Luigi Rizzo
ad63b4c7c1 update_call_counter(): indentation fixes and small simplifications
at the top of the function.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 23:26:10 +00:00
Luigi Rizzo
06ef2c1907 localize some variables and reduce nesting depth
(indentation will be fixed by a separate commit).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44749 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 23:04:12 +00:00
Luigi Rizzo
dd2121b075 small simplification to initreqprep()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 22:45:01 +00:00
Luigi Rizzo
36e4f62e7c Simplify function parse_request() using a single loop instead
of two very similar ones.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44747 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 22:20:35 +00:00
Luigi Rizzo
b90f91c3b4 do not dereference p if we know it is NULL.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44745 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 14:10:26 +00:00
Olle Johansson
1b64c41369 Fix some debug output for setsockopt for TOS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 20:42:27 +00:00
Olle Johansson
259f0d76b6 - move definition of global_autoframing to the same place as other globals
- set initial value at load/reload
- Add questionmarks for someone to fill in for doxygen 


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 18:57:11 +00:00
Olle Johansson
12ef70f0c0 Add/change doxygen and comments
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 16:32:31 +00:00
Olle Johansson
77c69dc4ef Recommend using "sip reload" since it's much easier to learn and
remember.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 16:26:11 +00:00
Olle Johansson
9cc9c38250 Explain usage of DEFAULT_SIP_PORT
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 16:03:36 +00:00
Olle Johansson
64aae4a887 Do *NOT* use DEFAULT_SIP_PORT in these comparisions, since users may change
that, but the protocol clearly states that if we DO NOT mention a port it
is 5060. DEFAULT_SIP_PORT is whatever we default to listen to.

I believe it's the third time I revert a patch like this.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 15:38:18 +00:00
Paul Cadach
1ed8fb571f Merged revisions 44684 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44684 | pcadach | 2006-10-07 20:39:34 +0600 (Сбт, 07 Окт 2006) | 1 line

Propagate caller's transfer capability too
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 14:48:32 +00:00
Paul Cadach
500353e095 Extend CALLERID() function for "pres" and "ton" values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44685 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 14:45:49 +00:00
Luigi Rizzo
901a66c401 slightly restructure the code that computes the channel's name
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 12:50:42 +00:00
Luigi Rizzo
a1a5824869 put repeated code to set nat mode in a function.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 12:20:16 +00:00
Luigi Rizzo
bc1e5f77af put common code in a function to avoid repetitions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44664 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 11:28:38 +00:00
Luigi Rizzo
b37dc86c74 remove hardwired usage of 5060, use DEFAULT_SIP_PORT instead
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 11:11:39 +00:00
Luigi Rizzo
e691246b6e improve and document function get_in_brackets(), introducing
a helper function find_closing_quote() of more general use.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 09:36:09 +00:00
Luigi Rizzo
6466c2ebf9 when possible, use ast_set2_flags instead of ast_set/ast_clr .
Also mark XXX some dubious places.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 08:56:59 +00:00
Kevin P. Fleming
eda9434455 Merged revisions 44631 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44631 | kpfleming | 2006-10-06 16:28:03 -0500 (Fri, 06 Oct 2006) | 2 lines

ensure that mutex locks inside list heads are initialized properly on platforms that require constructor initialization (issue #8029, patch from timrobbins)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44632 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 21:29:14 +00:00
Joshua Colp
62e6417b21 Merged revisions 44628 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44628 | file | 2006-10-06 17:08:54 -0400 (Fri, 06 Oct 2006) | 2 lines

Remove the seqno check for RFC2833, the handler is smart enough to not need it.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44630 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 21:10:42 +00:00
Luigi Rizzo
684d1f1698 basically fix indentation of a large function after previous
simplifications. On passing, use a single exit point.

(once done with the cleanup i will merge the changes into 1.4,
if applicable)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44626 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 21:04:43 +00:00
Luigi Rizzo
35cada23f0 s cannot be null here, so remove the useless test and error-handling block.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44617 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 20:34:11 +00:00
Luigi Rizzo
acd1073909 simplify logic in preparation to reduce indentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 20:16:13 +00:00
Joshua Colp
85625f3505 Merged revisions 44605 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44605 | file | 2006-10-06 14:46:28 -0400 (Fri, 06 Oct 2006) | 2 lines

When the sequence number rolls over then reset the recorded sequence number for DTMF (issue #8106 reported by bungalow)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 18:47:49 +00:00
Tilghman Lesher
13ece8cc39 Massive cleanup of the rpt code, updating to current coding guidelines
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 17:27:30 +00:00
Joshua Colp
1ddda62208 Merged revisions 44581 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r44581 | file | 2006-10-06 12:53:48 -0400 (Fri, 06 Oct 2006) | 10 lines

Merged revisions 44580 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44580 | file | 2006-10-06 12:52:14 -0400 (Fri, 06 Oct 2006) | 2 lines

Even more frames to treat as though the remote side disappeared (issue #8097 reported by eldadran)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44582 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 16:56:05 +00:00
Luigi Rizzo
b19b4b9764 document a bit the use of templates.
They are highly convenient for writing configuration files, especially
if you have many similar entries, or want to switch quickly between
different configurations without having to comment/uncomment large
sections of the files.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 16:43:36 +00:00
Luigi Rizzo
f94849ca2a document the "contact" option a bit better.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44578 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 16:20:42 +00:00
Luigi Rizzo
a96afe5d6d help old bsd-system which don't have RLIMIT_AS and use RLIMIT_VMEM
for virtual memory limits.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 16:08:28 +00:00
Luigi Rizzo
3f641c6048 make sure sockets are blocking when they should be blocking.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 15:59:57 +00:00
Luigi Rizzo
ccca5843fd Two things:
1. slightly rearrange/simplify the parsing of the argument in sip_register.
   This brings in a patch that has been in Mantis (5834)  for ages,
   and is the larger part of the commit;

2. implement the "contact" option for peers, similar to the one in users.conf:

   If you put a "contact" option with a non-empty argument (e.g. contact=123)
   in a peer section, asterisk will register with the provider as if you had a     

        register= username:secret@host/contact 

   line in the general section.

The latter is a very small is a new feature so i am not putting it
in the 1.4 branch, although the "contact" option in user.conf is
already in the 1.4 branch and so it wouldn't be too strange to
merge it.

Note that the implementation of "contact" is much simpler than
the one in 5834, and limited to a few lines in build_peer().



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44566 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 15:41:12 +00:00
Olle Johansson
cb127f4baa Remove deprecated "incominglimit" config option
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 09:01:09 +00:00
Luigi Rizzo
2a7ac3f735 update example commands to match current syntax
(does not apply to 1.4)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44537 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 06:43:49 +00:00
Russell Bryant
283e7369ea regenerate the configure script to reflect the latest changes done by
Luigi Rizzo


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 02:24:26 +00:00
Joshua Colp
9565f72ad3 Fix indenting a bit (issue #8082 reported by selsky)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 20:13:04 +00:00
Joshua Colp
3dd0ce45fd Merged revisions 44502 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r44502 | file | 2006-10-05 15:57:16 -0400 (Thu, 05 Oct 2006) | 10 lines

Merged revisions 44501 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44501 | file | 2006-10-05 15:55:41 -0400 (Thu, 05 Oct 2006) | 2 lines

Treat busy control frames as hangup in the file streaming core (issue #8097 reported by eldadran)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44503 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 19:58:50 +00:00
Steve Murphy
6f34a8d78d These mods fix a problem pointed out by dgartang, where in certain situations, the target of a goto cannot be found, even right under your nose. This is because the current context is not updated properly, and rather than waste time and find why and where the context should have been updated, I just use my newly added 'dad' ptrs, and pop until I have either the context or extension, and use that instead.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44489 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 18:29:06 +00:00
Joshua Colp
0b26b56316 Merged revisions 44486 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44486 | file | 2006-10-05 14:01:51 -0400 (Thu, 05 Oct 2006) | 2 lines

One more T.38 fix! Don't leave a reinvite hanging by a thread if the other side is already setup with T.38

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 18:03:34 +00:00
Kevin P. Fleming
8f1fc1ca08 Merged revisions 44476 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44476 | kpfleming | 2006-10-05 11:10:01 -0500 (Thu, 05 Oct 2006) | 3 lines

don't segfault when an argument without a close parenthesis is found
stop parsing as soon as that situation occurs

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 16:11:09 +00:00
Luigi Rizzo
f4cd569b12 Basically, this commit only simplifies configure.ac and makes the
mechanism more flexible, but otherwise should not affect your build
even if you regenerate the "configure" script.
(Most likely you need to run bootstrap.sh as you really need to re-run
autoheader for reasons that i do not completely understand).

If you don't regenerate "configure", of course you will see no difference.

In detail:

- restructure the check for mandatory modules to remove some
  redundant code blocks;

- extend the AST_EXT_LIB_CHECK so that it can used also for
  checking headers;

- define the AST_C_DEFINE_CHECK macro to test for #defined symbols;

- for the two above macros, add a last argument that getscopied into
  HAVE_$1_VERSION so the source can adapt to different versions of the
  same libraries/header/etc

- document the above;

- document a problem that existed before and i did not manage to solve:
  the 'description' argument to AC_DEFINE does not substiture shell variables
  so you will not see the actual values in the comments (in autoconfig.h)..




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 15:42:14 +00:00