Commit Graph

1451 Commits

Author SHA1 Message Date
Luigi Rizzo
d18e363523 some code simplifications using S_OR() to remove some if blocks
and duplicate code.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31868 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:17:54 +00:00
Luigi Rizzo
ec46b5a4ce use ast_skip_blanks() where appropriate, and use standard
C jargoon  *foo++ = '\0'; instead of two separate statements.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31861 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 23:03:29 +00:00
Luigi Rizzo
b7b716b618 mark XXX a buggy section of code and implement a probable
replacement (leave the original in case my code does not
do what the function was meant to do).
oej, please check this...



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31843 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 22:56:45 +00:00
Luigi Rizzo
7483e1d2b6 simplify logic in a small block of code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 22:29:37 +00:00
Luigi Rizzo
c7a5a96fc6 mark XXX a bug in the code. oej/kevin, any idea what you want
to use here ?



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31841 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 22:18:41 +00:00
Luigi Rizzo
a63b2e4c53 remove duplicate code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 20:40:54 +00:00
Luigi Rizzo
1a38041830 Replace '\"' with '"'.
The escape is unnecessary, and makes a bad example
to people reading the code.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31813 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-03 20:34:26 +00:00
Olle Johansson
e0a8649273 - Formatting
- Add some comments


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 19:21:46 +00:00
Olle Johansson
b7cfe5bd08 Minor change to DEBUG and WARNING messages
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31494 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 19:15:40 +00:00
Olle Johansson
4d17451c55 Issue #7103 take two. Thanks Mikael!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 16:58:06 +00:00
Russell Bryant
4c76028de9 - add the ability to configure forced jitterbuffers on h323, jingle,
and mgcp channels
- remove the jitterbuffer configuration from the pvt structures in
  the sip, zap, and skinny channel drivers, as copying the same global
  configuration into each pvt structure has no benefit.
- update and fix some typos in jitterbuffer related documentation
(issue #7257, north, with additional updates and modifications)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31413 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 16:47:28 +00:00
Russell Bryant
62b2f320a1 make a global variable static and remove an unused global variable
(issue #7258, tardieu)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31359 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 14:15:16 +00:00
Olle Johansson
725e285bc4 Commit of the new SIP transfer support (oej/siptransfer branch)
- improved support of attended transfers (REFER with replaces)
- support of INVITE/replaces in the context of a transfer
- improved support of blind transfers (REFER)

Thanks to Voop, Nuvio and Foniris for sponsoring this work.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-01 07:30:45 +00:00
Russell Bryant
414106a3a6 move the includes of abstract_jb.h to be with the rest of the asterisk includes.
These used to be wrapped in a #ifdef


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31078 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-31 17:29:12 +00:00
Russell Bryant
bb7dd96cfe Add support for using a jitterbuffer for RTP on bridged calls. This includes
a new implementation of a fixed size jitterbuffer, as well as support for the
existing adaptive jitterbuffer implementation. (issue #3854, Slav Klenov)

Thank you very much to Slav Klenov of Securax and all of the people involved
in the testing of this feature for all of your hard work!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-31 16:56:50 +00:00
Joshua Colp
503486e99d OKAY - Only replace our IP address in the outgoing SIP messages if the actual source address is within the specified local network. (issue #7051 reported by Luke-Jr with mods by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-31 16:31:41 +00:00
Olle Johansson
c7007e1f55 Add congestion message to SIP history
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-31 14:36:47 +00:00
Olle Johansson
bc0f0a3226 Use ast_channel_trylock for channels
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30990 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-31 14:28:29 +00:00
Kevin P. Fleming
f890cab292 Merged revisions 30293 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r30293 | kpfleming | 2006-05-25 12:18:01 -0500 (Thu, 25 May 2006) | 2 lines

allow SIPCHANINFO(peername) to work for calls from users as well (issue #7215)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-25 17:22:26 +00:00
Kevin P. Fleming
57f6093661 don't send CANCEL for an INVITE that we haven't received a provisional response for yet... mark it pending until a response arrives (issue #7079)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-24 20:37:45 +00:00
Olle Johansson
b8b1fda04c Typo
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@30038 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-24 19:58:36 +00:00
Kevin P. Fleming
3e99be68d1 add a new option for 'obscuring' SIP user/peer names from fishers
use an enum for authentication results and clean up code
fix a bug where SUBSCRIBE for an unknown user/peer would not generate a response


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-24 03:28:49 +00:00
Kevin P. Fleming
b31af470e7 Merged revisions 29764 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r29764 | kpfleming | 2006-05-23 13:16:40 -0500 (Tue, 23 May 2006) | 2 lines

simplify/fix lock retry, and fix comment

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29765 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-23 18:17:40 +00:00
BJ Weschke
c4227714fd Sanity check code for an extended failure in trying to obtain a channel lock that may have been obtained elsewhere. Prevents the monitor thread of the SIP module from going into an infinite loop, effectively, breaking SIP until you restart Asterisk or the mutex is unlocked, whichever comes first.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29735 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-23 17:31:05 +00:00
Olle Johansson
16a648aaf1 Breaking once will stop us... :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29668 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-23 12:39:48 +00:00
Olle Johansson
883e4d6a9b Code formatting
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29665 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-23 12:14:35 +00:00
Mark Spencer
fa9e0ed768 Handle ringing (early) state properly on SIP
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29619 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-23 04:49:31 +00:00
Luigi Rizzo
76c47813fe remove code duplication generating some ast_verbose messages .
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 03:16:38 +00:00
Luigi Rizzo
82dbf5a4c1 use the functional form of time(), and mark XXX a couple of places
with dubious assignments.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:43:24 +00:00
Luigi Rizzo
afe7c46924 more constifications
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:31:58 +00:00
Luigi Rizzo
322aff00c6 various constification of function arguments to prevent erroneous
usage and to ease understanding of the function themselves.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29332 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:27:33 +00:00
Luigi Rizzo
ba195ee2d4 the msg argument of the various transmi_response*() functions is const.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29331 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:22:39 +00:00
Luigi Rizzo
75c6b453a3 mark const the 'header' argument of gettag
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29330 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:19:14 +00:00
Luigi Rizzo
1a709886e3 mark const the source of copy_request
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:17:52 +00:00
Luigi Rizzo
c76882a94a fix indentation to make a table more readable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29328 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:16:04 +00:00
Luigi Rizzo
3ade391d1d simplify register_peer_exten() removing some duplicated code.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 02:02:57 +00:00
Luigi Rizzo
734535011a use strsep() to trim away ;xxx from SIP messages.
Note that in a couple of places the code overwrites the string
in the buffer - mark the two places with XXX but do not fix the
bug yet.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29299 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 01:27:52 +00:00
Luigi Rizzo
8414445108 use a more compact method to trim the trailing ;... from SIP lines.
These are just the first two instances, there are many more to replace.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 01:08:41 +00:00
Luigi Rizzo
917182e286 annotate const parameters of copy_header()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 00:46:04 +00:00
Luigi Rizzo
27f4fb4990 src is const in parse_copy()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 00:32:36 +00:00
Luigi Rizzo
564ca6394a minor logic simplification in get_sip_pvt_byid_locked()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 00:29:12 +00:00
Luigi Rizzo
15b7465cd2 simplify logic in function create_addr()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 00:17:46 +00:00
Luigi Rizzo
a234f92337 simplify logic in realtime_peer(), removing an unnecessary
initialization, an extra variable (newpeername) and a 
variable newpeername, and an 'else' branch.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-22 00:07:48 +00:00
Luigi Rizzo
94d3a99089 strcmp() is the right function to use here, not strncmp().
On passing simplify an ast_cli message nearby.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-21 23:54:28 +00:00
Russell Bryant
ed0b86c916 fix the possibility of writing one byte past the end of a buffer.
(issue #7189, Mithraen)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@29053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 19:54:14 +00:00
Kevin P. Fleming
6d92d53d41 attributes need trailing CR-LF
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28863 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 23:08:47 +00:00
Kevin P. Fleming
42e2cf61d8 Merged revisions 28794 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r28794 | kpfleming | 2006-05-19 14:39:55 -0500 (Fri, 19 May 2006) | 2 lines

use the specified 'subscribecontext' for a peer rather than the context found via the target domain (domain contexts are for calls, not for subscriptions) (issue #7122, reported by raarts)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28795 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 19:43:33 +00:00
Tilghman Lesher
d0c36296d2 As requested by kpfleming, renaming messagecount to inboxcount and messagecount2 to messagecount.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28745 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 18:21:31 +00:00
Olle Johansson
cd03597f0c Formatting cleanup
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28483 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 07:52:08 +00:00
Kevin P. Fleming
0c73d47618 Merged revisions 28380,28384 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r28380 | kpfleming | 2006-05-18 15:24:07 -0500 (Thu, 18 May 2006) | 2 lines

handle incoming multipart/mixed message bodies in SIP and find the SDP, if presnet (issue #7124 reported and patched by eborgstrom, but very different fix)

........
r28384 | kpfleming | 2006-05-18 15:43:42 -0500 (Thu, 18 May 2006) | 2 lines

fix up a few more places to find the SDP properly (fallout from fix for #7124)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-18 21:02:21 +00:00