Tilghman Lesher
0cfb462845
Format vulnerability fix - allowing the user to specify a format is not a good idea (Bug 7811)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 23:12:29 +00:00
Joshua Colp
0367363edb
Let's use the same thing we use in other places to calculate our time for ast_cond_timedwait (issue #7697 reported by bn999)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42260 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:30:44 +00:00
Steve Murphy
d3d62f3678
This should fix the problem reported in 7564: logger config file errors getting lost because logging isn't configured yet. The problem was that the code that exists to handle this case was not getting reached, because other tests were causing an early return from ast_log().
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 02:14:14 +00:00
Steve Murphy
283039a071
added hours,minutes,seconds .gsm files to the install portion of the makefile, as per bug 7545
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 20:09:10 +00:00
Joshua Colp
754cb0114f
Don't close the second file descriptor if it's the same as the first one, as it will have already been closed elsewhere and could cause massive panic. (issue #7699 reported by bn999)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 20:02:59 +00:00
BJ Weschke
ff9fce4bb8
Look ma! No more deadlocks! <sic>
...
As posted from #7458 and others similar to it in Mantis:
p->app_lock was a mutex really designed for use with agents not in callback mode. That being the case, I've tried to code it so that when callback mode is used, the app_lock mutex will not be locked/unlocked at all. Please let me know how you make out - and if you continue to deadlock now, please reproduce the deadlock logging information and post to Mantis.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 18:16:41 +00:00
Christian Richter
8be5b66038
fixed pipe consuming bug when using chanIsAvail ( #7878 ), also moved a debug log to the very begining of misdn_hangup.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42110 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 17:10:41 +00:00
Joshua Colp
e627ecb8a7
Make realtime regseconds work as people expected (0 on registration expiration or release, and actual on normal state) (issue #7684 reported by kshumard)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42086 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 15:55:20 +00:00
Joshua Colp
68de3c0b29
Merge in last round of spy fixes. This should hopefully eliminate all the issues people have been seeing by distinctly separating what each component (core/spy) is responsible for. Core is responsible for adding a spy to a channel, feeding frames to the spy, removing the spy from a channel, and telling the spy to stop. Spy is responsible for reading frames in, and cleaning up after itself.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42054 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 20:02:48 +00:00
Jason Parker
cc82df15ff
Small typo in zapata.conf.sample
...
Reported by ppyy in 7881
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42014 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 16:27:46 +00:00
Olle Johansson
9eb92ed083
Don't kill the pvt before we have sent ACK on CANCEL (needs more testing before making a release)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-04 15:46:07 +00:00
BJ Weschke
a05a361fc3
Make sure the forwarded channel inherits variables appropriately when we receive a call forward in the queue. ( #7867 - raarts reported and patched)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:38:22 +00:00
BJ Weschke
aaf0ad7b77
Don't keep trying the same member in certain strategies when members of the queue are unavailable ( #7278 - diLLec reported and patched) - This should have been patched here first and then merged into /trunk. My bad!
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:13:38 +00:00
BJ Weschke
919cb0b1a8
Let's NOT spy on Zap/psuedo channels, mmmmmmmmk?
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:50:59 +00:00
BJ Weschke
c3b61adc5b
Setting a retry of 0 is generally not a good idea and shouldn't be allowed. ( #7574 - reported by regin)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:16:08 +00:00
Joshua Colp
1e21d7a537
Only wipe the redirected audio & video IP/port if it's specified, and trigger a reinvite.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-01 22:49:07 +00:00
Kevin P. Fleming
abb4e3a3a4
put in proper fix for issue #7294 instead of the broken partial fix that was committed, and thereby also fix issue #7438
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-01 17:35:06 +00:00
Joshua Colp
c42a8d9b99
Finish up the last commit (was worse then originally reported)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-01 16:33:00 +00:00
Joshua Colp
a5641b46de
Don't treat an unexpected control subclass as voice (issue #7858 reported by PCadach)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-01 16:28:08 +00:00
Olle Johansson
abfcb8d31e
Issue #7572 - Hangup when receiving a buggy 487 response to an INVITE
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41423 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-30 19:01:55 +00:00
Russell Bryant
e174a3c762
Restore original functionality of 1.2 in places where ANI was not set, but was
...
changed to be set. The original change was done to ensure that the behavior of
the "callerid" option in each channel driver was consistent, but it caused an
unexpected behavior change of CDR records for users, so this change is being
reverted in 1.2. (issue #7695 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41411 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-30 18:59:44 +00:00
Joshua Colp
6b466228c4
Properly handle an ETIMEDOUT result from pthread_cond_timedwait (issue #7318 reported by arkadia)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41390 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-30 17:58:31 +00:00
Olle Johansson
955aa04edc
Issue 7822 - don't use SRV lookups if it's disabled.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-30 14:31:47 +00:00
Russell Bryant
41fad4887e
clean up last commit ... most notably, there is no reason to do heap
...
allocations here, and it also included a potential memory leak
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-29 13:33:34 +00:00
Steve Murphy
c6d94b0d89
Fixes for bug 7813, via patch submitted by stevens.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-29 05:49:12 +00:00
Steve Murphy
c4f13b4c28
Removed from the docs the mention of the ! and =~ operators, as these
...
were knocked out of ast_expr2 because they were new features. Let's hope
I can keep them from getting knocked out of the trunk, too!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41240 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-28 20:51:08 +00:00
Steve Murphy
6daea8e8fb
According to a note added to 7731 by mneuhauser, this
...
will repair a break caused by the last fix (7731).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-28 19:06:55 +00:00
Matthew Fredrickson
640f0361b9
There, much better.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-25 15:21:18 +00:00
Matthew Fredrickson
3bfeacea91
Don't send proceeding twice ( #7800 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-25 15:13:43 +00:00
Tilghman Lesher
e83bbab1ec
Text only - clarify the reason for entry into authentication mode when the skipuser option is ignored
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-25 15:07:16 +00:00
Russell Bryant
034a919e1f
Fix a few issues related to the handling of channel variables
...
- in pbx_builtin_serialize_variables(), the variable list traversal would stop
on a variables with empty name/values, which is not appropriate
- When removing the GROUP variables, use AST_LIST_REMOVE_CURRENT instead of
AST_LIST_REMOVE
- During masquerading, when copying the variables list from one channel to the
other, using AST_LIST_INSERT_TAIL is not valid for appending a whole list.
It leaves the tail pointer of the list invalid. Introduce a new macro,
AST_LIST_APPEND_LIST that appends a list properly.
(issue #7802 , softins)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-24 19:41:26 +00:00
Joshua Colp
761d98663f
I can type english. Honest. Thanks Kenny.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-24 17:13:04 +00:00
Joshua Colp
fac91f48ef
Minor documentation fix to add the 'dynamic' dialplan option from angler
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40971 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-24 16:44:41 +00:00
Tilghman Lesher
39e622f7cf
Revert last change - breaks retrieval of builtin variables
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-23 16:05:26 +00:00
Tilghman Lesher
dad6bc4d32
Bug 7779 - Using initstate(3) means that we cannot unload this module once loaded.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-22 02:59:37 +00:00
Matt O'Gorman
4514a22df3
Move the load_modules call so that if a module needs
...
realtime support it will work, none do currently but a good
move none the less.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40798 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 22:34:26 +00:00
Tilghman Lesher
c7a845c978
Reformat to match the contribution style of other contributors
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-20 22:09:57 +00:00
Joshua Colp
379785c401
Turn media level c= parsing on by default (issue #7725 reported by psm)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40601 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-20 04:49:48 +00:00
Jason Parker
d98055d875
Fix a bug with app_voicemail when trying to use app_directory to leave messages
...
to another user (options 3, 5, 2).
If the context/extension didn't exist in the dialplan (and why should it have to?),
it would fail, saying that it's an "invalid extension".
Fix was different in svn trunk.
(issue BE-71)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-19 01:03:22 +00:00
Kevin P. Fleming
86b0330dc5
make a feeble attempt to avoid the 'how do I enable my hardware echo canceler' questions
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-18 19:10:51 +00:00
Kevin P. Fleming
2650ee2f9a
rename file per crichter's request
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40310 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 22:00:37 +00:00
Christian Richter
71b348be1c
This rather small ;-) commit merges the changes from my team branch 0.3.0 into t
...
he 1.2 branch.
These changes include the new mISDN mqueue interface which makes it possible to
compile chan_misdn against the current cvs version of mISDN/mISDNuser.
These changes also contain various additions and numerous bugfixes to chan_misdn
.
Each change is documented in the commit logs in the team/crichter/0.3.0 branch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40306 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 21:57:19 +00:00
Russell Bryant
2f5c21ded7
revert bogus change to attempt to fix bug 7506 which actually causes half of
...
the channels not to get "Newchannel" events at all (issue #7745 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40227 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:36:21 +00:00
Joshua Colp
3d759745f9
Use the last CDR entry instead of the first CDR entry for variable retrieving variables using the CDR dialplan function. (issue #7689 reported by voipgate)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40225 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:22:58 +00:00
Joshua Colp
afedbd97af
Make app_macro compile again
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:18:08 +00:00
Steve Murphy
4098ad798d
In app_macro, changed the previously changed upper recursion depth limit to a variable, default of the original val of 7. MACRO_RECURSION is a channel variable that will override the limit, but until I can understand and fix why this limit is neccessary, I am not advertising this variable in the docs. This fix mirrors the changes made in r40200 in trunk.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40220 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:07:21 +00:00
Kevin P. Fleming
c3a46b712e
don't allow AUEP responses to overflow the stack during a string copy (reported by Mu Security)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-16 18:57:44 +00:00
Russell Bryant
465207a28d
use pbx_builtin_getvar_helper() so that GET VARIABLE can retrieve global
...
variables (issue #7609 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@39935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-15 22:49:41 +00:00
Steve Murphy
f4e47e9b51
This revision fixes bug 7731, the inability for macros to be called more than one level deep in the 'h' extension.
...
It also pushes up the limit of recursion depth from 7 to 20.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@39931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-15 22:13:47 +00:00
Kevin P. Fleming
7b46b7133d
add explicit listing of anthm's contributions (issue #7683 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@39379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-08 18:39:16 +00:00