Commit Graph

7016 Commits

Author SHA1 Message Date
Joshua Colp
1204f825d7 Reset our stream and vstream pointers back to NULL so that any generator that uses them (file based MOH) will not try to close them again. (issue #7668 reported by jmls)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@39056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-07 00:15:51 +00:00
Russell Bryant
f4c24d5d62 Always generate a Newstate event in ast_setstate() instead of making it a
Newchannel event if the state was AST_STATE_DOWN.  The Newchannel event will
always be generated in ast_request(), so this just causes a duplicated
Newchannel event in some cases.  
(issue #7506, repoted by capouch, fixed by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38982 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 09:01:37 +00:00
Russell Bryant
e81646d2dd remove duplicate queue log entry when the caller exits on a timeout
(issue #7616, ppyy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38972 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 08:08:48 +00:00
Russell Bryant
54b8d83e4f don't advertise that this function can set a SIP header when it can only
do reads


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 07:21:12 +00:00
Russell Bryant
183541b44d make sure the priv-callerintros directory exists before trying to create a file
there (issue #7659, patch by hads, with some modifications by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38928 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 06:37:59 +00:00
Russell Bryant
66b15a3461 Fix an issue that would cause a NewCallerID manager event to be generated
before the channel's NewChannel event.  This was due to a somewhat recent
change that included using ast_set_callerid() where it wasn't before.  This
function should not be used in the channel driver "new" functions.
(issue #7654, fixed by me)

Also, fix a couple minor bugs in usecount handling.  chan_iax2 could have
increased the usecount but then returned an error.  The place where chan_sip
increased the usecount did not call ast_update_usecount()


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38904 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 05:08:50 +00:00
Russell Bryant
5e3b7eec7d suppress a compiler warning about the usage of a potentially uninitialized variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 05:07:39 +00:00
Joshua Colp
a56f08e345 Treat the file as invalid if we have no valid formats for it (issue #7643 reported by KNK)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38825 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-03 19:54:02 +00:00
Tilghman Lesher
84ad1fe0f3 Bug 7648 - Checking wrong count for plurality on new messages for Dutch language
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38761 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-03 05:22:19 +00:00
Kevin P. Fleming
8ddb00adaa fix brain-damage I introduced when trying to fix the CANCEL/BYE sending mechanism for pending INVITES
accept unknown 1xx responses as 183 responses (as RFC3261 mandates we should do)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-02 19:29:56 +00:00
Kevin P. Fleming
4f3b40fe79 ensure that the 'feature digit timeout' value is taken into account when deciding how long the bridge should run (this fixes a problem report where a digit press that did not invoke a feature is never passed across the bridge)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-01 23:07:06 +00:00
Joshua Colp
83f9228c1d Close the stream when file based MOH stop. This won't get rid of their position in the file but it will cause the translation path to be setup again. (issue #7634 reported by asimpson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38654 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-01 19:20:05 +00:00
Kevin P. Fleming
532ff6487b don't reissue hangup requests for SIP channels that have expired their RTP timeouts (one time is enough)
don't rescan the SIP private structure list too fast, it can cause channels to not be able to hang up (issue #7495, and probably others)
use ast_softhangup_nolock() since we already hold the channel's lock


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-31 21:14:11 +00:00
Joshua Colp
f41b9baed4 Add missing code to bring transferee channel out of MOH/autoservice under certain circumstance (issue #7611 reported by guillecabeza with minor mods by myself)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38585 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-31 17:09:10 +00:00
Russell Bryant
af0052ee94 one more small tweak for thread-safety of TRACE_FRAMES
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38547 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-31 04:06:16 +00:00
Russell Bryant
70d6a82a9f Make the frame counting done with TRACE_FRAMES defined thread-safe
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-31 04:04:02 +00:00
Joshua Colp
1020b9d11a How many attempts does it take to make a SIP URI parser that works well? I'm up to 5 personally. On to the good stuff - parse the domain first, user second, and get rid of port & options/params last. (issue #7616 reported by andrew)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-29 23:18:00 +00:00
Joshua Colp
2e7e645c77 Make a copy of the request URI in check_user_full instead of modifying the one on the structure, and also strip params properly from the user portion of the SIP URI so as to preserve the domain (issue #7552 reported by dan42)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-28 18:49:00 +00:00
Kevin P. Fleming
7b9abdf138 use the enum that defines the option arguments, so that the likelihood of mismatched option indexes is reduced (which in this case was a bug, the volume argument was not checked properly)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-27 22:23:38 +00:00
Kevin P. Fleming
6afc9c6c8f do a better job avoiding translation path teardown/setup when not needed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-27 15:40:03 +00:00
Russell Bryant
228c35198c Fix crash when using the "regexten" option with MALLOC_DEBUG enabled. This was
not reported in the bug tracker but the same bug has been demonstrated in other
places in the code.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38328 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-27 04:25:41 +00:00
Kevin P. Fleming
0b6aa9cd29 don't do useless translation destroy/build when the channel is already in the correct format
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38310 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-27 02:43:49 +00:00
Russell Bryant
425c51cfd5 fix a crash when MALLOC_DEBUG is enabled and the regexten is enabled. The crash
would occur when the extension got removed. (fixes issue #7484)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-27 01:58:41 +00:00
Joshua Colp
46012df0b6 Put default callerid into contact when the one specified is either NULL or has a zero string length. (issue #7590 reported by key2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-26 15:26:06 +00:00
Russell Bryant
96048caf41 This resolves a deadlock that a tech support customer was getting frequently
when his users would answer call waiting. If another thread is currently
holding the zt_pvt lock for the first channel, unlock both channels and let
asterisk retry the native bridge, just like what is done for the second channel
directly below these changes.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-25 19:43:38 +00:00
Steve Murphy
f46ab63b6c This fixes a compile problem for s390 as reported in bug 7253.
Tested on both an s390 and non-s390 machine.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-24 17:05:56 +00:00
Kevin P. Fleming
1cd1b27779 ensure that global 'maxauthreq' is reset to zero during 'reload'
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37949 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-19 17:10:10 +00:00
Russell Bryant
b97c12b80b don't crash if the frame has no data, but has a src
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37856 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-18 00:41:47 +00:00
Russell Bryant
09a334573e if asked to duplicate a frame that has no data, don't set the frame's data
pointer past the end of the allocatted buffer for the new frame


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 23:25:33 +00:00
Tilghman Lesher
dfe118c2fd Backport buffer increase to 1.2
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 22:36:56 +00:00
Tilghman Lesher
f23368365a Overflow bad
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37765 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-17 15:52:15 +00:00
Tilghman Lesher
c5623e2acd Bug 7513 - ensure that each time we do a query, the results are returned in the
same logical order, so that when we iterate over the list, we get all results,
not some results repeated, due to insufficient sorting.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-15 23:29:28 +00:00
Tilghman Lesher
ce37a590e5 Bug 7526 - previous commit broke app_sms
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37612 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-14 13:31:11 +00:00
Kevin P. Fleming
6ea65400a0 don't fail/abort if the message category sound file cannot be played, just generate a warning message and continue message playback
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-13 21:22:11 +00:00
Russell Bryant
1d8f732f3f yeah, ummm... This frame pointer should not be static. This situation only
exists in 1.2 (pointed out by Constantine Filin on the asterisk-dev mailing list)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-13 18:44:17 +00:00
Kevin P. Fleming
88ccb628f9 report address of peer trying to subscribe to unknown hint
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37531 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-13 16:44:23 +00:00
Tilghman Lesher
fcf0d79afa Bug 7532 - Typo in enum example
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-13 15:45:33 +00:00
Tilghman Lesher
39882ad2f7 Merge fixup for asterisk startup script to zaptel startup script
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37458 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 18:29:01 +00:00
Kevin P. Fleming
ff3890a952 fix a weird case where a lock file could be left (but would happen almost never)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37442 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 15:53:53 +00:00
Kevin P. Fleming
0c754a13a8 fix a case where ast_lock_path() could leave a randomly-named lock file hanging around
make ast_unlock_path actually report when unlocking fails


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37441 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 15:46:56 +00:00
Joshua Colp
ff29ba6296 Add support to have maxauthreq as a global option
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 15:23:59 +00:00
Kevin P. Fleming
648bc1828d remove some more bad examples of using printf
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 13:54:10 +00:00
Kevin P. Fleming
fe1708f190 get rid of some more printf's (although most of these were ifdef-ed out)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37417 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 13:18:21 +00:00
Matt O'Gorman
f009c13db7 GRRR no fprintf!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 03:55:36 +00:00
Joshua Colp
3d8ef8de96 Add configuration option for IAX2 users that will limit the amount of outstanding AUTHREQs we are waiting for replies on.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-11 19:00:50 +00:00
Kevin P. Fleming
152df40d57 do masquerade-behind-proxy checking with better control over locks
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-10 21:01:35 +00:00
Joshua Colp
f1b2416353 Change message regarding marker bit forcing when SSRC changes to be shown only during debug so it doesn't overload high capacity systems
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-07 23:57:53 +00:00
Matt O'Gorman
84881a0662 patch resolves issue with when to decide if its right time
to native bridge, feature redirect was not being checked.
patch from bug #7296


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37224 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-06 21:41:23 +00:00
BJ Weschke
b617860594 Don't do wierd things on a callback agent that has attempted logoff while still on the phone.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-06 20:38:45 +00:00
Joshua Colp
5a86fcf1f8 Instead of giving the scheduled item ID on a peer expiration, give the time until they expire (issue #7455 reported by slavon)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-06 15:48:07 +00:00