Commit Graph

7554 Commits

Author SHA1 Message Date
Jason Parker
4ce4fe74ae Fix another problem in voicemail with missing symbols.
Issue 10074, patch by kryptolus, extended to include #if 0'd blocks (just in case)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72184 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 18:40:15 +00:00
Christian Richter
3637816f4c simplified generation for dummy bchannels, also we mark them as dummies, so they are not used later as real-bchannels, optimized the RESTART mechanisms, we block a channel now on cause:44, and send out a RESTART automatically, then on reception of RESTART_ACKNOWLEDGE we unblock the channel again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 13:22:37 +00:00
Christian Richter
5f272436b9 simplified channel finding and locking a lot. removed unnecessary #ifdefed areas.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72087 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 09:26:53 +00:00
Christian Richter
085065ac35 isdn_lib.c didn't compile
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72041 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 07:54:30 +00:00
Christian Richter
16ecedee04 for inbound TE calls, we setup the bchannel when we get the CONNECT_ACKNOWLEDGE, to make sure mISDN has everything ready. removed some #if 0 areas which weren't used anymore.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72040 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 07:49:27 +00:00
Jason Parker
c2cfb7ba64 Don't try to install an init script that doesn't exist.
Reported to me on #asterisk on Freenode IRC.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 17:49:14 +00:00
Tilghman Lesher
8f2a415995 Issue 10062 - Trying to move a message without selecting one first results in memory corruption
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 12:25:58 +00:00
Tilghman Lesher
5be40827e5 Issue 10035 - handle_exec returns a result inconsistent with all of the other AGI commands
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 18:12:37 +00:00
Joshua Colp
76b4eb5daa Ignore other URIs after the first in a 300 Multiple Choice response. (issue #10041 reported by homesick)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-25 01:02:49 +00:00
Russell Bryant
fb50a2da95 Revert the patch from issue 9654 due to an unexpected side effect
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71358 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 20:04:21 +00:00
Tilghman Lesher
f7a787c757 Issue 10043 - There is a legitimate need to be able to set variables to the empty string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 17:32:21 +00:00
Joshua Colp
7e22d574a7 Send an unhold indication when going off hold. (issue #10036 reported by speedy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 16:02:40 +00:00
Jason Parker
01f5e6d56b Fix a few silly usages of ast_playstream() - it only ever returns 0...
Issue 10035


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 14:52:18 +00:00
Brett Bryant
b9000f54b2 Fixed infinite loop when controlling terminal was lost
and return value of input function wasn't checked for
errors. This would cause 100% cpu to be taken up.

(closes issue #9654, issue #10010)
Reported by: mnicholson, and eserra

Idea for the patch from mnicholson, patched by me



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 14:39:34 +00:00
Steve Murphy
c25932a107 This little fix is in response to bug 10016, but may not cure it. The code is wrong, clearly. In a situation where you set the CDR's amaflags, and then ForkCDR, and then set the new CDR's amaflags to some other value, you will see that all CDRs have had their amaflags changed. This is not good. So I fixed it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70948 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 22:29:50 +00:00
Joshua Colp
e179ccaff2 Don't explode if the gain option is specified without a value. (issue #9274 reported by mfarver)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 21:37:55 +00:00
Steve Murphy
7a7b6536c7 it was pointed out that the cdr_custom config load could get a lock, and under certain circumstances, would never release it. I also noted that the situation where more than one mapping spec was warned about, but did not ignore further mappings as it had promised. I think I have fixed both situations.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 19:13:17 +00:00
Christian Richter
d8d4454ae5 we activate the bchannels in TE mode on incoming calls only when we want to connect the call.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 13:11:29 +00:00
Joshua Colp
6357ad5659 Don't overwrite the configured username setting upon a REGISTER. (issue #8565 reported by jsmith)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 22:20:16 +00:00
Tilghman Lesher
a1cc9b4966 Issue 9997 - Timelimit times out the wrong channel
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 19:25:54 +00:00
Russell Bryant
cfaead2b9c Fix a problem where an established call would not be properly disconnected
when a PRI disconnect is received depending on which cause code was received.
(issue #9588, original patch by softins, updated patch from jtexter3, and some
 additional feedback from mhardeman)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70396 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 18:45:38 +00:00
Christian Richter
f5f018a209 forgot one place ..
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 15:42:39 +00:00
Christian Richter
7fc236e53b fixed a bug that was introduced by copy and paste in the last commit ..bchannels weren't cleaned properly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70341 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 15:29:09 +00:00
Christian Richter
ede913f976 on receiption of cause:44 we mark the channel as in use and inform the user about the situation, we need to test the RESTART stuff then. Also shuffled the empty_chan_in_stack function after the bchannel cleaning functions, to avoid race conditions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 14:47:59 +00:00
Steve Murphy
8da289e13c This fixes 9246, where channel variables are not available in the 'h' exten, on a 'ZOMBIE' channel. The fix is to consolidate the channel variables during a masquerade, and then copy the merged variables back onto the clone, so the zombie has the same vars that the 'original' has.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 18:07:59 +00:00
Joshua Colp
3d1a5f71c5 Handle the CC field in the RTP header. (issue #9384 reported by DoodleHu)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 17:00:58 +00:00
Russell Bryant
6e0248318b Backport fix for crashes related to subscriptions from 1.4 ...
Fix a crash that could occur when handing device state changes.
When the state of a device changes, the device state thread tells the extension
state handling code that it changed.  Then, the extension state code calls the
callback in chan_sip so that it can update subscriptions to that extension.
A pointer to a sip_pvt structure is passed to this function as the call which
needs a NOTIFY sent.  However, there was no locking done to ensure that the pvt
struct didn't disappear during this process.
(issue #9946, reported by tdonahue, patch by me, patch updated to trunk to use
 the sip_pvt lock wrappers by eliel)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69990 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 16:45:37 +00:00
Joshua Colp
07b9fc569f Update BRIDGEPEER variable if set to the new channel name when a masquerade happens. (issue #9699 reported by dimas)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69986 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 16:21:29 +00:00
Joshua Colp
e21d079484 Perform an extra hangup check just in case. (issue #9589 reported by bcnit)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69894 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 13:54:03 +00:00
Christian Richter
3322095dea when we send out a SETUP, but get no response, we should cleanup everything after reception of a hangup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 13:23:04 +00:00
Joshua Colp
234b7d22fe Add parked call extension AFTER the parking slot has been announced, otherwise two threads will try to handle the same channel and it will go kaboom. (issue #9191 reported by japple)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 12:57:55 +00:00
Joshua Colp
dc41ce9857 Set the peer name on the dialog to the one configured in sip.conf and NOT the username to be used for authentication attempts. (issue #9967 reported by achauvin)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69765 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 18:13:03 +00:00
Tilghman Lesher
ff8bb42cbc Issue 9998 - Remove SIG prefix, since it's not supported by ksh
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69743 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 17:45:15 +00:00
Jason Parker
9aa74f204a Fix an issue where the line number in an unterminated comment block error message would show the wrong line number.
"Reported" to me on #asterisk (somebody posted an error message, and I happened to catch it)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 23:21:45 +00:00
Russell Bryant
dc41cf2347 Backport rev 69010 from the 1.4 branch ...
In ast_channel_make_compatible(), just return if the channels' read and write
formats already match up.  There are code paths that call this function on a
pair of channels multiple times.  This made calls fail that were using g729
in some cases.  The reason is that codec_g729a will unregister itself from the
list of available translators will all licenses are in use.  So, the first
time the function got called, the right translation path was allocated.
However, the second time it got called, the code would not find a translation
path to/from g729 and make the call fail, even if the channel actually already
had a g729 translation path allocated.

(SPD-32)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 20:56:19 +00:00
Jason Parker
fab1ba87cd Change a quite broken while loop to a for loop, so "continue;" works as expected instead of eating 99% CPU...
Issue 9966, patch by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 15:15:53 +00:00
Joshua Colp
0156942fe0 Return group counting to previous behavior where you could only have one group per category. (issue #9711 reported by irroot)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 18:12:48 +00:00
Christian Richter
ba372aa9a4 restart indicator 0x80 is correct, at least that's what libpri does.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 09:55:54 +00:00
Joshua Colp
28464199ee Bring RTP back to Asterisk at the end of a native bridge no matter what.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 14:18:57 +00:00
Christian Richter
37ded96cfa if the bridged partner is mISDN too we should not send dtmf tones, they are transmitted inband always
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 08:35:22 +00:00
Christian Richter
7bb272f942 if we have already some digits, we just stop the tones.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 07:48:52 +00:00
Christian Richter
9809905c76 added check for NULL Pointer when calling misdn_new. Asterisk does not allow us to create channels anymore when stop gracefully is used :). also modified the restart_indicator to 0
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68732 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 16:49:00 +00:00
Joshua Colp
41421be994 Improve deadlock handling of the channel list. (issue #8376 reported by one47)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 14:29:58 +00:00
Christian Richter
5cc2b1078e fixed problem that the dummybc chanels had no lock, checking for the lock now. Also fixed the channel restart stuff, we can now specify and restart particular channels too.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 09:18:01 +00:00
Russell Bryant
086aba207e Don't automatically hang up after running Dictate so that callers can exit
cleanly using '#'
(closes issue #9577, patch from Thomas Andrews)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 22:22:36 +00:00
Joshua Colp
d8fb68b9cb Don't call ast_waitstream_full when the control file descriptor and audio file descriptor are not set, simply call ast_waitstream! (issue #8530 reported by rickead2000)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68397 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 00:15:33 +00:00
Joshua Colp
49ffa786ff Do a DNS lookup immediately upon calling the dnsmgr function, don't wait until a refresh happens. (issue #9097 reported by plack)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:59:04 +00:00
Russell Bryant
c00062ff31 Fix a problem where saying a character wouldn't properly break out when the caller pressed '#'
(issue #8113, reported by patbaker82, patch from jamesgolovich (hey, long time no see!) and patbaker82)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:13:33 +00:00
Jason Parker
a3961d646a Don't try to save voicemail greetings unless the user presses '1' to accept/save.
Issue 9904, patch by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68204 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:02:50 +00:00
Joshua Colp
9c0627eab0 Allow the 'g' option to work if used with the 'S' option. (issue #9888 reported by gasparz)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 14:19:40 +00:00